211760 2020-05-11 19:15:44 -0700 [WebAuthn] Don't assume extensions always exist 2020-05-12 17:11:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan bfulgham jiewen_tan webkit-bug-importer oldest_to_newest 1651576 0 jiewen_tan 2020-05-11 19:15:44 -0700 [WebAuthn] Don't assume extensions always exist. 1651577 1 jiewen_tan 2020-05-11 19:18:00 -0700 <rdar://problem/61217642> 1651578 2 399087 jiewen_tan 2020-05-11 19:20:50 -0700 Created attachment 399087 Patch 1652008 3 399087 bfulgham 2020-05-12 16:08:35 -0700 Comment on attachment 399087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review > Source/WebKit/ChangeLog:3 > + [WebAuthn] Don't assume extensions always exist The ASSERT_NOT_REACHED implies that we do assume these extensions exist. I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts. 1652033 4 399087 jiewen_tan 2020-05-12 17:08:53 -0700 Comment on attachment 399087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review Thanks Brent for the r+. >> Source/WebKit/ChangeLog:3 >> + [WebAuthn] Don't assume extensions always exist > > The ASSERT_NOT_REACHED implies that we do assume these extensions exist. > > I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts. It is only valid from IPC fuzzing not real world cases. That's why I do it this way. 1652037 5 ews-feeder 2020-05-12 17:11:07 -0700 Committed r261588: <https://trac.webkit.org/changeset/261588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399087. 399087 2020-05-11 19:20:50 -0700 2020-05-12 17:11:07 -0700 Patch bug-211760-20200511192049.patch text/plain 4723 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk2Y2Q3ZjNiOTQwNTFh YmMxNGJhYjMxZTE3ODQ1OWU0YmZiOGQ1NS4uMTYyYzlmZTBhMTAxMTUxNjQ4MjQ5MDM4ZGM3Zjc2 NDc5ZGU1NzE5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTExICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhuXSBEb24n dCBhc3N1bWUgZXh0ZW5zaW9ucyBhbHdheXMgZXhpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTc2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjEyMTc2NDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBNb2R1bGVzL3dlYmF1dGhuL2ZpZG8vVTJmQ29tbWFuZENvbnN0cnVjdG9yLmNwcDoKKyAg ICAgICAgKGZpZG86OnByb2Nlc3NHb29nbGVMZWdhY3lBcHBJZFN1cHBvcnRFeHRlbnNpb24pOgor CiAyMDIwLTA1LTA4ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gVGV4dC1zdHlsZSBmb250cyBhcmVuJ3QgbG9jYWxlLXNwZWNpZmljCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCmluZGV4IGJkZmRlZjVmNjliYmY3YjJjMDU1NDJiNDNiYjQ4MTQ5NTRkODNkMDUuLjk1ZjE0 ZDRjMTIwMDY3OGZkMmI4YTA2YTEzMmNhMDdiNTBiMGIwODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMjAtMDUtMTEgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKwor ICAgICAgICBbV2ViQXV0aG5dIERvbid0IGFzc3VtZSBleHRlbnNpb25zIGFsd2F5cyBleGlzdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNzYwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTIxNzY0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9B dXRoZW50aWNhdG9yTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvcmU6OnByb2Nl c3NHb29nbGVMZWdhY3lBcHBJZFN1cHBvcnRFeHRlbnNpb24pOgorICAgICAgICAqIFVJUHJvY2Vz cy9XZWJBdXRoZW50aWNhdGlvbi9maWRvL0N0YXBBdXRoZW50aWNhdG9yLmNwcDoKKyAgICAgICAg KFdlYktpdDo6Q3RhcEF1dGhlbnRpY2F0b3I6OnByb2Nlc3NHb29nbGVMZWdhY3lBcHBJZFN1cHBv cnRFeHRlbnNpb24pOgorCiAyMDIwLTA1LTA4ICBOaWtvcyBNb3VjaHRhcmlzICA8bm1vdWNodGFy aXNAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCB3ZWItc2hhcmUgdjIgZm9yIGZpbGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL2ZpZG8vVTJmQ29t bWFuZENvbnN0cnVjdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlk by9VMmZDb21tYW5kQ29uc3RydWN0b3IuY3BwCmluZGV4IGYyZjlkYzMxNGM5ODk0ZjcyMzRiMzZm NDkyOTk2MjY4ODg2MTZkM2IuLjk5YmQxYTk0OTQwNjJmNmY0YzMwYjNiY2UwZDAyOWQ4Yzg2Nzky OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlkby9VMmZD b21tYW5kQ29uc3RydWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0 aG4vZmlkby9VMmZDb21tYW5kQ29uc3RydWN0b3IuY3BwCkBAIC0xMzMsOCArMTMzLDEyIEBAIFZl Y3Rvcjx1aW50OF90PiBjb25zdHJ1Y3RCb2d1c1UyZlJlZ2lzdHJhdGlvbkNvbW1hbmQoKQogCiBT dHJpbmcgcHJvY2Vzc0dvb2dsZUxlZ2FjeUFwcElkU3VwcG9ydEV4dGVuc2lvbihjb25zdCBPcHRp b25hbDxBdXRoZW50aWNhdGlvbkV4dGVuc2lvbnNDbGllbnRJbnB1dHM+JiBleHRlbnNpb25zKQog ewotICAgIC8vIEF1dGhlbnRpY2F0b3JDb29yZGluYXRvcjo6Y3JlYXRlIHNob3VsZCBhbHdheXMg c2V0IGl0LgotICAgIEFTU0VSVCghIWV4dGVuc2lvbnMpOworICAgIGlmICghZXh0ZW5zaW9ucykg eworICAgICAgICAvLyBBdXRoZW50aWNhdG9yQ29vcmRpbmF0b3I6OmNyZWF0ZSBzaG91bGQgYWx3 YXlzIHNldCBpdC4KKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVy biBTdHJpbmcoKTsKKyAgICB9CisKICAgICBpZiAoIWV4dGVuc2lvbnMtPmdvb2dsZUxlZ2FjeUFw cGlkU3VwcG9ydCkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIHJldHVybiAiaHR0cHM6 Ly93d3cuZ3N0YXRpYy5jb20vc2VjdXJpdHlrZXkvb3JpZ2lucy5qc29uIl9zOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRv ck1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24v QXV0aGVudGljYXRvck1hbmFnZXIuY3BwCmluZGV4IDI3YmU1ODEwZGU2NTNlNmIzNWNmOTEwZDE2 Njk2NDU2ZWYyM2JkMTcuLmM3ZTJiNzg5MWU4YWI4YmM4ZWRhYjNkNDIxMDlkNTUwNDU2YTIzYTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0F1 dGhlbnRpY2F0b3JNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHAKQEAgLTEyMyw4ICsxMjMsMTEg QEAgc3RhdGljIEF1dGhlbnRpY2F0b3JNYW5hZ2VyOjpUcmFuc3BvcnRTZXQgY29sbGVjdFRyYW5z cG9ydHMoY29uc3QgVmVjdG9yPFB1YmxpY0sKIC8vIE9ubHkgcm9hbWluZyBhdXRoZW50aWNhdG9y cyBhcmUgc3VwcG9ydGVkIGZvciBHb29nbGUgbGVnYWN5IEFwcElEIHN1cHBvcnQuCiBzdGF0aWMg dm9pZCBwcm9jZXNzR29vZ2xlTGVnYWN5QXBwSWRTdXBwb3J0RXh0ZW5zaW9uKGNvbnN0IE9wdGlv bmFsPEF1dGhlbnRpY2F0aW9uRXh0ZW5zaW9uc0NsaWVudElucHV0cz4mIGV4dGVuc2lvbnMsIEF1 dGhlbnRpY2F0b3JNYW5hZ2VyOjpUcmFuc3BvcnRTZXQmIHRyYW5zcG9ydHMpCiB7Ci0gICAgLy8g QXV0aGVudGljYXRvckNvb3JkaW5hdG9yOjpjcmVhdGUgc2hvdWxkIGFsd2F5cyBzZXQgaXQuCi0g ICAgQVNTRVJUKCEhZXh0ZW5zaW9ucyk7CisgICAgaWYgKCFleHRlbnNpb25zKSB7CisgICAgICAg IC8vIEF1dGhlbnRpY2F0b3JDb29yZGluYXRvcjo6Y3JlYXRlIHNob3VsZCBhbHdheXMgc2V0IGl0 LgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0K ICAgICBpZiAoIWV4dGVuc2lvbnMtPmdvb2dsZUxlZ2FjeUFwcGlkU3VwcG9ydCkKICAgICAgICAg cmV0dXJuOwogICAgIHRyYW5zcG9ydHMucmVtb3ZlKEF1dGhlbnRpY2F0b3JUcmFuc3BvcnQ6Oklu dGVybmFsKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRp Y2F0aW9uL2ZpZG8vQ3RhcEF1dGhlbnRpY2F0b3IuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKaW5kZXggOGYy MmVkYTZkNjFlYjliZGE5ZTFlZWIwNjNjZjJjYjAyNDBlMGExMy4uN2Y0NmNmYmYzYmRkMDAyOTll ZDMyMGRkMmQ4Y2E1ZThhYzlkNDEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGlj YXRvci5jcHAKQEAgLTM1NSw5ICszNTUsMTIgQEAgYm9vbCBDdGFwQXV0aGVudGljYXRvcjo6dHJ5 RG93bmdyYWRlKCkKIC8vIE9ubHkgVTJGIHByb3RvY29sIGlzIHN1cHBvcnRlZCBmb3IgR29vZ2xl IGxlZ2FjeSBBcHBJRCBzdXBwb3J0LgogYm9vbCBDdGFwQXV0aGVudGljYXRvcjo6cHJvY2Vzc0dv b2dsZUxlZ2FjeUFwcElkU3VwcG9ydEV4dGVuc2lvbigpCiB7Ci0gICAgLy8gQXV0aGVudGljYXRv ckNvb3JkaW5hdG9yOjpjcmVhdGUgc2hvdWxkIGFsd2F5cyBzZXQgaXQuCiAgICAgYXV0byYgZXh0 ZW5zaW9ucyA9IFdURjo6Z2V0PFB1YmxpY0tleUNyZWRlbnRpYWxDcmVhdGlvbk9wdGlvbnM+KHJl cXVlc3REYXRhKCkub3B0aW9ucykuZXh0ZW5zaW9uczsKLSAgICBBU1NFUlQoISFleHRlbnNpb25z KTsKKyAgICBpZiAoIWV4dGVuc2lvbnMpIHsKKyAgICAgICAgLy8gQXV0aGVudGljYXRvckNvb3Jk aW5hdG9yOjpjcmVhdGUgc2hvdWxkIGFsd2F5cyBzZXQgaXQuCisgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogICAgIGlmIChleHRlbnNp b25zLT5nb29nbGVMZWdhY3lBcHBpZFN1cHBvcnQpCiAgICAgICAgIHRyeURvd25ncmFkZSgpOwog ICAgIHJldHVybiBleHRlbnNpb25zLT5nb29nbGVMZWdhY3lBcHBpZFN1cHBvcnQ7Cg==