<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>211313</bug_id>
          
          <creation_ts>2020-05-01 12:46:37 -0700</creation_ts>
          <short_desc>REGRESSION: stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js fails on ARM (thumb2 only?)</short_desc>
          <delta_ts>2020-05-08 14:08:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=211304</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=211205</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=211020</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pablo Saavedra">psaavedra</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>ashvayka</cc>
    
    <cc>fpizlo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1647987</commentid>
    <comment_count>0</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2020-05-01 12:46:37 -0700</bug_when>
    <thetext>* Related to: https://bugs.webkit.org/show_bug.cgi?id=211304
* Regression appears after https://bugs.webkit.org/show_bug.cgi?id=211205</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648006</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Shvayka">ashvayka</who>
    <bug_when>2020-05-01 13:03:29 -0700</bug_when>
    <thetext>I wonder if it is https://bugs.webkit.org/show_bug.cgi?id=211020 to blame for regression? The change for ArrayBuffer is barely observable though and the test was flaky before r260992.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648232</commentid>
    <comment_count>2</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2020-05-02 05:10:06 -0700</bug_when>
    <thetext>(In reply to Alexey Shvayka from comment #1)
&gt; I wonder if it is https://bugs.webkit.org/show_bug.cgi?id=211020 to blame
&gt; for regression? The change for ArrayBuffer is barely observable though and
&gt; the test was flaky before r260992.

Yes, https://bugs.webkit.org/show_bug.cgi?id=211020 looks like a more porbable candidate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648233</commentid>
    <comment_count>3</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2020-05-02 05:10:21 -0700</bug_when>
    <thetext>*probable</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648239</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Shvayka">ashvayka</who>
    <bug_when>2020-05-02 07:06:52 -0700</bug_when>
    <thetext>Can I somehow obtain a crash log from EWS or reproduce the failure locally?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1649787</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-05-06 14:04:25 -0700</bug_when>
    <thetext>The test was skipped in https://trac.webkit.org/r261010. It was skipped for all ARM, which seems wrong, as we never had evidence of this affecting iOS.

Index: /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js
===================================================================
--- /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js	(revision 261009)
+++ /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js	(revision 261010)
@@ -1,2 +1,3 @@
+//@ skip if [&quot;arm&quot;].include?($architecture)
 //@ requireOptions(&quot;-e&quot;, &quot;let iterations=40000&quot;) if [&quot;mips&quot;].include?($architecture)
 //@ runDefault(&quot;--jitPolicyScale=0&quot;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1650556</commentid>
    <comment_count>6</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2020-05-08 03:58:43 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #5)
&gt; The test was skipped in https://trac.webkit.org/r261010. It was skipped for
&gt; all ARM, which seems wrong, as we never had evidence of this affecting iOS.
&gt; 
&gt; Index:
&gt; /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-
&gt; add-in-dfg.js
&gt; ===================================================================
&gt; ---
&gt; /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-
&gt; add-in-dfg.js	(revision 261009)
&gt; +++
&gt; /trunk/JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-
&gt; add-in-dfg.js	(revision 261010)
&gt; @@ -1,2 +1,3 @@
&gt; +//@ skip if [&quot;arm&quot;].include?($architecture)
&gt;  //@ requireOptions(&quot;-e&quot;, &quot;let iterations=40000&quot;) if
&gt; [&quot;mips&quot;].include?($architecture)
&gt;  //@ runDefault(&quot;--jitPolicyScale=0&quot;)

I think I rushed myself when I skipped the test with not enough information to fill the issue. I just re-added the test again. Let&apos;s see the results for the next builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1650756</commentid>
    <comment_count>7</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2020-05-08 14:08:12 -0700</bug_when>
    <thetext>The test only is failing in JSCOnly Linux for ARMv7:

* https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20SoftFP%20Release/builds/5768
* https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/11484</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>