211309 2020-05-01 12:13:56 -0700 Avoid unnecessary copying in AnimationTimeline and other clean ups 2020-05-01 15:18:17 -0700 1 1 1 Unclassified WebKit Animations WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202109 InRadar P2 Normal --- 1 dbates dbates dino graouts simon.fraser webkit-bug-importer oldest_to_newest 1647965 0 dbates 2020-05-01 12:13:56 -0700 On random code inspection noticed that AnimationTimeline::relevantAnimations() and ::allAnimations() are copying into a new Vector. They don't need to. Moreover, allAnimations() isn't being used, so I was tempted to remove, but maybe it will be used soon? 1647974 1 398216 dbates 2020-05-01 12:21:05 -0700 Created attachment 398216 Patch 1648096 2 398216 dbates 2020-05-01 15:17:03 -0700 Comment on attachment 398216 Patch Clearing flags on attachment: 398216 Committed r261029: <https://trac.webkit.org/changeset/261029> 1648097 3 dbates 2020-05-01 15:17:07 -0700 All reviewed patches have been landed. Closing bug. 1648101 4 webkit-bug-importer 2020-05-01 15:18:17 -0700 <rdar://problem/62749337> 398216 2020-05-01 12:21:05 -0700 2020-05-01 15:17:03 -0700 Patch bug-211309-20200501122104.patch text/plain 3642 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ4ZGQ2ZmU1ODYzMDc2 YmIyM2Q1ZmYwYTdhYTc1NzZhMjAyYWQ2NS4uMmRmNWFmNzQ0YjNlOTA0MjE4OWY4ZDhlMjRkYzVm MjIxZTU5YTZlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA1LTAxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lY2Vzc2Fy eSBjb3B5aW5nIGluIEFuaW1hdGlvblRpbWVsaW5lIGFuZCBvdGhlciBjbGVhbiB1cHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTMwOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldHVybiBhbmltYXRp b25zIGJ5IGNvbnN0IGx2YWx1ZSByZWYgdG8gYXZvaWQgY29weWluZyB0aGUgVmVjdG9ycy4KKyAg ICAgICAgRGVmYXVsdCB0aGUgY29uc3RydWN0b3IgYW5kIGRlc3RydWN0b3IgaW1wbGVtZW50YXRp b25zLiBSZW1vdmUgYW4KKyAgICAgICAgdW5uZXNzYXJ5IGFyZ3VtZW50IG5hbWUgZnJvbSBhbmlt YXRpb25zRm9yRWxlbWVudCgpIGFuZCByZS1hcnJhbmdlCisgICAgICAgIGRlY2xzIHRvIG1ha2Ug Y2xhc3MgZGVmaW5pdGlvbiBtb3JlIGlkaW9tYXRpYy4KKworICAgICAgICAqIGFuaW1hdGlvbi9B bmltYXRpb25UaW1lbGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25UaW1lbGlu ZTo6QW5pbWF0aW9uVGltZWxpbmUpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6QW5pbWF0 aW9uVGltZWxpbmU6On5BbmltYXRpb25UaW1lbGluZSk6IERlbGV0ZWQuCisgICAgICAgICogYW5p bWF0aW9uL0FuaW1hdGlvblRpbWVsaW5lLmg6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25U aW1lbGluZTo6cmVsZXZhbnRBbmltYXRpb25zIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkFu aW1hdGlvblRpbWVsaW5lOjphbGxBbmltYXRpb25zIGNvbnN0KToKKwogMjAyMC0wNS0wMSAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIEhpdFRlc3RS ZXN1bHQ6Ok5vZGVTZXQgZnJvbSBzZXQgb2YgUmVmUHRycyB0byBzZXQgb2YgUmVmcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0FuaW1hdGlvblRpbWVsaW5lLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9BbmltYXRpb25UaW1lbGluZS5jcHAKaW5kZXggYTBlZDc0 OTFhYmEyNmFmYzRlYTE0MjQ1ZWFmODY4MTZjM2RmZjE1Ny4uNGJiOTM1ZTU2ZThhNmViNDUxNzcw NjJiZWYxODM0OWI4MThjNDAxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9u L0FuaW1hdGlvblRpbWVsaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQW5p bWF0aW9uVGltZWxpbmUuY3BwCkBAIC00NywxMyArNDcsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKLUFuaW1hdGlvblRpbWVsaW5lOjpBbmltYXRpb25UaW1lbGluZSgpCi17Ci19Ci0KLUFu aW1hdGlvblRpbWVsaW5lOjp+QW5pbWF0aW9uVGltZWxpbmUoKQotewotfQorQW5pbWF0aW9uVGlt ZWxpbmU6OkFuaW1hdGlvblRpbWVsaW5lKCkgPSBkZWZhdWx0OworQW5pbWF0aW9uVGltZWxpbmU6 On5BbmltYXRpb25UaW1lbGluZSgpID0gZGVmYXVsdDsKIAogdm9pZCBBbmltYXRpb25UaW1lbGlu ZTo6Zm9yZ2V0QW5pbWF0aW9uKFdlYkFuaW1hdGlvbiogYW5pbWF0aW9uKQogewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0FuaW1hdGlvblRpbWVsaW5lLmggYi9Tb3VyY2Uv V2ViQ29yZS9hbmltYXRpb24vQW5pbWF0aW9uVGltZWxpbmUuaAppbmRleCA0ZWRjNTUzNDJmMDEy ODU1MGI5MDQzOGE2NzEzNmY2NzA4NWMwYTI0Li42MTU2ZDQ5Yzg3NWFkNTg0OWZhNDdhNzRiZDAw NmRjYWZjMTgwYWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQW5pbWF0 aW9uVGltZWxpbmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQW5pbWF0aW9uVGlt ZWxpbmUuaApAQCAtNDgsMTAgKzQ4LDEyIEBAIGNsYXNzIEVsZW1lbnQ7CiAKIGNsYXNzIEFuaW1h dGlvblRpbWVsaW5lIDogcHVibGljIFJlZkNvdW50ZWQ8QW5pbWF0aW9uVGltZWxpbmU+LCBwdWJs aWMgQ2FuTWFrZVdlYWtQdHI8QW5pbWF0aW9uVGltZWxpbmU+IHsKIHB1YmxpYzoKKyAgICB2aXJ0 dWFsIH5BbmltYXRpb25UaW1lbGluZSgpOworCiAgICAgdmlydHVhbCBib29sIGlzRG9jdW1lbnRU aW1lbGluZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKLSAgICBBbmltYXRpb25Db2xsZWN0 aW9uIHJlbGV2YW50QW5pbWF0aW9ucygpIGNvbnN0IHsgcmV0dXJuIG1fYW5pbWF0aW9uczsgfQot ICAgIFZlY3RvcjxXZWFrUHRyPFdlYkFuaW1hdGlvbj4+IGFsbEFuaW1hdGlvbnMoKSBjb25zdCB7 IHJldHVybiBtX2FsbEFuaW1hdGlvbnM7IH0KKyAgICBjb25zdCBBbmltYXRpb25Db2xsZWN0aW9u JiByZWxldmFudEFuaW1hdGlvbnMoKSBjb25zdCB7IHJldHVybiBtX2FuaW1hdGlvbnM7IH0KKyAg ICBjb25zdCBWZWN0b3I8V2Vha1B0cjxXZWJBbmltYXRpb24+PiYgYWxsQW5pbWF0aW9ucygpIGNv bnN0IHsgcmV0dXJuIG1fYWxsQW5pbWF0aW9uczsgfQogCiAgICAgdm9pZCBmb3JnZXRBbmltYXRp b24oV2ViQW5pbWF0aW9uKik7CiAgICAgdmlydHVhbCB2b2lkIGFuaW1hdGlvblRpbWluZ0RpZENo YW5nZShXZWJBbmltYXRpb24mKTsKQEAgLTYxLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgT3B0aW9uYWw8U2Vjb25kcz4gY3VycmVudFRpbWUoKSB7IHJldHVybiBtX2N1cnJlbnRUaW1l OyB9CiAKICAgICBlbnVtIGNsYXNzIE9yZGVyaW5nIDogdWludDhfdCB7IFNvcnRlZCwgVW5zb3J0 ZWQgfTsKLSAgICBWZWN0b3I8UmVmUHRyPFdlYkFuaW1hdGlvbj4+IGFuaW1hdGlvbnNGb3JFbGVt ZW50KEVsZW1lbnQmLCBPcmRlcmluZyBvcmRlcmluZyA9IE9yZGVyaW5nOjpVbnNvcnRlZCkgY29u c3Q7CisgICAgVmVjdG9yPFJlZlB0cjxXZWJBbmltYXRpb24+PiBhbmltYXRpb25zRm9yRWxlbWVu dChFbGVtZW50JiwgT3JkZXJpbmcgPSBPcmRlcmluZzo6VW5zb3J0ZWQpIGNvbnN0OwogCiAgICAg dm9pZCBlbGVtZW50V2FzUmVtb3ZlZChFbGVtZW50Jik7CiAKQEAgLTc2LDggKzc4LDYgQEAgcHVi bGljOgogICAgIHZvaWQgdXBkYXRlQ1NTQW5pbWF0aW9uc0ZvckVsZW1lbnQoRWxlbWVudCYsIGNv bnN0IFJlbmRlclN0eWxlKiBjdXJyZW50U3R5bGUsIGNvbnN0IFJlbmRlclN0eWxlJiBhZnRlckNo YW5nZVN0eWxlKTsKICAgICB2b2lkIHVwZGF0ZUNTU1RyYW5zaXRpb25zRm9yRWxlbWVudChFbGVt ZW50JiwgY29uc3QgUmVuZGVyU3R5bGUmIGN1cnJlbnRTdHlsZSwgY29uc3QgUmVuZGVyU3R5bGUm IGFmdGVyQ2hhbmdlU3R5bGUpOwogCi0gICAgdmlydHVhbCB+QW5pbWF0aW9uVGltZWxpbmUoKTsK LQogcHJvdGVjdGVkOgogICAgIGV4cGxpY2l0IEFuaW1hdGlvblRpbWVsaW5lKCk7CiAK