21115 2008-09-25 12:10:45 -0700 REGRESSION (r34702): Safari no longer zips bundled documents 2009-05-21 00:56:55 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 25879 1 darin darin oldest_to_newest 92770 0 darin 2008-09-25 12:10:45 -0700 This feature got broken somewhere along the line. 92771 1 darin 2008-09-25 12:11:08 -0700 <rdar://problem/6245773> 92772 2 23814 darin 2008-09-25 12:12:35 -0700 Created attachment 23814 patch 92783 3 darin 2008-09-25 13:02:30 -0700 http://trac.webkit.org/changeset/36903 122266 4 eric 2009-05-21 00:34:04 -0700 Looks like this regressed again, see bug 25879. At least we can make automated tests for this now with bug 25852 resolved! 122274 5 mrowe 2009-05-21 00:54:35 -0700 This didn't regress. Eric misunderstood how this works. 122275 6 eric 2009-05-21 00:56:55 -0700 What Mark means is that the ChromeClient gets to decide. The Safari client only decides to handle package files. bug 25879 is related, but not the same bug, as it's about handling directories in <input> elements. We accept the drop of a directory and then fail to handle it. We should either not accept the drop or handle them if we accept them. :) 23814 2008-09-25 12:12:35 -0700 2008-09-25 12:51:11 -0700 patch BundlePatch.txt text/plain 3697 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjkwMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMjUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTExNQorICAgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MjQ1NzczPiBSRUdSRVNTSU9OIChyMzQ3MDIpOiBTYWZhcmkgbm8g bG9uZ2VyIHppcHMKKyAgICAgICAgICBidW5kbGVkIGRvY3VtZW50cworCisgICAgICAgICogaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50 Ojpmb3JtRGF0YSk6IFVzZSBmaWxlcygpIGluc3RlYWQgb2YgdmFsdWUoKQorICAgICAgICB0byBn ZXQgdGhlIHBhdGgsIHNpbmNlIHZhbHVlKCkgbm93IHJldHVybnMganVzdCB0aGUgYmFzZW5hbWUu CisKIDIwMDgtMDktMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAg ICAgIFJ1YmJlcnN0YW1wZWQgYnkgTWFyayBSb3dlCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZv cm1FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50 LmNwcAkocmV2aXNpb24gMzY5MDEpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgIkRvY3VtZW50Lmgi CiAjaW5jbHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCisjaW5jbHVkZSAi RmlsZUxpc3QuaCIKICNpbmNsdWRlICJGaWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiRm9ybURhdGEu aCIKICNpbmNsdWRlICJGb3JtRGF0YUxpc3QuaCIKQEAgLTI3NCwxNyArMjc1LDIzIEBAIFBhc3NS ZWZQdHI8Rm9ybURhdGE+IEhUTUxGb3JtRWxlbWVudDo6Zm8KICAgICAgICAgICAgICAgICAgICAg Ly8gaW5jbHVkZSB0aGUgZmlsZW5hbWUKICAgICAgICAgICAgICAgICAgICAgaWYgKGNvbnRyb2wt Pmhhc0xvY2FsTmFtZShpbnB1dFRhZykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmJiBz dGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oY29udHJvbCktPmlucHV0VHlwZSgpID09IEhU TUxJbnB1dEVsZW1lbnQ6OkZJTEUpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZyBw YXRoID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KGNvbnRyb2wpLT52YWx1ZSgpOwot ICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIGZpbGVuYW1lID0gcGF0aEdldEZpbGVOYW1l KHBhdGgpOworICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIHBhdGg7CisgICAgICAgICAg ICAgICAgICAgICAgICBTdHJpbmcgZmlsZW5hbWU7CisgICAgICAgICAgICAgICAgICAgICAgICBj b25zdCBGaWxlTGlzdCogZmlsZXMgPSBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oY29u dHJvbCktPmZpbGVzKCk7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWZpbGVzLT5pc0Vt cHR5KCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBOT1RFOiBXZSBjdXJyZW50 bHkgb25seSBoYW5kbGUgb25lIGZpbGU7IHNvbWUgZGF5IHdlJ2xsIGFkZCBtdWx0aXBsZSBmaWxl IHN1cHBvcnQuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgRmlsZSogZmlsZSA9 IGZpbGVzLT5pdGVtKDApOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhdGggPSBmaWxl LT5wYXRoKCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZW5hbWUgPSBmaWxlLT5m aWxlTmFtZSgpOworICAgICAgICAgICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAg ICAgICAgICAvLyBMZXQgdGhlIGFwcGxpY2F0aW9uIHNwZWNpZnkgYSBmaWxlbmFtZSBpZiBpdHMg Z29pbmcgdG8gZ2VuZXJhdGUgYSByZXBsYWNlbWVudCBmaWxlIGZvciB0aGUgdXBsb2FkCisgICAg ICAgICAgICAgICAgICAgICAgICAvLyBMZXQgdGhlIGFwcGxpY2F0aW9uIHNwZWNpZnkgYSBmaWxl bmFtZSBpZiBpdCdzIGdvaW5nIHRvIGdlbmVyYXRlIGEgcmVwbGFjZW1lbnQgZmlsZSBmb3IgdGhl IHVwbG9hZC4KICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZG9jdW1l bnQoKS0+cGFnZSgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIGdlbmVy YXRlZEZpbGVuYW1lOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNob3VsZEdlbmVyYXRl RmlsZSA9IHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+c2hvdWxkUmVwbGFjZVdpdGhHZW5lcmF0 ZWRGaWxlRm9yVXBsb2FkKHBhdGgsIGdlbmVyYXRlZEZpbGVuYW1lKTsKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpZiAoc2hvdWxkR2VuZXJhdGVGaWxlKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBmaWxlbmFtZSA9IGdlbmVyYXRlZEZpbGVuYW1lOwogICAgICAgICAgICAg ICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgICAgICAgCiAKICAgICAgICAgICAgICAg ICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHdvbid0IHdvcmsgaWYgdGhlIGZpbGVuYW1lIGluY2x1 ZGVzIGEgIiBtYXJrLAogICAgICAgICAgICAgICAgICAgICAgICAgLy8gb3IgY29udHJvbCBjaGFy YWN0ZXJzIGxpa2UgQ1Igb3IgTEYuIFRoaXMgYWxzbyBkb2VzIHN0cmFuZ2UKQEAgLTI5NSw2ICsz MDIsOSBAQCBQYXNzUmVmUHRyPEZvcm1EYXRhPiBIVE1MRm9ybUVsZW1lbnQ6OmZvCiAgICAgICAg ICAgICAgICAgICAgICAgICBoZWFkZXIuYXBwZW5kKCciJyk7CiAKICAgICAgICAgICAgICAgICAg ICAgICAgIGlmICghZmlsZW5hbWUuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLy8gRklYTUU6IFRoaXMgZnVuY3Rpb24ncyBuYW1lIG1ha2VzIGl0IHNvdW5kIGxpa2Ug aXQgdGFrZXMgYSBwYXRoLCBub3QganVzdCBhIGJhc2VuYW1lLgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIC8vIEJ1dCBmaWxlbmFtZSBpcyBub3QgdGhlIHBhdGguIEJ1dCBub3RlLCB0aGF0 IGl0J3Mgbm90IHNhZmUgdG8ganVzdCB1c2UgcGF0aCwgaW5zdGVhZAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIC8vIHNpbmNlIGluIHRoZSBnZW5lcmF0ZWQtZmlsZSBjYXNlIGl0IHdpbGwg bm90IHJlZmxlY3QgdGhlIE1JTUUgdHlwZSBvZiB0aGUgZ2VuZXJhdGVkIGZpbGUuCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgU3RyaW5nIG1pbWVUeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6 Z2V0TUlNRVR5cGVGb3JQYXRoKGZpbGVuYW1lKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpZiAoIW1pbWVUeXBlLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBhcHBlbmRTdHJpbmcoaGVhZGVyLCAiXHJcbkNvbnRlbnQtVHlwZTogIik7Cg==