211133 2020-04-28 09:40:44 -0700 REGRESSION(r260822): Broke media/track/track-in-band-metadata-display-order.html on Mac 2020-04-28 11:58:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210976 InRadar P2 Normal --- 1 pnormand pnormand calvaris eric.carlson ews-watchlist glenn jer.noble Lawrence.j philipj sergio webkit-bug-importer oldest_to_newest 1646529 0 pnormand 2020-04-28 09:40:44 -0700 , 1646532 1 397847 pnormand 2020-04-28 09:47:04 -0700 Created attachment 397847 Patch 1646534 2 pnormand 2020-04-28 09:49:52 -0700 *** Bug 211132 has been marked as a duplicate of this bug. *** 1646539 3 pnormand 2020-04-28 09:57:10 -0700 history: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-in-band-metadata-display-order.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-actual.txt @@ -15,7 +15,7 @@ RUN(metadataTrack.addCue(new DataCue(2.25, video.duration, "second data cue"))) RUN(video.currentTime = 3) EVENT(seeked) -EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later') OK -EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier') OK +EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later'), OBSERVED 'I am later ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL +EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier'), OBSERVED 'I am earlier ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL END OF TEST [tag] [reply] [−] Comment 7 1646541 4 pnormand 2020-04-28 09:58:47 -0700 Apololgies for not noticing this, because in GTK we had that test flagged already as failing/crash/pass ... See #198830 1646554 5 397847 pnormand 2020-04-28 10:39:14 -0700 Comment on attachment 397847 Patch Forgot to rebaseline. 1646557 6 397856 pnormand 2020-04-28 10:53:29 -0700 Created attachment 397856 Patch 1646559 7 pnormand 2020-04-28 10:54:51 -0700 I unflagged the test on GTK and checked it passes. Can't check on mac currently though. 1646589 8 ews-feeder 2020-04-28 11:57:09 -0700 Committed r260835: <https://trac.webkit.org/changeset/260835> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397856. 1646590 9 webkit-bug-importer 2020-04-28 11:58:20 -0700 <rdar://problem/62534924> 397847 2020-04-28 09:47:04 -0700 2020-04-28 10:53:25 -0700 Patch bug-211133-20200428164703.patch text/plain 1855 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTg0OWJjYWIyOGU0YTc5OGQwOGQ2 NTA5MDkyYmNiNDMwODc2Njg5OC4uYWQ2YWQyNmMxYzBjNWI3YjI2MTFhOWRmMjJkZDk3MDQxMGZl MjhmZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI4ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjA4MjIpOiBC cm9rZSBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLW1ldGFkYXRhLWRpc3BsYXktb3JkZXIuaHRt bCBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMTEzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLmh0bWw6 IEVuc3VyZSB0aGUgY2FwdGlvbgorICAgICAgICBkaXNwbGF5IG1vZGUgaXMgc2V0IHRvIGF1dG9t YXRpYywgdGhpcyBpcyBhIHJlcXVpcmVtZW50IGZvciB0aGUKKyAgICAgICAgdGVzdC4KKwogMjAy MC0wNC0yOCAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBO dWxscHRyIGNyYXNoIGluIEVkaXRDb21tYW5kOjpFZGl0Q29tbWFuZCB2aWEgQ29tcG9zaXRlRWRp dENvbW1hbmQ6OnJlbW92ZU5vZGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLWluLWJhbmQtbWV0YWRhdGEtZGlzcGxheS1vcmRlci5odG1sIGIvTGF5b3V0VGVzdHMv bWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLmh0bWwKaW5k ZXggZTMxZThhODllMzc2YjU0MTcxMWYyMjlhY2M5MmJjM2IzODk5NDExMi4uZTcyZmRmMGQzNTZk YzRiMjNkZjdkNDY5MWE3NTM3ZTIzZjVjNmExNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9y ZGVyLmh0bWwKQEAgLTYsNiArNiwxMiBAQAogICAgIDxzY3JpcHQgc3JjPSIuLi9tZWRpYS1maWxl LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iLi4vbWVkaWEtY29udHJvbHMuanMiPjwv c2NyaXB0PgogICAgIDxzY3JpcHQ+CisgICAgICAgIGZ1bmN0aW9uIHNldHVwKCkKKyAgICAgICAg eworICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgICAgICAgICAgcnVu KCJpbnRlcm5hbHMuc2V0Q2FwdGlvbkRpc3BsYXlNb2RlKCdBdXRvbWF0aWMnKSIpOworICAgICAg ICB9CisKICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBhc3luYyBldmVu dCA9PiB7CiAgICAgICAgICAgICB3aW5kb3cudmlkZW8gPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCd2aWRlbycpOwogICAgICAgICAgICAgcnVuKCd2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCJ2 aWRlbyIsICIuLi9jb250ZW50L3Rlc3QiKScpOwpAQCAtMzUsNyArNDEsNyBAQAogICAgICAgICB9 KTsKICAgICA8L3NjcmlwdD4KIDwvaGVhZD4KLTxib2R5PgorPGJvZHkgb25sb2FkPSJzZXR1cCgp Ij4KICAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KIDwvYm9keT4KLTwvaHRtbD4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis8L2h0bWw+Cg== 397856 2020-04-28 10:53:29 -0700 2020-04-28 11:57:10 -0700 Patch bug-211133-20200428175327.patch text/plain 2323 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTg0OWJjYWIyOGU0YTc5OGQwOGQ2 NTA5MDkyYmNiNDMwODc2Njg5OC4uNDc4ZDIxZDYyM2UzYTQwNTNlZWJlZWM2OGIwNTAxY2U4NWM2 NzNkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI4ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjA4MjIpOiBC cm9rZSBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLW1ldGFkYXRhLWRpc3BsYXktb3JkZXIuaHRt bCBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMTEzMworCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICAq IG1lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtbWV0YWRhdGEtZGlzcGxheS1vcmRlci5odG1sOiBF bnN1cmUgdGhlIGNhcHRpb24KKyAgICAgICAgZGlzcGxheSBtb2RlIGlzIHNldCB0byBmb3JjZWQt b25seSwgdGhpcyBpcyBhIHJlcXVpcmVtZW50IGZvciB0aGUKKyAgICAgICAgdGVzdC4KKwogMjAy MC0wNC0yOCAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBO dWxscHRyIGNyYXNoIGluIEVkaXRDb21tYW5kOjpFZGl0Q29tbWFuZCB2aWEgQ29tcG9zaXRlRWRp dENvbW1hbmQ6OnJlbW92ZU5vZGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLWluLWJhbmQtbWV0YWRhdGEtZGlzcGxheS1vcmRlci1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1pbi1iYW5kLW1ldGFkYXRhLWRpc3BsYXktb3JkZXIt ZXhwZWN0ZWQudHh0CmluZGV4IDYwZjc1ZDI4NDE1MzQ5YTc0MGVhNzkxYzk5MzMwNTNmMDU4ZmFm OTMuLmU0NGExYjAzNjdkN2FkYTZhMjYzNGJkZDhiNmE2MzhiYWMwMWEwZTQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtbWV0YWRhdGEtZGlzcGxheS1v cmRlci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4t YmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLWV4cGVjdGVkLnR4dApAQCAtMSw0ICsxLDUgQEAK IAorUlVOKGludGVybmFscy5zZXRDYXB0aW9uRGlzcGxheU1vZGUoJ0ZvcmNlZE9ubHknKSkKIFJV Tih2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICIuLi9jb250ZW50L3Rlc3QiKSkK IEVWRU5UKGNhbnBsYXl0aHJvdWdoKQogUlVOKGNhcHRpb25UcmFjayA9IHZpZGVvLmFkZFRleHRU cmFjaygiY2FwdGlvbnMiKSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3Ry YWNrLWluLWJhbmQtbWV0YWRhdGEtZGlzcGxheS1vcmRlci5odG1sIGIvTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLmh0bWwKaW5kZXgg ZTMxZThhODllMzc2YjU0MTcxMWYyMjlhY2M5MmJjM2IzODk5NDExMi4uOWM2NDM3OTczMzRlM2Rl ZjllOTE4MjQ1NDFiYzg1MTAzODRkMWQ2YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVyLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1tZXRhZGF0YS1kaXNwbGF5LW9yZGVy Lmh0bWwKQEAgLTcsNiArNyw4IEBACiAgICAgPHNjcmlwdCBzcmM9Ii4uL21lZGlhLWNvbnRyb2xz LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0PgogICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcignbG9hZCcsIGFzeW5jIGV2ZW50ID0+IHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50 ZXJuYWxzKQorICAgICAgICAgICAgICAgIHJ1bigiaW50ZXJuYWxzLnNldENhcHRpb25EaXNwbGF5 TW9kZSgnRm9yY2VkT25seScpIik7CiAgICAgICAgICAgICB3aW5kb3cudmlkZW8gPSBkb2N1bWVu dC5xdWVyeVNlbGVjdG9yKCd2aWRlbycpOwogICAgICAgICAgICAgcnVuKCd2aWRlby5zcmMgPSBm aW5kTWVkaWFGaWxlKCJ2aWRlbyIsICIuLi9jb250ZW50L3Rlc3QiKScpOwogCkBAIC0zOCw0ICs0 MCw0IEBACiA8Ym9keT4KICAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KIDwvYm9keT4KLTwv aHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis8L2h0bWw+Cg==