210658 2020-04-17 09:26:21 -0700 REGRESSION (r234105): [iOS] WKColorButton leaks a UIColor 2020-04-17 15:08:37 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 187871 1 ddkilzer ddkilzer cdumez darin esprehn+autocc ews-watchlist gyuyoung.kim mifenton thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1642706 0 ddkilzer 2020-04-17 09:26:21 -0700 WKColorButton leaks a UIColor. Found by clang static analyzer: 'WKColorButton' lacks a 'dealloc' instance method but must release '_color' -- #pragma mark - WKColorButton @interface WKColorButton : UIButton @property (nonatomic, strong) UIColor *color; + (instancetype)colorButtonWithColor:(UIColor *)color; @end @implementation WKColorButton + (instancetype)colorButtonWithColor:(UIColor *)color { WKColorButton *colorButton = [WKColorButton buttonWithType:UIButtonTypeCustom]; colorButton.color = color; colorButton.backgroundColor = color; return colorButton; } @end 1642708 1 webkit-bug-importer 2020-04-17 09:27:32 -0700 <rdar://problem/61938137> 1642709 2 396770 ddkilzer 2020-04-17 09:31:30 -0700 Created attachment 396770 Patch v1 1642727 3 396770 darin 2020-04-17 10:15:28 -0700 Comment on attachment 396770 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396770&action=review > Source/WebCore/page/Chrome.cpp:428 > #if PLATFORM(IOS_FAMILY) > return nullptr; > -#endif > +#else > notifyPopupOpeningObservers(); > return m_client.createColorChooser(client, initialColor); > +#endif We need UNUSED_PARAM here. I also think the "always-null color chooser" design strategy is a little messy, but that goes beyond this function 1642850 4 396803 ddkilzer 2020-04-17 14:42:16 -0700 Created attachment 396803 Patch for landing 1642862 5 ews-feeder 2020-04-17 15:08:36 -0700 Committed r260290: <https://trac.webkit.org/changeset/260290> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396803. 396770 2020-04-17 09:31:30 -0700 2020-04-17 14:42:14 -0700 Patch v1 bug-210658-20200417093247.patch text/plain 3333 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFmZWYwZTg3MjIzNjk0 MmY2NWFhMzJiNmM3ZTFlMWYwMzkyZjhlZC4uOTdjZGQ1ZDM0Yjc0Y2E0ODFlMTlmMWIwNjUxNjUz MWIyZTIwODVhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTE3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIz NDEwNSk6IFtpT1NdIFdLQ29sb3JCdXR0b24gbGVha3MgYSBVSUNvbG9yCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8yMTA2NTg+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTkzODEz Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0 bWwvQ29sb3JJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3JJbnB1dFR5cGU6 OmlzS2V5Ym9hcmRGb2N1c2FibGUgY29uc3QpOgorICAgICAgICAqIHBhZ2UvQ2hyb21lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6Y3JlYXRlQ29sb3JDaG9vc2VyKToKKyAgICAgICAg LSBEcml2ZS1ieSBmaXggb2YgdW5yZWFjaGFibGUgY29kZSBvbiBQTEFURk9STShJT1NfRkFNSUxZ KS4KKwogMjAyMC0wNC0xNiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBmb3Igbm9uIHVuaWZpZWQgYnVpbGRz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwppbmRleCBiMWQ3YWY5OWMxYTY4OWQ2N2NhNTQ5YjI5ODkyZTliMmE5YWZkYTlkLi5m MjQ2N2VhNDQ3Zjc3MmE2ZDEwYWExN2I4Mjc1ZGUxZGRjMGU1NDM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTA0LTE3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIzNDEwNSk6IFtpT1NdIFdLQ29sb3JCdXR0b24gbGVh a3MgYSBVSUNvbG9yCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTA2NTg+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MTkzODEzNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtQ29sb3JQ aWNrZXIubW06CisgICAgICAgICgtW1dLQ29sb3JCdXR0b24gZGVhbGxvY10pOiBBZGQuCisgICAg ICAgIC0gUmVsZWFzZSBfY29sb3IgaW5zdGFuY2UgdmFyaWFibGUgdG8gZml4IGxlYWsuCisKIDIw MjAtMDQtMTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMjU2NzU2KTogLVtXS1VzZXJEZWZhdWx0cyBpbml0V2l0aFN1aXRlTmFtZTpd OiBJbnN0YW5jZSB2YXJpYWJsZSB1c2VkIHdoaWxlICdzZWxmJyBpcyBub3Qgc2V0IHRvIHRoZSBy ZXN1bHQgb2YgJ1soc3VwZXIgb3Igc2VsZikgaW5pdC4uLl0nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29s b3JJbnB1dFR5cGUuY3BwCmluZGV4IDg1Y2ViMzMxM2VhOTEyZmU0ZjMxZjlmOWFiNDc0OTVmNGUw YzJjYmEuLjIzNzhhZDYxMDk4ODMzNjZlMGU0YTdmMGJiODkxMWZkNzdmOTA3MjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCkBAIC05NCw4ICs5NCw5IEBAIGJvb2wgQ29s b3JJbnB1dFR5cGU6OmlzS2V5Ym9hcmRGb2N1c2FibGUoS2V5Ym9hcmRFdmVudCopIGNvbnN0CiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHJldHVybiBlbGVtZW50KCktPmlzVGV4dEZvcm1D b250cm9sRm9jdXNhYmxlKCk7Ci0jZW5kaWYKKyNlbHNlCiAgICAgcmV0dXJuIGZhbHNlOworI2Vu ZGlmCiB9CiAKIGJvb2wgQ29sb3JJbnB1dFR5cGU6OmlzQ29sb3JDb250cm9sKCkgY29uc3QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvQ2hyb21lLmNwcAppbmRleCBhMGNlYWIxNmI1OGY4ZGQ2MjU2ZjNkODZiMTkyOGZmYzc4 MDRhOTgzLi41Nzg1ZTM4MzMxZTY5NWE0MDdjYTYxOGI2ZmZhNzY1OWM0YjFhMzAyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9DaHJvbWUuY3BwCkBAIC00MjIsOSArNDIyLDEwIEBAIHN0ZDo6dW5pcXVlX3B0cjxDb2xv ckNob29zZXI+IENocm9tZTo6Y3JlYXRlQ29sb3JDaG9vc2VyKENvbG9yQ2hvb3NlckNsaWVudCYg Y2xpCiB7CiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICByZXR1cm4gbnVsbHB0cjsKLSNl bmRpZgorI2Vsc2UKICAgICBub3RpZnlQb3B1cE9wZW5pbmdPYnNlcnZlcnMoKTsKICAgICByZXR1 cm4gbV9jbGllbnQuY3JlYXRlQ29sb3JDaG9vc2VyKGNsaWVudCwgaW5pdGlhbENvbG9yKTsKKyNl bmRpZgogfQogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0Zvcm1Db2xvclBpY2tlci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0Zvcm1Db2xvclBpY2tlci5tbQppbmRleCBjZTY3ODQyYzdmZTAzYjUxYzY2MGEx ODk2NTIyMzcyOWUxNTVmZmJjLi5lODk1Y2EwZTQ0NTlhYThiMmQwMWEzOGFhMjJlNjAxOTlkZGMz MmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3Jt Q29sb3JQaWNrZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dL Rm9ybUNvbG9yUGlja2VyLm1tCkBAIC03NSw2ICs3NSwxNCBAQCArIChpbnN0YW5jZXR5cGUpY29s b3JCdXR0b25XaXRoQ29sb3I6KFVJQ29sb3IgKiljb2xvcgogICAgIHJldHVybiBjb2xvckJ1dHRv bjsKIH0KIAorLSAodm9pZClkZWFsbG9jCit7CisgICAgW19jb2xvciByZWxlYXNlXTsKKyAgICBf Y29sb3IgPSBuaWw7CisKKyAgICBbc3VwZXIgZGVhbGxvY107Cit9CisKIEBlbmQKIAogI3ByYWdt YSBtYXJrIC0gV0tDb2xvck1hdHJpeFZpZXcK 396803 2020-04-17 14:42:16 -0700 2020-04-17 15:08:36 -0700 Patch for landing bug-210658-20200417144334.patch text/plain 3350 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjNzkwNjFmM2E1Nzlh ZDkzNDU4ZDlkZTgwZGI3NDFmMTkxMjJhYi4uNWE5YWQ3MGM1YjhjYzY4ZjMwZjU0YTlhYzIxYzZj MTdmYmYxM2NjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTE3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIz NDEwNSk6IFtpT1NdIFdLQ29sb3JCdXR0b24gbGVha3MgYSBVSUNvbG9yCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8yMTA2NTg+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTkzODEz Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIGh0bWwv Q29sb3JJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3JJbnB1dFR5cGU6Omlz S2V5Ym9hcmRGb2N1c2FibGUgY29uc3QpOgorICAgICAgICAqIHBhZ2UvQ2hyb21lLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNocm9tZTo6Y3JlYXRlQ29sb3JDaG9vc2VyKToKKyAgICAgICAgLSBE cml2ZS1ieSBmaXggb2YgdW5yZWFjaGFibGUgY29kZSBvbiBQTEFURk9STShJT1NfRkFNSUxZKS4K KwogMjAyMC0wNC0xNyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAg ICAgICAgIFtDTWFrZV0gQWRkIFdlYktpdDo6V2ViQ29yZSB0YXJnZXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZDdk ZDk5OWUyMjlhM2NkNjM2NmYzNjUzMTAwMjI4MGFiNjdjY2YwYS4uYzJjNjAwZjg0NTI5Y2YyMmJj NjBlODMxYjAwMzlhNjA0NDZiNDcwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0w NC0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04gKHIyMzQxMDUpOiBbaU9TXSBXS0NvbG9yQnV0dG9uIGxlYWtzIGEgVUlDb2xvcgorICAg ICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjEwNjU4PgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjE5MzgxMzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybUNvbG9yUGlja2VyLm1tOgorICAgICAgICAo LVtXS0NvbG9yQnV0dG9uIGRlYWxsb2NdKTogQWRkLgorICAgICAgICAtIFJlbGVhc2UgX2NvbG9y IGluc3RhbmNlIHZhcmlhYmxlIHRvIGZpeCBsZWFrLgorCiAyMDIwLTA0LTE3ICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEJyaW5nIEZ1bGxzY3JlZW4gQVBJICsg YWxlcnQoKSBiZWhhdmlvciBmcm9tIGlPUyB0byBtYWNPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9Db2xvcklucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9y SW5wdXRUeXBlLmNwcAppbmRleCA4NWNlYjMzMTNlYTkxMmZlNGYzMWY5ZjlhYjQ3NDk1ZjRlMGMy Y2JhLi4yMzc4YWQ2MTA5ODgzMzY2ZTBlNGE3ZjBiYjg5MTFmZDc3ZjkwNzIxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcApAQCAtOTQsOCArOTQsOSBAQCBib29sIENvbG9y SW5wdXRUeXBlOjppc0tleWJvYXJkRm9jdXNhYmxlKEtleWJvYXJkRXZlbnQqKSBjb25zdAogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1cm4gZWxlbWVudCgpLT5pc1RleHRGb3JtQ29u dHJvbEZvY3VzYWJsZSgpOwotI2VuZGlmCisjZWxzZQogICAgIHJldHVybiBmYWxzZTsKKyNlbmRp ZgogfQogCiBib29sIENvbG9ySW5wdXRUeXBlOjppc0NvbG9yQ29udHJvbCgpIGNvbnN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0Nocm9tZS5jcHAKaW5kZXggYTBjZWFiMTZiNThmOGRkNjI1NmYzZDg2YjE5MjhmZmM3ODA0 YTk4My4uYTNjZGUzZTBmNTI0ZDA2ZmM3N2Y1ZTBiYjgyYzlhNTk4NzcwNjMzYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvQ2hyb21lLmNwcApAQCAtNDIxLDEwICs0MjEsMTMgQEAgdm9pZCBDaHJvbWU6OmRpc2FibGVT dWRkZW5UZXJtaW5hdGlvbigpCiBzdGQ6OnVuaXF1ZV9wdHI8Q29sb3JDaG9vc2VyPiBDaHJvbWU6 OmNyZWF0ZUNvbG9yQ2hvb3NlcihDb2xvckNob29zZXJDbGllbnQmIGNsaWVudCwgY29uc3QgQ29s b3ImIGluaXRpYWxDb2xvcikKIHsKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorICAgIFVOVVNF RF9QQVJBTShjbGllbnQpOworICAgIFVOVVNFRF9QQVJBTShpbml0aWFsQ29sb3IpOwogICAgIHJl dHVybiBudWxscHRyOwotI2VuZGlmCisjZWxzZQogICAgIG5vdGlmeVBvcHVwT3BlbmluZ09ic2Vy dmVycygpOwogICAgIHJldHVybiBtX2NsaWVudC5jcmVhdGVDb2xvckNob29zZXIoY2xpZW50LCBp bml0aWFsQ29sb3IpOworI2VuZGlmCiB9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybUNvbG9yUGlja2VyLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybUNvbG9yUGlja2VyLm1tCmluZGV4IGNlNjc4 NDJjN2ZlMDNiNTFjNjYwYTE4OTY1MjIzNzI5ZTE1NWZmYmMuLmU4OTVjYTBlNDQ1OWFhOGIyZDAx YTM4YWEyMmU2MDE5OWRkYzMyZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9mb3Jtcy9XS0Zvcm1Db2xvclBpY2tlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tGb3JtQ29sb3JQaWNrZXIubW0KQEAgLTc1LDYgKzc1LDE0IEBAICsg KGluc3RhbmNldHlwZSljb2xvckJ1dHRvbldpdGhDb2xvcjooVUlDb2xvciAqKWNvbG9yCiAgICAg cmV0dXJuIGNvbG9yQnV0dG9uOwogfQogCistICh2b2lkKWRlYWxsb2MKK3sKKyAgICBbX2NvbG9y IHJlbGVhc2VdOworICAgIF9jb2xvciA9IG5pbDsKKworICAgIFtzdXBlciBkZWFsbG9jXTsKK30K KwogQGVuZAogCiAjcHJhZ21hIG1hcmsgLSBXS0NvbG9yTWF0cml4Vmlldwo=