210329 2020-04-10 01:52:00 -0700 [GTK] Avoid direct GdkEvent field usage in GtkUtilities.h 2020-04-10 03:25:35 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez aperez aperez bugs-noreply cdumez cgarcia mcatanzaro zan oldest_to_newest 1640080 0 aperez 2020-04-10 01:52:00 -0700 Accessing GdkEvent field events is deprecated in GTK3 and unsupported in GTK4. Let's not do that in “Source/WebCore/platform/gtk/GtkUtilities.h” :) 1640081 1 396067 aperez 2020-04-10 01:54:30 -0700 Created attachment 396067 Patch 1640084 2 396067 aperez 2020-04-10 02:10:22 -0700 Comment on attachment 396067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396067&action=review > Source/WebCore/platform/gtk/GtkUtilities.h:37 > + const auto eventTime = gdk_event_get_time(reinterpret_cast<GdkEvent*>(const_cast<GdkEventType*>(event))); FTR, the “const_cast” here is needed because the accessor does no longer have “const” as type qualifier in GTK4, even when its code does not modify the GdkEvent. 1640097 3 ews-feeder 2020-04-10 03:25:34 -0700 Committed r259854: <https://trac.webkit.org/changeset/259854> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396067. 396067 2020-04-10 01:54:30 -0700 2020-04-10 03:25:34 -0700 Patch bug-210329-20200410115429.patch text/plain 1659 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdhOGRkMDNkODNhMWFk ZWNiZWVkMjYyZDM3YzM5ZjhlYzFiMGEwYi4uMTI1YThlODIxZjBmZWM4N2U4MDE0ZDRlOGNhNzFl ZTMwNDkzYjBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTEwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g QXZvaWQgZGlyZWN0IEdka0V2ZW50IGZpZWxkIHVzYWdlIGluIEd0a1V0aWxpdGllcy5oCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzMjkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0a1V0aWxpdGllcy5oOgorICAgICAg ICAoV2ViQ29yZTo6d2FsbFRpbWVGb3JFdmVudCk6IFVzZSBnZGtfZXZlbnRfZ2V0X3RpbWUoKSBp bnN0ZWFkIG9mIGRpcmVjdCBmaWVsZCBhY2Nlc3MuCisKIDIwMjAtMDQtMDcgIEFkcmlhbiBQZXJl eiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLNF0gRml4IHVz YWdlIG9mIEdESyBldmVudCBmdW5jdGlvbnMgaW4gUGxhdGZvcm1XaGVlbEV2ZW50R3RrCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0aWVzLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0aWVzLmgKaW5kZXggYzhkMDg3MGJiNWRi MDJkOGMyY2YyYWI5Y2Y0Yjk2NmFhN2Q5ODI0Mi4uZmE4OTY3ZWRiN2Y1NmZmMDNjYWIzNjJjMWJl NDk1N2YxOGY4OWJmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0 a1V0aWxpdGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtVdGlsaXRp ZXMuaApAQCAtMzQsOSArMzQsMTAgQEAgYm9vbCB3aWRnZXRJc09uc2NyZWVuVG9wbGV2ZWxXaW5k b3coR3RrV2lkZ2V0Kik7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBHZGtFdmVudFR5cGU+CiBXYWxsVGlt ZSB3YWxsVGltZUZvckV2ZW50KGNvbnN0IEdka0V2ZW50VHlwZSogZXZlbnQpCiB7Ci0gICAgaWYg KGV2ZW50LT50aW1lID09IEdES19DVVJSRU5UX1RJTUUpCisgICAgY29uc3QgYXV0byBldmVudFRp bWUgPSBnZGtfZXZlbnRfZ2V0X3RpbWUocmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGNvbnN0 X2Nhc3Q8R2RrRXZlbnRUeXBlKj4oZXZlbnQpKSk7CisgICAgaWYgKGV2ZW50VGltZSA9PSBHREtf Q1VSUkVOVF9USU1FKQogICAgICAgICByZXR1cm4gV2FsbFRpbWU6Om5vdygpOwotICAgIHJldHVy biBNb25vdG9uaWNUaW1lOjpmcm9tUmF3U2Vjb25kcyhldmVudC0+dGltZSAvIDEwMDAuKS5hcHBy b3hpbWF0ZVdhbGxUaW1lKCk7CisgICAgcmV0dXJuIE1vbm90b25pY1RpbWU6OmZyb21SYXdTZWNv bmRzKGV2ZW50VGltZSAvIDEwMDAuKS5hcHByb3hpbWF0ZVdhbGxUaW1lKCk7CiB9CiAKIHRlbXBs YXRlPD4K