210249 2020-04-08 23:24:22 -0700 [CSS Shadow Parts] Bad style sharing between sibling elements with different part attributes 2020-07-03 03:27:11 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Major --- 148695 1 justin webkit-unassigned emilio iamkulykov koivisto rniwa simon.fraser webkit-bug-importer oldest_to_newest 1639500 0 justin 2020-04-08 23:24:22 -0700 The ::part() selector released in 13.1, and as currently implemented in TP and nightly, is selecting the wrong elements when parts are nested in any container element in a shadow root. Given this DOM: <!-- This div is necessary to trigger the bug --> <div> <span part="one">Should be Blue</span> | <span part="two">Should be Red</span> </div> And these selectors: my-element::part(one) { color: blue; } my-element::part(two) { color: red; } The text spans should be blue then red as described. Instead they are both blue. If the <div> is removed, or if the second <span> is changed to a different tag, the colors are correct. JS Bin: https://jsbin.com/bucejul/3/edit 1639506 1 iamkulykov 2020-04-09 00:31:04 -0700 Setting style attribute, e.g. display, or direction attribute on part="two", also forces the red color to apply. 1639946 2 webkit-bug-importer 2020-04-09 16:10:25 -0700 <rdar://problem/61547528> 1640139 3 emilio 2020-04-10 06:15:22 -0700 That smells a lot like broken style sharing. Firefox had a somewhat similar bug in fact: https://bugzilla.mozilla.org/show_bug.cgi?id=1604989 1640151 4 koivisto 2020-04-10 06:46:26 -0700 Yeah, bet that's the problem. Those spans are obvious style sharing candidates if you forget about 'part'. 1640152 5 396079 koivisto 2020-04-10 07:14:40 -0700 Created attachment 396079 patch 1640163 6 396082 koivisto 2020-04-10 07:54:24 -0700 Created attachment 396082 patch 1640165 7 396082 dbates 2020-04-10 07:57:00 -0700 Comment on attachment 396082 patch Make sense to me, 1640209 8 ews-feeder 2020-04-10 09:13:47 -0700 Committed r259877: <https://trac.webkit.org/changeset/259877> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396082. 1640254 9 justin 2020-04-10 10:33:25 -0700 Thanks for the really quick turnaround! 1640260 10 justin 2020-04-10 10:48:56 -0700 A question about the release process for bug fixes like this: will this go out in a patch release on 13.1, or the next big release? ie, will we have to tell developers to use a ::part() polyfill until 13.2? 1640264 11 rniwa 2020-04-10 11:02:18 -0700 (In reply to Justin Fagnani from comment #10) > A question about the release process for bug fixes like this: will this go > out in a patch release on 13.1, or the next big release? ie, will we have to > tell developers to use a ::part() polyfill until 13.2? It’s unlikely that a bug fix like this makes it to a software update unless there is a major site that’s been actively affected. 1668529 12 koivisto 2020-07-03 03:27:11 -0700 FYI, this fix is in the current macOS 10.15.6/iOS 13.6 public beta. 396079 2020-04-10 07:14:40 -0700 2020-04-10 07:54:24 -0700 patch shadow-part-style-sharing.patch text/plain 4219 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZDAwZjViZTg5MS4uYzY3ODYzNjVkZTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMC0wNC0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg W0NTUyBTaGFkb3cgUGFydHNdIDo6cGFydCgpIHNlbGVjdG9yIHNlbGVjdHMgd3JvbmcgZWxlbWVu dHMgd2hlbiBwYXJ0cyBhcmUgbm90IHRvcC1sZXZlbCBjaGlsZHJlbiBvZiBhIHNoYWRvdyByb290 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyNDkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxNTQ3NTI4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9jc3Mvc2hhZG93LXBhcnRzL3NoYWRv dy1wYXJ0LXN0eWxlLXNoYXJpbmctZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9jc3Mvc2hhZG93LXBhcnRzL3NoYWRvdy1wYXJ0LXN0eWxlLXNoYXJpbmcuaHRtbDogQWRkZWQu CisKIDIwMjAtMDQtMDggIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBHYXJkZW5pbmcsIHVwZGF0ZSBUZXN0RXhwZWN0YXRpb25zCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUt c2hhcmluZy1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc2hhZG93LXBhcnRz L3NoYWRvdy1wYXJ0LXN0eWxlLXNoYXJpbmctZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMTc4MzBkMGFiODIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUtc2hhcmlu Zy1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjAgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+ CisgIDxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAgIFtwYXJ0PW9uZV0geworICAgICAgICBjb2xv cjogYmx1ZTsKKyAgICAgIH0KKyAgICAgIFtwYXJ0PXR3b10geworICAgICAgICBjb2xvcjogcmVk OworICAgICAgfQorICAgIDwvc3R5bGU+CisKKyAgPC9oZWFkPgorICA8Ym9keT4KKyAgICA8ZGl2 PgorICAgICAgPHNwYW4gcGFydD0ib25lIj5TaG91bGQgYmUgQmx1ZTwvc3Bhbj4gfAorICAgICAg PHNwYW4gcGFydD0idHdvIj5TaG91bGQgYmUgUmVkPC9zcGFuPgorICAgIDwvZGl2PgorICA8L2Jv ZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFy dHMvc2hhZG93LXBhcnQtc3R5bGUtc2hhcmluZy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv c2hhZG93LXBhcnRzL3NoYWRvdy1wYXJ0LXN0eWxlLXNoYXJpbmcuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMjdlZTg1Mzk5OTIKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUtc2hh cmluZy5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+CisgIDxo ZWFkPgorICAgIDxzdHlsZT4KKyAgICAgIG15LWVsZW1lbnQ6OnBhcnQob25lKSB7CisgICAgICAg IGNvbG9yOiBibHVlOworICAgICAgfQorICAgICAgbXktZWxlbWVudDo6cGFydCh0d28pIHsKKyAg ICAgICAgY29sb3I6IHJlZDsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+Cisg ICAgICBjbGFzcyBNeUVsZW1lbnQgZXh0ZW5kcyBIVE1MRWxlbWVudCB7CisgICAgICAgIGNvbnN0 cnVjdG9yKCkgeworICAgICAgICAgIHN1cGVyKCk7CisgICAgICAgICAgdGhpcy5hdHRhY2hTaGFk b3coe21vZGU6ICdvcGVuJ30pLmlubmVySFRNTCA9IGAKKyAgICAgICAgICAgIDwhLS0gVGhpcyBk aXYgaXMgbmVjY2Vzc2FyeSB0byB0cmlnZ2VyIHRoZSBidWcgLS0+CisgICAgICAgICAgICA8ZGl2 PgorICAgICAgICAgICAgICA8c3BhbiBwYXJ0PSJvbmUiPlNob3VsZCBiZSBCbHVlPC9zcGFuPiB8 CisgICAgICAgICAgICAgIDxzcGFuIHBhcnQ9InR3byI+U2hvdWxkIGJlIFJlZDwvc3Bhbj4KKyAg ICAgICAgICAgIDwvZGl2PgorICAgICAgICAgIGA7CisgICAgICAgIH0KKyAgICAgIH0KKyAgICAg IGN1c3RvbUVsZW1lbnRzLmRlZmluZSgnbXktZWxlbWVudCcsIE15RWxlbWVudCk7CisgICAgPC9z Y3JpcHQ+CisgIDwvaGVhZD4KKyAgPGJvZHk+CisgICAgPG15LWVsZW1lbnQ+PC9teS1lbGVtZXRu dD4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDUxMWRkYzdkZWYzLi5iMmI3ZWIx OTg1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA0LTEwICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBbQ1NTIFNoYWRvdyBQYXJ0c10gOjpw YXJ0KCkgc2VsZWN0b3Igc2VsZWN0cyB3cm9uZyBlbGVtZW50cyB3aGVuIHBhcnRzIGFyZSBub3Qg dG9wLWxldmVsIGNoaWxkcmVuIG9mIGEgc2hhZG93IHJvb3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDI0OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjE1NDc1Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU3R5bGUgc2hhcmluZyBvcHRpbWl6YXRpb24gd2FzIHVuY29uZGl0aW9uYWxseSBhbGxv d2VkIGZvciBlbGVtZW50cyB0aGF0IHdlcmUgc3R5bGVkIHdpdGggcGFydCBwc2V1ZG8gZWxlbWVu dC4KKyAgICAgICAgVGhpcyBjb3VsZCBsZWFkIHRvIG1pc2NvbXB1dGVkIHN0eWxlLgorCisgICAg ICAgIFRlc3QgY2FzZSBieSBKdXN0aW4gRmFnbmFuaS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nz cy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUtc2hhcmluZy5odG1sCisKKyAgICAgICAg KiBzdHlsZS9TdHlsZVNoYXJpbmdSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHls ZTo6U2hhcmluZ1Jlc29sdmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQpOgorCisgICAgICAg IE9ubHkgYWxsb3cgc3R5bGUgc2hhcmluZyBpZiBwYXJ0cyBtYXRjaC4KKwogMjAyMC0wNC0wOCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIHF1ZXJ5U2VsZWN0b3Io IiNcdTAwMDAiKSBzaG91bGQgbWF0Y2ggYW4gZWxlbWVudCB3aXRoIElEIFUrRkZGRApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwCmluZGV4IDYyZWNjZjZm MzYxLi4zZWIwOTliZTFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVT aGFyaW5nUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlU2hhcmlu Z1Jlc29sdmVyLmNwcApAQCAtMjI5LDYgKzIyOSw4IEBAIGJvb2wgU2hhcmluZ1Jlc29sdmVyOjpj YW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQoY29uc3QgQ29udGV4dCYgY29udGV4dCwgY29uc3QgU3R5 CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoY2FuZGlkYXRlRWxlbWVudC5zaGFkb3dQ c2V1ZG9JZCgpICE9IGVsZW1lbnQuc2hhZG93UHNldWRvSWQoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIGlmIChlbGVtZW50LmlzSW5TaGFkb3dUcmVlKCkgJiYgY2FuZGlkYXRlRWxlbWVu dC5wYXJ0TmFtZXMoKSAhPSBlbGVtZW50LnBhcnROYW1lcygpKQorICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgaWYgKCZjYW5kaWRhdGVFbGVtZW50ID09IG1fZG9jdW1lbnQuY3NzVGFyZ2V0KCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIXNoYXJpbmdDYW5kaWRhdGVIYXNJZGVu dGljYWxTdHlsZUFmZmVjdGluZ0F0dHJpYnV0ZXMoY29udGV4dCwgY2FuZGlkYXRlRWxlbWVudCkp Cg== 396082 2020-04-10 07:54:24 -0700 2020-04-10 09:13:47 -0700 patch shadow-part-style-sharing-2.patch text/plain 4175 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZDAwZjViZTg5MS4uOTQ2ZTYzMGI3ZmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMC0wNC0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg W0NTUyBTaGFkb3cgUGFydHNdIEJhZCBzdHlsZSBzaGFyaW5nIGJldHdlZW4gc2libGluZyBlbGVt ZW50cyB3aXRoIGRpZmZlcmVudCBwYXJ0IGF0dHJpYnV0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDI0OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjE1NDc1Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUtc2hhcmluZy1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hh ZG93LXBhcnQtc3R5bGUtc2hhcmluZy5odG1sOiBBZGRlZC4KKwogMjAyMC0wNC0wOCAgRGllZ28g UGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEdhcmRlbmlu ZywgdXBkYXRlIFRlc3RFeHBlY3RhdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL3NoYWRvdy1wYXJ0cy9zaGFkb3ctcGFydC1zdHlsZS1zaGFyaW5nLWV4cGVjdGVkLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBhcnQtc3R5bGUtc2hh cmluZy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw Li4xNzgzMGQwYWI4MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3No YWRvdy1wYXJ0cy9zaGFkb3ctcGFydC1zdHlsZS1zaGFyaW5nLWV4cGVjdGVkLmh0bWwKQEAgLTAs MCArMSwyMCBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPHN0eWxl PgorICAgICAgW3BhcnQ9b25lXSB7CisgICAgICAgIGNvbG9yOiBibHVlOworICAgICAgfQorICAg ICAgW3BhcnQ9dHdvXSB7CisgICAgICAgIGNvbG9yOiByZWQ7CisgICAgICB9CisgICAgPC9zdHls ZT4KKworICA8L2hlYWQ+CisgIDxib2R5PgorICAgIDxkaXY+CisgICAgICA8c3BhbiBwYXJ0PSJv bmUiPlNob3VsZCBiZSBCbHVlPC9zcGFuPiB8CisgICAgICA8c3BhbiBwYXJ0PSJ0d28iPlNob3Vs ZCBiZSBSZWQ8L3NwYW4+CisgICAgPC9kaXY+CisgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3NoYWRvdy1wYXJ0cy9zaGFkb3ctcGFydC1zdHlsZS1z aGFyaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zaGFkb3ctcGFydHMvc2hhZG93LXBh cnQtc3R5bGUtc2hhcmluZy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwLi4yN2VlODUzOTk5MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3NoYWRvdy1wYXJ0cy9zaGFkb3ctcGFydC1zdHlsZS1zaGFyaW5nLmh0bWwKQEAgLTAsMCArMSwz MSBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPHN0eWxlPgorICAg ICAgbXktZWxlbWVudDo6cGFydChvbmUpIHsKKyAgICAgICAgY29sb3I6IGJsdWU7CisgICAgICB9 CisgICAgICBteS1lbGVtZW50OjpwYXJ0KHR3bykgeworICAgICAgICBjb2xvcjogcmVkOworICAg ICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgIGNsYXNzIE15RWxlbWVudCBl eHRlbmRzIEhUTUxFbGVtZW50IHsKKyAgICAgICAgY29uc3RydWN0b3IoKSB7CisgICAgICAgICAg c3VwZXIoKTsKKyAgICAgICAgICB0aGlzLmF0dGFjaFNoYWRvdyh7bW9kZTogJ29wZW4nfSkuaW5u ZXJIVE1MID0gYAorICAgICAgICAgICAgPCEtLSBUaGlzIGRpdiBpcyBuZWNjZXNzYXJ5IHRvIHRy aWdnZXIgdGhlIGJ1ZyAtLT4KKyAgICAgICAgICAgIDxkaXY+CisgICAgICAgICAgICAgIDxzcGFu IHBhcnQ9Im9uZSI+U2hvdWxkIGJlIEJsdWU8L3NwYW4+IHwKKyAgICAgICAgICAgICAgPHNwYW4g cGFydD0idHdvIj5TaG91bGQgYmUgUmVkPC9zcGFuPgorICAgICAgICAgICAgPC9kaXY+CisgICAg ICAgICAgYDsKKyAgICAgICAgfQorICAgICAgfQorICAgICAgY3VzdG9tRWxlbWVudHMuZGVmaW5l KCdteS1lbGVtZW50JywgTXlFbGVtZW50KTsKKyAgICA8L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8 Ym9keT4KKyAgICA8bXktZWxlbWVudD48L215LWVsZW1ldG50PgorICA8L2JvZHk+Cis8L2h0bWw+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggNTExZGRjN2RlZjMuLjA4NTZjOWYzYTVhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMjAtMDQtMTAgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgorCisgICAgICAgIFtDU1MgU2hhZG93IFBhcnRzXSBCYWQgc3R5bGUgc2hhcmluZyBiZXR3ZWVu IHNpYmxpbmcgZWxlbWVudHMgd2l0aCBkaWZmZXJlbnQgcGFydCBhdHRyaWJ1dGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyNDkKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYxNTQ3NTI4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFN0eWxlIHNoYXJpbmcgb3B0aW1pemF0aW9uIHdhcyB1bmNvbmRp dGlvbmFsbHkgYWxsb3dlZCBmb3IgZWxlbWVudHMgdGhhdCB3ZXJlIHN0eWxlZCB3aXRoIHBhcnQg cHNldWRvIGVsZW1lbnQuCisgICAgICAgIFRoaXMgY291bGQgbGVhZCB0byBtaXNjb21wdXRlZCBz dHlsZS4KKworICAgICAgICBUZXN0IGNhc2UgYnkgSnVzdGluIEZhZ25hbmkuCisKKyAgICAgICAg VGVzdDogZmFzdC9jc3Mvc2hhZG93LXBhcnRzL3NoYWRvdy1wYXJ0LXN0eWxlLXNoYXJpbmcuaHRt bAorCisgICAgICAgICogc3R5bGUvU3R5bGVTaGFyaW5nUmVzb2x2ZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U3R5bGU6OlNoYXJpbmdSZXNvbHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50 KToKKworICAgICAgICBPbmx5IGFsbG93IHN0eWxlIHNoYXJpbmcgaWYgcGFydHMgbWF0Y2guCisK IDIwMjAtMDQtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBx dWVyeVNlbGVjdG9yKCIjXHUwMDAwIikgc2hvdWxkIG1hdGNoIGFuIGVsZW1lbnQgd2l0aCBJRCBV K0ZGRkQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29s dmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcApp bmRleCA2MmVjY2Y2ZjM2MS4uM2ViMDk5YmUxYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3N0eWxlL1N0eWxlU2hhcmluZ1Jlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHls ZS9TdHlsZVNoYXJpbmdSZXNvbHZlci5jcHAKQEAgLTIyOSw2ICsyMjksOCBAQCBib29sIFNoYXJp bmdSZXNvbHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KGNvbnN0IENvbnRleHQmIGNvbnRl eHQsIGNvbnN0IFN0eQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGNhbmRpZGF0ZUVs ZW1lbnQuc2hhZG93UHNldWRvSWQoKSAhPSBlbGVtZW50LnNoYWRvd1BzZXVkb0lkKCkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAoZWxlbWVudC5pc0luU2hhZG93VHJlZSgpICYmIGNh bmRpZGF0ZUVsZW1lbnQucGFydE5hbWVzKCkgIT0gZWxlbWVudC5wYXJ0TmFtZXMoKSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICgmY2FuZGlkYXRlRWxlbWVudCA9PSBtX2RvY3VtZW50 LmNzc1RhcmdldCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFzaGFyaW5nQ2Fu ZGlkYXRlSGFzSWRlbnRpY2FsU3R5bGVBZmZlY3RpbmdBdHRyaWJ1dGVzKGNvbnRleHQsIGNhbmRp ZGF0ZUVsZW1lbnQpKQo=