210222 2020-04-08 15:55:28 -0700 Clean up more resources during WebGLLayer teardown 2020-04-14 09:04:37 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210213 210153 1 kbr kbr dino ews-watchlist graouts justin_fan kondapallykalyan ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1639334 0 kbr 2020-04-08 15:55:28 -0700 Examining the WebGLLayer cleanup code for the USE(ANGLE) path, it looks like textures can still be bound to IOSurfaces at the time the WebGLLayer is destroyed. Since the OpenGL context (provided via ANGLE) is going to be destroyed, it seems most prudent to unbind those textures if necessary, and delete them, in [WebGLLayer -dealloc]. 1641157 1 kbr 2020-04-13 16:08:34 -0700 Doing this work in -dealloc: turns out to not be a good idea. It looks like (from Bug 210213) the WebGLLayer is likely retained by the CALayer tree, so its lifetime is much longer than the GraphicsContextGL. There's a specific point just before deletion of the GraphicsContextGL's native context where these resources should be released. 1641158 2 396351 kbr 2020-04-13 16:09:47 -0700 Created attachment 396351 Patch 1641170 3 ews-feeder 2020-04-13 16:42:52 -0700 Committed r260049: <https://trac.webkit.org/changeset/260049> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396351. 1641171 4 webkit-bug-importer 2020-04-13 16:43:13 -0700 <rdar://problem/61745462> 1641188 5 kbr 2020-04-13 17:21:35 -0700 +ryanhaddad@ who found the crashers previously from the fix for Bug 210213 - hope that this patch doesn't cause similar issues. Please revert if it does; thanks. 1641391 6 ryanhaddad 2020-04-14 09:04:37 -0700 (In reply to Kenneth Russell from comment #5) > +ryanhaddad@ who found the crashers previously from the fix for Bug 210213 - > hope that this patch doesn't cause similar issues. Please revert if it does; > thanks. Thanks for the heads up! 396351 2020-04-13 16:09:47 -0700 2020-04-13 16:42:53 -0700 Patch bug-210222-20200413160946.patch text/plain 3255 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ3ZjAxMTNkMDcwM2I0 Yzg0N2VlMzljNmRjNmRiMjZmMTIxN2VjNS4uMzY2YzVkMWRhODc3NmFmNzcwYjliNGM4MWIyYmI5 NWQwMDdlMGFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTEzICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENsZWFuIHVwIG1vcmUg cmVzb3VyY2VzIGR1cmluZyBXZWJHTExheWVyIHRlYXJkb3duCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyMjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWxlYXNlIE9wZW5HTCByZXNvdXJjZXMganVz dCBiZWZvcmUgZGVzdHJ1Y3Rpb24gb2YgdGhlIHVuZGVybHlpbmcKKyAgICAgICAgT3BlbkdMIGNv bnRleHQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRl eHRHTE9wZW5HTENvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0R0xP cGVuR0w6On5HcmFwaGljc0NvbnRleHRHTE9wZW5HTCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY29jb2EvV2ViR0xMYXllci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nv Y29hL1dlYkdMTGF5ZXIubW06CisgICAgICAgICgtW1dlYkdMTGF5ZXIgcmVsZWFzZUdMUmVzb3Vy Y2VzXSk6CisgICAgICAgICgtW1dlYkdMTGF5ZXIgZGVhbGxvY10pOiBEZWxldGVkLgorCiAyMDIw LTA0LTEzICBOb2FtIFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCYWNr Z3JvdW5kIGltYWdlcyBzaG91bGQgZmlndXJlIGludG8gdmlzdWFsbHkgbm9uIGVtcHR5IGhldXJp c3RpYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2Ev R3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29jb2EubW0KaW5kZXggMTNm MDZiYzJiYjhmMWJjZWE4NDJiNzVlMGJkNjllYjMxODNlMDE1OS4uZjdjMjQ1NDIyMGY3MmIzYzI2 MDgwZjI1YWM2M2E0MWU5OWQ3MDY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY29jb2EvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHRHTE9w ZW5HTENvY29hLm1tCkBAIC01ODksNiArNTg5LDcgQEAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6 On5HcmFwaGljc0NvbnRleHRHTE9wZW5HTCgpCiAgICAgICAgIENHTFNldEN1cnJlbnRDb250ZXh0 KDApOwogICAgICAgICBDR0xEZXN0cm95Q29udGV4dChjZ2xDb250ZXh0KTsKICNlbGlmIFVTRShB TkdMRSkKKyAgICAgICAgW21fd2ViR0xMYXllciByZWxlYXNlR0xSZXNvdXJjZXNdOwogICAgICAg ICBFR0xfTWFrZUN1cnJlbnQobV9kaXNwbGF5T2JqLCBFR0xfTk9fU1VSRkFDRSwgRUdMX05PX1NV UkZBQ0UsIEVHTF9OT19DT05URVhUKTsKICAgICAgICAgRUdMX0Rlc3Ryb3lDb250ZXh0KG1fZGlz cGxheU9iaiwgbV9jb250ZXh0T2JqKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5oCmluZGV4IDhiNTY2NjZhMWJjODUw M2YwMTI2Mzg4MTEwMmRlNTE3MDFlNTBkMzcuLjlkMWY3MmY0YjI5YmE5NjNmMzE0MzRmNjU1Njgz MDEwZTM2NThlOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NvY29hL1dlYkdMTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jb2NvYS9XZWJHTExheWVyLmgKQEAgLTc5LDcgKzc5LDcgQEAgQUxMT1dfREVQUkVDQVRFRF9E RUNMQVJBVElPTlNfQkVHSU4KIAogI2lmIFVTRShBTkdMRSkKIC0gKHZvaWQpc2V0RUdMRGlzcGxh eToodm9pZCopZWdsRGlzcGxheSBjb25maWc6KHZvaWQqKWVnbENvbmZpZzsKLS0gKHZvaWQpZGVh bGxvYzsKKy0gKHZvaWQpcmVsZWFzZUdMUmVzb3VyY2VzOwogI2VuZGlmCiAKIEBlbmQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1t CmluZGV4IDNmZWMzNzgzMjI5MWY4YmEzZjY4N2NjMGEyMmJiNmI2MjViMmQ1NDUuLjM4Njc0YWQ1 YzUwOTA3YjZlZmExY2Q4NTY5YTY3MDk2YjBkZWY0MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbQpAQCAtMTk1LDEyICsx OTUsMTkgQEAgc3RhdGljIHZvaWQgZnJlZURhdGEodm9pZCAqLCBjb25zdCB2b2lkICpkYXRhLCBz aXplX3QgLyogc2l6ZSAqLykKICAgICBfZWdsQ29uZmlnID0gY29uZmlnOwogfQogCi0tICh2b2lk KWRlYWxsb2MKKy0gKHZvaWQpcmVsZWFzZUdMUmVzb3VyY2VzCiB7CisgICAgaWYgKCFfY29udGV4 dCkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKF9jb250ZXh0LT5tYWtlQ29udGV4dEN1cnJl bnQoKSAmJiBfbGF0Y2hlZFBidWZmZXIpIHsKKyAgICAgICAgRUdMX1JlbGVhc2VUZXhJbWFnZShf ZWdsRGlzcGxheSwgX2xhdGNoZWRQYnVmZmVyLCBFR0xfQkFDS19CVUZGRVIpOworICAgICAgICBf bGF0Y2hlZFBidWZmZXIgPSBudWxscHRyOworICAgIH0KKwogICAgIEVHTF9EZXN0cm95U3VyZmFj ZShfZWdsRGlzcGxheSwgX2NvbnRlbnRzUGJ1ZmZlcik7CiAgICAgRUdMX0Rlc3Ryb3lTdXJmYWNl KF9lZ2xEaXNwbGF5LCBfZHJhd2luZ1BidWZmZXIpOwogICAgIEVHTF9EZXN0cm95U3VyZmFjZShf ZWdsRGlzcGxheSwgX3NwYXJlUGJ1ZmZlcik7Ci0gICAgW3N1cGVyIGRlYWxsb2NdOwogfQogI2Vu ZGlmCiAK