210213 2020-04-08 14:40:44 -0700 Release WebGLLayer earlier in ~GraphicsContextGLOpenGL 2020-04-20 11:21:38 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 210151 210153 210222 1 kbr kbr dino ews-watchlist graouts justin_fan kondapallykalyan webkit-bug-importer oldest_to_newest 1639299 0 kbr 2020-04-08 14:40:44 -0700 In GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL in Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm, the native context is deleted and [WebGLLayer setContext:] called immediately afterward to clear out its NakedPtr<GraphicsContextGLOpenGL>. In order to allow WebGLLayer's cleanup code to potentially do work with the native context, it seems appropriate to release the WebGLLayer earlier. May be related to other recently filed crashes. 1639300 1 395871 kbr 2020-04-08 14:44:06 -0700 Created attachment 395871 Patch 1639336 2 ews-feeder 2020-04-08 15:57:56 -0700 Committed r259764: <https://trac.webkit.org/changeset/259764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395871. 1639338 3 webkit-bug-importer 2020-04-08 15:58:13 -0700 <rdar://problem/61482594> 1640438 4 ryanhaddad 2020-04-10 17:41:42 -0700 Reverted r259764 for reason: Causes layout test crashes under GuardMalloc Committed r259915: <https://trac.webkit.org/changeset/259915> 1640443 5 ryanhaddad 2020-04-10 17:44:23 -0700 (In reply to Ryan Haddad from comment #4) > Reverted r259764 for reason: > > Causes layout test crashes under GuardMalloc > > Committed r259915: <https://trac.webkit.org/changeset/259915> We were seeing crashes on iOS Simulator when running tests under GuardMalloc These are some of the tests that hit crashes: fast/canvas/webgl/no-info-log-for-simple-shaders.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html webgl/1.0.3/conformance/extensions/ext-blend-minmax.html fast/canvas/webgl/no-info-log-for-simple-shaders.html 1640453 6 kbr 2020-04-10 18:16:26 -0700 Thanks Ryan and sorry about the crashes. Was worried about that. How can I run my local iOS Simulator build with GuardMalloc? 1641160 7 kbr 2020-04-13 16:11:44 -0700 Note - per fix in Bug 210222, if that one lands and sticks, I'll likely close this as WontFix rather than trying to pursue it further. 1643542 8 kbr 2020-04-20 11:21:38 -0700 The fix for Bug 210222 seems that it's stable and won't be reverted, so closing this out as WontFix. 395871 2020-04-08 14:44:06 -0700 2020-04-08 15:57:56 -0700 Patch bug-210213-20200408144405.patch text/plain 3307 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNkNjZjMGZlOWQyODcx NTI4ODMzYTYxZmQzZTRlNGUyNWE2YWE4OC4uNTQ5NGUxZDFiODU1Mjg1OTY2NDFmNGM3NTk3ZDJh MzE2ODZlZjdkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTA4ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbGVhc2UgV2ViR0xM YXllciBlYXJsaWVyIGluIH5HcmFwaGljc0NvbnRleHRHTE9wZW5HTAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMjEzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsZWFzZSBXZWJHTExheWVyIGVhcmxp ZXIgYW5kIHJlbW92ZSBwdWJsaWMgY29udGV4dCBwcm9wZXJ0eSwKKyAgICAgICAgd2hpY2ggaXMg bm8gbG9uZ2VyIGNhbGxlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dy YXBoaWNzQ29udGV4dEdMT3BlbkdMQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHRHTE9wZW5HTDo6fkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLmg6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbToKKwogMjAyMC0wNC0wOCAgRGV2aW4gUm91c3Nv ICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3RvcmFnZTog Y2Fubm90IGNsZWFyIG91dCBtdWx0aXBsZSBvciBhbGwgbG9jYWwgc3RvcmFnZSBlbnRyaWVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGlj c0NvbnRleHRHTE9wZW5HTENvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY29jb2EvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbQppbmRleCAxM2YwNmJjMmJi OGYxYmNlYTg0MmI3NWUwYmQ2OWViMzE4M2UwMTU5Li4zNzgxMDBkNjg5NzNlYWUxZDQzMmQ5YTMw MDY5NWQ3YTg0NzQwNmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHRHTE9wZW5HTENvY29hLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29j b2EubW0KQEAgLTU4Miw2ICs1ODIsMTAgQEAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6On5HcmFw aGljc0NvbnRleHRHTE9wZW5HTCgpCiAgICAgICAgIGdsOjpEZWxldGVGcmFtZWJ1ZmZlcnMoMSwg Jm1fZmJvKTsKICNlbmRpZgogCisgICAgICAgIC8vIFJlbGVhc2UgdGhlIFdlYkdMTGF5ZXIgYmVm b3JlIGRlc3Ryb3lpbmcgdGhlIHVuZGVybHlpbmcKKyAgICAgICAgLy8gY29udGV4dCB0byBlbmFi bGUgaXQgdG8gZG8gYW55IG5lY2Vzc2FyeSBjbGVhbnVwcy4KKyAgICAgICAgbV93ZWJHTExheWVy ID0gbnVsbHB0cjsKKwogI2lmIFVTRShPUEVOR0xfRVMpCiAgICAgICAgIFtFQUdMQ29udGV4dCBz ZXRDdXJyZW50Q29udGV4dDowXTsKICAgICAgICAgW3N0YXRpY19jYXN0PEVBR0xDb250ZXh0ICo+ KG1fY29udGV4dE9iaikgcmVsZWFzZV07CkBAIC01OTIsNyArNTk2LDYgQEAgR3JhcGhpY3NDb250 ZXh0R0xPcGVuR0w6On5HcmFwaGljc0NvbnRleHRHTE9wZW5HTCgpCiAgICAgICAgIEVHTF9NYWtl Q3VycmVudChtX2Rpc3BsYXlPYmosIEVHTF9OT19TVVJGQUNFLCBFR0xfTk9fU1VSRkFDRSwgRUdM X05PX0NPTlRFWFQpOwogICAgICAgICBFR0xfRGVzdHJveUNvbnRleHQobV9kaXNwbGF5T2JqLCBt X2NvbnRleHRPYmopOwogI2VuZGlmCi0gICAgICAgIFttX3dlYkdMTGF5ZXIgc2V0Q29udGV4dDpu dWxscHRyXTsKICAgICB9CiAKICAgICBMT0coV2ViR0wsICJEZXN0cm95ZWQgYSBHcmFwaGljc0Nv bnRleHRHTE9wZW5HTCAoJXApLiIsIHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5oCmluZGV4IDhiNTY2NjZhMWJjODUwM2Yw MTI2Mzg4MTEwMmRlNTE3MDFlNTBkMzcuLjczZDBkNjM1ZGZjODJkY2I0OGQwY2M3MTYzZDNjZjZi NTQyNGUzZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nv Y29hL1dlYkdMTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9XZWJHTExheWVyLmgKQEAgLTY2LDggKzY2LDYgQEAgQUxMT1dfREVQUkVDQVRFRF9ERUNM QVJBVElPTlNfQkVHSU4KICNlbmRpZgogfQogCi1AcHJvcGVydHkgKG5vbmF0b21pYykgTmFrZWRQ dHI8V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w+IGNvbnRleHQ7Ci0KIC0gKGlkKWlu aXRXaXRoR3JhcGhpY3NDb250ZXh0R0w6KE5ha2VkUHRyPFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dEdMT3BlbkdMPiljb250ZXh0OwogCiAtIChDR0ltYWdlUmVmKWNvcHlJbWFnZVNuYXBzaG90V2l0 aENvbG9yU3BhY2U6KENHQ29sb3JTcGFjZVJlZiljb2xvclNwYWNlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIubW0KaW5kZXggMDA4 ZGJkN2QzOWUwMjQ2YTc5ODFmNWI0NTIzYjJiY2RjMDM5YzFkMC4uZjQ2YTcxNjgwZWU4NGI4ZjQz NmVlYjc3ZDE4ZTIwMjIxYjJiMTUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tCkBAIC01OSw4ICs1OSw2IEBACiAKIEBp bXBsZW1lbnRhdGlvbiBXZWJHTExheWVyCiAKLUBzeW50aGVzaXplIGNvbnRleHQ9X2NvbnRleHQ7 Ci0KIC0oaWQpaW5pdFdpdGhHcmFwaGljc0NvbnRleHRHTDooTmFrZWRQdHI8V2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0R0xPcGVuR0w+KWNvbnRleHQKIHsKICAgICBfY29udGV4dCA9IGNvbnRleHQ7 Cg==