<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>210037</bug_id>
          
          <creation_ts>2020-04-05 13:45:59 -0700</creation_ts>
          <short_desc>JSC shell shouldn&apos;t treat NUL as a terminator when printing a JS string</short_desc>
          <delta_ts>2020-04-05 21:35:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=167067</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Kirsling">ross.kirsling</reporter>
          <assigned_to name="Ross Kirsling">ross.kirsling</assigned_to>
          <cc>ashvayka</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1637944</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 13:45:59 -0700</bug_when>
    <thetext>JSC shell shouldn&apos;t treat NUL as a terminator when printing a JS string</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637947</commentid>
    <comment_count>1</comment_count>
      <attachid>395525</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 13:56:59 -0700</bug_when>
    <thetext>Created attachment 395525
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637950</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 14:24:56 -0700</bug_when>
    <thetext>Hmm, I suppose this would be the right opportunity to remove $vm.print too -- it&apos;s hardly used, and it doesn&apos;t do what it says.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637953</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-04-05 14:29:34 -0700</bug_when>
    <thetext>(In reply to Ross Kirsling from comment #2)
&gt; Hmm, I suppose this would be the right opportunity to remove $vm.print too
&gt; -- it&apos;s hardly used, and it doesn&apos;t do what it says.

Do not remove $vm.print().  Its uses go beyond what it in the existing test scripts.  I use it for custom debugging tests all the time.  It comes in especially handy when I want to print from WebCore and don&apos;t want to go thru console.log().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637961</commentid>
    <comment_count>4</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 14:57:14 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #3)
&gt; (In reply to Ross Kirsling from comment #2)
&gt; &gt; Hmm, I suppose this would be the right opportunity to remove $vm.print too
&gt; &gt; -- it&apos;s hardly used, and it doesn&apos;t do what it says.
&gt; 
&gt; Do not remove $vm.print().  Its uses go beyond what it in the existing test
&gt; scripts.  I use it for custom debugging tests all the time.  It comes in
&gt; especially handy when I want to print from WebCore and don&apos;t want to go thru
&gt; console.log().

Ah okay, thanks for the clarification. My concern is just because $vm.print is currently effectively dataLogLn, and I&apos;m not sure whether this same change is appropriate to apply to dataLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637962</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-04-05 15:00:01 -0700</bug_when>
    <thetext>Why should the jsc shell treat NULL as a terminator when printing a JS string?  JS strings come with a length, and is not necessarily null terminated like a C string.  I fail to see why we would want to make this change.  In fact, it feels wrong to do so.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637966</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-04-05 15:09:26 -0700</bug_when>
    <thetext>(In reply to Mark Lam from comment #5)
&gt; Why should the jsc shell treat NULL as a terminator when printing a JS
&gt; string?  JS strings come with a length, and is not necessarily null
&gt; terminated like a C string.  I fail to see why we would want to make this
&gt; change.  In fact, it feels wrong to do so.

I talked with Ross offline and clarified things.  I was mistaken above and misread the change as the opposite of what it&apos;s doing.  Sorry for that.  Carry on.

No need to worry about $vm.print() because it is purely a WebKit developer debugging tool, not a user facing tool.  User (as in the developer) beware when using it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637977</commentid>
    <comment_count>7</comment_count>
      <attachid>395533</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 16:06:25 -0700</bug_when>
    <thetext>Created attachment 395533
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637981</commentid>
    <comment_count>8</comment_count>
      <attachid>395533</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-04-05 16:15:15 -0700</bug_when>
    <thetext>Comment on attachment 395533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395533&amp;action=review

&gt; Source/JavaScriptCore/jsc.cpp:1293
&gt; +    fprintf(stderr, &quot;--&gt; &quot;);

fputs?

&gt; Source/JavaScriptCore/jsc.cpp:1295
&gt; +    fprintf(stderr, &quot;\n&quot;);

putc?

&gt; Source/JavaScriptCore/jsc.cpp:2803
&gt; +            printf(&quot;Exception: &quot;);

puts?

&gt; Source/JavaScriptCore/jsc.cpp:2808
&gt; +        printf(&quot;\n&quot;);

putchar?

&gt; JSTests/ChangeLog:11
&gt; +        Update baseline, but ensure that \0 isn&apos;t printed to file, lest the file be treated as binary.

For testing purposes I often like the idea of replacing a NUL with something like &quot;&lt;NUL&gt;&quot; rather than just deleting it. Seems more likely to help us catch bugs and unlikely to cause confusion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637989</commentid>
    <comment_count>9</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 16:39:35 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #8)
&gt; &gt; JSTests/ChangeLog:11
&gt; &gt; +        Update baseline, but ensure that \0 isn&apos;t printed to file, lest the file be treated as binary.
&gt; 
&gt; For testing purposes I often like the idea of replacing a NUL with something
&gt; like &quot;&lt;NUL&gt;&quot; rather than just deleting it. Seems more likely to help us
&gt; catch bugs and unlikely to cause confusion.

That&apos;s a good idea, though it&apos;s probably inappropriate that I edit this test in the first place. :-/

Given that JSTests/ChakraCore is the only subdirectory that does file diffs and only one of its tests is having this problem, it might be simpler to just map its echo function to $vm.print instead...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637991</commentid>
    <comment_count>10</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 16:55:47 -0700</bug_when>
    <thetext>(In reply to Ross Kirsling from comment #9)
&gt; Given that JSTests/ChakraCore is the only subdirectory that does file diffs
&gt; and only one of its tests is having this problem, it might be simpler to
&gt; just map its echo function to $vm.print instead...

Hrmm, but apparently $vm.print doesn&apos;t insert spaces between its arguments, so we&apos;d need to either make it do so or update two dozen baselines.

That or I suppose we could just have .baseline-jsc _be_ binary for this test. It&apos;s gross, but the data is correct, and we&apos;d avoid modifying files we shouldn&apos;t.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638007</commentid>
    <comment_count>11</comment_count>
      <attachid>395540</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 19:29:28 -0700</bug_when>
    <thetext>Created attachment 395540
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638008</commentid>
    <comment_count>12</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2020-04-05 19:31:00 -0700</bug_when>
    <thetext>(In reply to Ross Kirsling from comment #10)
&gt; That or I suppose we could just have .baseline-jsc _be_ binary for this
&gt; test. It&apos;s gross, but the data is correct, and we&apos;d avoid modifying files we
&gt; shouldn&apos;t.

Seems like this works fine after all, so long as the file is marked diffable in .gitattributes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638018</commentid>
    <comment_count>13</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-05 21:13:53 -0700</bug_when>
    <thetext>Found 1 new test failure: storage/indexeddb/value-cursor-cycle.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638023</commentid>
    <comment_count>14</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-05 21:34:40 -0700</bug_when>
    <thetext>Committed r259564: &lt;https://trac.webkit.org/changeset/259564&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395540.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638024</commentid>
    <comment_count>15</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-04-05 21:35:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/61328543&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>395525</attachid>
            <date>2020-04-05 13:56:59 -0700</date>
            <delta_ts>2020-04-05 16:06:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-210037-20200405135659.patch</filename>
            <type>text/plain</type>
            <size>3248</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj
ZmJjMGQ4ZTllNjA4ODQyNDQ0N2Q4ZWY4NTFmMzM2NDNmZWU5NjcwLi43NTEyNzc0MTk2ZTFlODM1
ZDU5ODdhODNmZWQwOGM4ZWMzZjA4MGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMCBAQAorMjAyMC0wNC0wNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgSlNDIHNoZWxsIHNob3VsZG4ndCB0cmVhdCBOVUwgYXMgYSB0ZXJt
aW5hdG9yIHdoZW4gcHJpbnRpbmcgYSBKUyBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDAzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIEpTIHN0cmluZ3MgYXJlbid0IG51bGwtdGVy
bWluYXRlZCwgaXQncyBwcm9iYWJseSBhIGJldHRlciBleHBlcmllbmNlIHRvIG5vdCBzdG9wIHBy
aW50aW5nIHdoZW4gd2Ugc2VlIFwwLgorICAgICAgICAoRldJVywgU3BpZGVyTW9ua2V5J3Mgc2hl
bGwgc3RvcHMgdG9vLCBidXQgVjgncyBwcmludHMgdGhlIHdob2xlIHN0cmluZy4pCisKKyAgICAg
ICAgVGhpcyBwYXRjaCB1cGRhdGVzIG91ciBwcmludGluZyBvZiBldmFsdWF0aW9uIHJlc3VsdHMg
YXMgd2VsbCBhcyB0aGUgcHJpbnQgLyBwcmludEVyciAvIGRlYnVnIGZ1bmN0aW9ucy4KKworICAg
ICAgICAqIGpzYy5jcHA6CisgICAgICAgIChwcmludEludGVybmFsKToKKyAgICAgICAgKGZ1bmN0
aW9uRGVidWcpOgorICAgICAgICAocnVuSW50ZXJhY3RpdmUpOgorCiAyMDIwLTA0LTA1ICBLZWl0
aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGVuc3VyZVN0aWxs
QWxpdmVIZXJlIGNhbiB0YWtlIHRoZSB2YWx1ZSBpbiBhbnkgbG9jYXRpb24KZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pz
Yy5jcHAKaW5kZXggODExMWRkNmJjMDkxOGM2YzhjNDc2NTAyMGNmNzI5OGM1NjBhOWNmNC4uY2E0
OTMyYzM2NDUyOWRjMDBkMTIwNDkyNDY0MTUxZGMyY2IzNTZlMCAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j
cHAKQEAgLTEyNjgsNyArMTI2OCw4IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBwcmludEludGVy
bmFsKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSogY2FsCiAgICAgICAg
IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgICAgICBh
dXRvIHN0cmluZyA9IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xvYmFsT2JqZWN0LCBzY29w
ZSwgdmlld1dpdGhTdHJpbmcpOwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBl
bmNvZGVkSlNWYWx1ZSgpKTsKLSAgICAgICAgaWYgKGZwcmludGYob3V0LCAiJXMiLCBzdHJpbmcu
ZGF0YSgpKSA8IDApCisgICAgICAgIGZ3cml0ZShzdHJpbmcuZGF0YSgpLCBzaXplb2YoY2hhciks
IHN0cmluZy5sZW5ndGgoKSwgb3V0KTsKKyAgICAgICAgaWYgKGZlcnJvcihvdXQpKQogICAgICAg
ICAgICAgZ290byBmYWlsOwogICAgIH0KIApAQCAtMTI4OSw3ICsxMjkwLDkgQEAgRW5jb2RlZEpT
VmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlYnVnKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxP
YmplY3QsIENhbGxGcmEKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNW
YWx1ZSgpKTsKICAgICBhdXRvIHN0cmluZyA9IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xv
YmFsT2JqZWN0LCBzY29wZSwgdmlld1dpdGhTdHJpbmcpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJ
T04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgIGZwcmludGYoc3RkZXJyLCAiLS0+ICVz
XG4iLCBzdHJpbmcuZGF0YSgpKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIi0tPiAiKTsKKyAgICBm
d3JpdGUoc3RyaW5nLmRhdGEoKSwgc2l6ZW9mKGNoYXIpLCBzdHJpbmcubGVuZ3RoKCksIHN0ZGVy
cik7CisgICAgZnByaW50ZihzdGRlcnIsICJcbiIpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNv
ZGUoanNVbmRlZmluZWQoKSk7CiB9CiAKQEAgLTI3OTUsMTAgKzI3OTgsMTQgQEAgc3RhdGljIHZv
aWQgcnVuSW50ZXJhY3RpdmUoR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCiAgICAgICAgIE5h
a2VkUHRyPEV4Y2VwdGlvbj4gZXZhbHVhdGlvbkV4Y2VwdGlvbjsKICAgICAgICAgSlNWYWx1ZSBy
ZXR1cm5WYWx1ZSA9IGV2YWx1YXRlKGdsb2JhbE9iamVjdCwganNjU291cmNlKGxpbmUsIHNvdXJj
ZU9yaWdpbiwgc291cmNlT3JpZ2luLnN0cmluZygpKSwgSlNWYWx1ZSgpLCBldmFsdWF0aW9uRXhj
ZXB0aW9uKTsKICNlbmRpZgotICAgICAgICBpZiAoZXZhbHVhdGlvbkV4Y2VwdGlvbikKLSAgICAg
ICAgICAgIHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgZXZhbHVhdGlvbkV4Y2VwdGlvbi0+dmFs
dWUoKS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpLnV0ZjgoKS5kYXRhKCkpOwotICAgICAgICBl
bHNlCi0gICAgICAgICAgICBwcmludGYoIiVzXG4iLCByZXR1cm5WYWx1ZS50b1dURlN0cmluZyhn
bG9iYWxPYmplY3QpLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBDU3RyaW5nIHJlc3VsdDsKKyAg
ICAgICAgaWYgKGV2YWx1YXRpb25FeGNlcHRpb24pIHsKKyAgICAgICAgICAgIHByaW50ZigiRXhj
ZXB0aW9uOiAiKTsKKyAgICAgICAgICAgIHJlc3VsdCA9IGV2YWx1YXRpb25FeGNlcHRpb24tPnZh
bHVlKCkudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7CisgICAgICAgIH0gZWxzZQor
ICAgICAgICAgICAgcmVzdWx0ID0gcmV0dXJuVmFsdWUudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0
KS51dGY4KCk7CisgICAgICAgIGZ3cml0ZShyZXN1bHQuZGF0YSgpLCBzaXplb2YoY2hhciksIHJl
c3VsdC5sZW5ndGgoKSwgc3Rkb3V0KTsKKyAgICAgICAgcHJpbnRmKCJcbiIpOwogCiAgICAgICAg
IHNjb3BlLmNsZWFyRXhjZXB0aW9uKCk7CiAgICAgICAgIHZtLmRyYWluTWljcm90YXNrcygpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>395533</attachid>
            <date>2020-04-05 16:06:25 -0700</date>
            <delta_ts>2020-04-05 19:29:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-210037-20200405160624.patch</filename>
            <type>text/plain</type>
            <size>6839</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj
ZmJjMGQ4ZTllNjA4ODQyNDQ0N2Q4ZWY4NTFmMzM2NDNmZWU5NjcwLi43NTEyNzc0MTk2ZTFlODM1
ZDU5ODdhODNmZWQwOGM4ZWMzZjA4MGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMCBAQAorMjAyMC0wNC0wNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgSlNDIHNoZWxsIHNob3VsZG4ndCB0cmVhdCBOVUwgYXMgYSB0ZXJt
aW5hdG9yIHdoZW4gcHJpbnRpbmcgYSBKUyBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDAzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIEpTIHN0cmluZ3MgYXJlbid0IG51bGwtdGVy
bWluYXRlZCwgaXQncyBwcm9iYWJseSBhIGJldHRlciBleHBlcmllbmNlIHRvIG5vdCBzdG9wIHBy
aW50aW5nIHdoZW4gd2Ugc2VlIFwwLgorICAgICAgICAoRldJVywgU3BpZGVyTW9ua2V5J3Mgc2hl
bGwgc3RvcHMgdG9vLCBidXQgVjgncyBwcmludHMgdGhlIHdob2xlIHN0cmluZy4pCisKKyAgICAg
ICAgVGhpcyBwYXRjaCB1cGRhdGVzIG91ciBwcmludGluZyBvZiBldmFsdWF0aW9uIHJlc3VsdHMg
YXMgd2VsbCBhcyB0aGUgcHJpbnQgLyBwcmludEVyciAvIGRlYnVnIGZ1bmN0aW9ucy4KKworICAg
ICAgICAqIGpzYy5jcHA6CisgICAgICAgIChwcmludEludGVybmFsKToKKyAgICAgICAgKGZ1bmN0
aW9uRGVidWcpOgorICAgICAgICAocnVuSW50ZXJhY3RpdmUpOgorCiAyMDIwLTA0LTA1ICBLZWl0
aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGVuc3VyZVN0aWxs
QWxpdmVIZXJlIGNhbiB0YWtlIHRoZSB2YWx1ZSBpbiBhbnkgbG9jYXRpb24KZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pz
Yy5jcHAKaW5kZXggODExMWRkNmJjMDkxOGM2YzhjNDc2NTAyMGNmNzI5OGM1NjBhOWNmNC4uY2E0
OTMyYzM2NDUyOWRjMDBkMTIwNDkyNDY0MTUxZGMyY2IzNTZlMCAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j
cHAKQEAgLTEyNjgsNyArMTI2OCw4IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBwcmludEludGVy
bmFsKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSogY2FsCiAgICAgICAg
IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgICAgICBh
dXRvIHN0cmluZyA9IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xvYmFsT2JqZWN0LCBzY29w
ZSwgdmlld1dpdGhTdHJpbmcpOwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBl
bmNvZGVkSlNWYWx1ZSgpKTsKLSAgICAgICAgaWYgKGZwcmludGYob3V0LCAiJXMiLCBzdHJpbmcu
ZGF0YSgpKSA8IDApCisgICAgICAgIGZ3cml0ZShzdHJpbmcuZGF0YSgpLCBzaXplb2YoY2hhciks
IHN0cmluZy5sZW5ndGgoKSwgb3V0KTsKKyAgICAgICAgaWYgKGZlcnJvcihvdXQpKQogICAgICAg
ICAgICAgZ290byBmYWlsOwogICAgIH0KIApAQCAtMTI4OSw3ICsxMjkwLDkgQEAgRW5jb2RlZEpT
VmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlYnVnKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxP
YmplY3QsIENhbGxGcmEKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNW
YWx1ZSgpKTsKICAgICBhdXRvIHN0cmluZyA9IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xv
YmFsT2JqZWN0LCBzY29wZSwgdmlld1dpdGhTdHJpbmcpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJ
T04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgIGZwcmludGYoc3RkZXJyLCAiLS0+ICVz
XG4iLCBzdHJpbmcuZGF0YSgpKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIi0tPiAiKTsKKyAgICBm
d3JpdGUoc3RyaW5nLmRhdGEoKSwgc2l6ZW9mKGNoYXIpLCBzdHJpbmcubGVuZ3RoKCksIHN0ZGVy
cik7CisgICAgZnByaW50ZihzdGRlcnIsICJcbiIpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNv
ZGUoanNVbmRlZmluZWQoKSk7CiB9CiAKQEAgLTI3OTUsMTAgKzI3OTgsMTQgQEAgc3RhdGljIHZv
aWQgcnVuSW50ZXJhY3RpdmUoR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCiAgICAgICAgIE5h
a2VkUHRyPEV4Y2VwdGlvbj4gZXZhbHVhdGlvbkV4Y2VwdGlvbjsKICAgICAgICAgSlNWYWx1ZSBy
ZXR1cm5WYWx1ZSA9IGV2YWx1YXRlKGdsb2JhbE9iamVjdCwganNjU291cmNlKGxpbmUsIHNvdXJj
ZU9yaWdpbiwgc291cmNlT3JpZ2luLnN0cmluZygpKSwgSlNWYWx1ZSgpLCBldmFsdWF0aW9uRXhj
ZXB0aW9uKTsKICNlbmRpZgotICAgICAgICBpZiAoZXZhbHVhdGlvbkV4Y2VwdGlvbikKLSAgICAg
ICAgICAgIHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgZXZhbHVhdGlvbkV4Y2VwdGlvbi0+dmFs
dWUoKS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpLnV0ZjgoKS5kYXRhKCkpOwotICAgICAgICBl
bHNlCi0gICAgICAgICAgICBwcmludGYoIiVzXG4iLCByZXR1cm5WYWx1ZS50b1dURlN0cmluZyhn
bG9iYWxPYmplY3QpLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBDU3RyaW5nIHJlc3VsdDsKKyAg
ICAgICAgaWYgKGV2YWx1YXRpb25FeGNlcHRpb24pIHsKKyAgICAgICAgICAgIHByaW50ZigiRXhj
ZXB0aW9uOiAiKTsKKyAgICAgICAgICAgIHJlc3VsdCA9IGV2YWx1YXRpb25FeGNlcHRpb24tPnZh
bHVlKCkudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7CisgICAgICAgIH0gZWxzZQor
ICAgICAgICAgICAgcmVzdWx0ID0gcmV0dXJuVmFsdWUudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0
KS51dGY4KCk7CisgICAgICAgIGZ3cml0ZShyZXN1bHQuZGF0YSgpLCBzaXplb2YoY2hhciksIHJl
c3VsdC5sZW5ndGgoKSwgc3Rkb3V0KTsKKyAgICAgICAgcHJpbnRmKCJcbiIpOwogCiAgICAgICAg
IHNjb3BlLmNsZWFyRXhjZXB0aW9uKCk7CiAgICAgICAgIHZtLmRyYWluTWljcm90YXNrcygpOwpk
aWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFrcmFDb3JlL3Rlc3QvZXM1L2hhc0l0ZW0uYmFzZWxpbmUg
Yi9KU1Rlc3RzL0NoYWtyYUNvcmUvdGVzdC9lczUvaGFzSXRlbS5iYXNlbGluZQppbmRleCA3MzE1
NzliZTQwOWNjYzA4MTIyZjhjMjIxZDZmZmQ4OTc4MzhmMTY2Li5jOTNkOGYwN2VhYWNjMjg4ZTA0
NTA5NGE4YWEyZDJkZTg0ZTM1MzU4IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYWtyYUNvcmUvdGVz
dC9lczUvaGFzSXRlbS5iYXNlbGluZQorKysgYi9KU1Rlc3RzL0NoYWtyYUNvcmUvdGVzdC9lczUv
aGFzSXRlbS5iYXNlbGluZQpAQCAtNiw4ICs2LDggQEAgVGVzdCBlbXB0eSBvYmplY3QKICAgcGFz
cyAoMTApCiAgIHBhc3MgKDQyOTQ5NjcyOTQpCiAgIHBhc3MgKHggeSkKLSAgcGFzcyAoeAotICBw
YXNzICh4CisgIHBhc3MgKHh5KQorICBwYXNzICh4eSkKIFRlc3QgZW1wdHkgYXJyYXkKICAgcGFz
cyAoYWJjKQogICBwYXNzICgtMSkKQEAgLTE2LDggKzE2LDggQEAgVGVzdCBlbXB0eSBhcnJheQog
ICBwYXNzICgxMCkKICAgcGFzcyAoNDI5NDk2NzI5NCkKICAgcGFzcyAoeCB5KQotICBwYXNzICh4
Ci0gIHBhc3MgKHgKKyAgcGFzcyAoeHkpCisgIHBhc3MgKHh5KQogVGVzdCBudW1iZXIgb2JqZWN0
CiAgIHBhc3MgKGFiYykKICAgcGFzcyAoLTEpCkBAIC0yNiw4ICsyNiw4IEBAIFRlc3QgbnVtYmVy
IG9iamVjdAogICBwYXNzICgxMCkKICAgcGFzcyAoNDI5NDk2NzI5NCkKICAgcGFzcyAoeCB5KQot
ICBwYXNzICh4Ci0gIHBhc3MgKHgKKyAgcGFzcyAoeHkpCisgIHBhc3MgKHh5KQogVGVzdCBzdHJp
bmcgb2JqZWN0CiAgIHBhc3MgKGFiYykKICAgcGFzcyAoLTEpCkBAIC0zNiw4ICszNiw4IEBAIFRl
c3Qgc3RyaW5nIG9iamVjdAogICBwYXNzICgxMCkKICAgcGFzcyAoNDI5NDk2NzI5NCkKICAgcGFz
cyAoeCB5KQotICBwYXNzICh4Ci0gIHBhc3MgKHgKKyAgcGFzcyAoeHkpCisgIHBhc3MgKHh5KQog
VGVzdCBPYmplY3QKICAgcGFzcyAoYWJjKQogICBwYXNzICgtMSkKQEAgLTQ2LDggKzQ2LDggQEAg
VGVzdCBPYmplY3QKICAgcGFzcyAoMTApCiAgIHBhc3MgKDQyOTQ5NjcyOTQpCiAgIHBhc3MgKHgg
eSkKLSAgcGFzcyAoeAotICBwYXNzICh4CisgIHBhc3MgKHh5KQorICBwYXNzICh4eSkKIFRlc3Qg
Z2xvYmFsIG9iamVjdAogICBwYXNzIChhYmMpCiAgIHBhc3MgKC0xKQpAQCAtNTYsOCArNTYsOCBA
QCBUZXN0IGdsb2JhbCBvYmplY3QKICAgcGFzcyAoMTApCiAgIHBhc3MgKDQyOTQ5NjcyOTQpCiAg
IHBhc3MgKHggeSkKLSAgcGFzcyAoeAotICBwYXNzICh4CisgIHBhc3MgKHh5KQorICBwYXNzICh4
eSkKIFRlc3Qgb2JqZWN0IHdpdGggMSBwcm9wZXJ0eQogICBwYXNzIChhYmMpCiAgIHBhc3MgKC0x
KQpAQCAtNjYsOCArNjYsOCBAQCBUZXN0IG9iamVjdCB3aXRoIDEgcHJvcGVydHkKICAgcGFzcyAo
MTApCiAgIHBhc3MgKDQyOTQ5NjcyOTQpCiAgIHBhc3MgKHggeSkKLSAgcGFzcyAoeAotICBwYXNz
ICh4CisgIHBhc3MgKHh5KQorICBwYXNzICh4eSkKIFRlc3Qgb2JqZWN0IHdpdGggbWFueSBwcm9w
ZXJ0aWVzCiAgIHBhc3MgKGFiYykKICAgcGFzcyAoLTEpCkBAIC03Niw4ICs3Niw4IEBAIFRlc3Qg
b2JqZWN0IHdpdGggbWFueSBwcm9wZXJ0aWVzCiAgIHBhc3MgKDEwKQogICBwYXNzICg0Mjk0OTY3
Mjk0KQogICBwYXNzICh4IHkpCi0gIHBhc3MgKHgKLSAgcGFzcyAoeAorICBwYXNzICh4eSkKKyAg
cGFzcyAoeHkpCiBUZXN0IG9iamVjdCB3aXRoIGFjY2Vzc29yCiAgIHBhc3MgKGFiYykKICAgcGFz
cyAoLTEpCkBAIC04Niw4ICs4Niw4IEBAIFRlc3Qgb2JqZWN0IHdpdGggYWNjZXNzb3IKICAgcGFz
cyAoMTApCiAgIHBhc3MgKDQyOTQ5NjcyOTQpCiAgIHBhc3MgKHggeSkKLSAgcGFzcyAoeAotICBw
YXNzICh4CisgIHBhc3MgKHh5KQorICBwYXNzICh4eSkKIFRlc3QgYXJyYXkKICAgcGFzcyAoYWJj
KQogICBwYXNzICgtMSkKQEAgLTk2LDggKzk2LDggQEAgVGVzdCBhcnJheQogICBwYXNzICgxMCkK
ICAgcGFzcyAoNDI5NDk2NzI5NCkKICAgcGFzcyAoeCB5KQotICBwYXNzICh4Ci0gIHBhc3MgKHgK
KyAgcGFzcyAoeHkpCisgIHBhc3MgKHh5KQogVGVzdCBlczUgYXJyYXkKICAgcGFzcyAoYWJjKQog
ICBwYXNzICgtMSkKQEAgLTEwNiw1ICsxMDYsNSBAQCBUZXN0IGVzNSBhcnJheQogICBwYXNzICgx
MCkKICAgcGFzcyAoNDI5NDk2NzI5NCkKICAgcGFzcyAoeCB5KQotICBwYXNzICh4Ci0gIHBhc3Mg
KHgKKyAgcGFzcyAoeHkpCisgIHBhc3MgKHh5KQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFrcmFD
b3JlL3Rlc3QvZXM1L2hhc0l0ZW0uanMgYi9KU1Rlc3RzL0NoYWtyYUNvcmUvdGVzdC9lczUvaGFz
SXRlbS5qcwppbmRleCBkMTFiNTI5ODQyNzMzZjA0ZDJiZDVlNmExYTJjZGU4YWM3YWY4NzVlLi5i
OWI0OGJhZTFjZTg4MGEzZGVkNjkzZjIzOTRhNWY4ZDQ4MmMwMGI5IDEwMDY0NAotLS0gYS9KU1Rl
c3RzL0NoYWtyYUNvcmUvdGVzdC9lczUvaGFzSXRlbS5qcworKysgYi9KU1Rlc3RzL0NoYWtyYUNv
cmUvdGVzdC9lczUvaGFzSXRlbS5qcwpAQCAtMTcsNyArMTcsNyBAQCBmdW5jdGlvbiB0ZXN0SGFz
SXRlbShvLCBwcm9wKSB7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgZWNobygiICIsIG8u
aGFzT3duUHJvcGVydHkocHJvcCkgJiYgIW8ucHJvcGVydHlJc0VudW1lcmFibGUocHJvcCkgPyAi
cGFzcyIgOiAiZmFpbCIsCi0gICAgICAgICIoIiArIHByb3AgKyAiKSIpOworICAgICAgICBgKCR7
cHJvcH0pYC5yZXBsYWNlKC9cMC9nLCAnJykpOwogfQogCiB2YXIgb2JqcyA9IHsKZGlmZiAtLWdp
dCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjE4ZmQ2ZWI1
NTk4MDVkOGM5NTk0ODA1MGU5NmYyNTIyMTZjNmZhOS4uZWNjMGM0NGY3NzYwZmYwNmU4NzljMDAx
MzU5Mjg4NmEwMzIxNmE3MiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU
ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wNC0wNSAgUm9zcyBLaXJzbGlu
ZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CisKKyAgICAgICAgSlNDIHNoZWxsIHNob3VsZG4n
dCB0cmVhdCBOVUwgYXMgYSB0ZXJtaW5hdG9yIHdoZW4gcHJpbnRpbmcgYSBKUyBzdHJpbmcKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDAzNworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ2hha3JhQ29y
ZS90ZXN0L2VzNS9oYXNJdGVtLmJhc2VsaW5lOgorICAgICAgICAqIENoYWtyYUNvcmUvdGVzdC9l
czUvaGFzSXRlbS5qczoKKyAgICAgICAgKHRlc3RIYXNJdGVtKToKKyAgICAgICAgVXBkYXRlIGJh
c2VsaW5lLCBidXQgZW5zdXJlIHRoYXQgXDAgaXNuJ3QgcHJpbnRlZCB0byBmaWxlLCBsZXN0IHRo
ZSBmaWxlIGJlIHRyZWF0ZWQgYXMgYmluYXJ5LgorCiAyMDIwLTA0LTA1ICBBbGV4ZXkgU2h2YXlr
YSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBPY3RhbCBlc2NhcGVzIHNob3Vs
ZCBiZSBtYXggMyBkaWdpdHMgYW5kIHN5bnRheCBlcnJvcnMgaW4gVW5pY29kZSBwYXR0ZXJucwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>395540</attachid>
            <date>2020-04-05 19:29:28 -0700</date>
            <delta_ts>2020-04-05 21:34:41 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-210037-20200405192927.patch</filename>
            <type>text/plain</type>
            <size>7331</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj
ZmJjMGQ4ZTllNjA4ODQyNDQ0N2Q4ZWY4NTFmMzM2NDNmZWU5NjcwLi5mYmQwMDNlMTdlODNlZWUy
NDFiOWMxYzI1NTlmNjlhYTI4NjMyY2M0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMCBAQAorMjAyMC0wNC0wNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgSlNDIHNoZWxsIHNob3VsZG4ndCB0cmVhdCBOVUwgYXMgYSB0ZXJt
aW5hdG9yIHdoZW4gcHJpbnRpbmcgYSBKUyBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDAzNworCisgICAgICAgIFJldmlld2VkIGJ5IERh
cmluIEFkbGVyLgorCisgICAgICAgIFNpbmNlIEpTIHN0cmluZ3MgYXJlbid0IG51bGwtdGVybWlu
YXRlZCwgaXQncyBwcm9iYWJseSBhIGJldHRlciBleHBlcmllbmNlIHRvIG5vdCBzdG9wIHByaW50
aW5nIHdoZW4gd2Ugc2VlIFwwLgorICAgICAgICBUaGF0IGlzLCAnYWJjXDBkZWYnIHNob3VsZCBi
ZSBwcmludGVkIGFzIGBhYmNkZWZgIGFuZCBub3QgYGFiY2AuCisKKyAgICAgICAgVGhpcyBwYXRj
aCB1cGRhdGVzIG91ciBwcmludGluZyBvZiBldmFsdWF0aW9uIHJlc3VsdHMgYXMgd2VsbCBhcyB0
aGUgcHJpbnQgLyBwcmludEVyciAvIGRlYnVnIGZ1bmN0aW9ucy4KKworICAgICAgICAqIGpzYy5j
cHA6CisgICAgICAgIChwcmludEludGVybmFsKToKKyAgICAgICAgKGZ1bmN0aW9uRGVidWcpOgor
ICAgICAgICAocnVuSW50ZXJhY3RpdmUpOgorCiAyMDIwLTA0LTA1ICBLZWl0aCBNaWxsZXIgIDxr
ZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGVuc3VyZVN0aWxsQWxpdmVIZXJlIGNh
biB0YWtlIHRoZSB2YWx1ZSBpbiBhbnkgbG9jYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKaW5kZXgg
ODExMWRkNmJjMDkxOGM2YzhjNDc2NTAyMGNmNzI5OGM1NjBhOWNmNC4uNzAyZjhkZjNjNDc0MDQ3
YWQ2MmE0YzM1MWI2MmM3YTk3N2UwOWViZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKQEAgLTEyNjgs
NyArMTI2OCw4IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBwcmludEludGVybmFsKEpTR2xvYmFs
T2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSogY2FsCiAgICAgICAgIFJFVFVSTl9JRl9F
WENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgICAgICBhdXRvIHN0cmluZyA9
IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xvYmFsT2JqZWN0LCBzY29wZSwgdmlld1dpdGhT
dHJpbmcpOwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1
ZSgpKTsKLSAgICAgICAgaWYgKGZwcmludGYob3V0LCAiJXMiLCBzdHJpbmcuZGF0YSgpKSA8IDAp
CisgICAgICAgIGZ3cml0ZShzdHJpbmcuZGF0YSgpLCBzaXplb2YoY2hhciksIHN0cmluZy5sZW5n
dGgoKSwgb3V0KTsKKyAgICAgICAgaWYgKGZlcnJvcihvdXQpKQogICAgICAgICAgICAgZ290byBm
YWlsOwogICAgIH0KIApAQCAtMTI4OSw3ICsxMjkwLDkgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hP
U1RfQ0FMTCBmdW5jdGlvbkRlYnVnKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxG
cmEKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgpKTsKICAg
ICBhdXRvIHN0cmluZyA9IGNTdHJpbmdGcm9tVmlld1dpdGhTdHJpbmcoZ2xvYmFsT2JqZWN0LCBz
Y29wZSwgdmlld1dpdGhTdHJpbmcpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVu
Y29kZWRKU1ZhbHVlKCkpOwotICAgIGZwcmludGYoc3RkZXJyLCAiLS0+ICVzXG4iLCBzdHJpbmcu
ZGF0YSgpKTsKKyAgICBmcHV0cygiLS0+ICIsIHN0ZGVycik7CisgICAgZndyaXRlKHN0cmluZy5k
YXRhKCksIHNpemVvZihjaGFyKSwgc3RyaW5nLmxlbmd0aCgpLCBzdGRlcnIpOworICAgIGZwdXRj
KCdcbicsIHN0ZGVycik7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgp
KTsKIH0KIApAQCAtMjc5NSwxMCArMjc5OCwxNCBAQCBzdGF0aWMgdm9pZCBydW5JbnRlcmFjdGl2
ZShHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICAgICAgTmFrZWRQdHI8RXhjZXB0aW9u
PiBldmFsdWF0aW9uRXhjZXB0aW9uOwogICAgICAgICBKU1ZhbHVlIHJldHVyblZhbHVlID0gZXZh
bHVhdGUoZ2xvYmFsT2JqZWN0LCBqc2NTb3VyY2UobGluZSwgc291cmNlT3JpZ2luLCBzb3VyY2VP
cmlnaW4uc3RyaW5nKCkpLCBKU1ZhbHVlKCksIGV2YWx1YXRpb25FeGNlcHRpb24pOwogI2VuZGlm
Ci0gICAgICAgIGlmIChldmFsdWF0aW9uRXhjZXB0aW9uKQotICAgICAgICAgICAgcHJpbnRmKCJF
eGNlcHRpb246ICVzXG4iLCBldmFsdWF0aW9uRXhjZXB0aW9uLT52YWx1ZSgpLnRvV1RGU3RyaW5n
KGdsb2JhbE9iamVjdCkudXRmOCgpLmRhdGEoKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAg
IHByaW50ZigiJXNcbiIsIHJldHVyblZhbHVlLnRvV1RGU3RyaW5nKGdsb2JhbE9iamVjdCkudXRm
OCgpLmRhdGEoKSk7CisgICAgICAgIENTdHJpbmcgcmVzdWx0OworICAgICAgICBpZiAoZXZhbHVh
dGlvbkV4Y2VwdGlvbikgeworICAgICAgICAgICAgZnB1dHMoIkV4Y2VwdGlvbjogIiwgc3Rkb3V0
KTsKKyAgICAgICAgICAgIHJlc3VsdCA9IGV2YWx1YXRpb25FeGNlcHRpb24tPnZhbHVlKCkudG9X
VEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAg
ICAgcmVzdWx0ID0gcmV0dXJuVmFsdWUudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7
CisgICAgICAgIGZ3cml0ZShyZXN1bHQuZGF0YSgpLCBzaXplb2YoY2hhciksIHJlc3VsdC5sZW5n
dGgoKSwgc3Rkb3V0KTsKKyAgICAgICAgcHV0Y2hhcignXG4nKTsKIAogICAgICAgICBzY29wZS5j
bGVhckV4Y2VwdGlvbigpOwogICAgICAgICB2bS5kcmFpbk1pY3JvdGFza3MoKTsKZGlmZiAtLWdp
dCBhL0pTVGVzdHMvLmdpdGF0dHJpYnV0ZXMgYi9KU1Rlc3RzLy5naXRhdHRyaWJ1dGVzCmluZGV4
IGQ4M2Y4NDdlNWI3NWNlNGM5ZjZkYjZmMzhiYzVlNTZjMmU3NmYyMDEuLmNmZDliY2YwZGFkYjdh
MmQwNzQ0Y2JlMzM2OGYyNzU1MWJhMTcwZmUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvLmdpdGF0dHJp
YnV0ZXMKKysrIGIvSlNUZXN0cy8uZ2l0YXR0cmlidXRlcwpAQCAtMSwzICsxLDUgQEAKK0NoYWty
YUNvcmUvdGVzdC9lczUvaGFzSXRlbS5iYXNlbGluZS1qc2MgZGlmZgorCiB0ZXN0MjYyL3Rlc3Qv
bGFuZ3VhZ2UvZXhwcmVzc2lvbnMvbG9naWNhbC1hc3NpZ25tZW50L2xnY2wtYW5kLXdoaXRlc3Bh
Y2UuanMgc3ZuLXByb3BlcnRpZXM9YWxsb3ctdGFicz1vbgogdGVzdDI2Mi90ZXN0L2xhbmd1YWdl
L2V4cHJlc3Npb25zL2xvZ2ljYWwtYXNzaWdubWVudC9sZ2NsLW9yLXdoaXRlc3BhY2UuanMgc3Zu
LXByb3BlcnRpZXM9YWxsb3ctdGFicz1vbgogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Np
b25zL2xvZ2ljYWwtYXNzaWdubWVudC9sZ2NsLW51bGxpc2gtd2hpdGVzcGFjZS5qcyBzdm4tcHJv
cGVydGllcz1hbGxvdy10YWJzPW9uCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYWtyYUNvcmUueWFt
bCBiL0pTVGVzdHMvQ2hha3JhQ29yZS55YW1sCmluZGV4IGFmZTc2MjMyMmRmODliOGY1ODZlZDg2
NTY1NWRlYWVmMzRkYzM2NmEuLjM4NDc4MWRkNjRlNzRjNDJhODNjYzQ4NjA5MGFkNDg5MDMwYzdj
NzkgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hha3JhQ29yZS55YW1sCisrKyBiL0pTVGVzdHMvQ2hh
a3JhQ29yZS55YW1sCkBAIC0xNDY5LDcgKzE0NjksNyBAQAogLSBwYXRoOiBDaGFrcmFDb3JlL3Rl
c3QvZXM1L2VudW1lcmFibGUuanMKICAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNl
cHRpb24iLCAiZW51bWVyYWJsZS5iYXNlbGluZS1qc2MiLCBbXQogLSBwYXRoOiBDaGFrcmFDb3Jl
L3Rlc3QvZXM1L2hhc0l0ZW0uanMKLSAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNl
cHRpb24iLCAiaGFzSXRlbS5iYXNlbGluZSIsIFtdCisgIGNtZDogcnVuQ2hha3JhIDpiYXNlbGlu
ZSwgIk5vRXhjZXB0aW9uIiwgImhhc0l0ZW0uYmFzZWxpbmUtanNjIiwgW10KIC0gcGF0aDogQ2hh
a3JhQ29yZS90ZXN0L2VzNS9yZWdleFNwYWNlLmpzCiAgIGNtZDogcnVuQ2hha3JhIDpiYXNlbGlu
ZSwgIk5vRXhjZXB0aW9uIiwgInJlZ2V4U3BhY2UuYmFzZWxpbmUiLCBbXQogLSBwYXRoOiBDaGFr
cmFDb3JlL3Rlc3QvZXM1L0VudW1lcmF0aW5nV2l0aEVTNS5qcwpkaWZmIC0tZ2l0IGEvSlNUZXN0
cy9DaGFrcmFDb3JlL3Rlc3QvZXM1L2hhc0l0ZW0uYmFzZWxpbmUtanNjIGIvSlNUZXN0cy9DaGFr
cmFDb3JlL3Rlc3QvZXM1L2hhc0l0ZW0uYmFzZWxpbmUtanNjCm5ldyBmaWxlIG1vZGUgMTAwNjQ0
CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0ZDhhYmQy
NTNiYWI2MzJiMDZmODAxMjQwZmYxOGI1ZTgyMWU2NDIKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rl
c3RzL0NoYWtyYUNvcmUvdGVzdC9lczUvaGFzSXRlbS5iYXNlbGluZS1qc2MKQEAgLTAsMCArMSwx
MTAgQEAKK1Rlc3QgZW1wdHkgb2JqZWN0CisgIHBhc3MgKGFiYykKKyAgcGFzcyAoLTEpCisgIHBh
c3MgKDApCisgIHBhc3MgKDEpCisgIHBhc3MgKDEwKQorICBwYXNzICg0Mjk0OTY3Mjk0KQorICBw
YXNzICh4IHkpCisgIHBhc3MgKHgAeSkKKyAgcGFzcyAoeAAAeSkKK1Rlc3QgZW1wdHkgYXJyYXkK
KyAgcGFzcyAoYWJjKQorICBwYXNzICgtMSkKKyAgcGFzcyAoMCkKKyAgcGFzcyAoMSkKKyAgcGFz
cyAoMTApCisgIHBhc3MgKDQyOTQ5NjcyOTQpCisgIHBhc3MgKHggeSkKKyAgcGFzcyAoeAB5KQor
ICBwYXNzICh4AAB5KQorVGVzdCBudW1iZXIgb2JqZWN0CisgIHBhc3MgKGFiYykKKyAgcGFzcyAo
LTEpCisgIHBhc3MgKDApCisgIHBhc3MgKDEpCisgIHBhc3MgKDEwKQorICBwYXNzICg0Mjk0OTY3
Mjk0KQorICBwYXNzICh4IHkpCisgIHBhc3MgKHgAeSkKKyAgcGFzcyAoeAAAeSkKK1Rlc3Qgc3Ry
aW5nIG9iamVjdAorICBwYXNzIChhYmMpCisgIHBhc3MgKC0xKQorICBwYXNzIC4uLmNhbiBub3Qg
ZGVmaW5lUHJvcGVydHkuLi4gKDApCisgIHBhc3MgLi4uY2FuIG5vdCBkZWZpbmVQcm9wZXJ0eS4u
LiAoMSkKKyAgcGFzcyAoMTApCisgIHBhc3MgKDQyOTQ5NjcyOTQpCisgIHBhc3MgKHggeSkKKyAg
cGFzcyAoeAB5KQorICBwYXNzICh4AAB5KQorVGVzdCBPYmplY3QKKyAgcGFzcyAoYWJjKQorICBw
YXNzICgtMSkKKyAgcGFzcyAoMCkKKyAgcGFzcyAoMSkKKyAgcGFzcyAoMTApCisgIHBhc3MgKDQy
OTQ5NjcyOTQpCisgIHBhc3MgKHggeSkKKyAgcGFzcyAoeAB5KQorICBwYXNzICh4AAB5KQorVGVz
dCBnbG9iYWwgb2JqZWN0CisgIHBhc3MgKGFiYykKKyAgcGFzcyAoLTEpCisgIHBhc3MgKDApCisg
IHBhc3MgKDEpCisgIHBhc3MgKDEwKQorICBwYXNzICg0Mjk0OTY3Mjk0KQorICBwYXNzICh4IHkp
CisgIHBhc3MgKHgAeSkKKyAgcGFzcyAoeAAAeSkKK1Rlc3Qgb2JqZWN0IHdpdGggMSBwcm9wZXJ0
eQorICBwYXNzIChhYmMpCisgIHBhc3MgKC0xKQorICBwYXNzICgwKQorICBwYXNzICgxKQorICBw
YXNzICgxMCkKKyAgcGFzcyAoNDI5NDk2NzI5NCkKKyAgcGFzcyAoeCB5KQorICBwYXNzICh4AHkp
CisgIHBhc3MgKHgAAHkpCitUZXN0IG9iamVjdCB3aXRoIG1hbnkgcHJvcGVydGllcworICBwYXNz
IChhYmMpCisgIHBhc3MgKC0xKQorICBwYXNzICgwKQorICBwYXNzICgxKQorICBwYXNzICgxMCkK
KyAgcGFzcyAoNDI5NDk2NzI5NCkKKyAgcGFzcyAoeCB5KQorICBwYXNzICh4AHkpCisgIHBhc3Mg
KHgAAHkpCitUZXN0IG9iamVjdCB3aXRoIGFjY2Vzc29yCisgIHBhc3MgKGFiYykKKyAgcGFzcyAo
LTEpCisgIHBhc3MgKDApCisgIHBhc3MgKDEpCisgIHBhc3MgKDEwKQorICBwYXNzICg0Mjk0OTY3
Mjk0KQorICBwYXNzICh4IHkpCisgIHBhc3MgKHgAeSkKKyAgcGFzcyAoeAAAeSkKK1Rlc3QgYXJy
YXkKKyAgcGFzcyAoYWJjKQorICBwYXNzICgtMSkKKyAgcGFzcyAoMCkKKyAgcGFzcyAoMSkKKyAg
cGFzcyAoMTApCisgIHBhc3MgKDQyOTQ5NjcyOTQpCisgIHBhc3MgKHggeSkKKyAgcGFzcyAoeAB5
KQorICBwYXNzICh4AAB5KQorVGVzdCBlczUgYXJyYXkKKyAgcGFzcyAoYWJjKQorICBwYXNzICgt
MSkKKyAgcGFzcyAoMCkKKyAgcGFzcyAoMSkKKyAgcGFzcyAoMTApCisgIHBhc3MgKDQyOTQ5Njcy
OTQpCisgIHBhc3MgKHggeSkKKyAgcGFzcyAoeAB5KQorICBwYXNzICh4AAB5KQpkaWZmIC0tZ2l0
IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBmMThmZDZlYjU1
OTgwNWQ4Yzk1OTQ4MDUwZTk2ZjI1MjIxNmM2ZmE5Li43YjQyZTdkNTUzNjY2NzNlYWE1NzczYTE5
Nzg1NTdhNGVjY2MyY2IxIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rl
c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTA1ICBSb3NzIEtpcnNsaW5n
ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBKU0Mgc2hlbGwgc2hvdWxkbid0
IHRyZWF0IE5VTCBhcyBhIHRlcm1pbmF0b3Igd2hlbiBwcmludGluZyBhIEpTIHN0cmluZworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMDM3CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiAuZ2l0YXR0cmlidXRl
czoKKyAgICAgICAgKiBDaGFrcmFDb3JlLnlhbWw6CisgICAgICAgICogQ2hha3JhQ29yZS90ZXN0
L2VzNS9oYXNJdGVtLmJhc2VsaW5lLWpzYzogQWRkZWQuCisgICAgICAgIFVwZGF0ZSBiYXNlbGlu
ZSBhbmQgbWFyayBpdCBkaWZmYWJsZSAoYXMgcGxhaW50ZXh0KSBpbiBzcGl0ZSBvZiBjb250YWlu
aW5nIFwwLgorCiAyMDIwLTA0LTA1ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWls
LmNvbT4KIAogICAgICAgICBPY3RhbCBlc2NhcGVzIHNob3VsZCBiZSBtYXggMyBkaWdpdHMgYW5k
IHN5bnRheCBlcnJvcnMgaW4gVW5pY29kZSBwYXR0ZXJucwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>