209946 2020-04-02 19:12:59 -0700 Do not link with OpenGL on Apple platforms 2020-04-03 17:39:09 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209890 1 krollin krollin dino ews-watchlist fred.wang graouts kbr kondapallykalyan sam simon.fraser webkit-bug-importer oldest_to_newest 1637200 0 krollin 2020-04-02 19:12:59 -0700 OpenGL is not used in our build of ANGLE. Attempting to link with it causes warnings, which can turn to errors in some cases (in particular with building with Xcode's "new" build system). 1637201 1 webkit-bug-importer 2020-04-02 19:13:11 -0700 <rdar://problem/61237956> 1637202 2 395337 krollin 2020-04-02 19:15:51 -0700 Created attachment 395337 Patch 1637203 3 ews-watchlist 2020-04-02 19:16:37 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1637447 4 ews-feeder 2020-04-03 11:00:38 -0700 Committed r259475: <https://trac.webkit.org/changeset/259475> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395337. 1637500 5 kbr 2020-04-03 13:05:27 -0700 How are references to functions like CGLCreateContext resolved after this patch? 1637573 6 dino 2020-04-03 17:12:41 -0700 (In reply to Kenneth Russell from comment #5) > How are references to functions like CGLCreateContext resolved after this > patch? Yeah. ANGLE only dynamically loads /System/Library/Frameworks/OpenGL.framework/Libraries/libGL.dylib All the CGL stuff is in /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL So how did this pass tests? 1637578 7 dino 2020-04-03 17:19:58 -0700 Oh. It's because it is linked into WebCore which links OpenGL. 1637579 8 dino 2020-04-03 17:20:55 -0700 However, this change shouldn't have been necessary. If the new build system can't link against OpenGL, it can't build WebCore or WebKit. 1637581 9 dino 2020-04-03 17:23:12 -0700 Did you find out what was actually causing the compiler warning? Because if it was unused functions when linking, then we also have a bunch of those in other projects. e.g. ld: warning: linking with (/System/Library/Frameworks/CoreAudio.framework/CoreAudio) but not using any symbols from it ld: warning: linking with (/System/Library/Frameworks/VideoToolbox.framework/VideoToolbox) but not using any symbols from it ld: warning: linking with (/System/Library/Frameworks/CoreMedia.framework/CoreMedia) but not using any symbols from it ld: warning: linking with (/System/Library/PrivateFrameworks/URLFormatting.framework/URLFormatting) but not using any symbols from it ld: warning: linking with (/usr/lib/libAccessibility.dylib) but not using any symbols from it 1637584 10 krollin 2020-04-03 17:39:09 -0700 (In reply to Dean Jackson from comment #8) > However, this change shouldn't have been necessary. If the new build system > can't link against OpenGL, it can't build WebCore or WebKit. It's not that it can't link against OpenGL. I'm pretty sure that it's because it can't link against an OpenGL that doesn't exist. OpenGL.framework is not in the iphonesimulator SDK. That's where the error was occurring. WebCore is able to link because it only links against OpenGL on the macOS: WebCore.xcconfig 108:WK_OPENGL_LDFLAGS_iphoneos = -framework OpenGLES; 109:WK_OPENGL_LDFLAGS_iphonesimulator = -framework OpenGLES; 114:WK_OPENGL_LDFLAGS_maccatalyst = -framework OpenGL; 115:WK_OPENGL_LDFLAGS_macosx = -framework OpenGL; Thanks for clarifying all of this. I was going crazy today trying to figure out how macOS was linking! 395337 2020-04-02 19:15:51 -0700 2020-04-03 11:00:39 -0700 Patch bug-209946-20200402191550.patch text/plain 2744 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggODE5OWJjMTNlM2NmOWJlZTU1YzlhOTdiZjNmM2VlMjdkZjAzNzE3Yy4uM2ViZGUwOTczYTQz NmI2ZGI1YmU4MWRmOTY1MmY2MDYzNWJlNzk0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTAyICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFw cGxlLmNvbT4KKworICAgICAgICBEbyBub3QgbGluayB3aXRoIE9wZW5HTCBvbiBBcHBsZSBwbGF0 Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTk0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjEyMzc5NTY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3BlbkdMIGlzIG5vdCB1c2VkIGluIG91 ciBidWlsZCBvZiBBTkdMRS4gQXR0ZW1wdGluZyB0byBsaW5rIHdpdGggaXQKKyAgICAgICAgY2F1 c2VzIHdhcm5pbmdzLCB3aGljaCBjYW4gdHVybiBpbnRvIGVycm9ycyBpbiBzb21lIGNhc2VzIChp bgorICAgICAgICBwYXJ0aWN1bGFyLCB3aGVuIGJ1aWxkaW5nIHdpdGggWGNvZGUncyAibmV3IiBi dWlsZCBzeXN0ZW0pLgorCisgICAgICAgICogQU5HTEUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv ajoKKwogMjAyMC0wMy0yNyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVc2UgQU5HTEVfcm9idXN0X2NsaWVudF9tZW1vcnkgdG8gcmVwbGFjZSBmcmFtZWJ1 ZmZlci90ZXh0dXJlIHZhbGlkYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL0FOR0xFLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9BTkdMRS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGJmN2M5NGFjMmIzNmRm M2RhMmNmMGQ3ZWQyNDA3MWVmYTI5NjdlMzcuLmRjNTE3YmIxY2ViYjgxOWIzNTZjMGNkZWM2NjBi MjhiYTZkMDM0YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5H TEUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtNDUyLDcgKzQ1Miw2IEBACiAJCTVDQjMw MTQ2MURFMzlGMUEwMEQyQzQwNSAvKiBWZXJ0ZXhBcnJheUdMLmggaW4gSGVhZGVycyAqLyA9IHtp c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0IzMDExMzFERTM5RjFBMDBEMkM0MDUgLyog VmVydGV4QXJyYXlHTC5oICovOyB9OwogCQk1Q0IzMDE0RjFERTM5RjQ3MDBEMkM0MDUgLyogRGlz cGxheUNHTC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g NUNCMzAxNDkxREUzOUY0NzAwRDJDNDA1IC8qIERpc3BsYXlDR0wuaCAqLzsgfTsKIAkJNUNCMzAx NTExREUzOUY0NzAwRDJDNDA1IC8qIFBidWZmZXJTdXJmYWNlQ0dMLmggaW4gSGVhZGVycyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1Q0IzMDE0QjFERTM5RjQ3MDBEMkM0MDUg LyogUGJ1ZmZlclN1cmZhY2VDR0wuaCAqLzsgfTsKLQkJNUNCMzA0OTIxREU0MTU2MjAwRDJDNDA1 IC8qIE9wZW5HTC5mcmFtZXdvcmsgaW4gRnJhbWV3b3JrcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZp bGU7IGZpbGVSZWYgPSA1Q0IzMDQ4RDFERTQxNDQ0MDBEMkM0MDUgLyogT3BlbkdMLmZyYW1ld29y ayAqLzsgfTsKIAkJNUNCMzA0OTMxREU0MTU2QjAwRDJDNDA1IC8qIFF1YXJ0ekNvcmUuZnJhbWV3 b3JrIGluIEZyYW1ld29ya3MgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNUNC MzA0OEYxREU0MTQ1NTAwRDJDNDA1IC8qIFF1YXJ0ekNvcmUuZnJhbWV3b3JrICovOyB9OwogCQk1 Q0IzMDQ5NDFERTQxNTcyMDBEMkM0MDUgLyogQ29yZUdyYXBoaWNzLmZyYW1ld29yayBpbiBGcmFt ZXdvcmtzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDVDQjMwNDhCMURFNDE0 MzUwMEQyQzQwNSAvKiBDb3JlR3JhcGhpY3MuZnJhbWV3b3JrICovOyB9OwogCQk1Q0IzMDQ5NjFE RTQxNTdCMDBEMkM0MDUgLyogZW50cnlfcG9pbnRzX2VnbF9leHQuaCBpbiBIZWFkZXJzICovID0g e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDVDQjMwMEJDMURFMzlFNzUwMEQyQzQwNSAv KiBlbnRyeV9wb2ludHNfZWdsX2V4dC5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFB1 YmxpYywgKTsgfTsgfTsKQEAgLTE1MTgsNyArMTUxNyw2IEBACiAJCQlidWlsZEFjdGlvbk1hc2sg PSAyMTQ3NDgzNjQ3OwogCQkJZmlsZXMgPSAoCiAJCQkJNUNCMzA0OTQxREU0MTU3MjAwRDJDNDA1 IC8qIENvcmVHcmFwaGljcy5mcmFtZXdvcmsgaW4gRnJhbWV3b3JrcyAqLywKLQkJCQk1Q0IzMDQ5 MjFERTQxNTYyMDBEMkM0MDUgLyogT3BlbkdMLmZyYW1ld29yayBpbiBGcmFtZXdvcmtzICovLAog CQkJCTVDQjMwNDkzMURFNDE1NkIwMEQyQzQwNSAvKiBRdWFydHpDb3JlLmZyYW1ld29yayBpbiBG cmFtZXdvcmtzICovLAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3Np bmcgPSAwOwo=