209915 2020-04-02 11:27:11 -0700 REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm 2020-04-02 12:17:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188245 1 ddkilzer ddkilzer darin webkit-bug-importer oldest_to_newest 1636962 0 ddkilzer 2020-04-02 11:27:11 -0700 Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm. CFTypeRef createCoreAnimationLayer() { CALayer *caLayer = [[TestPluginLayer alloc] init]; [...] return CFBridgingRetain(caLayer); } This function currently returns a +2 retained object instead of a +1 retained object. 1636965 1 395282 ddkilzer 2020-04-02 11:29:59 -0700 Created attachment 395282 Patch v1 1636970 2 ddkilzer 2020-04-02 11:38:34 -0700 This is also the _last_ static analyzer warning in DumpRenderTree for the version of the clang static analyzer we're running! 1637002 3 ews-feeder 2020-04-02 12:16:12 -0700 Committed r259403: <https://trac.webkit.org/changeset/259403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395282. 1637004 4 webkit-bug-importer 2020-04-02 12:17:13 -0700 <rdar://problem/61220322> 395282 2020-04-02 11:29:59 -0700 2020-04-02 12:16:12 -0700 Patch v1 bug-209915-20200402113123.patch text/plain 1886 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYThlM2E2YTlmNWQwNzRiOTkyMjMzMjZlNTY1ZTE0ODI1 ZGNiZDVkYi4uMTQ3MGY4YWI0YzA1OTY5NGZhODZmZjFiZWVkMjQ2Mjk3ZjAxZjFiMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA0LTAyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjIzNDY4NSk6IExlYWsgb2YgQ0FMYXllciBpbiBjcmVhdGVDb3Jl QW5pbWF0aW9uTGF5ZXIoKSBpbiBQbHVnaW5PYmplY3RNYWMubW0KKyAgICAgICAgPGh0dHBzOi8v d2Via2l0Lm9yZy9iLzIwOTkxNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5P YmplY3RNYWMubW06CisgICAgICAgIChjcmVhdGVDb3JlQW5pbWF0aW9uTGF5ZXIpOiBVc2UgUmV0 YWluUHRyPD4gdG8gZml4IGxlYWsuCisKIDIwMjAtMDMtMzEgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBUEk6OlBhZ2VDb25maWd1cmF0aW9uIG1heSBoYXZl IGNvbmZsaWN0aW5nIHByZWZlcmVuY2UgdmFsdWVzIGJldHdlZW4gV2ViUHJlZmVyZW5jZXMgYW5k IFdlYlByZWZlcmVuY2VzU3RvcmU6OlZhbHVlTWFwIGluc3RhbmNlIHZhcmlhYmxlcwpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVj dE1hYy5tbSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5P YmplY3RNYWMubW0KaW5kZXggZWYyYjdkOTU4ODIyNzg0ODljMzkwMjU0OTZhMThlY2NlMzlmYTNl Yy4uYTY0NTdhMDc2YjFiOTIyMmVjMTgzNjJkNGJjOTRjYjQ3MmEzYTNjYyAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdE1hYy5t bQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2Jq ZWN0TWFjLm1tCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiUGx1Z2luT2JqZWN0LmgiCiAK ICNpbmNsdWRlIDxRdWFydHpDb3JlL1F1YXJ0ekNvcmUuaD4KKyNpbmNsdWRlIDx3dGYvUmV0YWlu UHRyLmg+CiAKIEBpbnRlcmZhY2UgVGVzdFBsdWdpbkxheWVyIDogQ0FMYXllcgogQGVuZApAQCAt NDQsNyArNDUsNyBAQCBAZW5kCiAKIENGVHlwZVJlZiBjcmVhdGVDb3JlQW5pbWF0aW9uTGF5ZXIo KQogewotICAgIENBTGF5ZXIgKmNhTGF5ZXIgPSBbW1Rlc3RQbHVnaW5MYXllciBhbGxvY10gaW5p dF07CisgICAgUmV0YWluUHRyPENBTGF5ZXI+IGNhTGF5ZXIgPSBhZG9wdE5TKFtbVGVzdFBsdWdp bkxheWVyIGFsbG9jXSBpbml0XSk7CiAKICAgICBOU051bGwgKm51bGxWYWx1ZSA9IFtOU051bGwg bnVsbF07CiAgICAgTlNEaWN0aW9uYXJ5ICphY3Rpb25zID0gW05TRGljdGlvbmFyeSBkaWN0aW9u YXJ5V2l0aE9iamVjdHNBbmRLZXlzOgpAQCAtOTMsNSArOTQsNSBAQCBDRlR5cGVSZWYgY3JlYXRl Q29yZUFuaW1hdGlvbkxheWVyKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZTprQ0FDb25zdHJhaW50TWF4WF1dOwogCiAgICAg W2NhTGF5ZXIgYWRkU3VibGF5ZXI6c3VibGF5ZXJdOwotICAgIHJldHVybiBDRkJyaWRnaW5nUmV0 YWluKGNhTGF5ZXIpOworICAgIHJldHVybiBDRkJyaWRnaW5nUmV0YWluKGNhTGF5ZXIuZ2V0KCkp OwogfQo=