209570 2020-03-25 16:30:45 -0700 REGRESSION (r258989): ASSERTION FAILED: !isMissingPostLayoutData in WebKit::EditorState::PostLayoutData 2020-03-26 13:29:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199960 https://bugs.webkit.org/show_bug.cgi?id=201608 InRadar P2 Normal --- 199960 1 ryanhaddad dbates darin dbates webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1634113 0 ryanhaddad 2020-03-25 16:30:45 -0700 Seeing the following API test fail an assertion on iOS Debug bots: TestWebKitAPI.ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink MRMediaRemoteSetNowPlayingApplicationPlaybackStateForOrigin(stopped) failed with error 3 ASSERTION FAILED: Attempt to access post layout data before receiving it !isMissingPostLayoutData /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/Shared/EditorState.h(157) : const WebKit::EditorState::PostLayoutData &WebKit::EditorState::postLayoutData() const 1 0x11028bf19 WTFCrash 2 0x1209e028b WebKit::EditorState::postLayoutData() const 3 0x121b759d9 -[WKContentView(WKInteraction) selectedText] 4 0x121b8a768 -[WKContentView(WKInteraction) selectedTextForActionSheetAssistant:] 5 0x120f7147d -[WKActionSheetAssistant showDataDetectorsSheet] 6 0x121b6dff9 -[WKContentView(WKInteraction) _showDataDetectorsSheet] 7 0x121b96c89 -[WKContentView(WKTesting) _simulateLongPressActionAtLocation:]::$_44::operator()(WebKit::InteractionInformationAtPosition) const 8 0x121b96c29 __63-[WKContentView(WKTesting) _simulateLongPressActionAtLocation:]_block_invoke 9 0x121b6f27a WTF::BlockPtr<void (WebKit::InteractionInformationAtPosition)>::operator()(WebKit::InteractionInformationAtPosition) const 10 0x121b6ee4d -[WKContentView(WKInteraction) _invokeAndRemovePendingHandlersValidForCurrentPositionInformation] 11 0x121b73425 -[WKContentView(WKInteraction) _positionInformationDidChange:] 12 0x120f305d4 WebKit::PageClientImpl::positionInformationDidChange(WebKit::InteractionInformationAtPosition const&) 13 0x120fb7cf1 WebKit::WebPageProxy::didReceivePositionInformation(WebKit::InteractionInformationAtPosition const&) 14 0x12194acaa void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>, 0ul>(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>&&, std::__1::integer_sequence<unsigned long, 0ul>) 15 0x121949fd0 void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&), std::__1::tuple<WebKit::InteractionInformationAtPosition>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::InteractionInformationAtPosition>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)) 16 0x1219029ce void IPC::handleMessage<Messages::WebPageProxy::DidReceivePositionInformation, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::InteractionInformationAtPosition const&)) 17 0x1218f9169 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 18 0x12011ff39 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 19 0x120bf8104 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 20 0x120df096a WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 21 0x12008bbd9 IPC::Connection::dispatchMessage(IPC::Decoder&) 22 0x12008c541 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 23 0x12008ac4b IPC::Connection::dispatchIncomingMessages() 24 0x1200ab3d5 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7::operator()() 25 0x1200ab309 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7, void>::call() 26 0x1102b6baa WTF::Function<void ()>::operator()() const 27 0x11032bb78 WTF::RunLoop::performWork() 28 0x11032d22e WTF::RunLoop::performWork(void*) 29 0x117e4b471 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 30 0x117e4b39c __CFRunLoopDoSource0 31 0x117e4ab74 __CFRunLoopDoSources0 Child process terminated with signal 11: Segmentation fault https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20%28Tests%29/builds/2789 1634115 1 webkit-bug-importer 2020-03-25 16:31:41 -0700 <rdar://problem/60895050> 1634118 2 ryanhaddad 2020-03-25 16:33:19 -0700 https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=258994&stop_rev=258983&limit=100&verbose=on Probably related to https://trac.webkit.org/changeset/258989/webkit 1634462 3 dbates 2020-03-26 11:45:18 -0700 Looking at this now. 1634503 4 394645 dbates 2020-03-26 12:57:55 -0700 Created attachment 394645 Patch 1634536 5 dbates 2020-03-26 13:28:18 -0700 Thanks Darin! 1634537 6 394645 dbates 2020-03-26 13:29:18 -0700 Comment on attachment 394645 Patch Clearing flags on attachment: 394645 Committed r259071: <https://trac.webkit.org/changeset/259071> 1634538 7 dbates 2020-03-26 13:29:20 -0700 All reviewed patches have been landed. Closing bug. 394645 2020-03-26 12:57:55 -0700 2020-03-26 13:29:18 -0700 Patch bug-209570-20200326125754.patch text/plain 2514 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzZmJjZDNjNDU3M2M4YjZl Mzc1MmVmZTFlMGFmZDFhMjYyYmVhZjUuLjIzNWRiZGNmOGNjNTFlZGY3NmYwZDJlMzdiZjkwYzI3 ZjdhMWYwMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDMtMjYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTg5ODkp OiBBU1NFUlRJT04gRkFJTEVEOiAhaXNNaXNzaW5nUG9zdExheW91dERhdGEgaW4gV2ViS2l0OjpF ZGl0b3JTdGF0ZTo6UG9zdExheW91dERhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwOTU3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjA4OTUw NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2Vu ZCBhbiBlZGl0b3Igc3RhdGUgdXBkYXRlIGJlZm9yZSByZXNwb25kaW5nIHRvIGEgcmVxdWVzdCBm b3IgcG9zaXRpb24gaW5mb3JtYXRpb24KKyAgICAgICAgdG8gZW5zdXJlIHRoYXQgdGhlIFVJIHBy b2Nlc3MgaGFzIHVwLXRvLWRhdGUgc2VsZWN0aW9uIHN0YXRlLiBPdGhlcndpc2UsIGNhbGxpbmcg Y29kZQorICAgICAgICB0aGF0IHVzZXMgdGhpcyBpbmZvcm1hdGlvbiB0byBkZXRlcm1pbmUgd2hl dGhlciB0byBxdWVyeSBmb3IgdGhlIHNlbGVjdGlvbiB0ZXh0IHdpbGwKKyAgICAgICAgY2F1c2Ug YW4gYXNzZXJ0aW9uIGZhaWx1cmUuCisKKyAgICAgICAgVGhpcyBmaXhlcyB0aGUgdGVzdCBmYWls dXJlIFRlc3RXZWJLaXRBUEkuQWN0aW9uU2hlZXRUZXN0cy5EYXRhRGV0ZWN0b3JzTGlua0lzTm90 UHJlc2VudGVkQXNBTGluaworICAgICAgICBjYXVzZWQgYnkgcjI1ODk4OS4gRm9sbG93aW5nIHIy NTg5ODkgV2ViS2l0IG5vdyBhY2N1cmF0ZWx5IHJlcG9ydHMgd2hldGhlciBlZGl0b3Igc3RhdGUK KyAgICAgICAgaGFzIG9yIGRvZXMgbm90IGhhdmUgcG9zdC1sYXlvdXQgZGV0YWlscy4gUHJpb3Ig dG8gdGhpcyB0aGUgZGVmYXVsdCBFZGl0b3JTdGF0ZSB3YXMgbWFya2VkCisgICAgICAgIGFzIGhh dmluZyBwb3N0LWxheW91dCBkYXRhIGV2ZW4gaWYgaXQgZGlkIG5vdCBhY3R1YWxseSBoYXZlIHN1 Y2ggZGF0YS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnJlcXVlc3RQb3NpdGlvbkluZm9ybWF0aW9uKToKKwog MjAyMC0wMy0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViUGFnZTo6c2VsZWN0UG9zaXRpb25BdFBvaW50KCkgZG9lcyBub3QgZm9jdXMgYW4gZWxlbWVu dCBpbiBhIG5vbi1mb2N1c2VkIGZyYW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDU4MGViYzllNTg1Yzc1NWE5MjA5YWVi NWE0ZmMxYTE2MWRmNDNiMTAuLjcwODE2Yzg0OGY0MmJkNTc5NjFiMGVkNzMwOTkxMzFmMjFhZDc1 MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCkBAIC0yNTg5LDYgKzI1ODksOCBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9u SW5mb3JtYXRpb24oY29uc3QgSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QmIHJlcXVlcwog ICAgICAgICByZXR1cm4gcmVwbHkoeyB9KTsKICAgICB9CiAKKyAgICBzZW5kRWRpdG9yU3RhdGVV cGRhdGUoKTsKKwogICAgIG1fcGVuZGluZ1N5bmNocm9ub3VzUG9zaXRpb25JbmZvcm1hdGlvblJl cGx5ID0gV1RGTW92ZShyZXBseSk7CiAKICAgICBhdXRvIGluZm9ybWF0aW9uID0gcG9zaXRpb25J bmZvcm1hdGlvbihyZXF1ZXN0KTsKQEAgLTI5NjMsNiArMjk2NSw3IEBAIEludGVyYWN0aW9uSW5m b3JtYXRpb25BdFBvc2l0aW9uIFdlYlBhZ2U6OnBvc2l0aW9uSW5mb3JtYXRpb24oY29uc3QgSW50 ZXJhY3Rpb25JCiAKIHZvaWQgV2ViUGFnZTo6cmVxdWVzdFBvc2l0aW9uSW5mb3JtYXRpb24oY29u c3QgSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QmIHJlcXVlc3QpCiB7CisgICAgc2VuZEVk aXRvclN0YXRlVXBkYXRlKCk7CiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWRS ZWNlaXZlUG9zaXRpb25JbmZvcm1hdGlvbihwb3NpdGlvbkluZm9ybWF0aW9uKHJlcXVlc3QpKSk7 CiB9CiAK