209389 2020-03-21 19:52:37 -0700 Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover 2021-03-17 15:01:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 31157 119175 1 hi hi bburg hi inspector-bugzilla-changes m.kurz+webkitbugs spamfaenger webkit-bug-importer oldest_to_newest 1632571 0 hi 2020-03-21 19:52:37 -0700 Rather than have a `<input type="text">` that we `Date.parse` on each `"input"`, using a `<input type="datetime-local">` would be preferred. 1740312 1 423418 hi 2021-03-16 17:05:49 -0700 Created attachment 423418 Patch 1740832 2 423418 bburg 2021-03-17 12:06:18 -0700 Comment on attachment 423418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review > Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 > + data.expires = formatDate(cookie.expires || this._defaultExpires()); Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now? 1740837 3 423418 hi 2021-03-17 12:16:19 -0700 Comment on attachment 423418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review >> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 >> + data.expires = formatDate(cookie.expires || this._defaultExpires()); > > Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now? AFAIU this is the format expected by `<input type="datetime-local">` according to @Aditya Keerthi. The "local" part of "datetime-local" means that it will always be based on the local time. 1740916 4 423418 bburg 2021-03-17 14:53:18 -0700 Comment on attachment 423418 Patch r=me. We may get pushback if this breaks localizations. 1740918 5 ews-feeder 2021-03-17 14:59:52 -0700 Committed r274593: <https://commits.webkit.org/r274593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423418. 1740919 6 webkit-bug-importer 2021-03-17 15:01:19 -0700 <rdar://problem/75545445> 423418 2021-03-16 17:05:49 -0700 2021-03-17 14:59:53 -0700 Patch 209389.diff text/plain 4488 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI3ODU5MjE2MTk5YS4uNTZiZWE5YTM5MWE0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMS0wMy0xNiAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog dXNlIG5hdGl2ZSBkYXRldGltZS1sb2NhbCBwaWNrZXIgZm9yIGNoYW5naW5nIGBleHBpcmVzYCB2 YWx1ZSBpbiBjb29raWUgcG9wb3ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA5Mzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgcjI1OTE3MyBhbHJlYWR5IG1hZGUgaXQgc28gdGhhdCB0aGUgYDxpbnB1 dD5gIGZvciBFeHBpcmVzIHVzZWQgYGRhdGV0aW1lLWxvY2FsYCwgc28gbm90aGluZworICAgICAg ICBuZWVkcyB0byBiZSBjaGFuZ2VkIHRvIGFkb3B0IHRoYXQuIFdlIHN0aWxsIHdhbnQgdG8ga2Vl cCB0aGUgYCJpbnB1dCJgIGV2ZW50IGxpc3RlbmVyIHRoYXQKKyAgICAgICAgcGFyc2VzIGFuZCB2 YWxpZGF0ZXMgdGhlIGB2YWx1ZWAgKG9yIGBwbGFjZWhvbGRlcmApIG9mIHRoZSBgPGlucHV0IHR5 cGU9ImRhdGV0aW1lLWxvY2FsIj5gCisgICAgICAgIGJlY2F1c2UgZGF0ZXMgaW4gdGhlIHBhc3Qg c2hvdWxkIGJlIGNvbnNpZGVyZWQgaW52YWxpZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvQ29va2llUG9wb3Zlci5qczoKKyAgICAgICAgKFdJLkNvb2tpZVBvcG92ZXIucHJvdG90 eXBlLnNob3cpOiBBZGQgYHN0ZXAgPSAxYCBzbyB0aGF0IHRoZSBzZWNvbmRzIGZpZWxkIGlzIHNo b3duLgorICAgICAgICAoV0kuQ29va2llUG9wb3Zlci5wcm90b3R5cGUuc2hvdy5mb3JtYXREYXRl KTogQWRkZWQuCisgICAgICAgIChXSS5Db29raWVQb3BvdmVyLnByb3RvdHlwZS5zaG93LmZvcm1h dERhdGUucGFkKTogQWRkZWQuCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVQ b3BvdmVyLmNzczogUmVtb3ZlIHRoZSBGSVhNRSBjb21tZW50LgorCiAyMDIxLTAzLTE1ICBOaWtp dGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlbW92ZSBleHBlcmltZW50YWwgc2V0dGluZyBhbmQgZW5hYmxlIExheW91dCBzaWRlYmFy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b29raWVQb3BvdmVyLmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0Nvb2tpZVBvcG92ZXIuY3NzCmluZGV4IGE1ZTI1ZDlhOWIzOC4uZDdjMzBlYmM4MWMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db29r aWVQb3BvdmVyLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db29raWVQb3BvdmVyLmNzcwpAQCAtNDUsOCArNDUsNiBAQAogICAgIHBhZGRpbmctaW5s aW5lLXN0YXJ0OiA0cHg7CiB9CiAKLS8qIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjA5 Mzg5PiBXZWIgSW5zcGVjdG9yOiB1c2UgbmF0aXZlIGRhdGV0aW1lLWxvY2FsIHBpY2tlciBmb3Ig Y2hhbmdpbmcgYGV4cGlyZXNgIHZhbHVlIGluIGNvb2tpZSBwb3BvdmVyICovCi0KIC5wb3BvdmVy IC5jb29raWUtcG9wb3Zlci1jb250ZW50ID4gdGFibGUgPiB0ciA+IHRkID4gaW5wdXQ6bWF0Y2hl cyhbdHlwZT0idGV4dCJdLCBbdHlwZT0iZGF0ZXRpbWUtbG9jYWwiXSkgewogICAgIHdpZHRoOiAx MDAlOwogICAgIHBhZGRpbmc6IDNweCA0cHggMnB4OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llUG9wb3Zlci5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVBvcG92ZXIuanMKaW5kZXgg NDE4NjYzNGM2M2NiLi4yZTJjODE2NjhhOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVBvcG92ZXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llUG9wb3Zlci5qcwpAQCAtMTA3 LDEzICsxMDcsMzIgQEAgV0kuQ29va2llUG9wb3ZlciA9IGNsYXNzIENvb2tpZVBvcG92ZXIgZXh0 ZW5kcyBXSS5Qb3BvdmVyCiAgICAgICAgIHRoaXMuX3RhcmdldEVsZW1lbnQgPSB0YXJnZXRFbGVt ZW50OwogICAgICAgICB0aGlzLl9wcmVmZXJyZWRFZGdlcyA9IHByZWZlcnJlZEVkZ2VzOwogCisg ICAgICAgIGZ1bmN0aW9uIGZvcm1hdERhdGUoZGF0ZSkgeworICAgICAgICAgICAgZnVuY3Rpb24g cGFkKG51bWJlcikgeworICAgICAgICAgICAgICAgIHJldHVybiBTdHJpbmcobnVtYmVyKS5wYWRT dGFydCgyLCAiMCIpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIFsKKyAgICAg ICAgICAgICAgICBkYXRlLmdldEZ1bGxZZWFyKCksCisgICAgICAgICAgICAgICAgIi0iLAorICAg ICAgICAgICAgICAgIHBhZChkYXRlLmdldE1vbnRoKCkgKyAxKSwKKyAgICAgICAgICAgICAgICAi LSIsCisgICAgICAgICAgICAgICAgcGFkKGRhdGUuZ2V0RGF0ZSgpKSwKKyAgICAgICAgICAgICAg ICAiVCIsCisgICAgICAgICAgICAgICAgcGFkKGRhdGUuZ2V0SG91cnMoKSksCisgICAgICAgICAg ICAgICAgIjoiLAorICAgICAgICAgICAgICAgIHBhZChkYXRlLmdldE1pbnV0ZXMoKSksCisgICAg ICAgICAgICAgICAgIjoiLAorICAgICAgICAgICAgICAgIHBhZChkYXRlLmdldFNlY29uZHMoKSks CisgICAgICAgICAgICBdLmpvaW4oIiIpOworICAgICAgICB9CisKICAgICAgICAgbGV0IGRhdGEg PSB7fTsKICAgICAgICAgaWYgKGNvb2tpZSkgewogICAgICAgICAgICAgZGF0YS5uYW1lID0gY29v a2llLm5hbWU7CiAgICAgICAgICAgICBkYXRhLnZhbHVlID0gY29va2llLnZhbHVlOwogICAgICAg ICAgICAgZGF0YS5kb21haW4gPSBjb29raWUuZG9tYWluOwogICAgICAgICAgICAgZGF0YS5wYXRo ID0gY29va2llLnBhdGg7Ci0gICAgICAgICAgICBkYXRhLmV4cGlyZXMgPSAoY29va2llLmV4cGly ZXMgfHwgdGhpcy5fZGVmYXVsdEV4cGlyZXMoKSkudG9Mb2NhbGVTdHJpbmcoKTsKKyAgICAgICAg ICAgIGRhdGEuZXhwaXJlcyA9IGZvcm1hdERhdGUoY29va2llLmV4cGlyZXMgfHwgdGhpcy5fZGVm YXVsdEV4cGlyZXMoKSk7CiAgICAgICAgICAgICBkYXRhLnNlc3Npb24gPSBjb29raWUuc2Vzc2lv bjsKICAgICAgICAgICAgIGRhdGEuaHR0cE9ubHkgPSBjb29raWUuaHR0cE9ubHk7CiAgICAgICAg ICAgICBkYXRhLnNlY3VyZSA9IGNvb2tpZS5zZWN1cmU7CkBAIC0xMjQsNyArMTQzLDcgQEAgV0ku Q29va2llUG9wb3ZlciA9IGNsYXNzIENvb2tpZVBvcG92ZXIgZXh0ZW5kcyBXSS5Qb3BvdmVyCiAg ICAgICAgICAgICBkYXRhLnZhbHVlID0gIiI7CiAgICAgICAgICAgICBkYXRhLmRvbWFpbiA9IHVy bENvbXBvbmVudHMuaG9zdDsKICAgICAgICAgICAgIGRhdGEucGF0aCA9IHVybENvbXBvbmVudHMu cGF0aDsKLSAgICAgICAgICAgIGRhdGEuZXhwaXJlcyA9IHRoaXMuX2RlZmF1bHRFeHBpcmVzKCku dG9Mb2NhbGVTdHJpbmcoKTsKKyAgICAgICAgICAgIGRhdGEuZXhwaXJlcyA9IGZvcm1hdERhdGUo dGhpcy5fZGVmYXVsdEV4cGlyZXMoKSk7CiAgICAgICAgICAgICBkYXRhLnNlc3Npb24gPSB0cnVl OwogICAgICAgICAgICAgZGF0YS5odHRwT25seSA9IGZhbHNlOwogICAgICAgICAgICAgZGF0YS5z ZWN1cmUgPSBmYWxzZTsKQEAgLTE5Niw2ICsyMTUsNyBAQCBXSS5Db29raWVQb3BvdmVyID0gY2xh c3MgQ29va2llUG9wb3ZlciBleHRlbmRzIFdJLlBvcG92ZXIKIAogICAgICAgICBsZXQgZXhwaXJl c0lucHV0Um93ID0gY3JlYXRlSW5wdXRSb3coImV4cGlyZXMiLCBXSS51bmxvY2FsaXplZFN0cmlu ZygiRXhwaXJlcyIpLCAiZGF0ZXRpbWUtbG9jYWwiLCBkYXRhLmV4cGlyZXMpOwogICAgICAgICB0 aGlzLl9leHBpcmVzSW5wdXRFbGVtZW50ID0gZXhwaXJlc0lucHV0Um93LmlucHV0RWxlbWVudDsK KyAgICAgICAgdGhpcy5fZXhwaXJlc0lucHV0RWxlbWVudC5zdGVwID0gMTsgLy8gQ2F1c2VzIHRo ZSBzZWNvbmRzIGZpZWxkIHRvIGJlIHNob3duLgogICAgICAgICB0aGlzLl9leHBpcmVzSW5wdXRF bGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImlucHV0IiwgKGV2ZW50KSA9PiB7CiAgICAgICAgICAg ICB0aGlzLl9leHBpcmVzSW5wdXRFbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImludmFsaWQiLCBp c05hTih0aGlzLl9wYXJzZUV4cGlyZXMoKSkpOwogICAgICAgICB9KTsK