209358 2020-03-20 12:33:05 -0700 [MSVC] Remove experimental lambda processor usage 2021-05-21 00:12:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226070 InRadar P2 Normal --- 1 don.olmstead don.olmstead annulen cdumez darin esprehn+autocc ews-watchlist fujii gyuyoung.kim kangil.han ryuan.choi sergio webkit-bug-importer oldest_to_newest 1632216 0 don.olmstead 2020-03-20 12:33:05 -0700 The experimental lambda processor is currently crashing MSVC when compiling WebKit code in Visual Studio 16.5.0. 1632222 1 394111 don.olmstead 2020-03-20 12:42:56 -0700 Created attachment 394111 Patch 1632254 2 fujii 2020-03-20 13:41:19 -0700 *** Bug 209311 has been marked as a duplicate of this bug. *** 1632256 3 fujii 2020-03-20 13:43:32 -0700 See also: Bug 209358 – [MSVC] Remove experimental lambda processor usage 1632262 4 394111 fujii 2020-03-20 13:55:55 -0700 Comment on attachment 394111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394111&action=review > Source/WebCore/dom/DocumentStorageAccess.cpp:200 > + m_document.eventLoop().queueMicrotask([this, weakThis = WTFMove(weakThis)] { You can't WTFMove(weakThis) twice. You need to copy the weak ptr. 1632281 5 394111 fujii 2020-03-20 14:25:14 -0700 Comment on attachment 394111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394111&action=review >> Source/WebCore/dom/DocumentStorageAccess.cpp:200 >> + m_document.eventLoop().queueMicrotask([this, weakThis = WTFMove(weakThis)] { > > You can't WTFMove(weakThis) twice. You need to copy the weak ptr. It can be copied by [this, weakThis]. 1633408 6 394390 don.olmstead 2020-03-24 11:57:26 -0700 Created attachment 394390 Patch 1633425 7 394390 darin 2020-03-24 12:31:02 -0700 Comment on attachment 394390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394390&action=review > Source/WebCore/dom/DocumentStorageAccess.cpp:185 > + m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] { Doesn’t the syntax [this, weakThis] work without a call to makeWeakPtr? 1633459 8 don.olmstead 2020-03-24 13:42:30 -0700 Confirmed that the crash is still there in VS 16.5.1. 1633462 9 darin 2020-03-24 13:47:27 -0700 You mean you tried [this, weakThis] and it also failed? I think we need a comment here otherwise people won't know and will keep re-breaking it. 1633466 10 fujii 2020-03-24 13:53:47 -0700 Did you test it by removing /experimental:newLambdaProcessor switch? The compiler crash is caused by the switch. I confirmed [this, weakThis] works with my VS 16.5.1. 1634714 11 394697 fujii 2020-03-26 20:00:26 -0700 Created attachment 394697 Patch 1634732 12 ews-feeder 2020-03-26 21:31:07 -0700 Committed r259104: <https://trac.webkit.org/changeset/259104> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394697. 1634733 13 webkit-bug-importer 2020-03-26 21:32:13 -0700 <rdar://problem/60951813> 394111 2020-03-20 12:42:56 -0700 2020-03-24 11:57:26 -0700 Patch bug-209358.diff text/plain 3375 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGNmMTk2ZTVlYjMuLjBm NTY0YjBlNWU4NiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAzLTIwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgW01TVkNdIFJlbW92ZSBleHBlcmltZW50YWwgbGFtYmRhIHByb2Nlc3Nv ciB1c2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA5MzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIC9leHBlcmltZW50YWw6bmV3TGFtYmRhUHJvY2Vzc29yIHNpbmNlIFdlYktpdCBpcyBu byBsb25nZXIgYWJsZSB0byBidWlsZAorICAgICAgICB3aXRoIHRoaXMgc2V0dGluZyBhcyBvZiBW aXN1YWwgU3R1ZGlvIDE2LjUuMC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zTVNW Qy5jbWFrZToKKwogMjAyMC0wMy0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgUkVMRUFTRV9MT0cgc2hvdWxkIG5vdCBiZSBDb2NvYSBzcGVjaWZp YwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGRmMTkwY2Y0MGYyMy4uM2ZhMjM5NTdhOTI2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMjAgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBz b255LmNvbT4KKworICAgICAgICBbTVNWQ10gUmVtb3ZlIGV4cGVyaW1lbnRhbCBsYW1iZGEgcHJv Y2Vzc29yIHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDkzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggYnVpbGQgZm9yIFZpc3VhbCBTdHVkaW8gc2NvcGluZyBpc3N1ZSBmb3IgbGFtYmRh cy4gVGhlIGV4cGVyaW1lbnRhbCBsYW1iYWRhCisgICAgICAgIHByb2Nlc3NvciBkaWQgYnVpbGQg dGhpcyBjb2RlIGJ1dCBpcyBub3cgZmFpbGluZyB0byBidWlsZCBXZWJLaXQgYXQgYWxsLgorCisg ICAgICAgICogZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKToKKwogMjAyMC0w My0yMCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gQXZvaWQgaW5maW5pdGUgbG9vcCB3aGVuIHN0dWNrIG9uIHBhcnRpYWwgY29udGVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRTdG9yYWdlQWNjZXNzLmNwcAppbmRleCBiZTY5NDRk NjM4Y2IuLjFmOTkyZmRiNjExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50U3RvcmFnZUFjY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3Rv cmFnZUFjY2Vzcy5jcHAKQEAgLTE4Miw3ICsxODIsNyBAQCB2b2lkIERvY3VtZW50U3RvcmFnZUFj Y2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUmVmPERlZmVycmVkUHJvbWlzZT4mJiBwcm9taXNl KQogICAgICAgICBib29sIHNob3VsZFByZXNlcnZlVXNlckdlc3R1cmUgPSB3YXNHcmFudGVkID09 IFN0b3JhZ2VBY2Nlc3NXYXNHcmFudGVkOjpZZXMgfHwgcHJvbXB0V2FzU2hvd24gPT0gU3RvcmFn ZUFjY2Vzc1Byb21wdFdhc1Nob3duOjpObzsKIAogICAgICAgICBpZiAoc2hvdWxkUHJlc2VydmVV c2VyR2VzdHVyZSkgewotICAgICAgICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1ZU1p Y3JvdGFzayhbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyldIHsKKyAgICAgICAg ICAgIG1fZG9jdW1lbnQuZXZlbnRMb29wKCkucXVldWVNaWNyb3Rhc2soW3RoaXMsIHdlYWtUaGlz ID0gV1RGTW92ZSh3ZWFrVGhpcyldIHsKICAgICAgICAgICAgICAgICBpZiAod2Vha1RoaXMpCiAg ICAgICAgICAgICAgICAgICAgIGVuYWJsZVRlbXBvcmFyeVRpbWVVc2VyR2VzdHVyZSgpOwogICAg ICAgICAgICAgfSk7CkBAIC0xOTcsNyArMTk3LDcgQEAgdm9pZCBEb2N1bWVudFN0b3JhZ2VBY2Nl c3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKFJlZjxEZWZlcnJlZFByb21pc2U+JiYgcHJvbWlzZSkK ICAgICAgICAgfQogCiAgICAgICAgIGlmIChzaG91bGRQcmVzZXJ2ZVVzZXJHZXN0dXJlKSB7Ci0g ICAgICAgICAgICBtX2RvY3VtZW50LmV2ZW50TG9vcCgpLnF1ZXVlTWljcm90YXNrKFt0aGlzLCB3 ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0geworICAgICAgICAgICAgbV9kb2N1bWVudC5l dmVudExvb3AoKS5xdWV1ZU1pY3JvdGFzayhbdGhpcywgd2Vha1RoaXMgPSBXVEZNb3ZlKHdlYWtU aGlzKV0gewogICAgICAgICAgICAgICAgIGlmICh3ZWFrVGhpcykKICAgICAgICAgICAgICAgICAg ICAgY29uc3VtZVRlbXBvcmFyeVRpbWVVc2VyR2VzdHVyZSgpOwogICAgICAgICAgICAgfSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc01TVkMuY21ha2UKaW5kZXggMmFiMjNlNGZiMzc1Li45ZjJkNzU1MDM4YzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc01TVkMuY21ha2UKQEAgLTI5LDExICsyOSw2IEBAIGVuZGlmICgpCiAjIFNwZWNpZnkg dGhlIHNvdXJjZSBjb2RlIGVuY29kaW5nCiBhZGRfY29tcGlsZV9vcHRpb25zKC91dGYtOCAvdmFs aWRhdGUtY2hhcnNldCkKIAotIyBFbmFibGUgdGhlIG5ldyBsYW1iZGEgcHJvY2Vzc29yIGZvciBi ZXR0ZXIgQysrIGNvbmZvcm1hbmNlIHdpdGggL3N0ZDpjKysxNwotaWYgKE5PVCBDT01QSUxFUl9J U19DTEFOR19DTCkKLSAgICBhZGRfY29tcGlsZV9vcHRpb25zKC9leHBlcmltZW50YWw6bmV3TGFt YmRhUHJvY2Vzc29yKQotZW5kaWYgKCkKLQogaWYgKCR7Q01BS0VfQlVJTERfVFlQRX0gTUFUQ0hF UyAiRGVidWciKQogICAgIHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NI QVJFRF9MSU5LRVJfRkxBR1N9IC9PUFQ6Tk9SRUYgL09QVDpOT0lDRiIpCiAgICAgc2V0KENNQUtF X0VYRV9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30gL09QVDpOT1JFRiAv T1BUOk5PSUNGIikK 394390 2020-03-24 11:57:26 -0700 2020-03-26 20:00:10 -0700 Patch bug-209358.diff text/plain 3385 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGNmMTk2ZTVlYjMuLjBm NTY0YjBlNWU4NiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAzLTIwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgW01TVkNdIFJlbW92ZSBleHBlcmltZW50YWwgbGFtYmRhIHByb2Nlc3Nv ciB1c2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA5MzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIC9leHBlcmltZW50YWw6bmV3TGFtYmRhUHJvY2Vzc29yIHNpbmNlIFdlYktpdCBpcyBu byBsb25nZXIgYWJsZSB0byBidWlsZAorICAgICAgICB3aXRoIHRoaXMgc2V0dGluZyBhcyBvZiBW aXN1YWwgU3R1ZGlvIDE2LjUuMC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zTVNW Qy5jbWFrZToKKwogMjAyMC0wMy0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgUkVMRUFTRV9MT0cgc2hvdWxkIG5vdCBiZSBDb2NvYSBzcGVjaWZp YwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGRmMTkwY2Y0MGYyMy4uM2ZhMjM5NTdhOTI2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMjAgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBz b255LmNvbT4KKworICAgICAgICBbTVNWQ10gUmVtb3ZlIGV4cGVyaW1lbnRhbCBsYW1iZGEgcHJv Y2Vzc29yIHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDkzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggYnVpbGQgZm9yIFZpc3VhbCBTdHVkaW8gc2NvcGluZyBpc3N1ZSBmb3IgbGFtYmRh cy4gVGhlIGV4cGVyaW1lbnRhbCBsYW1iYWRhCisgICAgICAgIHByb2Nlc3NvciBkaWQgYnVpbGQg dGhpcyBjb2RlIGJ1dCBpcyBub3cgZmFpbGluZyB0byBidWlsZCBXZWJLaXQgYXQgYWxsLgorCisg ICAgICAgICogZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdlQWNjZXNzKToKKwogMjAyMC0w My0yMCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gQXZvaWQgaW5maW5pdGUgbG9vcCB3aGVuIHN0dWNrIG9uIHBhcnRpYWwgY29udGVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRTdG9yYWdlQWNjZXNzLmNwcAppbmRleCBiZTY5NDRk NjM4Y2IuLjBmNTJkNjAxZTYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50U3RvcmFnZUFjY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3Rv cmFnZUFjY2Vzcy5jcHAKQEAgLTE4Miw3ICsxODIsNyBAQCB2b2lkIERvY3VtZW50U3RvcmFnZUFj Y2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUmVmPERlZmVycmVkUHJvbWlzZT4mJiBwcm9taXNl KQogICAgICAgICBib29sIHNob3VsZFByZXNlcnZlVXNlckdlc3R1cmUgPSB3YXNHcmFudGVkID09 IFN0b3JhZ2VBY2Nlc3NXYXNHcmFudGVkOjpZZXMgfHwgcHJvbXB0V2FzU2hvd24gPT0gU3RvcmFn ZUFjY2Vzc1Byb21wdFdhc1Nob3duOjpObzsKIAogICAgICAgICBpZiAoc2hvdWxkUHJlc2VydmVV c2VyR2VzdHVyZSkgewotICAgICAgICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1ZU1p Y3JvdGFzayhbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyldIHsKKyAgICAgICAg ICAgIG1fZG9jdW1lbnQuZXZlbnRMb29wKCkucXVldWVNaWNyb3Rhc2soW3RoaXMsIHdlYWtUaGlz ID0gbWFrZVdlYWtQdHIoKndlYWtUaGlzKV0gewogICAgICAgICAgICAgICAgIGlmICh3ZWFrVGhp cykKICAgICAgICAgICAgICAgICAgICAgZW5hYmxlVGVtcG9yYXJ5VGltZVVzZXJHZXN0dXJlKCk7 CiAgICAgICAgICAgICB9KTsKQEAgLTE5Nyw3ICsxOTcsNyBAQCB2b2lkIERvY3VtZW50U3RvcmFn ZUFjY2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUmVmPERlZmVycmVkUHJvbWlzZT4mJiBwcm9t aXNlKQogICAgICAgICB9CiAKICAgICAgICAgaWYgKHNob3VsZFByZXNlcnZlVXNlckdlc3R1cmUp IHsKLSAgICAgICAgICAgIG1fZG9jdW1lbnQuZXZlbnRMb29wKCkucXVldWVNaWNyb3Rhc2soW3Ro aXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXSB7CisgICAgICAgICAgICBtX2RvY3Vt ZW50LmV2ZW50TG9vcCgpLnF1ZXVlTWljcm90YXNrKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFr UHRyKCp3ZWFrVGhpcyldIHsKICAgICAgICAgICAgICAgICBpZiAod2Vha1RoaXMpCiAgICAgICAg ICAgICAgICAgICAgIGNvbnN1bWVUZW1wb3JhcnlUaW1lVXNlckdlc3R1cmUoKTsKICAgICAgICAg ICAgIH0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlIGIvU291 cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlCmluZGV4IDJhYjIzZTRmYjM3NS4uOWYyZDc1NTAz OGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKKysrIGIvU291 cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlCkBAIC0yOSwxMSArMjksNiBAQCBlbmRpZiAoKQog IyBTcGVjaWZ5IHRoZSBzb3VyY2UgY29kZSBlbmNvZGluZwogYWRkX2NvbXBpbGVfb3B0aW9ucygv dXRmLTggL3ZhbGlkYXRlLWNoYXJzZXQpCiAKLSMgRW5hYmxlIHRoZSBuZXcgbGFtYmRhIHByb2Nl c3NvciBmb3IgYmV0dGVyIEMrKyBjb25mb3JtYW5jZSB3aXRoIC9zdGQ6YysrMTcKLWlmIChOT1Qg Q09NUElMRVJfSVNfQ0xBTkdfQ0wpCi0gICAgYWRkX2NvbXBpbGVfb3B0aW9ucygvZXhwZXJpbWVu dGFsOm5ld0xhbWJkYVByb2Nlc3NvcikKLWVuZGlmICgpCi0KIGlmICgke0NNQUtFX0JVSUxEX1RZ UEV9IE1BVENIRVMgIkRlYnVnIikKICAgICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAi JHtDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTfSAvT1BUOk5PUkVGIC9PUFQ6Tk9JQ0YiKQogICAg IHNldChDTUFLRV9FWEVfTElOS0VSX0ZMQUdTICIke0NNQUtFX0VYRV9MSU5LRVJfRkxBR1N9IC9P UFQ6Tk9SRUYgL09QVDpOT0lDRiIpCg== 394697 2020-03-26 20:00:26 -0700 2020-03-26 21:31:08 -0700 Patch bug-209358-20200327120025.patch text/plain 3612 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk4NjI4ZjU0MTEyMjc1 OGFmOWY4ZWIyY2Q3Yjg0N2YyNTAwNDdjNS4uZDBhMDczN2JhMzg2YzJjNTE1MDM5MjU2M2U5Njdk NmU1ZTlkY2E4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTI2ICBEb24g T2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIFJlbW92 ZSBleHBlcmltZW50YWwgbGFtYmRhIHByb2Nlc3NvciB1c2FnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzU4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIGZvciBWaXN1YWwgU3R1ZGlv IHNjb3BpbmcgaXNzdWUgZm9yIGxhbWJkYXMuIFRoZSBleHBlcmltZW50YWwgbGFtYmFkYQorICAg ICAgICBwcm9jZXNzb3IgZGlkIGJ1aWxkIHRoaXMgY29kZSBidXQgaXMgbm93IGZhaWxpbmcgdG8g YnVpbGQgV2ViS2l0IGF0IGFsbC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudFN0b3JhZ2VBY2Nl c3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRTdG9yYWdlQWNjZXNzOjpyZXF1ZXN0 U3RvcmFnZUFjY2Vzcyk6CisKIDIwMjAtMDMtMjYgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxl LmNvbT4KIAogICAgICAgICBTd2lwZSBkb3duIGdlc3R1cmVzIGNhdXNlIHRoZSB2aWRlbyBsYXll ciB0byBzdGljayBmb3IgYSBtb21lbnQgYmVmb3JlIGJvdW5jaW5nIGJhY2sgaW50byBwbGFjZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3RvcmFnZUFjY2Vzcy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRTdG9yYWdlQWNjZXNzLmNwcAppbmRleCBiZTY5 NDRkNjM4Y2JhMmYwNmQ1ZWZkYjNlMTlmNjllYjE2NGQ5NzNkLi44MGE0ZGI3ODg2NjEzYTU3NzY0 MmZmMTNiMTc1YzJlMjVmY2NlOTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnRTdG9yYWdlQWNjZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRT dG9yYWdlQWNjZXNzLmNwcApAQCAtMTgyLDcgKzE4Miw3IEBAIHZvaWQgRG9jdW1lbnRTdG9yYWdl QWNjZXNzOjpyZXF1ZXN0U3RvcmFnZUFjY2VzcyhSZWY8RGVmZXJyZWRQcm9taXNlPiYmIHByb21p c2UpCiAgICAgICAgIGJvb2wgc2hvdWxkUHJlc2VydmVVc2VyR2VzdHVyZSA9IHdhc0dyYW50ZWQg PT0gU3RvcmFnZUFjY2Vzc1dhc0dyYW50ZWQ6OlllcyB8fCBwcm9tcHRXYXNTaG93biA9PSBTdG9y YWdlQWNjZXNzUHJvbXB0V2FzU2hvd246Ok5vOwogCiAgICAgICAgIGlmIChzaG91bGRQcmVzZXJ2 ZVVzZXJHZXN0dXJlKSB7Ci0gICAgICAgICAgICBtX2RvY3VtZW50LmV2ZW50TG9vcCgpLnF1ZXVl TWljcm90YXNrKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0geworICAgICAg ICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1ZU1pY3JvdGFzayhbdGhpcywgd2Vha1Ro aXNdIHsKICAgICAgICAgICAgICAgICBpZiAod2Vha1RoaXMpCiAgICAgICAgICAgICAgICAgICAg IGVuYWJsZVRlbXBvcmFyeVRpbWVVc2VyR2VzdHVyZSgpOwogICAgICAgICAgICAgfSk7CkBAIC0x OTcsNyArMTk3LDcgQEAgdm9pZCBEb2N1bWVudFN0b3JhZ2VBY2Nlc3M6OnJlcXVlc3RTdG9yYWdl QWNjZXNzKFJlZjxEZWZlcnJlZFByb21pc2U+JiYgcHJvbWlzZSkKICAgICAgICAgfQogCiAgICAg ICAgIGlmIChzaG91bGRQcmVzZXJ2ZVVzZXJHZXN0dXJlKSB7Ci0gICAgICAgICAgICBtX2RvY3Vt ZW50LmV2ZW50TG9vcCgpLnF1ZXVlTWljcm90YXNrKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFr UHRyKCp0aGlzKV0geworICAgICAgICAgICAgbV9kb2N1bWVudC5ldmVudExvb3AoKS5xdWV1ZU1p Y3JvdGFzayhbdGhpcywgd2Vha1RoaXNdIHsKICAgICAgICAgICAgICAgICBpZiAod2Vha1RoaXMp CiAgICAgICAgICAgICAgICAgICAgIGNvbnN1bWVUZW1wb3JhcnlUaW1lVXNlckdlc3R1cmUoKTsK ICAgICAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNt YWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlCmluZGV4IDJhYjIzZTRmYjM3NTdh ZjJlMjc1MTlhYjc3MTljYzk5N2VlYWQxNGYuLjlmMmQ3NTUwMzhjNGM0NjAyYTA5MWFkNGIxYjdh MzJkZmU4NWM5YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQor KysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKQEAgLTI5LDExICsyOSw2IEBAIGVu ZGlmICgpCiAjIFNwZWNpZnkgdGhlIHNvdXJjZSBjb2RlIGVuY29kaW5nCiBhZGRfY29tcGlsZV9v cHRpb25zKC91dGYtOCAvdmFsaWRhdGUtY2hhcnNldCkKIAotIyBFbmFibGUgdGhlIG5ldyBsYW1i ZGEgcHJvY2Vzc29yIGZvciBiZXR0ZXIgQysrIGNvbmZvcm1hbmNlIHdpdGggL3N0ZDpjKysxNwot aWYgKE5PVCBDT01QSUxFUl9JU19DTEFOR19DTCkKLSAgICBhZGRfY29tcGlsZV9vcHRpb25zKC9l eHBlcmltZW50YWw6bmV3TGFtYmRhUHJvY2Vzc29yKQotZW5kaWYgKCkKLQogaWYgKCR7Q01BS0Vf QlVJTERfVFlQRX0gTUFUQ0hFUyAiRGVidWciKQogICAgIHNldChDTUFLRV9TSEFSRURfTElOS0VS X0ZMQUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1N9IC9PUFQ6Tk9SRUYgL09QVDpOT0lD RiIpCiAgICAgc2V0KENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9G TEFHU30gL09QVDpOT1JFRiAvT1BUOk5PSUNGIikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCBkZjIxNTdhYmYzN2VmZDgwMDg3MDA4ZjhiM2U1MmI0M2Y4NzI5Zjc4Li4z ZGEzODM1MzZlMWFjYWFhYjJiNDgzY2E0MWU2ZWMxM2U4OWIzMDhkIDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMjYgIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAgICBbTVNWQ10gUmVtb3Zl IGV4cGVyaW1lbnRhbCBsYW1iZGEgcHJvY2Vzc29yIHVzYWdlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzNTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgL2V4cGVyaW1lbnRhbDpuZXdMYW1i ZGFQcm9jZXNzb3Igc2luY2UgV2ViS2l0IGlzIG5vIGxvbmdlciBhYmxlIHRvIGJ1aWxkCisgICAg ICAgIHdpdGggdGhpcyBzZXR0aW5nIGFzIG9mIFZpc3VhbCBTdHVkaW8gMTYuNS4wLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNNU1ZDLmNtYWtlOgorCiAyMDIwLTAzLTI2ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI1OTAzNS4K