209281 2020-03-19 08:15:38 -0700 [ iOS wk2 and Mac wk2 ] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html is flaky failing. 2020-05-11 00:40:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac macOS 10.14 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204147 InRadar P2 Normal --- 1 Lawrence.j rbuis darin rbuis webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1631654 0 Lawrence.j 2020-03-19 08:15:38 -0700 imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html Description: This test is flaky failing on Mac wk2 and iOS wk2. The flaky failures are visible since the introduction of the test. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fstale-while-revalidate%2Fframe-removal.html&limit=50000 Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal-actual.txt @@ -1,4 +1,4 @@ -PASS Frame removal should cancel its revalidations +FAIL Frame removal should cancel its revalidations assert_equals: expected "2" but got "1" 1631655 1 webkit-bug-importer 2020-03-19 08:16:22 -0700 <rdar://problem/60634122> 1631659 2 Lawrence.j 2020-03-19 08:29:58 -0700 I can reproduce this issue with r258694 using the command below. run-webkit-tests --iterations 1400 --exit-after-n-failures 3 --force -f --no-retry imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html [12/1400] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html failed unexpectedly (text diff) [32/1400] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html failed unexpectedly (text diff) [63/1400] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html failed unexpectedly (text diff) Exiting early after 3 failures. 60 tests run. 57 tests ran as expected, 3 didn't (1340 didn't run): 1631696 3 Lawrence.j 2020-03-19 09:51:16 -0700 I have marked this test as failing while this issue is investigated. https://trac.webkit.org/changeset/258703/webkit 1645135 4 rbuis 2020-04-24 02:34:40 -0700 This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=210905. 1645136 5 rbuis 2020-04-24 02:35:02 -0700 Oops, closing wrong bug. 1649163 6 398499 rbuis 2020-05-05 05:43:40 -0700 Created attachment 398499 Patch 1651008 7 398499 darin 2020-05-09 17:13:12 -0700 Comment on attachment 398499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398499&action=review > LayoutTests/imported/w3c/ChangeLog:15 > + * web-platform-tests/fetch/stale-while-revalidate/frame-removal.html: > + * web-platform-tests/fetch/stale-while-revalidate/resources/stale-frame.py: > + (main): Will this change get upstreamed? 1651064 8 ews-feeder 2020-05-10 00:26:20 -0700 Committed r261455: <https://trac.webkit.org/changeset/261455> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398499. 1651201 9 398499 rbuis 2020-05-11 00:40:48 -0700 Comment on attachment 398499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398499&action=review >> LayoutTests/imported/w3c/ChangeLog:15 >> + (main): > > Will this change get upstreamed? I would like to, but Google has some problems with the test related to the chrome implementation, see https://github.com/web-platform-tests/wpt/pull/22292. I'll try to follow the hints in that issue to see if we can get to a test that works for multiple implementations. 398499 2020-05-05 05:43:40 -0700 2020-05-10 00:26:21 -0700 Patch bug-209281-20200505144338.patch text/plain 4092 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDg2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCAwYTc1ZTU5NGI3ZGY1YjdmZGMwZmM2MTg4MzliNTliYjFjM2QxNjY5Li5kMjcxNzQ0MjQ4 MjVmYTRkN2Y0NTg2YTgwYTBhYmViZjAxNDUzNGI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wNS0wNSAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2Fs aWEuY29tPgorCisgICAgICAgIFsgaU9TIHdrMiBhbmQgTWFjIHdrMiBdIGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvc3RhbGUtd2hpbGUtcmV2YWxpZGF0ZS9mcmFtZS1yZW1v dmFsLmh0bWwgaXMgZmxha3kgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwOTI4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNpbmNlIGl0IGlzIGRpZmZpY3VsdCB0byBlc3RpbWF0ZSB3aGVu IHRoZSByZXZhbGlkYXRpb25zIGFyZSByZWNlaXZlZAorICAgICAgICBpbiByZWxhdGlvbiB0byB0 aGUgZnJhbWUgbG9hZHMsIGFkZCB0d28gcG9sbGluZyBsb29wcyB0byBtYWtlIHN1cmUKKyAgICAg ICAgcmV2YWxpZGF0aW9ucyBoYXZlIGJlZW4gcmVjZWl2ZWQgYmVmb3JlIHByb2NlZGluZyB3aXRo IHRoZSBuZXh0CisgICAgICAgIHRlc3Qgc3RlcC4gVGhpcyBpcyBzaW1pbGFyIHRvIHdoYXQgZmV0 Y2guaHRtbCBkb2VzLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL3N0YWxl LXdoaWxlLXJldmFsaWRhdGUvZnJhbWUtcmVtb3ZhbC5odG1sOgorICAgICAgICAqIHdlYi1wbGF0 Zm9ybS10ZXN0cy9mZXRjaC9zdGFsZS13aGlsZS1yZXZhbGlkYXRlL3Jlc291cmNlcy9zdGFsZS1m cmFtZS5weToKKyAgICAgICAgKG1haW4pOgorCiAyMDIwLTA1LTA0ICBFbWlsaW8gQ29ib3Mgw4Fs dmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgogCiAgICAgICAgIFB1dCBsaCAvIHJsaCB1bml0cyBi ZWhpbmQgYSBmbGFnIHVudGlsIGJ1ZyAyMTEzNTEgaXMgc29ydGVkIG91dC4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvc3RhbGUt d2hpbGUtcmV2YWxpZGF0ZS9mcmFtZS1yZW1vdmFsLmh0bWwgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL3N0YWxlLXdoaWxlLXJldmFsaWRhdGUvZnJh bWUtcmVtb3ZhbC5odG1sCmluZGV4IGFlNWYzNGVmODFmZDA1NGQxODYyOTk1YThjYmMzN2FhNTEw ZjI3Y2MuLjdhNDBlYWY0ODkwNzQ4MWU1OTNiN2YzM2NkZTIxNmIzM2M1N2Y2Y2IgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvc3Rh bGUtd2hpbGUtcmV2YWxpZGF0ZS9mcmFtZS1yZW1vdmFsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9zdGFsZS13aGlsZS1yZXZhbGlk YXRlL2ZyYW1lLXJlbW92YWwuaHRtbApAQCAtNiw2ICs2LDE0IEBACiA8c2NyaXB0IHNyYz0iL2Nv bW1vbi91dGlscy5qcyI+PC9zY3JpcHQ+CiA8Ym9keT4KIDxzY3JpcHQ+CitmdW5jdGlvbiB3YWl0 MjVtcyh0ZXN0KSB7CisgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHsKKyAgICB0ZXN0 LnN0ZXBfdGltZW91dCgoKSA9PiB7CisgICAgICByZXNvbHZlKCk7CisgICAgfSwgMjUpOworICB9 KTsKK30KKwogYXN5bmNfdGVzdChmdW5jdGlvbih0KSB7CiAgIHZhciByZXF1ZXN0X3Rva2VuID0g dG9rZW4oKTsKICAgY29uc3QgdXJsID0gYHJlc291cmNlcy9zdGFsZS1mcmFtZS5weT90b2tlbj1g ICsgcmVxdWVzdF90b2tlbgpAQCAtMTcsMTcgKzI1LDI1IEBAIGFzeW5jX3Rlc3QoZnVuY3Rpb24o dCkgewogICAgIC8vIHNlY29uZCBmcmFtZSBsb2FkLCB0cmlnZ2VycyByZXZhbGlkYXRpb24KICAg ICBsZXQgZnJhbWUyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CiAgICAgZnJh bWUyLnNyYyA9IHVybDsKLSAgICBmcmFtZTIub25sb2FkID0gKCkgPT4geworICAgIGZyYW1lMi5v bmxvYWQgPSBhc3luYyAoKSA9PiB7CisgICAgICB3aGlsZSAodHJ1ZSkgeworICAgICAgICBjb25z dCByZXZhbGlkYXRpb25fY2hlY2sgPSBhd2FpdCBmZXRjaChgcmVzb3VyY2VzL3N0YWxlLWZyYW1l LnB5P3F1ZXJ5JnRva2VuPWAgKyByZXF1ZXN0X3Rva2VuKTsKKyAgICAgICAgaWYgKHJldmFsaWRh dGlvbl9jaGVjay5oZWFkZXJzLmdldCgnQ291bnQnKSA9PSAnMScpCisgICAgICAgICAgYnJlYWs7 CisgICAgICAgIGF3YWl0IHdhaXQyNW1zKHQpOworICAgICAgfQogICAgICAgLy8gcmVtb3ZlIGZy YW1lLCBjYW5jZWxpbmcgcmV2YWxpZGF0aW9uCiAgICAgICBmcmFtZTIucmVtb3ZlKCk7CiAgICAg ICAvLyB0aGlyZCBmcmFtZSBsb2FkLCB0cmlnZ2VycyBuZXcgcmV2YWxpZGF0aW9uCiAgICAgICBs ZXQgZnJhbWUzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CiAgICAgICBmcmFt ZTMuc3JjID0gdXJsOwotICAgICAgZnJhbWUzLm9ubG9hZCA9ICgpID0+IHsKLSAgICAgICAgZmV0 Y2goInJlc291cmNlcy9zdGFsZS1mcmFtZS5weT9xdWVyeSZ0b2tlbj0iICsgcmVxdWVzdF90b2tl bikudGhlbih0LnN0ZXBfZnVuYygocmVzcG9uc2UpID0+IHsKLSAgICAgICAgICBhc3NlcnRfZXF1 YWxzKHJlc3BvbnNlLmhlYWRlcnMuZ2V0KCJDb3VudCIpLCAnMicpOwotICAgICAgICAgIHQuZG9u ZSgpOwotICAgICAgICB9KSk7CisgICAgICBmcmFtZTMub25sb2FkID0gYXN5bmMgKCkgPT4gewor ICAgICAgICB3aGlsZSAodHJ1ZSkgeworICAgICAgICAgIGNvbnN0IHJldmFsaWRhdGlvbl9jaGVj ayA9IGF3YWl0IGZldGNoKGByZXNvdXJjZXMvc3RhbGUtZnJhbWUucHk/cXVlcnkmdG9rZW49YCAr IHJlcXVlc3RfdG9rZW4pOworICAgICAgICAgIGlmIChyZXZhbGlkYXRpb25fY2hlY2suaGVhZGVy cy5nZXQoJ0NvdW50JykgPT0gJzInKQorICAgICAgICAgICAgdC5kb25lKCk7CisgICAgICAgICAg YXdhaXQgd2FpdDI1bXModCk7CisgICAgICAgIH0KICAgICAgIH0KICAgICAgIGRvY3VtZW50LmJv ZHkuYXBwZW5kQ2hpbGQoZnJhbWUzKTsKICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL3N0YWxlLXdoaWxlLXJldmFsaWRh dGUvcmVzb3VyY2VzL3N0YWxlLWZyYW1lLnB5IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9zdGFsZS13aGlsZS1yZXZhbGlkYXRlL3Jlc291cmNlcy9z dGFsZS1mcmFtZS5weQppbmRleCA3MWI4MTBmMWNmZTNkNmQ4M2M3YWViYzE1NGViNWFmOTM1ODVm YzUyLi45OWE1OWZhZTg3MmE0NjBjMGFlYzkyNzE4ZjQzOWFhOWZkYjdkNWFjIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL3N0YWxl LXdoaWxlLXJldmFsaWRhdGUvcmVzb3VyY2VzL3N0YWxlLWZyYW1lLnB5CisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvc3RhbGUtd2hpbGUtcmV2 YWxpZGF0ZS9yZXNvdXJjZXMvc3RhbGUtZnJhbWUucHkKQEAgLTIxLDkgKzIxLDYgQEAgZGVmIG1h aW4ocmVxdWVzdCwgcmVzcG9uc2UpOgogICAgICAgICAgIGNvdW50ID0gY291bnQgKyAxCiAgICAg ICAgIHJlcXVlc3Quc2VydmVyLnN0YXNoLnB1dCh0b2tlbiwgY291bnQpCiAKLSAgICBpZiBpc19y ZXZhbGlkYXRpb24gaXMgbm90IE5vbmU6Ci0gICAgICB0aW1lLnNsZWVwKDUpOwotCiAgICAgaWYg aXNfcXVlcnk6CiAgICAgICBoZWFkZXJzID0gWygiQ291bnQiLCBjb3VudCksICgiVGVzdCIsIHN0 cihyZXF1ZXN0LnJhd19oZWFkZXJzKSldCiAgICAgICBjb250ZW50ID0gIiIK