209227 2020-03-18 07:36:13 -0700 [ews] commit-queue should comment on bug in case patch fails to build 2020-03-18 08:36:50 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209226 InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1631120 0 aakash_jain 2020-03-18 07:36:13 -0700 commit-queue should comment on bug and set cq- flag in case patch fails to build. 1631121 1 393852 aakash_jain 2020-03-18 07:37:14 -0700 Created attachment 393852 Patch 1631122 2 aakash_jain 2020-03-18 07:37:46 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1598 1631160 3 aakash_jain 2020-03-18 08:35:08 -0700 Committed r258637: <https://trac.webkit.org/changeset/258637> 1631162 4 webkit-bug-importer 2020-03-18 08:36:50 -0700 <rdar://problem/60585344> 393852 2020-03-18 07:37:14 -0700 2020-03-18 08:05:12 -0700 Patch bug-209227-20200318103713.patch text/plain 3516 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODYzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAzLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIGNvbW1lbnQgb24gYnVnIGlu IGNhc2UgcGF0Y2ggZmFpbHMgdG8gYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwOTIyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5 OgorICAgICAgICAoQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzLnN0YXJ0KToKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IEFkZGVkIHVu aXQtdGVzdC4KKwogMjAyMC0wMy0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBNaWdyYXRlIHRvIEZsYXRwYWstYmFzZWQgZGV2 IFNESwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQko cmV2aXNpb24gMjU4NjMwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzMyLDkgKzEzMzIsMTUgQEAgY2xhc3MgQW5hbHl6 ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKGJ1aWxkcwogCiAgICAgICAgIHNlbGYuZmluaXNoZWQoRkFJ TFVSRSkKICAgICAgICAgc2VsZi5idWlsZC5yZXN1bHRzID0gRkFJTFVSRQotICAgICAgICBtZXNz YWdlID0gJ1BhdGNoIGRvZXMgbm90IGJ1aWxkJworICAgICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0 UHJvcGVydHkoJ3BhdGNoX2lkJywgJycpCisgICAgICAgIG1lc3NhZ2UgPSAnUGF0Y2gge30gZG9l cyBub3QgYnVpbGQnLmZvcm1hdChwYXRjaF9pZCkKICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRv bmUgPSBtZXNzYWdlCi0gICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0s IEZBSUxVUkUpCisgICAgICAgIGlmIHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJycp Lmxvd2VyKCkgPT0gJ2NvbW1pdC1xdWV1ZSc6CisgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCdidWd6aWxsYV9jb21tZW50X3RleHQnLCBtZXNzYWdlKQorICAgICAgICAgICAgc2VsZi5zZXRQ cm9wZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknLCBtZXNzYWdlKQorICAgICAgICAgICAgc2Vs Zi5idWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0NvbW1lbnRPbkJ1ZygpLCBTZXRDb21t aXRRdWV1ZU1pbnVzRmxhZ09uUGF0Y2goKV0pCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBz ZWxmLmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21lc3NhZ2VdLCBGQUlMVVJFKQogCiAgICAgICAgIHJl dHVybiBkZWZlci5zdWNjZWVkKE5vbmUpCiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1ODYzMCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtMTA2MSw4ICsxMDYxLDI2IEBAIGNsYXNzIFRlc3RBbmFseXplQ29t cGlsZVdlYktpdFJlc3VsdHMoQnUKICAgICAgICAgICAgIG1vY2tfc3RlcChDb21waWxlV2ViS2l0 VG9UKCksIHJlc3VsdHM9U1VDQ0VTUyksCiAgICAgICAgIF0KICAgICAgICAgc2VsZi5zZXR1cFN0 ZXAoQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKCksIHByZXZpb3VzX3N0ZXBzPXByZXZpb3Vz X3N0ZXBzKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRl X3N0cmluZz0nUGF0Y2ggZG9lcyBub3QgYnVpbGQgKGZhaWx1cmUpJykKLSAgICAgICAgcmV0dXJu IHNlbGYucnVuU3RlcCgpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEy MzQnKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0 cmluZz0nUGF0Y2ggMTIzNCBkb2VzIG5vdCBidWlsZCAoZmFpbHVyZSknKQorICAgICAgICByYyA9 IHNlbGYucnVuU3RlcCgpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0 eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JyksIE5vbmUpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknKSwgTm9uZSkKKyAgICAg ICAgcmV0dXJuIHJjCisKKyAgICBkZWYgdGVzdF9wYXRjaF93aXRoX2J1aWxkX2ZhaWx1cmVfb25f Y29tbWl0X3F1ZXVlKHNlbGYpOgorICAgICAgICBwcmV2aW91c19zdGVwcyA9IFsKKyAgICAgICAg ICAgIG1vY2tfc3RlcChDb21waWxlV2ViS2l0KCksIHJlc3VsdHM9RkFJTFVSRSksCisgICAgICAg ICAgICBtb2NrX3N0ZXAoQ29tcGlsZVdlYktpdFRvVCgpLCByZXN1bHRzPVNVQ0NFU1MpLAorICAg ICAgICBdCisgICAgICAgIHNlbGYuc2V0dXBTdGVwKEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0 cygpLCBwcmV2aW91c19zdGVwcz1wcmV2aW91c19zdGVwcykKKyAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgncGF0Y2hfaWQnLCAnMTIzNCcpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxk ZXJuYW1lJywgJ2NvbW1pdC1xdWV1ZScpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1 bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSdQYXRjaCAxMjM0IGRvZXMgbm90IGJ1aWxkIChmYWls dXJlKScpCisgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChzZWxmLmdldFByb3BlcnR5KCdidWd6aWxsYV9jb21tZW50X3RleHQnKSwgJ1BhdGNoIDEy MzQgZG9lcyBub3QgYnVpbGQnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJv cGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5JyksICdQYXRjaCAxMjM0IGRvZXMgbm90IGJ1aWxk JykKKyAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9wYXRjaF93aXRoX1RvVF9mYWls dXJlKHNlbGYpOgogICAgICAgICBwcmV2aW91c19zdGVwcyA9IFsK