209226 2020-03-18 06:45:02 -0700 [ews] commit-queue should comment on bug in case of test failures 2020-03-19 15:04:58 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209227 InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1631102 0 aakash_jain 2020-03-18 06:45:02 -0700 [ews] commit-queue should comment on bug and set cq- flag in case of test failures. 1631106 1 393845 aakash_jain 2020-03-18 07:01:03 -0700 Created attachment 393845 Patch 1631118 2 aakash_jain 2020-03-18 07:28:02 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1593 1631204 3 393845 jbedard 2020-03-18 09:45:59 -0700 Comment on attachment 393845 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393845&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1830 > + self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()]) Is this the current behavior? If I recall, this logic doesn't apply to flaky tests, but I can see some circumstances where this behavior is undesirable. 1631252 4 aakash_jain 2020-03-18 11:09:06 -0700 (In reply to Jonathan Bedard from comment #3) > Is this the current behavior? If I recall, this logic doesn't apply to flaky tests. Yes, I think so. The comment and cq- would be when a test failure is confirmed (test consistently failed in first and second run, and passed in clean-tree-run). Test which were found to be flaky during the run would not affect the result. 1631260 5 aakash_jain 2020-03-18 11:15:37 -0700 Committed r258652: <https://trac.webkit.org/changeset/258652> 1631264 6 webkit-bug-importer 2020-03-18 11:16:19 -0700 <rdar://problem/60592347> 1631856 7 aakash_jain 2020-03-19 15:04:58 -0700 This change seems to be working fine. Patch with test failure: https://ews-build.webkit.org/#/builders/28/builds/63 Flaky test: https://ews-build.webkit.org/#/builders/28/builds/66 393845 2020-03-18 07:01:03 -0700 2020-03-18 11:12:36 -0700 Patch bug-209226-20200318100101.patch text/plain 4365 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODYyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAzLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIGNvbW1lbnQgb24gYnVnIGlu IGNhc2Ugb2YgdGVzdCBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA5MjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6Cisg ICAgICAgIChBbmFseXplTGF5b3V0VGVzdHNSZXN1bHRzLnJlcG9ydF9mYWlsdXJlKTogQ29tbWVu dCBvbiBidWcgYW5kIHNldCBjcS0gaW4gY2FzZSBvZiB0ZXN0IGZhaWx1cmUgb24gY29tbWl0LXF1 ZXVlLgorICAgICAgICAoQnVpbGRMb2dMaW5lT2JzZXJ2ZXIub3V0TGluZVJlY2VpdmVkKTogRHJp dmUtYnkgZml4IHRvIHVzZSBzaW5nbGUgcXVvdGVzIGluc3RlYWQgb2YgZG91YmxlIHF1b3Rlcy4K KyAgICAgICAgKFNldEJ1aWxkU3VtbWFyeSk6IERpdHRvLgorICAgICAgICAqIEJ1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weTogQWRkZWQgdW5pdC10ZXN0LgorCiAy MDIwLTAzLTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXVtXUEVdIE1pZ3JhdGUgdG8gRmxhdHBhay1iYXNlZCBkZXYgU0RLCkluZGV4OiBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTg2 MjcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtp bmcgY29weSkKQEAgLTEyMTEsNyArMTIxMSw3IEBAIGNsYXNzIEJ1aWxkTG9nTGluZU9ic2VydmVy KGxvZ29ic2VydmVyLkwKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHNlbGYuZXJyb3JfY29u dGV4dF9idWZmZXIuYXBwZW5kKGxpbmUpCiAKLSAgICAgICAgaWYgInJyb3I6IiBpbiBsaW5lIGFu ZCBzZWxmLmVycm9yUmVjZWl2ZWQ6CisgICAgICAgIGlmICdycm9yOicgaW4gbGluZSBhbmQgc2Vs Zi5lcnJvclJlY2VpdmVkOgogICAgICAgICAgICAgbWFwKHNlbGYuZXJyb3JSZWNlaXZlZCwgc2Vs Zi5lcnJvcl9jb250ZXh0X2J1ZmZlcikKICAgICAgICAgICAgIHNlbGYuZXJyb3JfY29udGV4dF9i dWZmZXIgPSBbXQogCkBAIC0xODIzLDcgKzE4MjMsMTMgQEAgY2xhc3MgQW5hbHl6ZUxheW91dFRl c3RzUmVzdWx0cyhidWlsZHN0ZQogICAgICAgICBuZXdfZmFpbHVyZXNfc3RyaW5nID0gJywgJy5q b2luKFtmYWlsdXJlX25hbWUgZm9yIGZhaWx1cmVfbmFtZSBpbiBuZXdfZmFpbHVyZXNdKQogICAg ICAgICBtZXNzYWdlID0gJ0ZvdW5kIHt9IG5ldyB0ZXN0IGZhaWx1cmV7fToge30nLmZvcm1hdChs ZW4obmV3X2ZhaWx1cmVzKSwgcGx1cmFsU3VmZml4LCBuZXdfZmFpbHVyZXNfc3RyaW5nKQogICAg ICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9IG1lc3NhZ2UKLSAgICAgICAgc2VsZi5idWlsZC5i dWlsZEZpbmlzaGVkKFttZXNzYWdlXSwgRkFJTFVSRSkKKworICAgICAgICBpZiBzZWxmLmdldFBy b3BlcnR5KCdidWlsZGVybmFtZScsICcnKS5sb3dlcigpID09ICdjb21taXQtcXVldWUnOgorICAg ICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JywgbWVzc2Fn ZSkKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5Jywg bWVzc2FnZSkKKyAgICAgICAgICAgIHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVw KFtDb21tZW50T25CdWcoKSwgU2V0Q29tbWl0UXVldWVNaW51c0ZsYWdPblBhdGNoKCldKQorICAg ICAgICBlbHNlOgorICAgICAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFttZXNzYWdl XSwgRkFJTFVSRSkKICAgICAgICAgcmV0dXJuIGRlZmVyLnN1Y2NlZWQoTm9uZSkKIAogICAgIGRl ZiByZXBvcnRfcHJlX2V4aXN0aW5nX2ZhaWx1cmVzKHNlbGYsIGNsZWFuX3RyZWVfZmFpbHVyZXMs IGZsYWt5X2ZhaWx1cmVzKToKQEAgLTI0MTgsNyArMjQyNCw3IEBAIGNsYXNzIEFwcGx5V2F0Y2hM aXN0KHNoZWxsLlNoZWxsQ29tbWFuZCkKIAogCiBjbGFzcyBTZXRCdWlsZFN1bW1hcnkoYnVpbGRz dGVwLkJ1aWxkU3RlcCk6Ci0gICAgbmFtZSA9ICJzZXQtYnVpbGQtc3VtbWFyeSIKKyAgICBuYW1l ID0gJ3NldC1idWlsZC1zdW1tYXJ5JwogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsnU2V0IGJ1aWxk IHN1bW1hcnknXQogICAgIGFsd2F5c1J1biA9IFRydWUKICAgICBoYWx0T25GYWlsdXJlID0gRmFs c2UKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVz dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1ODYyNykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTgwNCwx MCArMTgwNCwyNSBAQCBjbGFzcyBUZXN0QW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhCdWlsCiAK ICAgICBkZWYgdGVzdF9mbGFreV9hbmRfY29uc2lzdGVudF9mYWlsdXJlc193aXRob3V0X2NsZWFu X3RyZWVfZmFpbHVyZXMoc2VsZik6CiAgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcCgpCisgICAg ICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ2lPUy0xMy1TaW11bGF0b3ItV0sy LVRlc3RzLUVXUycpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2ZpcnN0X3J1bl9mYWlsdXJl cycsIFsndGVzdDEnLCAndGVzdDInXSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnc2Vjb25k X3J1bl9mYWlsdXJlcycsIFsndGVzdDEnXSkKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJl c3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0ZvdW5kIDEgbmV3IHRlc3QgZmFpbHVyZTogdGVz dDEgKGZhaWx1cmUpJykKLSAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisgICAgICAgIHJj ID0gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLmdldFByb3Bl cnR5KCdidWd6aWxsYV9jb21tZW50X3RleHQnKSwgTm9uZSkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChzZWxmLmdldFByb3BlcnR5KCdidWlsZF9maW5pc2hfc3VtbWFyeScpLCBOb25lKQorICAg ICAgICByZXR1cm4gcmMKKworICAgIGRlZiB0ZXN0X2NvbnNpc3RlbnRfZmFpbHVyZV93aXRob3V0 X2NsZWFuX3RyZWVfZmFpbHVyZXNfY29tbWl0X3F1ZXVlKHNlbGYpOgorICAgICAgICBzZWxmLmNv bmZpZ3VyZVN0ZXAoKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdD b21taXQtUXVldWUnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmaXJzdF9ydW5fZmFpbHVy ZXMnLCBbJ3Rlc3QxJ10pCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3NlY29uZF9ydW5fZmFp bHVyZXMnLCBbJ3Rlc3QxJ10pCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJ TFVSRSwgc3RhdGVfc3RyaW5nPSdGb3VuZCAxIG5ldyB0ZXN0IGZhaWx1cmU6IHRlc3QxIChmYWls dXJlKScpCisgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChzZWxmLmdldFByb3BlcnR5KCdidWd6aWxsYV9jb21tZW50X3RleHQnKSwgJ0ZvdW5kIDEg bmV3IHRlc3QgZmFpbHVyZTogdGVzdDEnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYu Z2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5JyksICdGb3VuZCAxIG5ldyB0ZXN0IGZh aWx1cmU6IHRlc3QxJykKKyAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9mbGFreV9h bmRfaW5jb25zaXN0ZW50X2ZhaWx1cmVzX3dpdGhvdXRfY2xlYW5fdHJlZV9mYWlsdXJlcyhzZWxm KToKICAgICAgICAgc2VsZi5jb25maWd1cmVTdGVwKCkK