208811 2020-03-09 07:48:14 -0700 Generate commit-queue status bubble from new EWS 2020-03-18 07:44:50 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209215 InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1627748 0 aakash_jain 2020-03-09 07:48:14 -0700 Display commit-queue status bubble from new EWS. 1627749 1 393033 aakash_jain 2020-03-09 07:49:56 -0700 Created attachment 393033 Patch 1627758 2 aakash_jain 2020-03-09 08:08:39 -0700 Sample runs: https://ews.webkit-uat.org/status-bubble/391081/ https://ews.webkit-uat.org/status-bubble/392839/ 1627809 3 393033 jbedard 2020-03-09 09:33:49 -0700 Comment on attachment 393033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 > + for queue in StatusBubble.ALL_QUEUES: This part confuses me a bit because it seems to be the inverse of what we had before. Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. 1627814 4 393033 aakash_jain 2020-03-09 09:41:58 -0700 Comment on attachment 393033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 >> + for queue in StatusBubble.ALL_QUEUES: > > This part confuses me a bit because it seems to be the inverse of what we had before. > > Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well. 1627865 5 393033 jbedard 2020-03-09 11:48:21 -0700 Comment on attachment 393033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review >>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302 >>> + for queue in StatusBubble.ALL_QUEUES: >> >> This part confuses me a bit because it seems to be the inverse of what we had before. >> >> Before, we would iterate through all bubbles if there was a patch and is had NOT been sent to Buildbot, now, we iterate through all the bubble is there is a patch and it HAS been sent to Buildbot. > > Before, if a patch was not sent to buildbot, we would exit early and display submit-to-ews button. If the patch was sent to buildbot, we would generate all it's bubbles. Should be same now as well. I'm sorry, you're right, was mis-reading the code. 1628193 6 ews-feeder 2020-03-10 05:27:25 -0700 Committed r258198: <https://trac.webkit.org/changeset/258198> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393033. 1628194 7 webkit-bug-importer 2020-03-10 05:28:12 -0700 <rdar://problem/60269688> 393033 2020-03-09 07:49:56 -0700 2020-03-10 05:27:25 -0700 Patch bug-208811-20200309104954.patch text/plain 2255 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODEzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAzLTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBHZW5lcmF0ZSBjb21taXQtcXVldWUgc3RhdHVzIGJ1YmJsZSBmcm9tIG5l dyBFV1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5OgorICAg ICAgICAoU3RhdHVzQnViYmxlLl9idWlsZF9idWJibGVzX2Zvcl9wYXRjaCk6CisKIDIwMjAtMDMt MDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdW1dQRV0gU3Vycm91bmRpbmcgdGV4dCBmb3IgaW5wdXQgbWV0aG9kcyBzaG91bGQgbm90 IGJlIGxpbWl0ZWQgdG8gdGhlIGN1cnJlbnQgcGFyYWdyYXBoCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxl LnB5CShyZXZpc2lvbiAyNTgxMzcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5NSwxNiArMjk1 LDI0IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICAgICAgc2hvd19yZXRyeSA9IEZh bHNlCiAgICAgICAgIGJ1YmJsZXMgPSBbXQogCi0gICAgICAgIGlmIG5vdCAocGF0Y2ggYW5kIHBh dGNoLnNlbnRfdG9fYnVpbGRib3QpOgorICAgICAgICBpZiBub3QgcGF0Y2g6CiAgICAgICAgICAg ICByZXR1cm4gKE5vbmUsIHNob3dfc3VibWl0X3RvX2V3cywgZmFpbGVkX3RvX2FwcGx5LCBzaG93 X3JldHJ5KQogCi0gICAgICAgIGZvciBxdWV1ZSBpbiBTdGF0dXNCdWJibGUuQUxMX1FVRVVFUzoK LSAgICAgICAgICAgIGJ1YmJsZSA9IHNlbGYuX2J1aWxkX2J1YmJsZShwYXRjaCwgcXVldWUsIGhp ZGVfaWNvbnMpCi0gICAgICAgICAgICBpZiBidWJibGU6Ci0gICAgICAgICAgICAgICAgc2hvd19z dWJtaXRfdG9fZXdzID0gRmFsc2UKLSAgICAgICAgICAgICAgICBidWJibGVzLmFwcGVuZChidWJi bGUpCi0gICAgICAgICAgICAgICAgaWYgYnViYmxlWydzdGF0ZSddIGluICgnZmFpbCcsICdlcnJv cicpOgotICAgICAgICAgICAgICAgICAgICBzaG93X3JldHJ5ID0gVHJ1ZQorICAgICAgICBpZiBw YXRjaC5zZW50X3RvX2J1aWxkYm90OgorICAgICAgICAgICAgZm9yIHF1ZXVlIGluIFN0YXR1c0J1 YmJsZS5BTExfUVVFVUVTOgorICAgICAgICAgICAgICAgIGJ1YmJsZSA9IHNlbGYuX2J1aWxkX2J1 YmJsZShwYXRjaCwgcXVldWUsIGhpZGVfaWNvbnMpCisgICAgICAgICAgICAgICAgaWYgYnViYmxl OgorICAgICAgICAgICAgICAgICAgICBzaG93X3N1Ym1pdF90b19ld3MgPSBGYWxzZQorICAgICAg ICAgICAgICAgICAgICBidWJibGVzLmFwcGVuZChidWJibGUpCisgICAgICAgICAgICAgICAgICAg IGlmIGJ1YmJsZVsnc3RhdGUnXSBpbiAoJ2ZhaWwnLCAnZXJyb3InKToKKyAgICAgICAgICAgICAg ICAgICAgICAgIHNob3dfcmV0cnkgPSBUcnVlCisKKyAgICAgICAgaWYgcGF0Y2guc2VudF90b19j b21taXRfcXVldWU6CisgICAgICAgICAgICBpZiBub3QgcGF0Y2guc2VudF90b19idWlsZGJvdDoK KyAgICAgICAgICAgICAgICBoaWRlX2ljb25zID0gVHJ1ZQorICAgICAgICAgICAgY3FfYnViYmxl ID0gc2VsZi5fYnVpbGRfYnViYmxlKHBhdGNoLCAnY29tbWl0JywgaGlkZV9pY29ucykKKyAgICAg ICAgICAgIGlmIGNxX2J1YmJsZToKKyAgICAgICAgICAgICAgICBidWJibGVzLmluc2VydCgwLCBj cV9idWJibGUpCiAKICAgICAgICAgcmV0dXJuIChidWJibGVzLCBzaG93X3N1Ym1pdF90b19ld3Ms IGZhaWxlZF90b19hcHBseSwgc2hvd19yZXRyeSkKIAo=