208793 2020-03-08 16:46:55 -0700 Revise In-App Browser Privacy checks to better reflect the meaning of the flag 2020-03-24 12:20:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208818 1 bfulgham bfulgham bfulgham cdumez commit-queue webkit-bug-importer wilander oldest_to_newest 1627615 0 bfulgham 2020-03-08 16:46:55 -0700 The 'isInAppBrowserPrivacyEnabled' seems like a feature, but it's really an internal debugging flag. Revise the use of these calls to make it clearer. 1627616 1 webkit-bug-importer 2020-03-08 16:47:54 -0700 <rdar://problem/60206256> 1627617 2 393000 bfulgham 2020-03-08 16:50:59 -0700 Created attachment 393000 Patch 1627619 3 393000 wilander 2020-03-08 16:56:45 -0700 Comment on attachment 393000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review r=me with one comment. > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1219 > + if (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS) Is there a reason for doing this is two if clauses and not if (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes && (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)) ? You do write a single if clause in the second case below. 1627620 4 bfulgham 2020-03-08 16:59:04 -0700 (In reply to John Wilander from comment #3) > Comment on attachment 393000 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393000&action=review > > r=me with one comment. > > > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1219 > > + if (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS) > > Is there a reason for doing this is two if clauses and not if > (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes && > (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)) ? You > do write a single if clause in the second case below. I probably should have done both identically. 1627640 5 bfulgham 2020-03-08 17:55:21 -0700 Committed r258124: <https://trac.webkit.org/changeset/258124> 1627643 6 commit-queue 2020-03-08 18:03:07 -0700 The commit-queue encountered the following flaky tests while processing attachment 393000: imported/w3c/web-platform-tests/xhr/open-send-open.htm bug 208794 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1633418 7 393000 cdumez 2020-03-24 12:20:09 -0700 Comment on attachment 393000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:3100 > + if (isMainFrame && (m_preferences->isInAppBrowserPrivacyEnabled() || WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2)) { So now this can get enabled even if the pref is disabled? See <rdar://problem/60518694>. 393000 2020-03-08 16:50:59 -0700 2020-03-24 12:20:09 -0700 Patch bug-208793-20200308165058.patch text/plain 3505 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQwZGQ2NDA3ZmRhN2MzMjg1 ZGY1ZjA1OTA4ZjA2MzMwYTRlZmRhYTAuLmRjZjFiODViMDBhZWUxZWNjMmIyMzk5NjE2Njc1MGMz YmUzMWFlOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDMtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aXNlIEluLUFwcCBCcm93 c2VyIFByaXZhY3kgY2hlY2tzIHRvIGJldHRlciByZWZsZWN0IHRoZSBtZWFuaW5nIG9mIHRoZSBm bGFnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg3 OTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwMjA2MjU2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSAnaXNJbkFwcEJyb3dzZXJQcml2YWN5 RW5hYmxlZCcgc2VlbXMgbGlrZSBhIGZlYXR1cmUsIGJ1dCBpdCdzIHJlYWxseSBhbiBpbnRlcm5h bCBkZWJ1Z2dpbmcgZmxhZy4KKworICAgICAgICBSZXZpc2UgdGhlIHVzZSBvZiB0aGVzZSBjYWxs cyB0byBtYWtlIGl0IGNsZWFyZXIuCisKKyAgICAgICAgVGVzdGVkIGJ5IGV4aXN0aW5nIHRlc3Qg Y2FzZXMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNv Y29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpzZXNzaW9uV3Jh cHBlckZvclRhc2spOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJUGFnZUNvbmZpZ3VyYXRp b24uY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OnNldElzTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4pOgor CiAyMDIwLTAzLTA4ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAK ICAgICAgICAgQnVpbGQgRml4IFdhdGNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KaW5kZXggZTU3ODYwNzk0 MzMzZGU0ODdiZmVlM2U4M2VhODQ0NmE0NmI4YzQ5Ni4uNGU1YzcyZmYwYWM1YmMzYjQxOWJiNWU1 N2UwZGJiNzFlZTAxZjliZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAtNjEsNiArNjEsOCBAQAog CiAjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKICNpbmNsdWRlIDxXZWJLaXRBZGRpdGlvbnMv TmV0d29ya1Nlc3Npb25Db2NvYUFkZGl0aW9ucy5oPgorI2Vsc2UKKyNkZWZpbmUgTkVUV09SS19T RVNTSU9OX0NPQ09BX0FERElUSU9OUyBmYWxzZQogI2VuZGlmCiAKICNpbXBvcnQgIkRldmljZU1h bmFnZW1lbnRTb2Z0TGluay5oIgpAQCAtMTIxMyw4ICsxMjE1LDEwIEBAIFNlc3Npb25XcmFwcGVy JiBOZXR3b3JrU2Vzc2lvbkNvY29hOjpzZXNzaW9uV3JhcHBlckZvclRhc2soY29uc3QgV2ViQ29y ZTo6UmVzb3VyCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogI2VuZGlmCiAKLSAgICBp ZiAobV9pc0luQXBwQnJvd3NlclByaXZhY3lFbmFibGVkICYmIGlzTmF2aWdhdGluZ1RvQXBwQm91 bmREb21haW4gPT0gTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW46OlllcykKLSAgICAgICAgcmV0 dXJuIGFwcEJvdW5kU2Vzc2lvbihzdG9yZWRDcmVkZW50aWFsc1BvbGljeSk7CisgICAgaWYgKGlz TmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4gPT0gTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW46 OlllcykgeworICAgICAgICBpZiAobV9pc0luQXBwQnJvd3NlclByaXZhY3lFbmFibGVkIHx8IE5F VFdPUktfU0VTU0lPTl9DT0NPQV9BRERJVElPTlMpCisgICAgICAgICAgICByZXR1cm4gYXBwQm91 bmRTZXNzaW9uKHN0b3JlZENyZWRlbnRpYWxzUG9saWN5KTsKKyAgICB9CiAKICAgICBzd2l0Y2gg KHN0b3JlZENyZWRlbnRpYWxzUG9saWN5KSB7CiAgICAgY2FzZSBXZWJDb3JlOjpTdG9yZWRDcmVk ZW50aWFsc1BvbGljeTo6VXNlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKaW5kZXggNDk0ZTNjN2FmZjdmYTA1ODc4MmQ4NDZiZWJiMTg0Zjc0NmI0ZTZkYy4uMDhjYWI1 YTRmMzVhZTRkYmNkM2M4YmY5NjE1MGZhYTA5NTJkMzBlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0yODAsNiArMjgwLDcgQEAKICNpbmNsdWRlIDxXZWJL aXRBZGRpdGlvbnMvV2ViUGFnZVByb3h5QWRkaXRpb25zLmg+CiAjZWxzZQogI2RlZmluZSBXRUJf UEFHRV9QUk9YWV9BRERJVElPTlNfU0VUSVNOQVZJR0FUSU5HVE9BUFBCT1VORERPTUFJTgorI2Rl ZmluZSBXRUJfUEFHRV9QUk9YWV9BRERJVElPTlNfU0VUSVNOQVZJR0FUSU5HVE9BUFBCT1VORERP TUFJTl8yIGZhbHNlCiAjZW5kaWYKIAogLy8gVGhpcyBjb250cm9scyB3aGF0IHN0cmF0ZWd5IHdl IHVzZSBmb3IgbW91c2Ugd2hlZWwgY29hbGVzY2luZy4KQEAgLTMwOTYsNyArMzA5Nyw3IEBAIHBy aXZhdGU6CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRJc05hdmlnYXRpbmdUb0FwcEJvdW5kRG9t YWluKGJvb2wgaXNNYWluRnJhbWUsIGNvbnN0IFVSTCYgcmVxdWVzdFVSTCwgTmF2aWdhdGluZ1Rv QXBwQm91bmREb21haW4gaXNOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbikKIHsKLSAgICBpZiAo bV9wcmVmZXJlbmNlcy0+aXNJbkFwcEJyb3dzZXJQcml2YWN5RW5hYmxlZCgpICYmIGlzTWFpbkZy YW1lKSB7CisgICAgaWYgKGlzTWFpbkZyYW1lICYmIChtX3ByZWZlcmVuY2VzLT5pc0luQXBwQnJv d3NlclByaXZhY3lFbmFibGVkKCkgfHwgV0VCX1BBR0VfUFJPWFlfQURESVRJT05TX1NFVElTTkFW SUdBVElOR1RPQVBQQk9VTkRET01BSU5fMikpIHsKICAgICAgICAgV0VCX1BBR0VfUFJPWFlfQURE SVRJT05TX1NFVElTTkFWSUdBVElOR1RPQVBQQk9VTkRET01BSU4KICAgICAgICAgaWYgKGlzTmF2 aWdhdGluZ1RvQXBwQm91bmREb21haW4gPT0gTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW46Ok5v KSB7CiAgICAgICAgICAgICBtX2NvbmZpZ3VyYXRpb24tPnNldFdlYlZpZXdDYXRlZ29yeShXZWJW aWV3Q2F0ZWdvcnk6OkluQXBwQnJvd3Nlcik7Cg==