208502 2020-03-02 23:57:25 -0800 Web Inspector: the execution context picker is shown on pages with only one execution context if there are internal execution contexts 2020-03-04 12:48:16 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED https://devinrousso.com/demo/WebKit/stream_of_water.html InRadar P2 Normal --- 206110 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1624969 0 hi 2020-03-02 23:57:25 -0800 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/stream_of_water.html> => the execution context picker is shown with: * Auto - stream_of_water.html ----- * stream_of_water.html This is because the page also has internal execution contexts, which are currently incorrectly counted when determining whether to show the execution context picker (we shouldn't show it if there is only one execution context). For non-engineering builds, internal execution contexts should be ignored. 1624971 1 392252 hi 2020-03-03 00:13:17 -0800 Created attachment 392252 Patch 1625703 2 commit-queue 2020-03-04 12:46:47 -0800 The commit-queue encountered the following flaky tests while processing attachment 392252: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1625704 3 392252 commit-queue 2020-03-04 12:47:29 -0800 Comment on attachment 392252 Patch Clearing flags on attachment: 392252 Committed r257873: <https://trac.webkit.org/changeset/257873> 1625705 4 commit-queue 2020-03-04 12:47:30 -0800 All reviewed patches have been landed. Closing bug. 1625706 5 webkit-bug-importer 2020-03-04 12:48:16 -0800 <rdar://problem/60052184> 392252 2020-03-03 00:13:17 -0800 2020-03-04 12:47:29 -0800 Patch 208502.diff text/plain 2359 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZhNGRjM2VhMzQwLi5jMjk1YWE0ZGFjZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDMtMDMgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRo ZSBleGVjdXRpb24gY29udGV4dCBwaWNrZXIgaXMgc2hvd24gb24gcGFnZXMgd2l0aCBvbmx5IG9u ZSBleGVjdXRpb24gY29udGV4dCBpZiB0aGVyZSBhcmUgaW50ZXJuYWwgZXhlY3V0aW9uIGNvbnRl eHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg1 MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzOgorICAgICAgICAoV0kuUXVpY2tDb25z b2xlLnByb3RvdHlwZS5fdXBkYXRlQWN0aXZlRXhlY3V0aW9uQ29udGV4dERpc3BsYXkpOgorICAg ICAgICAoV0kuUXVpY2tDb25zb2xlLnByb3RvdHlwZS5faGFuZGxlRW5naW5lZXJpbmdTaG93SW50 ZXJuYWxFeGVjdXRpb25Db250ZXh0c1NldHRpbmdDaGFuZ2VkKToKKwogMjAyMC0wMy0wMiAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog SXRlbXMgaW4gdGhlIHRvb2xiYXIgdGFrZSB1cCB0byBtdWNoIHZlcnRpY2FsIHNwYWNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9RdWlja0Nv bnNvbGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9RdWlj a0NvbnNvbGUuanMKaW5kZXggNmJlZTFhMTdhNGUuLjljNjM0NjA0MzIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tDb25z b2xlLmpzCkBAIC0xOTksOSArMTk5LDEzIEBAIFdJLlF1aWNrQ29uc29sZSA9IGNsYXNzIFF1aWNr Q29uc29sZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQog Ci0gICAgICAgIGlmIChXSS5uZXR3b3JrTWFuYWdlci5mcmFtZXMubGVuZ3RoID09PSAxICYmIFdJ Lm5ldHdvcmtNYW5hZ2VyLm1haW5GcmFtZS5leGVjdXRpb25Db250ZXh0TGlzdC5jb250ZXh0cy5s ZW5ndGggPT09IDEgJiYgIVdJLnRhcmdldE1hbmFnZXIud29ya2VyVGFyZ2V0cy5sZW5ndGgpIHsK LSAgICAgICAgICAgIHRvZ2dsZUhpZGRlbih0cnVlKTsKLSAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgaWYgKFdJLm5ldHdvcmtNYW5hZ2VyLmZyYW1lcy5sZW5ndGggPT09IDEgJiYgIVdJLnRh cmdldE1hbmFnZXIud29ya2VyVGFyZ2V0cy5sZW5ndGgpIHsKKyAgICAgICAgICAgIGxldCBtYWlu RnJhbWVDb250ZXh0cyA9IFdJLm5ldHdvcmtNYW5hZ2VyLm1haW5GcmFtZS5leGVjdXRpb25Db250 ZXh0TGlzdC5jb250ZXh0czsKKyAgICAgICAgICAgIGxldCBjb250ZXh0c1RvU2hvdyA9IG1haW5G cmFtZUNvbnRleHRzLmZpbHRlcigoY29udGV4dCkgPT4gY29udGV4dC50eXBlICE9PSBXSS5FeGVj dXRpb25Db250ZXh0LlR5cGUuSW50ZXJuYWwgfHwgV0kuc2V0dGluZ3MuZW5naW5lZXJpbmdTaG93 SW50ZXJuYWxFeGVjdXRpb25Db250ZXh0cy52YWx1ZSk7CisgICAgICAgICAgICBpZiAoY29udGV4 dHNUb1Nob3cubGVuZ3RoIDw9IDEpIHsKKyAgICAgICAgICAgICAgICB0b2dnbGVIaWRkZW4odHJ1 ZSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQogICAgICAgICB9CiAK ICAgICAgICAgY29uc3QgbWF4TGVuZ3RoID0gNDA7CkBAIC0zMzUsNiArMzM5LDggQEAgV0kuUXVp Y2tDb25zb2xlID0gY2xhc3MgUXVpY2tDb25zb2xlIGV4dGVuZHMgV0kuVmlldwogCiAgICAgX2hh bmRsZUVuZ2luZWVyaW5nU2hvd0ludGVybmFsRXhlY3V0aW9uQ29udGV4dHNTZXR0aW5nQ2hhbmdl ZChldmVudCkKICAgICB7CisgICAgICAgIHRoaXMuX3VwZGF0ZUFjdGl2ZUV4ZWN1dGlvbkNvbnRl eHREaXNwbGF5KCk7CisKICAgICAgICAgaWYgKFdJLnJ1bnRpbWVNYW5hZ2VyLmFjdGl2ZUV4ZWN1 dGlvbkNvbnRleHQudHlwZSAhPT0gV0kuRXhlY3V0aW9uQ29udGV4dC5UeXBlLkludGVybmFsKQog ICAgICAgICAgICAgcmV0dXJuOwogCg==