208094 2020-02-22 12:28:07 -0800 Enable lazy image loading by default 2022-03-09 09:02:22 -0800 1 1 1 Unclassified WebKit Images Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230998 https://bugs.webkit.org/show_bug.cgi?id=237660 InRadar P2 Enhancement --- 200764 203557 207901 208119 196698 1 mjs nmouchtaris addyo adieulot bugmail jonlee mjs nicolas nmouchtaris pp.mizdra rik rwlbuis simon.fraser webkit-bug-importer oldest_to_newest 1621892 0 mjs 2020-02-22 12:28:07 -0800 This bug tracks enabling lazy image loading by default in WebKit trunk, once it seems ready. 1621893 1 mjs 2020-02-22 12:29:21 -0800 I'm not sure it's ready to be turned on yet, but this is a bug to track for when it's ready. 1621895 2 webkit-bug-importer 2020-02-22 12:30:22 -0800 <rdar://problem/59700020> 1804164 3 addyo 2021-10-13 22:32:51 -0700 With the dependencies for this bug now closed (200764, 203557, 207901, 208119), is there a good chance loading=lazy might be turned on by default soon? 1804330 4 441235 nmouchtaris 2021-10-14 10:27:52 -0700 Created attachment 441235 Patch 1804405 5 441235 simon.fraser 2021-10-14 12:13:18 -0700 Comment on attachment 441235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441235&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:694 > - default: false > + default: true Is this tested? > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:698 > - default: false > + default: true I think you want to leave this off by default. It only applies in some weird situations (maybe the fake Page associated with SVG images or something). 1804464 6 441268 nmouchtaris 2021-10-14 13:25:40 -0700 Created attachment 441268 enable lazy image load for webkit 1804524 7 441289 nmouchtaris 2021-10-14 14:42:59 -0700 Created attachment 441289 enable lazy image load for webkit 1804654 8 ews-feeder 2021-10-14 19:22:01 -0700 Committed r284228 (243037@main): <https://commits.webkit.org/243037@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441289. 1809623 9 rik 2021-10-28 03:40:43 -0700 It seems this patch enabled `IsSameSiteStrictEnforcementEnabled` instead of `LazyImageLoadingEnabled`. $ git show --pretty=oneline 30c67adc54a265473c4fd44bbab6702e9be4487a -- Source/WTF/Scripts/ at 11:39:12 30c67adc54a265473c4fd44bbab6702e9be4487a Enable lazy image loading by default https://bugs.webkit.org/show_bug.cgi?id=208094 diff --git Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml index 0266e84653..d9e36c19ed 100644 --- Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml +++ Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml @@ -700,7 +700,7 @@ IsSameSiteStrictEnforcementEnabled: WebKitLegacy: default: false WebKit: - default: false + default: true WebCore: default: false Notice @@ -700,7 +700,7 @@ IsSameSiteStrictEnforcementEnabled: 1809675 10 simon.fraser 2021-10-28 08:24:48 -0700 You're right. The patches look correct. I wonder if this was a merge issue by commit-queue. 1809748 11 442718 nmouchtaris 2021-10-28 10:39:45 -0700 Created attachment 442718 Patch 1809759 12 ap 2021-10-28 11:11:59 -0700 Seems like something that needs a manual commit! 1809790 13 nmouchtaris 2021-10-28 12:56:11 -0700 Committed r284995 (243641@main): <https://commits.webkit.org/243641@main> 441235 2021-10-14 10:27:52 -0700 2021-10-28 10:39:37 -0700 Patch bug-208094-20211014102751.patch text/plain 1414 nmouchtaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIxZWI3N2U0MDU1OTJiOTVmOThmMWJm ZDE4ZWQwYjJjYzQ0MWVmMGEuLjVjZjNmZmQ1OTFkZjczNmQ5N2Y5NzkxMjU2NjY0ZGYyZGRlYTY3 OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMTQgIE5pa29zIE1vdWNodGFyaXMgIDxu bW91Y2h0YXJpc0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIGxhenkgaW1hZ2UgbG9hZGlu ZyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDgwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUdXJuIG9uIGxhenkgaW1hZ2UgbG9hZCBieSBkZWZhdWx0LgorCisgICAgICAgICogU2Ny aXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sOgorCiAyMDIx LTEwLTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR0xpYl0gTWVkaWEgc2Vzc2lvbiBtYW5hZ2VyIHVuYWJsZSB0byBoYW5kbGUgbW9yZSB0aGFu IG9uZSBzZXNzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMv V2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbCBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVm ZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sCmluZGV4IDU5MzA2MGJlYmYz MzIzODhjNDE2YjQ2NmFmOGIyZDY2MDc1ZTc1NWIuLjVhZjRkMDdlZGRiYWVhZTIzMTVhNWQ3ZGM1 MmY1Y2YwODFjZjc1ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNl cy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sCisrKyBiL1NvdXJjZS9XVEYvU2NyaXB0 cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sCkBAIC02OTEsMTEg KzY5MSwxMSBAQCBMYXp5SW1hZ2VMb2FkaW5nRW5hYmxlZDoKICAgaHVtYW5SZWFkYWJsZURlc2Ny aXB0aW9uOiAiRW5hYmxlIGxhenkgaW1hZ2UgbG9hZGluZyBzdXBwb3J0IgogICBkZWZhdWx0VmFs dWU6CiAgICAgV2ViS2l0TGVnYWN5OgotICAgICAgZGVmYXVsdDogZmFsc2UKKyAgICAgIGRlZmF1 bHQ6IHRydWUKICAgICBXZWJLaXQ6Ci0gICAgICBkZWZhdWx0OiBmYWxzZQorICAgICAgZGVmYXVs dDogdHJ1ZQogICAgIFdlYkNvcmU6Ci0gICAgICBkZWZhdWx0OiBmYWxzZQorICAgICAgZGVmYXVs dDogdHJ1ZQogCiBMaW5rUHJlZmV0Y2hFbmFibGVkOgogICB0eXBlOiBib29sCg== 441268 2021-10-14 13:25:40 -0700 2021-10-28 10:39:40 -0700 enable lazy image load for webkit bug-208094-20211014132539.patch text/plain 1262 nmouchtaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIxZWI3N2U0MDU1OTJiOTVmOThmMWJm ZDE4ZWQwYjJjYzQ0MWVmMGEuLmQ1NjE1MTY4NTRiYzc1Zjc4ZWU2ODNjNGU4OGRhY2I4MWIzZGMz OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMTQgIE5pa29zIE1vdWNodGFyaXMgIDxu bW91Y2h0YXJpc0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIGxhenkgaW1hZ2UgbG9hZGlu ZyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDgwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUdXJuIG9uIGxhenkgaW1hZ2UgbG9hZCBieSBkZWZhdWx0IGluIFdlYktpdC4KKworICAg ICAgICAqIFNjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFt bDoKKwogMjAyMS0xMC0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dMaWJdIE1lZGlhIHNlc3Npb24gbWFuYWdlciB1bmFibGUgdG8gaGFuZGxl IG1vcmUgdGhhbiBvbmUgc2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9TY3JpcHRzL1By ZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwgYi9Tb3VyY2UvV1RGL1Nj cmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAppbmRleCA1 OTMwNjBiZWJmMzMyMzg4YzQxNmI0NjZhZjhiMmQ2NjA3NWU3NTViLi40NjZhNzJkNjVjMDFhOTk1 ZTM1YTI3OTA1MDdjNWMxNDU4OTcyMGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMv UHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAorKysgYi9Tb3VyY2Uv V1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbApA QCAtNjkzLDcgKzY5Myw3IEBAIExhenlJbWFnZUxvYWRpbmdFbmFibGVkOgogICAgIFdlYktpdExl Z2FjeToKICAgICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViS2l0OgotICAgICAgZGVmYXVsdDog ZmFsc2UKKyAgICAgIGRlZmF1bHQ6IHRydWUKICAgICBXZWJDb3JlOgogICAgICAgZGVmYXVsdDog ZmFsc2UKIAo= 441289 2021-10-14 14:42:59 -0700 2021-10-28 10:39:42 -0700 enable lazy image load for webkit bug-208094-20211014144258.patch text/plain 1260 nmouchtaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIxZWI3N2U0MDU1OTJiOTVmOThmMWJm ZDE4ZWQwYjJjYzQ0MWVmMGEuLjI1NTUzYzUwZDA1YTI5ZDQ1NWYyZmIzMzk5OTBjOTc2YmRkMzkw MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMTQgIE5pa29zIE1vdWNodGFyaXMgIDxu bW91Y2h0YXJpc0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIGxhenkgaW1hZ2UgbG9hZGlu ZyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDgwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAg ICAgVHVybiBvbiBsYXp5IGltYWdlIGxvYWQgYnkgZGVmYXVsdCBpbiBXZWJLaXQuCisKKyAgICAg ICAgKiBTY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWw6 CisKIDIwMjEtMTAtMDIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHTGliXSBNZWRpYSBzZXNzaW9uIG1hbmFnZXIgdW5hYmxlIHRvIGhhbmRsZSBt b3JlIHRoYW4gb25lIHNlc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVm ZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sIGIvU291cmNlL1dURi9TY3Jp cHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKaW5kZXggNTkz MDYwYmViZjMzMjM4OGM0MTZiNDY2YWY4YjJkNjYwNzVlNzU1Yi4uNDY2YTcyZDY1YzAxYTk5NWUz NWEyNzkwNTA3YzVjMTQ1ODk3MjBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9TY3JpcHRzL1By ZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKKysrIGIvU291cmNlL1dU Ri9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKQEAg LTY5Myw3ICs2OTMsNyBAQCBMYXp5SW1hZ2VMb2FkaW5nRW5hYmxlZDoKICAgICBXZWJLaXRMZWdh Y3k6CiAgICAgICBkZWZhdWx0OiBmYWxzZQogICAgIFdlYktpdDoKLSAgICAgIGRlZmF1bHQ6IGZh bHNlCisgICAgICBkZWZhdWx0OiB0cnVlCiAgICAgV2ViQ29yZToKICAgICAgIGRlZmF1bHQ6IGZh bHNlCiAK 442718 2021-10-28 10:39:45 -0700 2021-10-28 10:43:30 -0700 Patch bug-208094-20211028103944.patch text/plain 1431 nmouchtaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYyOWIzMjI4ZjQ5NjJiMTMzYWM3OGE0 MWZmNDY3Y2IzMTJjZWI2YzQuLjlhNjc3YmZiN2ZlZGQyMDIzNmE4MmY5MTY3NmRmZjBhYzkzMDIz OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMjggIE5pa29sYW9zIE1vdWNodGFyaXMg IDxubW91Y2h0YXJpc0BhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIGxhenkgaW1hZ2UgbG9h ZGluZyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDgwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggbWVyZ2UgZXJyb3Igb2YgY29tbWl0IHF1ZXVlLgorCisgICAgICAgICogU2Ny aXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sOgorCiAyMDIx LTEwLTIyICBQYWJsbyBDb3JyZWEgR8OzbWV6ICA8YWJsb2NvcnJlYUBob3RtYWlsLmNvbT4KIAog ICAgICAgICBFbmFibGUgbG9nZ2luZyBpbiB1bmRlciBub24tc3lzdGVtZCBsaW51eCBkaXN0cm9z CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5j ZXNFeHBlcmltZW50YWwueWFtbCBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQ cmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sCmluZGV4IDg0OGRhNzgwYzhiMmM3MWU1MDU0MmE2 NmFmZGRmNTk3M2EyNzljNmMuLjIyNWQyOGM4YWFkNzJiY2RhNmEzNzc1NjFjNWNhYzhlY2JkZWI5 OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJl bmNlc0V4cGVyaW1lbnRhbC55YW1sCisrKyBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNl cy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sCkBAIC03MjcsNyArNzI3LDcgQEAgSXNT YW1lU2l0ZVN0cmljdEVuZm9yY2VtZW50RW5hYmxlZDoKICAgICBXZWJLaXRMZWdhY3k6CiAgICAg ICBkZWZhdWx0OiBmYWxzZQogICAgIFdlYktpdDoKLSAgICAgIGRlZmF1bHQ6IHRydWUKKyAgICAg IGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViQ29yZToKICAgICAgIGRlZmF1bHQ6IGZhbHNlCiAKQEAg LTc2NCw3ICs3NjQsNyBAQCBMYXp5SW1hZ2VMb2FkaW5nRW5hYmxlZDoKICAgICBXZWJLaXRMZWdh Y3k6CiAgICAgICBkZWZhdWx0OiBmYWxzZQogICAgIFdlYktpdDoKLSAgICAgIGRlZmF1bHQ6IGZh bHNlCisgICAgICBkZWZhdWx0OiB0cnVlCiAgICAgV2ViQ29yZToKICAgICAgIGRlZmF1bHQ6IGZh bHNlCiAK