208041 2020-02-20 20:03:01 -0800 [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14 2020-02-21 04:39:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208001 InRadar P2 Normal --- 1 lmoura lmoura aboya bugs-noreply calvaris cgarcia clopez commit-queue ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1621548 0 lmoura 2020-02-20 20:03:01 -0800 [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14 1621550 1 391376 lmoura 2020-02-20 20:04:45 -0800 Created attachment 391376 Patch 1621594 2 391376 calvaris 2020-02-21 01:26:00 -0800 Comment on attachment 391376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 > + gst_tag_list_unref(combinerPad->tags); unref and then assign to nullptr, which is what clear is doing > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 > + gst_object_unref(combinerPad->funnelPad); ditto 1621599 3 391376 aboya 2020-02-21 02:39:01 -0800 Comment on attachment 391376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 >> + gst_tag_list_unref(combinerPad->tags); > > unref and then assign to nullptr, which is what clear is doing g_clear_pointer(&combinerPad->tags, gst_tag_list_unref); >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 >> + gst_object_unref(combinerPad->funnelPad); > > ditto g_clear_pointer(&combinerPad->funnelPad, gst_object_unref); 1621601 4 calvaris 2020-02-21 03:00:06 -0800 (In reply to Alicia Boya García from comment #3) > Comment on attachment 391376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391376&action=review > > >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 > >> + gst_tag_list_unref(combinerPad->tags); > > > > unref and then assign to nullptr, which is what clear is doing > > g_clear_pointer(&combinerPad->tags, gst_tag_list_unref); > > >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 > >> + gst_object_unref(combinerPad->funnelPad); > > > > ditto > > g_clear_pointer(&combinerPad->funnelPad, gst_object_unref); 👏🏼 I didn't remember this 1621609 5 391391 lmoura 2020-02-21 03:44:53 -0800 Created attachment 391391 Patch 1621616 6 clopez 2020-02-21 04:31:42 -0800 (In reply to Lauro Moura from comment #0) > [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14 In general I appreciate giving more pointers to when this started to happen in the bug description or at least adding the related bug in the see also field :) 1621618 7 391391 commit-queue 2020-02-21 04:38:23 -0800 Comment on attachment 391391 Patch Clearing flags on attachment: 391391 Committed r257133: <https://trac.webkit.org/changeset/257133> 1621619 8 commit-queue 2020-02-21 04:38:25 -0800 All reviewed patches have been landed. Closing bug. 1621620 9 webkit-bug-importer 2020-02-21 04:39:16 -0800 <rdar://problem/59665227> 391376 2020-02-20 20:04:45 -0800 2020-02-21 03:44:41 -0800 Patch bug-208041-20200221010442.patch text/plain 2187 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdlNDEwZDE2MjgyMThi OGJiM2M3ZWZlOTQxNzdlMDVmZmRhZmMyYS4uOTk3NTNlODZlZTA4NzQ0MzA2OGFkZDgzYThmYmZm MjM0M2ZhZTA2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTIwICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIFRleHRD b21iaW5lckdTdHJlYW1lciBpcyBmYWlsaW5nIHRvIGNvbXBpbGUgd2l0aCBHc3QxLjE0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwNDEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIHVzYWdl IG9mIGdzdF9jbGVhcl9vYmplY3QgYW5kIGdzdF9jbGVhcl90YWdfbGlzdCB3aXRoIHByZXZpb3Vz CisgICAgICAgICpfdW5yZWYgZnVuY3Rpb25zLiBUaGUgY2xlYXIgdmVyc2lvbnMgd2VyZSBhZGRl ZCBpbiAxLjE2IHdoaWxlIFVidW50dQorICAgICAgICAxOC4wNCAoY3VycmVudCBMVFMpIGFuZCBE ZWJpYW4gc3RhYmxlIHVzZXMgMS4xNC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2Via2l0VGV4dENv bWJpbmVyUGFkRGlzcG9zZSk6CisKIDIwMjAtMDItMjAgIFN1bm55IEhlICA8c3VubnlfaGVAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCBjcmFzaCBpbiBQYWdlOjp1cGRhdGVSZW5kZXJpbmcgd2hl biBkb2N1bWVudCBoYXMgbm8gZG9tV2luZG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dENvbWJpbmVyR1N0cmVhbWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3Ry ZWFtZXIuY3BwCmluZGV4IGM4YmE1Mjg5YjIzMzhlN2Y1MGQzN2EwZTgwYjVlMGVlYTFjNmYxOWUu LmQwN2MzY2Y2YjAzOWE2OTczMTdhOGJiMTA2MWQ1MmI5ZDBiMDI4ZDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3Ry ZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCkBAIC0xMDMsOCArMTAzLDE0IEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF90ZXh0X2NvbWJpbmVyX3BhZF9pbml0KFdlYktpdFRleHRDb21iaW5lclBhZCog cGFkKQogc3RhdGljIHZvaWQgd2Via2l0VGV4dENvbWJpbmVyUGFkRGlzcG9zZShHT2JqZWN0KiBv YmplY3QpCiB7CiAgICAgV2ViS2l0VGV4dENvbWJpbmVyUGFkKiBjb21iaW5lclBhZCA9IFdFQktJ VF9URVhUX0NPTUJJTkVSX1BBRChvYmplY3QpOwotICAgIGdzdF9jbGVhcl90YWdfbGlzdCgmY29t YmluZXJQYWQtPnRhZ3MpOwotICAgIGdzdF9jbGVhcl9vYmplY3QoJmNvbWJpbmVyUGFkLT5mdW5u ZWxQYWQpOworICAgIC8vIFRoZSBpZiBiZWxvdyBjb3VsZCBiZSByZXBsYWNlZCB3aXRoIG9ubHkg Z3N0X2NsZWFyX3RhZ19saXN0KCZjb21iaW5lclBhZC0+dGFncykKKyAgICAvLyBvbmNlIHdlIHJh aXNlIHRoZSBtaW5pbXVtIGdzdHJlYW1lciB2ZXJzaW9uIHRvIDEuMTYuIChVYnVudHUgMTguMDQg YW5kIERlYmlhbiBzdGFibGUKKyAgICAvLyBhcmUgdXNpbmcgMS4xNCkuCisgICAgaWYgKGNvbWJp bmVyUGFkLT50YWdzKQorICAgICAgICBnc3RfdGFnX2xpc3RfdW5yZWYoY29tYmluZXJQYWQtPnRh Z3MpOworICAgIC8vIERpdHRvLCBiZWluZyByZXBsYWNlZCB3aXRoIGdzdF9vYmplY3RfY2xlYXIo JmNvbWJpbmVyUGFkLT5mdW5uZWxQYWQpOworICAgIGlmIChjb21iaW5lclBhZC0+ZnVubmVsUGFk KQorICAgICAgICBnc3Rfb2JqZWN0X3VucmVmKGNvbWJpbmVyUGFkLT5mdW5uZWxQYWQpOwogICAg IEdfT0JKRUNUX0NMQVNTKHdlYmtpdF90ZXh0X2NvbWJpbmVyX3BhZF9wYXJlbnRfY2xhc3MpLT5k aXNwb3NlKG9iamVjdCk7CiB9CiAK 391391 2020-02-21 03:44:53 -0800 2020-02-21 04:38:23 -0800 Patch bug-208041-20200221084450.patch text/plain 1872 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3MTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWExNDg0M2ViZTdlYmY5 ODJkYThhMzE1ZjBkZWQ2NTVjZjUxZjVkOS4uMWY3ZjViODA5NzA1Njg5NTcwNzRhZmU1ZjcxYzM2 NGYxZGU3NWRhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTIxICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIFRleHRD b21iaW5lckdTdHJlYW1lciBpcyBmYWlsaW5nIHRvIGNvbXBpbGUgd2l0aCBHc3QxLjE0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDgwNDEKKworICAg ICAgICBSZXZpZXdlZCBieSBYYWJpZXIgUm9kcmlndWV6LUNhbHZhci4KKworICAgICAgICBSZXBs YWNlIHVzYWdlIG9mIGdzdF9jbGVhcl9vYmplY3QgYW5kIGdzdF9jbGVhcl90YWdfbGlzdCB3aXRo IHByZXZpb3VzCisgICAgICAgICpfdW5yZWYgZnVuY3Rpb25zLiBUaGUgY2xlYXIgdmVyc2lvbnMg d2VyZSBhZGRlZCBpbiAxLjE2IHdoaWxlIFVidW50dQorICAgICAgICAxOC4wNCAoY3VycmVudCBM VFMpIGFuZCBEZWJpYW4gc3RhYmxlIHVzZXMgMS4xNC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2Vi a2l0VGV4dENvbWJpbmVyUGFkRGlzcG9zZSk6CisKIDIwMjAtMDItMjEgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFVzZSBjdXN0b20g dGhlbWUgc3R5bGUgZm9yIG1lZGlhIGNvbnRyb2xzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dENvbWJpbmVyR1N0cmVhbWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJH U3RyZWFtZXIuY3BwCmluZGV4IGM4YmE1Mjg5YjIzMzhlN2Y1MGQzN2EwZTgwYjVlMGVlYTFjNmYx OWUuLjVkYjY1YzcxYWQ5YTNmNzAyZGYyMWZlNzkzZDY0Y2VlYzM5ZjViZDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJH U3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCkBAIC0xMDMsOCArMTAzLDggQEAgc3RhdGlj IHZvaWQgd2Via2l0X3RleHRfY29tYmluZXJfcGFkX2luaXQoV2ViS2l0VGV4dENvbWJpbmVyUGFk KiBwYWQpCiBzdGF0aWMgdm9pZCB3ZWJraXRUZXh0Q29tYmluZXJQYWREaXNwb3NlKEdPYmplY3Qq IG9iamVjdCkKIHsKICAgICBXZWJLaXRUZXh0Q29tYmluZXJQYWQqIGNvbWJpbmVyUGFkID0gV0VC S0lUX1RFWFRfQ09NQklORVJfUEFEKG9iamVjdCk7Ci0gICAgZ3N0X2NsZWFyX3RhZ19saXN0KCZj b21iaW5lclBhZC0+dGFncyk7Ci0gICAgZ3N0X2NsZWFyX29iamVjdCgmY29tYmluZXJQYWQtPmZ1 bm5lbFBhZCk7CisgICAgZ19jbGVhcl9wb2ludGVyKCZjb21iaW5lclBhZC0+dGFncywgZ3N0X3Rh Z19saXN0X3VucmVmKTsKKyAgICBnX2NsZWFyX3BvaW50ZXIoJmNvbWJpbmVyUGFkLT5mdW5uZWxQ YWQsIGdzdF9vYmplY3RfdW5yZWYpOwogICAgIEdfT0JKRUNUX0NMQVNTKHdlYmtpdF90ZXh0X2Nv bWJpbmVyX3BhZF9wYXJlbnRfY2xhc3MpLT5kaXNwb3NlKG9iamVjdCk7CiB9CiAK