207975 2020-02-19 17:03:30 -0800 Crash in Page::updateRendering when document has no domWindow 2020-02-20 18:58:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sunny_he webkit-unassigned bfulgham cdumez commit-queue rniwa sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 1620955 0 sunny_he 2020-02-19 17:03:30 -0800 rdar://56999099 1620957 1 391223 sunny_he 2020-02-19 17:09:09 -0800 Created attachment 391223 Patch 1621342 2 391223 rniwa 2020-02-20 11:49:16 -0800 Comment on attachment 391223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review > Source/WebCore/page/Page.cpp:1334 > + if (document.domWindow()) { Can we use an early return instead? 1621475 3 391223 sabouhallawa 2020-02-20 16:18:14 -0800 Comment on attachment 391223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review >> Source/WebCore/page/Page.cpp:1334 >> + if (document.domWindow()) { > > Can we use an early return instead? Should this be in forEachDocument()? Is there a reason to run any rendering update step for a document which does not have a window? 1621509 4 rniwa 2020-02-20 17:41:47 -0800 (In reply to Said Abou-Hallawa from comment #3) > Comment on attachment 391223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391223&action=review > > >> Source/WebCore/page/Page.cpp:1334 > >> + if (document.domWindow()) { > > > > Can we use an early return instead? > > Should this be in forEachDocument()? Is there a reason to run any rendering > update step for a document which does not have a window? I don’t think we want to do that there because it’s used in other places than Page::updateRendering. 1621516 5 391365 sunny_he 2020-02-20 17:55:09 -0800 Created attachment 391365 Patch 1621531 6 commit-queue 2020-02-20 18:57:28 -0800 The commit-queue encountered the following flaky tests while processing attachment 391365: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1621532 7 391365 commit-queue 2020-02-20 18:57:59 -0800 Comment on attachment 391365 Patch Clearing flags on attachment: 391365 Committed r257123: <https://trac.webkit.org/changeset/257123> 1621533 8 commit-queue 2020-02-20 18:58:01 -0800 All reviewed patches have been landed. Closing bug. 391223 2020-02-19 17:09:09 -0800 2020-02-20 17:55:08 -0800 Patch bug-207975-20200219170909.patch text/plain 2139 sunny_he U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhlNWEzYjEzZTk4NGEy MGFjZTc1ZWY5MDljMzUwMDExZjgwMWViNy4uNGUxNWQxNzgwNTdhYTE0MjMwNDRhOWI0ZjUwY2M1 NGE3NjQ0YjEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTE5ICBTdW5u eSBIZSAgPHN1bm55X2hlQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY3Jhc2ggaW4gUGFnZTo6 dXBkYXRlUmVuZGVyaW5nIHdoZW4gZG9jdW1lbnQgaGFzIG5vIGRvbVdpbmRvdworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3OTc1CisgICAgICAgIDxy ZGFyOi8vNTY5OTkwOTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBhIHN1YmZyYW1lIGlzIG5hdmlnYXRlZCwgYSBuZXcgZG9jdW1lbnQgaXMg Y3JlYXRlZCBhbmQKKyAgICAgICAgdGhlIHdpbmRvdyBpcyB0cmFuc2ZlcmVkIGFzeW5jaHJvbm91 c2x5LiBJdCBpcyBwb3NzaWJsZSB0byBoYXZlCisgICAgICAgIGEgY2FsbCB0byB1cGRhdGVSZW5k ZXJpbmcgaW4gdGhlIG1pZGRsZSBvZiB0aGlzIHByb2Nlc3MsIHJlc3VsdGluZworICAgICAgICBp biBhbiBhdHRlbXB0IHRvIHVwZGF0ZSBhIGRvY3VtZW50IHdpdGggbm8gd2luZG93LiBBZGQgYSBj aGVjayBmb3IKKyAgICAgICAgdGhpcyBjYXNlIGFuZCBza2lwIHN1Y2ggZG9jdW1lbnRzLgorCisg ICAgICAgIE5vIHRlc3QsIHNpbmNlIHRoaXMgY3Jhc2ggcmVsaWVzIG9uIHNlbnNpdGl2ZSB0aW1p bmcgdGhhdCBjYW5ub3QgYmUKKyAgICAgICAgY29uc2lzdGVudGx5IHJlcGxpY2F0ZWQgaW4gYSB0 ZXN0IGNhc2UuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGFnZTo6dXBkYXRlUmVuZGVyaW5nKToKKwogMjAyMC0wMi0xOCAgRGFuaWVsIEJhdGVzICA8ZGFi YXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQXNrIHRoZSBFZGl0b3JDbGllbnQgd2hldGhlciB0 byByZXZlYWwgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGFmdGVyIGluc2VydGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZS5jcHAKaW5kZXggYzYxYmYyYWJkMGY0M2JjMzc5OWM5MDI3ODk5MWM4NWQxZTJiYWViNy4uNDQw YTlkYmRjODM1MGNkYjNlOTA2ZDBhYzZmNDA5MWM0Njk4YWJjOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3Bw CkBAIC0xMzMxLDEwICsxMzMxLDEyIEBAIHZvaWQgUGFnZTo6dXBkYXRlUmVuZGVyaW5nKCkKICAg ICB9KTsKIAogICAgIGZvckVhY2hEb2N1bWVudChbXSAoRG9jdW1lbnQmIGRvY3VtZW50KSB7Ci0g ICAgICAgIERPTUhpZ2hSZXNUaW1lU3RhbXAgdGltZXN0YW1wID0gZG9jdW1lbnQuZG9tV2luZG93 KCktPm5vd1RpbWVzdGFtcCgpOwotICAgICAgICBkb2N1bWVudC51cGRhdGVBbmltYXRpb25zQW5k U2VuZEV2ZW50cyh0aW1lc3RhbXApOwotICAgICAgICAvLyBGSVhNRTogUnVuIHRoZSBmdWxsc2Ny ZWVuIHN0ZXBzLgotICAgICAgICBkb2N1bWVudC5zZXJ2aWNlUmVxdWVzdEFuaW1hdGlvbkZyYW1l Q2FsbGJhY2tzKHRpbWVzdGFtcCk7CisgICAgICAgIGlmIChkb2N1bWVudC5kb21XaW5kb3coKSkg eworICAgICAgICAgICAgRE9NSGlnaFJlc1RpbWVTdGFtcCB0aW1lc3RhbXAgPSBkb2N1bWVudC5k b21XaW5kb3coKS0+bm93VGltZXN0YW1wKCk7CisgICAgICAgICAgICBkb2N1bWVudC51cGRhdGVB bmltYXRpb25zQW5kU2VuZEV2ZW50cyh0aW1lc3RhbXApOworICAgICAgICAgICAgLy8gRklYTUU6 IFJ1biB0aGUgZnVsbHNjcmVlbiBzdGVwcy4KKyAgICAgICAgICAgIGRvY3VtZW50LnNlcnZpY2VS ZXF1ZXN0QW5pbWF0aW9uRnJhbWVDYWxsYmFja3ModGltZXN0YW1wKTsKKyAgICAgICAgfQogICAg IH0pOwogCiAgICAgbGF5b3V0SWZOZWVkZWQoKTsK 391365 2020-02-20 17:55:09 -0800 2020-02-20 18:57:59 -0800 Patch bug-207975-20200220175509.patch text/plain 1776 sunny_he U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhlNWEzYjEzZTk4NGEy MGFjZTc1ZWY5MDljMzUwMDExZjgwMWViNy4uNGUxNWQxNzgwNTdhYTE0MjMwNDRhOWI0ZjUwY2M1 NGE3NjQ0YjEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTE5ICBTdW5u eSBIZSAgPHN1bm55X2hlQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY3Jhc2ggaW4gUGFnZTo6 dXBkYXRlUmVuZGVyaW5nIHdoZW4gZG9jdW1lbnQgaGFzIG5vIGRvbVdpbmRvdworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3OTc1CisgICAgICAgIDxy ZGFyOi8vNTY5OTkwOTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBhIHN1YmZyYW1lIGlzIG5hdmlnYXRlZCwgYSBuZXcgZG9jdW1lbnQgaXMg Y3JlYXRlZCBhbmQKKyAgICAgICAgdGhlIHdpbmRvdyBpcyB0cmFuc2ZlcmVkIGFzeW5jaHJvbm91 c2x5LiBJdCBpcyBwb3NzaWJsZSB0byBoYXZlCisgICAgICAgIGEgY2FsbCB0byB1cGRhdGVSZW5k ZXJpbmcgaW4gdGhlIG1pZGRsZSBvZiB0aGlzIHByb2Nlc3MsIHJlc3VsdGluZworICAgICAgICBp biBhbiBhdHRlbXB0IHRvIHVwZGF0ZSBhIGRvY3VtZW50IHdpdGggbm8gd2luZG93LiBBZGQgYSBj aGVjayBmb3IKKyAgICAgICAgdGhpcyBjYXNlIGFuZCBza2lwIHN1Y2ggZG9jdW1lbnRzLgorCisg ICAgICAgIE5vIHRlc3QsIHNpbmNlIHRoaXMgY3Jhc2ggcmVsaWVzIG9uIHNlbnNpdGl2ZSB0aW1p bmcgdGhhdCBjYW5ub3QgYmUKKyAgICAgICAgY29uc2lzdGVudGx5IHJlcGxpY2F0ZWQgaW4gYSB0 ZXN0IGNhc2UuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGFnZTo6dXBkYXRlUmVuZGVyaW5nKToKKwogMjAyMC0wMi0xOCAgRGFuaWVsIEJhdGVzICA8ZGFi YXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQXNrIHRoZSBFZGl0b3JDbGllbnQgd2hldGhlciB0 byByZXZlYWwgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGFmdGVyIGluc2VydGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZS5jcHAKaW5kZXggYzYxYmYyYWJkMGY0M2JjMzc5OWM5MDI3ODk5MWM4NWQxZTJiYWViNy4uN2My MGZlYzMwNGE0YzkwZTU3YTM4MzVkZDMyOTEzNGI2ZWMyNTZkYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3Bw CkBAIC0xMzMxLDYgKzEzMzEsOCBAQCB2b2lkIFBhZ2U6OnVwZGF0ZVJlbmRlcmluZygpCiAgICAg fSk7CiAKICAgICBmb3JFYWNoRG9jdW1lbnQoW10gKERvY3VtZW50JiBkb2N1bWVudCkgeworICAg ICAgICBpZiAoIWRvY3VtZW50LmRvbVdpbmRvdygpKQorICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICBET01IaWdoUmVzVGltZVN0YW1wIHRpbWVzdGFtcCA9IGRvY3VtZW50LmRvbVdpbmRvdygp LT5ub3dUaW1lc3RhbXAoKTsKICAgICAgICAgZG9jdW1lbnQudXBkYXRlQW5pbWF0aW9uc0FuZFNl bmRFdmVudHModGltZXN0YW1wKTsKICAgICAgICAgLy8gRklYTUU6IFJ1biB0aGUgZnVsbHNjcmVl biBzdGVwcy4K