207949 2020-02-19 10:02:00 -0800 Disable the process cache when process-per-tab is disabled in the debug menu 2020-02-19 12:01:57 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1620718 0 cdumez 2020-02-19 10:02:00 -0800 Disable the process cache when process-per-tab is disabled in the debug menu. The process cache is a process-swap-on-navigation optimization and process-swap-on-navigation is already disabled when process-per-tab is disabled. The process cache is not useful with such configuration and actually leads to crashes too. 1620719 1 cdumez 2020-02-19 10:02:13 -0800 <rdar://problem/57094837> 1620720 2 391174 cdumez 2020-02-19 10:03:31 -0800 Created attachment 391174 Patch 1620738 3 391174 ggaren 2020-02-19 10:59:25 -0800 Comment on attachment 391174 Patch r=me 1620785 4 commit-queue 2020-02-19 12:01:20 -0800 The commit-queue encountered the following flaky tests while processing attachment 391174: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1620786 5 391174 commit-queue 2020-02-19 12:01:56 -0800 Comment on attachment 391174 Patch Clearing flags on attachment: 391174 Committed r256932: <https://trac.webkit.org/changeset/256932> 1620787 6 commit-queue 2020-02-19 12:01:57 -0800 All reviewed patches have been landed. Closing bug. 391174 2020-02-19 10:03:31 -0800 2020-02-19 12:01:56 -0800 Patch bug-207949-20200219100330.patch text/plain 2755 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzNDJiMTFlYmE1NjhmNDk4 YTc3N2U4ODY0YmVmNzE5NjI4YWQwN2UuLjM3ZmFhNDk1OTZhNDFjMjBkYTFlMGY3YzUyMWUyZjJj ZTBlNjJjMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDItMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEaXNhYmxlIHRoZSBwcm9jZXNzIGNh Y2hlIHdoZW4gcHJvY2Vzcy1wZXItdGFiIGlzIGRpc2FibGVkIGluIHRoZSBkZWJ1ZyBtZW51Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc5NDkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3MDk0ODM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgdGhlIHByb2Nlc3MgY2FjaGUgd2hlbiBw cm9jZXNzLXBlci10YWIgaXMgZGlzYWJsZWQgaW4gdGhlIGRlYnVnIG1lbnUuIFRoZSBwcm9jZXNz IGNhY2hlIGlzIGEKKyAgICAgICAgcHJvY2Vzcy1zd2FwLW9uLW5hdmlnYXRpb24gb3B0aW1pemF0 aW9uIGFuZCBwcm9jZXNzLXN3YXAtb24tbmF2aWdhdGlvbiBpcyBhbHJlYWR5IGRpc2FibGVkIHdo ZW4KKyAgICAgICAgcHJvY2Vzcy1wZXItdGFiIGlzIGRpc2FibGVkLiBUaGUgcHJvY2VzcyBjYWNo ZSBpcyBub3QgdXNlZnVsIHdpdGggc3VjaCBjb25maWd1cmF0aW9uIGFuZCBhY3R1YWxseQorICAg ICAgICBsZWFkcyB0byBjcmFzaGVzIHRvby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9j ZXNzQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzQ2FjaGU6OnVwZGF0ZUNh cGFjaXR5KToKKwogMjAyMC0wMi0xOSAgQ2F0aGllIENoZW4gIDxjYXRoaWVjaGVuQGlnYWxpYS5j b20+CiAKICAgICAgICAgRW5hYmxlIEFzcGVjdFJhdGlvT2ZJbWdGcm9tV2lkdGhBbmRIZWlnaHRF bmFibGVkIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlByb2Nlc3NDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzQ2Fj aGUuY3BwCmluZGV4IDFjODA2MzFlM2ExNjIxMDE4M2U2NDkzMWFiYmZjOTA1NDI2NWVjM2EuLmU4 MDMyNGNhOWNlMTBiOTg1NGIyMjU4YmY4YzJmMGZiOGIwNjkzYWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUHJvY2Vzc0NhY2hlLmNwcApAQCAtMTU2LDExICsxNTYsMTMgQEAgUmVm UHRyPFdlYlByb2Nlc3NQcm94eT4gV2ViUHJvY2Vzc0NhY2hlOjp0YWtlUHJvY2Vzcyhjb25zdCBX ZWJDb3JlOjpSZWdpc3RyYWJsZUQKIAogdm9pZCBXZWJQcm9jZXNzQ2FjaGU6OnVwZGF0ZUNhcGFj aXR5KFdlYlByb2Nlc3NQb29sJiBwcm9jZXNzUG9vbCkKIHsKLSAgICBpZiAoIXByb2Nlc3NQb29s LmNvbmZpZ3VyYXRpb24oKS5wcm9jZXNzU3dhcHNPbk5hdmlnYXRpb24oKSB8fCAhcHJvY2Vzc1Bv b2wuY29uZmlndXJhdGlvbigpLnVzZXNXZWJQcm9jZXNzQ2FjaGUoKSB8fCBMZWdhY3lHbG9iYWxT ZXR0aW5nczo6c2luZ2xldG9uKCkuY2FjaGVNb2RlbCgpICE9IENhY2hlTW9kZWw6OlByaW1hcnlX ZWJCcm93c2VyKSB7CisgICAgaWYgKCFwcm9jZXNzUG9vbC5jb25maWd1cmF0aW9uKCkucHJvY2Vz c1N3YXBzT25OYXZpZ2F0aW9uKCkgfHwgIXByb2Nlc3NQb29sLmNvbmZpZ3VyYXRpb24oKS51c2Vz V2ViUHJvY2Vzc0NhY2hlKCkgfHwgTGVnYWN5R2xvYmFsU2V0dGluZ3M6OnNpbmdsZXRvbigpLmNh Y2hlTW9kZWwoKSAhPSBDYWNoZU1vZGVsOjpQcmltYXJ5V2ViQnJvd3NlciB8fCBwcm9jZXNzUG9v bC5jb25maWd1cmF0aW9uKCkudXNlc1NpbmdsZVdlYlByb2Nlc3MoKSkgewogICAgICAgICBpZiAo IXByb2Nlc3NQb29sLmNvbmZpZ3VyYXRpb24oKS5wcm9jZXNzU3dhcHNPbk5hdmlnYXRpb24oKSkK ICAgICAgICAgICAgIFdFQlBST0NFU1NDQUNIRV9SRUxFQVNFX0xPRygidXBkYXRlQ2FwYWNpdHk6 IENhY2hlIGlzIGRpc2FibGVkIGJlY2F1c2UgcHJvY2VzcyBzd2FwIG9uIG5hdmlnYXRpb24gaXMg ZGlzYWJsZWQiLCAwKTsKICAgICAgICAgZWxzZSBpZiAoIXByb2Nlc3NQb29sLmNvbmZpZ3VyYXRp b24oKS51c2VzV2ViUHJvY2Vzc0NhY2hlKCkpCiAgICAgICAgICAgICBXRUJQUk9DRVNTQ0FDSEVf UkVMRUFTRV9MT0coInVwZGF0ZUNhcGFjaXR5OiBDYWNoZSBpcyBkaXNhYmxlZCBieSBjbGllbnQi LCAwKTsKKyAgICAgICAgZWxzZSBpZiAocHJvY2Vzc1Bvb2wuY29uZmlndXJhdGlvbigpLnVzZXNT aW5nbGVXZWJQcm9jZXNzKCkpCisgICAgICAgICAgICBXRUJQUk9DRVNTQ0FDSEVfUkVMRUFTRV9M T0coInVwZGF0ZUNhcGFjaXR5OiBDYWNoZSBpcyBkaXNhYmxlZCBiZWNhdXNlIHByb2Nlc3MtcGVy LXRhYiB3YXMgZGlzYWJsZWQiLCAwKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgV0VCUFJP Q0VTU0NBQ0hFX1JFTEVBU0VfTE9HKCJ1cGRhdGVDYXBhY2l0eTogQ2FjaGUgaXMgZGlzYWJsZWQg YmVjYXVzZSBjYWNoZSBtb2RlbCBpcyBub3QgUHJpbWFyeVdlYkJyb3dzZXIiLCAwKTsKICAgICAg ICAgbV9jYXBhY2l0eSA9IDA7Cg==