207918 2020-02-18 15:26:01 -0800 EWS should be able to search existing bugs for given test 2020-02-19 08:42:59 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=207845 P2 Normal --- 207935 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bot-watchers-bugzilla oldest_to_newest 1620377 0 aakash_jain 2020-02-18 15:26:01 -0800 EWS should be able to search existing bugs for given test. This is required so that EWS can decide whether or not to file new bug for flaky test (for commit-queue). 1620380 1 391106 aakash_jain 2020-02-18 15:27:14 -0800 Created attachment 391106 Patch 1620386 2 391106 aakash_jain 2020-02-18 15:30:04 -0800 Comment on attachment 391106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391106&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:498 > + def fetch_bug_id_for_flaky_test(self, flaky_test_name): Inspired from _lookup_bug_for_flaky_test https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py#L70 1620419 3 jbedard 2020-02-18 16:18:16 -0800 Before landing this, I think we should have a discussion about if this actually the right way to achieve our goals. We had an offline discussion about this today, I wonder if we should start with an umbrella bug with the problem statement and more formally determine which solution we want before implementing a solution. 1620646 4 aakash_jain 2020-02-19 07:45:04 -0800 This is required to migrate the existing functionality of commit-queue from old ews to new ews (irrespective of whether we decide for other EWS queue to automatically file bugs for flaky tests or not). I believe there isn't a disagreement about commit-queue filing bugs for flaky tests. 1620671 5 jbedard 2020-02-19 08:42:59 -0800 (In reply to Aakash Jain from comment #4) > This is required to migrate the existing functionality of commit-queue from > old ews to new ews (irrespective of whether we decide for other EWS queue to > automatically file bugs for flaky tests or not). > > I believe there isn't a disagreement about commit-queue filing bugs for > flaky tests. Didn't realize we have commit queue doing this now. 391106 2020-02-18 15:27:14 -0800 2020-02-19 08:42:39 -0800 Patch bug-207918-20200218182713.patch text/plain 2094 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Njg2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAyLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIGJlIGFibGUgdG8gc2VhcmNoIGV4aXN0aW5nIGJ1Z3Mg Zm9yIGdpdmVuIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNzkxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAo QnVnemlsbGFNaXhpbi5mZXRjaF9idWdfaWRfZm9yX2ZsYWt5X3Rlc3QpOgorCiAyMDIwLTAyLTE4 ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNP U10gV2ViIHByb2Nlc3MgbWF5IGNyYXNoIHVuZGVyIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6 OmJ1aWxkUG90ZW50aWFsSGlnaGxpZ2h0c0lmTmVlZGVkCkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTY4NjEpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ5 NSw2ICs0OTUsMzMgQEAgY2xhc3MgQnVnemlsbGFNaXhpbihvYmplY3QpOgogICAgICAgICBzZWxm Ll9hZGRUb0xvZygnc3RkaW8nLCAnRmlsZWQgYnVnOiB7fScuZm9ybWF0KGJ1Z190aXRsZSkpCiAg ICAgICAgIHJldHVybiBTVUNDRVNTCiAKKyAgICBkZWYgZmV0Y2hfYnVnX2lkX2Zvcl9mbGFreV90 ZXN0KHNlbGYsIGZsYWt5X3Rlc3RfbmFtZSk6CisgICAgICAgIF9ib3RfZW1haWxzID0gc2V0KFsK KyAgICAgICAgICAgICdjb21taXQtcXVldWVAd2Via2l0Lm9yZycsICAjIGNvbW1pdC1xdWV1ZQor ICAgICAgICAgICAgJ2V3c0B3ZWJraXQub3JnJywgICMgRVdTIHF1ZXVlcworICAgICAgICBdKQor ICAgICAgICBidWdfdXJsID0gJ3t9cmVzdC9idWc/c3VtbWFyeT17fScuZm9ybWF0KEJVR19TRVJW RVJfVVJMLCBmbGFreV90ZXN0X25hbWUpCisgICAgICAgIHJlc3BvbnNlID0gc2VsZi5mZXRjaF9k YXRhX2Zyb21fdXJsKGJ1Z191cmwpCisgICAgICAgIGlmIG5vdCByZXNwb25zZToKKyAgICAgICAg ICAgIHJldHVybiBOb25lCisKKyAgICAgICAgYnVnc19qc29uID0gcmVzcG9uc2UuanNvbigpLmdl dCgnYnVncycpCisgICAgICAgIGlmIG5vdCBidWdzX2pzb24gb3IgbGVuKGJ1Z3NfanNvbikgPT0g MDoKKyAgICAgICAgICAgIHJldHVybiBOb25lCisKKyAgICAgICAgIyBGaWx0ZXIgYnVncyBmaWxl ZCBieSBFV1MKKyAgICAgICAgcmVsZXZhbnRfYnVncyA9IFtdCisgICAgICAgIGZvciBidWcgaW4g YnVnc19qc29uOgorICAgICAgICAgICAgaWYgYnVnLmdldCgnY3JlYXRvcicpIGluIF9ib3RfZW1h aWxzOgorICAgICAgICAgICAgICAgIHJlbGV2YW50X2J1Z3MuYXBwZW5kKGJ1Zy5nZXQoJ2lkJykp CisKKyAgICAgICAgaWYgbm90IHJlbGV2YW50X2J1Z3M6CisgICAgICAgICAgICByZXR1cm4gTm9u ZQorCisgICAgICAgICMgRklYTUU6IFRoZXJlIGFyZSBwcm9iYWJseSBoZXVyaXN0aWNzIHdlIGNv dWxkIHVzZSBmb3IgZmluZGluZworICAgICAgICAjIHRoZSByaWdodCBidWcgaW5zdGVhZCBvZiB0 aGUgZmlyc3QsIGxpa2Ugb3BlbiB2cy4gY2xvc2VkLgorICAgICAgICByZXR1cm4gcmVsZXZhbnRf YnVnc1swXQorCiAKIGNsYXNzIFZhbGlkYXRlUGF0Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCwgQnVn emlsbGFNaXhpbik6CiAgICAgbmFtZSA9ICd2YWxpZGF0ZS1wYXRjaCcK