207910 2020-02-18 14:05:44 -0800 results.webkit.org: Correctly report JSC tests for windows 2020-02-20 07:27:52 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dbates ews-watchlist webkit-bug-importer zhifei_fang oldest_to_newest 1620314 0 jbedard 2020-02-18 14:05:44 -0800 We aren't setting the version number and version name for JSC testing correctly. 1620326 1 391092 jbedard 2020-02-18 14:22:57 -0800 Created attachment 391092 Patch 1620327 2 391092 aakash_jain 2020-02-18 14:26:05 -0800 Comment on attachment 391092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391092&action=review rs=me > Tools/Scripts/webkitdirs.pm:1372 > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; what does versionString looks like on windows? 1620335 3 jbedard 2020-02-18 14:47:53 -0800 (In reply to Aakash Jain from comment #2) > Comment on attachment 391092 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391092&action=review > > rs=me > > > Tools/Scripts/webkitdirs.pm:1372 > > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; > > what does versionString looks like on windows? 10.0.12345 Obviously that last part isn't accurate, but it is a large 4-5 digit number. 1620645 4 391160 jbedard 2020-02-19 07:38:50 -0800 Created attachment 391160 Patch for landing 1620667 5 commit-queue 2020-02-19 08:37:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 391160: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. 1620668 6 391160 commit-queue 2020-02-19 08:37:40 -0800 Comment on attachment 391160 Patch for landing Clearing flags on attachment: 391160 Committed r256920: <https://trac.webkit.org/changeset/256920> 1620669 7 commit-queue 2020-02-19 08:37:41 -0800 All reviewed patches have been landed. Closing bug. 1620670 8 webkit-bug-importer 2020-02-19 08:39:07 -0800 <rdar://problem/59591455> 1621204 9 jbedard 2020-02-20 07:27:52 -0800 Committed r257058: <https://trac.webkit.org/changeset/257058> 391092 2020-02-18 14:22:57 -0800 2020-02-19 07:38:47 -0800 Patch bug-207910-20200218142256.patch text/plain 1813 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Njg1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENvcnJlY3RseSByZXBvcnQgSlNDIHRl c3RzIGZvciB3aW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDc5MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorICAgICAgICAoY29u ZmlndXJhdGlvbkZvclVwbG9hZCk6IEdpdmUgV2luZG93cyBhIHZlcnNpb24gbmFtZS4KKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVXaW5WZXJzaW9u KTogQ29ycmVjdGx5IHBhcnNlIFdpbmRvd3MgMTAgdmVyc2lvbiBudW1iZXJzLCBjb25mb3JtIHRv CisgICAgICAgIFZlcnNpb24gZGljdGlvbmFyeS4KKwogMjAyMC0wMi0xOCAgTWF0dCBMZXdpcyAg PGpsZXdpczNAYXBwbGUuY29tPgogCiAgICAgICAgIFN0dWIgcmVwb3NpdG9yaWVzIGZhaWwgdG8g dXBsb2FkIHNvbWUgcmVzdWx0cyBkdWUgdG8gbWlzc2luZyBoZWFkIHN2biByZXZpc2lvbgpJbmRl eDogVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHJldmlzaW9uIDI1Njg1MykK KysrIFRvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCSh3b3JraW5nIGNvcHkp CkBAIC00MDMsNiArNDAzLDcgQEAgc3ViIGNvbmZpZ3VyYXRpb25Gb3JVcGxvYWQoKQogICAgICAg ICAkcGxhdGZvcm0gPSAnd2luJzsKICAgICAgICAgaWYgKCEkdmVyc2lvbikgewogICAgICAgICAg ICAgJHZlcnNpb24gPSB3aW5WZXJzaW9uKCk7CisgICAgICAgICAgICAkdmVyc2lvbk5hbWUgPSAi V2luJHZlcnNpb24tPntzdWJtaW5vcn0iOwogICAgICAgICB9CiAgICAgfSBlbHNpZiAoaXNBcHBs ZU1hY1dlYktpdCgpKSB7CiAgICAgICAgICRwbGF0Zm9ybSA9ICdtYWMnOwpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQkocmV2aXNpb24gMjU2ODUzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CSh3b3JraW5nIGNvcHkpCkBAIC0xMzY5LDEyICsxMzY5LDEyIEBAIHN1YiBkZXRlcm1pbmVXaW5W ZXJzaW9uKCkKICAgICB9CiAKICAgICBteSAkdmVyc2lvblN0cmluZyA9IGBjbWQgL2MgdmVyYDsK LSAgICAkdmVyc2lvblN0cmluZyA9fiAvKFxkKVwuKFxkKVwuKFxkKykvOworICAgICR2ZXJzaW9u U3RyaW5nID1+IC8oXGQrKVwuKFxkKylcLihcZCspLzsKIAogICAgICR3aW5WZXJzaW9uID0gewog ICAgICAgICBtYWpvciA9PiAkMSwKICAgICAgICAgbWlub3IgPT4gJDIsCi0gICAgICAgIGJ1aWxk ID0+ICQzLAorICAgICAgICBzdWJtaW5vciA9PiAkMywKICAgICB9OwogfQogCg== 391160 2020-02-19 07:38:50 -0800 2020-02-19 08:37:40 -0800 Patch for landing bug-207910-20200219073850.patch text/plain 1786 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjkxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENvcnJlY3RseSByZXBvcnQgSlNDIHRl c3RzIGZvciB3aW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDc5MTAKKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBYWthc2ggSmFpbi4K KworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzOgorICAgICAgICAo Y29uZmlndXJhdGlvbkZvclVwbG9hZCk6IEdpdmUgV2luZG93cyBhIHZlcnNpb24gbmFtZS4KKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVXaW5WZXJz aW9uKTogQ29ycmVjdGx5IHBhcnNlIFdpbmRvd3MgMTAgdmVyc2lvbiBudW1iZXJzLCBjb25mb3Jt IHRvCisgICAgICAgIFZlcnNpb24gZGljdGlvbmFyeS4KKwogMjAyMC0wMi0xOCAgWmFuIERvYmVy c2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gU3VwcG9ydCAyRCBh eGlzLCBzbW9vdGgtbW90aW9uIGV2ZW50cwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNj cmlwdGNvcmUtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlw dGNvcmUtdGVzdHMJKHJldmlzaW9uIDI1NjkxNykKKysrIFRvb2xzL1NjcmlwdHMvcnVuLWphdmFz Y3JpcHRjb3JlLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC00MDMsNiArNDAzLDcgQEAgc3ViIGNv bmZpZ3VyYXRpb25Gb3JVcGxvYWQoKQogICAgICAgICAkcGxhdGZvcm0gPSAnd2luJzsKICAgICAg ICAgaWYgKCEkdmVyc2lvbikgewogICAgICAgICAgICAgJHZlcnNpb24gPSB3aW5WZXJzaW9uKCk7 CisgICAgICAgICAgICAkdmVyc2lvbk5hbWUgPSAiV2luJHZlcnNpb24tPntzdWJtaW5vcn0iOwog ICAgICAgICB9CiAgICAgfSBlbHNpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgICAgICRw bGF0Zm9ybSA9ICdtYWMnOwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMjU2OTE3KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzY5LDEy ICsxMzY5LDEyIEBAIHN1YiBkZXRlcm1pbmVXaW5WZXJzaW9uKCkKICAgICB9CiAKICAgICBteSAk dmVyc2lvblN0cmluZyA9IGBjbWQgL2MgdmVyYDsKLSAgICAkdmVyc2lvblN0cmluZyA9fiAvKFxk KVwuKFxkKVwuKFxkKykvOworICAgICR2ZXJzaW9uU3RyaW5nID1+IC8oXGQrKVwuKFxkKylcLihc ZCspLzsKIAogICAgICR3aW5WZXJzaW9uID0gewogICAgICAgICBtYWpvciA9PiAkMSwKICAgICAg ICAgbWlub3IgPT4gJDIsCi0gICAgICAgIGJ1aWxkID0+ICQzLAorICAgICAgICBzdWJtaW5vciA9 PiAkMywKICAgICB9OwogfQogCg==