207905 2020-02-18 12:52:35 -0800 Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called 2020-02-18 16:22:52 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195954 https://bugs.webkit.org/show_bug.cgi?id=207908 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren nham webkit-bug-importer oldest_to_newest 1620278 0 cdumez 2020-02-18 12:52:35 -0800 Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called. It is bad for performance as we cannot leverage the process cache if we don't know the domain of the site that will be loaded. Instead we now queue those injected bundle messages until we really need to launch the process. 1620282 1 391078 cdumez 2020-02-18 12:55:16 -0800 Created attachment 391078 Patch 1620421 2 391078 commit-queue 2020-02-18 16:21:54 -0800 Comment on attachment 391078 Patch Clearing flags on attachment: 391078 Committed r256882: <https://trac.webkit.org/changeset/256882> 1620422 3 commit-queue 2020-02-18 16:21:55 -0800 All reviewed patches have been landed. Closing bug. 1620424 4 webkit-bug-importer 2020-02-18 16:22:52 -0800 <rdar://problem/59571018> 391078 2020-02-18 12:55:16 -0800 2020-02-18 16:21:54 -0800 Patch bug-207905-20200218125515.patch text/plain 4359 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4YWZmZWU2NzcyYTBlNDQw NTU4ODY2ZjdmNTMwOGI2ZWU5YmUxNTEuLmM3NDFmMTkzNTk0YWRjNmM5M2FiODZiMWFiNjI0N2Ri MjdmMTMzOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDItMTggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEbyBub3QgZWFnZXJseSBsYXVuY2gg V2ViUHJvY2VzcyB3aGVuIFdLUGFnZVBvc3RNZXNzYWdlVG9JbmplY3RlZEJ1bmRsZSgpIGlzIGNh bGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3 OTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8g bm90IGVhZ2VybHkgbGF1bmNoIFdlYlByb2Nlc3Mgd2hlbiBXS1BhZ2VQb3N0TWVzc2FnZVRvSW5q ZWN0ZWRCdW5kbGUoKSBpcyBjYWxsZWQuIEl0IGlzIGJhZCBmb3IKKyAgICAgICAgcGVyZm9ybWFu Y2UgYXMgd2UgY2Fubm90IGxldmVyYWdlIHRoZSBwcm9jZXNzIGNhY2hlIGlmIHdlIGRvbid0IGtu b3cgdGhlIGRvbWFpbiBvZiB0aGUgc2l0ZSB0aGF0CisgICAgICAgIHdpbGwgYmUgbG9hZGVkLgor CisgICAgICAgIEluc3RlYWQgd2Ugbm93IHF1ZXVlIHRob3NlIGluamVjdGVkIGJ1bmRsZSBtZXNz YWdlcyB1bnRpbCB3ZSByZWFsbHkgbmVlZCB0byBsYXVuY2ggdGhlIHByb2Nlc3MuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBXZWJLaXRUZXN0UnVubmVyIGV4dGVuc2l2ZWx5IHJlbGllcyBvbiB0 aGlzIHByaXZhdGUgQVBJIGFscmVhZHksIGFuZCB3YXMgdGhlCisgICAgICAgIHJlYXNvbiB3ZSBk aWQgdGhlIGVhZ2VyIHByb2Nlc3MgbGF1bmNoIGluIHRoZSBmaXJzdCBwbGFjZSAoaHR0cHM6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI0MzE1NikuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpsYXVuY2hQ cm9jZXNzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisKIDIwMjAtMDIt MTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjU0ODczLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggNTBlYmVmZDUyM2IwNmJlMmVjNjVlMWYyOTE2N2UxNzEz MzIzZDlkZi4uMDE5M2NlMzRmOGNkYWJkMGE1YWRkZWU0MWUxMDRjYWI0YjYzYTI2OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC03NzYsNiArNzc2LDEwIEBA IHZvaWQgV2ViUGFnZVByb3h5OjpsYXVuY2hQcm9jZXNzKGNvbnN0IFJlZ2lzdHJhYmxlRG9tYWlu JiByZWdpc3RyYWJsZURvbWFpbiwgUHJvCiAgICAgbV9wcm9jZXNzLT5hZGRNZXNzYWdlUmVjZWl2 ZXIoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3dlYlBh Z2VJRCwgKnRoaXMpOwogCiAgICAgZmluaXNoQXR0YWNoaW5nVG9XZWJQcm9jZXNzKHJlYXNvbik7 CisKKyAgICBhdXRvIHBlbmRpbmdJbmplY3RlZEJ1bmRsZU1lc3NhZ2UgPSBXVEZNb3ZlKG1fcGVu ZGluZ0luamVjdGVkQnVuZGxlTWVzc2FnZXMpOworICAgIGZvciAoYXV0byYgbWVzc2FnZSA6IHBl bmRpbmdJbmplY3RlZEJ1bmRsZU1lc3NhZ2UpCisgICAgICAgIHNlbmQoTWVzc2FnZXM6OldlYlBh Z2U6OlBvc3RJbmplY3RlZEJ1bmRsZU1lc3NhZ2UobWVzc2FnZS5tZXNzYWdlTmFtZSwgVXNlckRh dGEocHJvY2VzcygpLnRyYW5zZm9ybU9iamVjdHNUb0hhbmRsZXMobWVzc2FnZS5tZXNzYWdlQm9k eS5nZXQoKSkuZ2V0KCkpKSk7CiB9CiAKIGJvb2wgV2ViUGFnZVByb3h5OjpzdXNwZW5kQ3VycmVu dFBhZ2VJZlBvc3NpYmxlKEFQSTo6TmF2aWdhdGlvbiYgbmF2aWdhdGlvbiwgT3B0aW9uYWw8RnJh bWVJZGVudGlmaWVyPiBtYWluRnJhbWVJRCwgUHJvY2Vzc1N3YXBSZXF1ZXN0ZWRCeUNsaWVudCBw cm9jZXNzU3dhcFJlcXVlc3RlZEJ5Q2xpZW50LCBTaG91bGREZWxheUNsb3NpbmdVbnRpbEVudGVy aW5nQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUgc2hvdWxkRGVsYXlDbG9zaW5nVW50aWxFbnRl cmluZ0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKQpAQCAtNjI4Miw4ICs2Mjg2LDEwIEBAIE5h dGl2ZVdlYk1vdXNlRXZlbnQqIFdlYlBhZ2VQcm94eTo6Y3VycmVudGx5UHJvY2Vzc2VkTW91c2VE b3duRXZlbnQoKQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6cG9zdE1lc3NhZ2VUb0luamVjdGVkQnVu ZGxlKGNvbnN0IFN0cmluZyYgbWVzc2FnZU5hbWUsIEFQSTo6T2JqZWN0KiBtZXNzYWdlQm9keSkK IHsKLSAgICAvLyBGb3IgYmFja3dhcmQtY29tcGF0aWJpbGl0eSwgbWFrZSBzdXJlIHdlIGxhdW5j aCB0aGUgaW5pdGlhbCBwcm9jZXNzIGlmIHRoZSBjbGllbnQgYXNrcyB0byBwb3N0IGEgbWVzc2Fn ZSB0byBpdHMgaW5qZWN0ZWQgYnVuZGxlIGJlZm9yZSBkb2luZyBhIGxvYWQuCi0gICAgbGF1bmNo SW5pdGlhbFByb2Nlc3NJZk5lY2Vzc2FyeSgpOworICAgIGlmICghaGFzUnVubmluZ1Byb2Nlc3Mo KSkgeworICAgICAgICBtX3BlbmRpbmdJbmplY3RlZEJ1bmRsZU1lc3NhZ2VzLmFwcGVuZChJbmpl Y3RlZEJ1bmRsZU1lc3NhZ2UgeyBtZXNzYWdlTmFtZSwgbWVzc2FnZUJvZHkgfSk7CisgICAgICAg IHJldHVybjsKKyAgICB9CiAKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpQb3N0SW5qZWN0 ZWRCdW5kbGVNZXNzYWdlKG1lc3NhZ2VOYW1lLCBVc2VyRGF0YShwcm9jZXNzKCkudHJhbnNmb3Jt T2JqZWN0c1RvSGFuZGxlcyhtZXNzYWdlQm9keSkuZ2V0KCkpKSk7CiB9CkBAIC05NjAxLDcgKzk2 MDcsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Y2xlYXJBZENsaWNrQXR0cmlidXRpb24oQ29tcGxl dGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNvbXBsZXRpbwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAgICAgICAgIG5ldHdvcmtQcm9jZXNzLT5zZW5kV2l0aEFzeW5jUmVwbHkoTWVzc2Fn ZXM6Ok5ldHdvcmtQcm9jZXNzOjpDbGVhckFkQ2xpY2tBdHRyaWJ1dGlvbihtX3dlYnNpdGVEYXRh U3RvcmUtPnNlc3Npb25JRCgpKSwgV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwotICAgIH0K KyAgICB9IGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoKTsKIH0KIAogdm9pZCBXZWJQ YWdlUHJveHk6OnNldEFkQ2xpY2tBdHRyaWJ1dGlvbk92ZXJyaWRlVGltZXJGb3JUZXN0aW5nKGJv b2wgdmFsdWUsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggNjc4ZjgxYzBkYWZhMGIx YzU3OWM0MjUyNGUyYjY0OWQ1Y2VhZDQxMy4uNjViMDc5MmMyZTNhNjg1MzBjY2RiMGZmMzdmN2Ey MzhmOTMzNWZiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTI3 MTYsNiArMjcxNiwxMiBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0xheWVyVHJlZUZyb3plbkR1 ZVRvU3dpcGVBbmltYXRpb24geyBmYWxzZSB9OwogICAgIAogICAgIFN0cmluZyBtX292ZXJyaWRk ZW5NZWRpYVR5cGU7CisKKyAgICBzdHJ1Y3QgSW5qZWN0ZWRCdW5kbGVNZXNzYWdlIHsKKyAgICAg ICAgU3RyaW5nIG1lc3NhZ2VOYW1lOworICAgICAgICBSZWZQdHI8QVBJOjpPYmplY3Q+IG1lc3Nh Z2VCb2R5OworICAgIH07CisgICAgVmVjdG9yPEluamVjdGVkQnVuZGxlTWVzc2FnZT4gbV9wZW5k aW5nSW5qZWN0ZWRCdW5kbGVNZXNzYWdlczsKICAgICAgICAgCiAjaWYgUExBVEZPUk0oSU9TX0ZB TUlMWSkgJiYgRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKICAgICBzdGQ6OnVuaXF1ZV9wdHI8 V2ViRGV2aWNlT3JpZW50YXRpb25VcGRhdGVQcm92aWRlclByb3h5PiBtX3dlYkRldmljZU9yaWVu dGF0aW9uVXBkYXRlUHJvdmlkZXJQcm94eTsK