207897 2020-02-18 10:38:15 -0800 [iOS] Use one telemetry decoration for each sandbox rule 2020-02-24 15:19:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1620215 0 pvollan 2020-02-18 10:38:15 -0800 Currently, we are using the decorations '(with telemetry)' and '(with telemetry-backtrace)' for some sandbox rules in the WebContent process' sandbox. Only one of the two decorations should be used. 1620218 1 391065 pvollan 2020-02-18 10:40:58 -0800 Created attachment 391065 Patch 1620219 2 webkit-bug-importer 2020-02-18 10:41:44 -0800 <rdar://problem/59556086> 1622286 3 391065 bfulgham 2020-02-24 13:17:20 -0800 Comment on attachment 391065 Patch r=me 1622293 4 391065 pvollan 2020-02-24 13:37:33 -0800 Comment on attachment 391065 Patch Thanks for reviewing! 1622326 5 commit-queue 2020-02-24 14:31:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 391065: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. 1622329 6 commit-queue 2020-02-24 14:32:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 391065: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1622347 7 commit-queue 2020-02-24 15:03:06 -0800 The commit-queue encountered the following flaky tests while processing attachment 391065: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1622350 8 commit-queue 2020-02-24 15:03:23 -0800 The commit-queue encountered the following flaky tests while processing attachment 391065: editing/spelling/spellcheck-paste-disabled.html bug 208159 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch. 1622356 9 391065 commit-queue 2020-02-24 15:19:04 -0800 Comment on attachment 391065 Patch Clearing flags on attachment: 391065 Committed r257264: <https://trac.webkit.org/changeset/257264> 1622357 10 commit-queue 2020-02-24 15:19:06 -0800 All reviewed patches have been landed. Closing bug. 391065 2020-02-18 10:40:58 -0800 2020-02-24 15:19:04 -0800 Patch bug-207897-20200218104057.patch text/plain 3066 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTY4MzkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTE4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBVc2Ugb25lIHRlbGVt ZXRyeSBkZWNvcmF0aW9uIGZvciBlYWNoIHNhbmRib3ggcnVsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3ODk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCB3ZSBhcmUgdXNpbmcgdGhl IGRlY29yYXRpb25zICcod2l0aCB0ZWxlbWV0cnkpJyBhbmQgJyh3aXRoIHRlbGVtZXRyeS1iYWNr dHJhY2UpJyBmb3Igc29tZSBzYW5kYm94IHJ1bGVzCisgICAgICAgIGluIHRoZSBXZWJDb250ZW50 IHByb2Nlc3MnIHNhbmRib3guIE9ubHkgb25lIG9mIHRoZSB0d28gZGVjb3JhdGlvbnMgc2hvdWxk IGJlIHVzZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuc2I6CisKIDIwMjAtMDItMTggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgW1VJRGV2aWNlIGN1cnJlbnREZXZpY2VdIGNhbGxz IHRvIFVJIHByb2Nlc3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LnNiCShyZXZpc2lvbiAyNTY3NzgpCisrKyBTb3VyY2UvV2ViS2l0L1Jlc291 cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgko d29ya2luZyBjb3B5KQpAQCAtMTE1LDcgKzExNSw3IEBACiAgICAgICAgIChhbGxvdyBmaWxlLXJl YWQqIGFzc2V0LWFjY2Vzcy1maWx0ZXIpCiAgICAgICAgIChpZiAobWVtcSAnd2l0aC1tZWRpYS1w bGF5YmFjayBvcHRpb25zKQogICAgICAgICAgICAgKHBsYXktbWVkaWEgYXNzZXQtYWNjZXNzLWZp bHRlcikpCi0gICAgICAgIChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0ZWxlbWV0cnktYmFja3Ry YWNlKSAod2l0aCB0ZWxlbWV0cnkpCisgICAgICAgIChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0 ZWxlbWV0cnktYmFja3RyYWNlKQogICAgICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBw bGUubW9iaWxlYXNzZXRkIiAiY29tLmFwcGxlLm1vYmlsZWFzc2V0ZC52MiIpKQogICAgICAgICAo bW9iaWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5Nb2JpbGVBc3NldCIpKSkKIApAQCAt MzUzLDcgKzM1Myw3IEBACiAgICAgICAgICJjb20uYXBwbGUubXQiCiAgICAgICAgICJjb20uYXBw bGUucHJlZmVyZW5jZXMuc291bmRzIikKIAotICAgIChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0 ZWxlbWV0cnktYmFja3RyYWNlKSAod2l0aCB0ZWxlbWV0cnkpCisgICAgKGFsbG93IG1hY2gtbG9v a3VwICh3aXRoIHRlbGVtZXRyeS1iYWNrdHJhY2UpCiAgICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmZyb250Ym9hcmQuc3lzdGVtYXBwc2VydmljZXMiKSAgICAgICAgICAgICAgICAgOyAt W1VJVmlld1NlcnZpY2VJbnRlcmZhY2UgX2NyZWF0ZVByb2Nlc3NBc3NlcnRpb25dIC0+IFNCU1By b2Nlc3NJREZvckRpc3BsYXlJZGVudGlmaWVyKCkKICAgICApCiAKQEAgLTU0NCw3ICs1NDQsNyBA QAogKGFsbG93IGlwYy1wb3NpeC1zaG0tcmVhZCoKICAgICAgICAoaXBjLXBvc2l4LW5hbWUtcHJl Zml4ICJhcHBsZS5jZnByZWZzLiIpKQogIAotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHRlbGVt ZXRyeS1iYWNrdHJhY2UpICh3aXRoIHRlbGVtZXRyeSkKKyhhbGxvdyBtYWNoLWxvb2t1cCAod2l0 aCB0ZWxlbWV0cnktYmFja3RyYWNlKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxzZC5v cGVuIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sc2QubWFwZGIiKSkKIApAQCAtNjY5 LDcgKzY2OSw3IEBACiA7OyA8cmRhcjovL3Byb2JsZW0vNzM0NDcxOSYyNjMyMzQ0OT4gTGF1bmNo U2VydmljZXMgYXBwIGljb25zCiAoYWxsb3cgZmlsZS1yZWFkKgogICAgICh3ZWxsLWtub3duLXN5 c3RlbS1ncm91cC1jb250YWluZXItc3VicGF0aCAiL3N5c3RlbWdyb3VwLmNvbS5hcHBsZS5sc2Qu aWNvbnNjYWNoZSIpKQotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHRlbGVtZXRyeS1iYWNrdHJh Y2UpICh3aXRoIHRlbGVtZXRyeSkKKyhhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0ZWxlbWV0cnkt YmFja3RyYWNlKQogICAgICh4cGMtc2VydmljZS1uYW1lICJjb20uYXBwbGUuaWNvbnNlcnZpY2Vz IikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5pY29uc2VydmljZXMiKSkKIApAQCAtODI4 LDcgKzgyOCw3IEBACiAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxl bWV0cnkpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUud2ViaW5zcGVjdG9yIikpCiAK LShhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0ZWxlbWV0cnktYmFja3RyYWNlKSAod2l0aCB0ZWxl bWV0cnkpCisoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkKICAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5Qb3dlck1hbmFnZW1lbnQuY29udHJvbCIpKQogCiAo ZGVueSBmaWxlLXdyaXRlLWNyZWF0ZSAodm5vZGUtdHlwZSBTWU1MSU5LKSkK