207724 2020-02-13 15:01:57 -0800 [iOS] ASSERTION FAILED: index == indexComputedByVisiblePosition in HTMLTextFormControlElement::indexForPosition() 2022-02-09 10:14:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build iPhone / iPad iOS 13 ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=128806 https://bugs.webkit.org/show_bug.cgi?id=207725 https://bugs.webkit.org/show_bug.cgi?id=205706 InRadar P2 Normal --- 205706 1 dbates dbates cdumez esprehn+autocc ews-watchlist gyuyoung.kim mifenton pvollan webkit-bug-importer oldest_to_newest 1618726 0 dbates 2020-02-13 15:01:57 -0800 Steps to repro: 1. Visit <data:text/html,<input placeholder="placeholder" oninput="this.selectionStart">> 2. Tap field. 3. Press ‘h’ on the keyboard. 1618728 1 dbates 2020-02-13 15:05:08 -0800 Assert is always incorrect because of FIXME in HTMLTextFormControlElement::indexForPosition(). Well, FIXME is correct: [[ index = std::min(index, length); // FIXME: We shouldn't have to call innerTextValue() just to ignore the last LF. See finishText. ]] <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp?rev=256197#L652> but doesn't explain why. innerTextValue() is wrong because it represents the AFTER insertion value of the field. But the passed position is BEFORE insertion. So, guaranteed mismatch if indexForPosition() is called when the text input event is dispatched. 1618730 2 dbates 2020-02-13 15:06:03 -0800 I am just going to get rid of the assert because I would need to study the code to actually fix it up. The code has had the original FIXME since it was written in 2014! 1618733 3 390692 dbates 2020-02-13 15:10:48 -0800 Created attachment 390692 Patch 1618735 4 390692 pvollan 2020-02-13 15:11:42 -0800 Comment on attachment 390692 Patch R=me. 1618741 5 dbates 2020-02-13 15:19:44 -0800 <rdar://problem/59435896> 390692 2020-02-13 15:10:48 -0800 2020-02-13 15:11:42 -0800 Patch bug-207724-20200213151047.patch text/plain 2706 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q1NWQ5MTliODkxMGY4 ZDA1MWY1NWU2ZTc5YmM4ZDQ4NGE4NzBlMS4uODBhMTRhZTRjOTQ2ZGIzMzU1ZjcwZjQzZTQ3OGYw NDExYzAxNDU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAyLTEzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBU1NFUlRJT04g RkFJTEVEOiBpbmRleCA9PSBpbmRleENvbXB1dGVkQnlWaXNpYmxlUG9zaXRpb24gaW4gSFRNTFRl eHRGb3JtQ29udHJvbEVsZW1lbnQ6OmluZGV4Rm9yUG9zaXRpb24oKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3NzI0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIG5vdywgcmVtb3ZlIGFuIGFzc2Vy dCB0aGF0IHdpbGwgYWx3YXlzIGZhaWwgYXMgaXQgY29tcGFyZXMgdGhlIGluZGV4IG9mIHRoZSBw cmUtCisgICAgICAgIGluc2VydGlvbiBwb3NpdGlvbiB3aXRoIHRoZSBpbmRleCBhZnRlciBpbnNl cnRpb24uIFRvIGFkZCBiYWNrIHRoZSBhc3NlcnQgd2UgZmlyc3QgbmVlZAorICAgICAgICB0byBh ZGRyZXNzIHRoZSBvcmlnaW5hbCBGSVhNRSBhZGRlZCBpbiAyMDE0LgorCisgICAgICAgIFRoZSBh c3NlcnRpb24gY2FuIGJlIHRyaWdnZXJlZCB0cml2aWFsbHkgb24gaU9TOgorCisgICAgICAgICAg ICBMb2FkIDxkYXRhOnRleHQvaHRtbCw8aW5wdXQgcGxhY2Vob2xkZXI9InBsYWNlaG9sZGVyIiBv bmlucHV0PSJ0aGlzLnNlbGVjdGlvblN0YXJ0Ij4+LgorICAgICAgICAgICAgVGFwIHRoZSBmaWVs ZCB0aGVuIHByZXNzIGFueSBsZXR0ZXIgb24gdGhlIGtleWJvYXJkLgorCisKKyAgICAgICAgKiBo dG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjppbmRleEZvclBvc2l0aW9uIGNvbnN0KToKKwogMjAy MC0wMi0xMyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW5hbWUgU2VyaWFsaXplZFBsYXRmb3JtUmVwcmVzZW50YXRpb24gdG8gU2VyaWFsaXplZFBs YXRmb3JtRGF0YUN1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZv cm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNv bnRyb2xFbGVtZW50LmNwcAppbmRleCBmZjRlOWQ5ODBiYTNjZDZmZmFlZTgyYjFjNmQ4MDgyZjNh MjY1ZTJkLi4zODc3Y2M1ZWI2ZjdiYThjMTQzMzI0ZmZlNzgxZDg0NThlMDExNjAxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcApA QCAtNjU1LDE0ICs2NTUsOCBAQCB1bnNpZ25lZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6 aW5kZXhGb3JQb3NpdGlvbihjb25zdCBQb3NpdGlvbiYgcGFzc2VkUG9zaQogCiAgICAgdW5zaWdu ZWQgbGVuZ3RoID0gaW5uZXJUZXh0VmFsdWUoKS5sZW5ndGgoKTsKICAgICBpbmRleCA9IHN0ZDo6 bWluKGluZGV4LCBsZW5ndGgpOyAvLyBGSVhNRTogV2Ugc2hvdWxkbid0IGhhdmUgdG8gY2FsbCBp bm5lclRleHRWYWx1ZSgpIGp1c3QgdG8gaWdub3JlIHRoZSBsYXN0IExGLiBTZWUgZmluaXNoVGV4 dC4KLSNpZiBBU1NFUlRfRU5BQkxFRAotICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlUG9zaXRp b24gPSBwYXNzZWRQb3NpdGlvbjsKLSAgICBpZiAodmlzaWJsZVBvc2l0aW9uLmlzTm90TnVsbCgp KSB7Ci0gICAgICAgIHVuc2lnbmVkIGluZGV4Q29tcHV0ZWRCeVZpc2libGVQb3NpdGlvbiA9IFdl YkNvcmU6OmluZGV4Rm9yVmlzaWJsZVBvc2l0aW9uKCppbm5lclRleHQsIHZpc2libGVQb3NpdGlv biwKLSAgICAgICAgICAgIHsgVGV4dEl0ZXJhdG9yTGVuZ3RoT3B0aW9uOjpHZW5lcmF0ZVNwYWNl c0ZvclJlcGxhY2VkRWxlbWVudHMsIFRleHRJdGVyYXRvckxlbmd0aE9wdGlvbjo6SWdub3JlVmlz aWJpbGl0eSB9KTsKLSAgICAgICAgQVNTRVJUKGluZGV4ID09IGluZGV4Q29tcHV0ZWRCeVZpc2li bGVQb3NpdGlvbik7Ci0gICAgfQotI2VuZGlmCisgICAgLy8gRklYTUU6IEFzc2VydCB0aGF0IGlu ZGV4ID09IFdlYkNvcmU6OmluZGV4Rm9yVmlzaWJsZVBvc2l0aW9uKCppbm5lclRleHQsIHBhc3Nl ZFBvc2l0aW9uLCB7IFRleHRJdGVyYXRvckxlbmd0aE9wdGlvbjo6R2VuZXJhdGVTcGFjZXNGb3JS ZXBsYWNlZEVsZW1lbnRzLCBUZXh0SXRlcmF0b3JMZW5ndGhPcHRpb246Oklnbm9yZVZpc2liaWxp dHkgfQorICAgIC8vIG9uY2UgdGhlIGFib3ZlIEZJWE1FIGlzIGZpeGVkLiBPdGhlcndpc2UsIHRo ZSBhc3NlcnQgY2FuIHRyaXZpYWxseSBmYWlsIG9uIGlPUyAoZS5nLiB0eXBlIGludG8gPGlucHV0 IHBsYWNlaG9sZGVyPSJwbGFjZWhvbGRlciIgb25pbnB1dD0idGhpcy5zZWxlY3Rpb25TdGFydCI+ KS4KICAgICByZXR1cm4gaW5kZXg7CiB9CiAK