207492 2020-02-10 12:12:25 -0800 [ews] Use SetBuildSummary instead of buildFinished in Layout tests 2020-02-19 07:41:55 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1617023 0 aakash_jain 2020-02-10 12:12:25 -0800 [ews] Use SetBuildSummary instead of buildFinished in Layout tests to set custom build summary. buildFinished() method finishes the build immediately, while it might not be desirable in some cases/factories. We added SetBuildSummary build step in https://bugs.webkit.org/show_bug.cgi?id=207026 for this purpose. We are using that for webkitpy tests. We should start using that that in layout-tests as well. 1617024 1 390282 aakash_jain 2020-02-10 12:14:14 -0800 Created attachment 390282 Patch 1617025 2 aakash_jain 2020-02-10 12:17:08 -0800 Sample runs: No failures: https://ews-build.webkit-uat.org/#/builders/16/builds/76 Flaky failures: https://ews-build.webkit-uat.org/#/builders/16/builds/80 pre-existing test failures: https://ews-build.webkit-uat.org/#/builders/16/builds/82 1617053 3 aakash_jain 2020-02-10 13:14:42 -0800 Committed r256206: <https://trac.webkit.org/changeset/256206> 1617055 4 webkit-bug-importer 2020-02-10 13:15:16 -0800 <rdar://problem/59322779> 390282 2020-02-10 12:14:14 -0800 2020-02-10 13:11:21 -0800 Patch bug-207492-20200210151413.patch text/plain 3060 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjE5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTAyLTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBVc2UgU2V0QnVpbGRTdW1tYXJ5IGluc3RlYWQgb2YgYnVpbGRG aW5pc2hlZCBpbiBMYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Ogor ICAgICAgICAoUnVuV2ViS2l0VGVzdHMuZXZhbHVhdGVDb21tYW5kKToKKyAgICAgICAgKFJlUnVu V2ViS2l0VGVzdHMuZXZhbHVhdGVDb21tYW5kKToKKyAgICAgICAgKEFuYWx5emVMYXlvdXRUZXN0 c1Jlc3VsdHMucmVwb3J0X3ByZV9leGlzdGluZ19mYWlsdXJlcyk6CisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKyAgICAgICAgKFRlc3RGYWN0b3J5 Ll9faW5pdF9fKToKKwogMjAyMC0wMi0xMCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTYwOTEuCkluZGV4OiBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHJldmlz aW9uIDI1NjE5OSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3Jp ZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTExMyw2ICsxMTMsNyBAQCBjbGFzcyBUZXN0RmFjdG9y eShGYWN0b3J5KToKICAgICAgICAgc2VsZi5hZGRTdGVwKEtpbGxPbGRQcm9jZXNzZXMoKSkKICAg ICAgICAgaWYgc2VsZi5MYXlvdXRUZXN0Q2xhc3M6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAo c2VsZi5MYXlvdXRUZXN0Q2xhc3MoKSkKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChTZXRCdWls ZFN1bW1hcnkoKSkKICAgICAgICAgaWYgc2VsZi5BUElUZXN0Q2xhc3M6CiAgICAgICAgICAgICBz ZWxmLmFkZFN0ZXAoc2VsZi5BUElUZXN0Q2xhc3MoKSkKIApJbmRleDogVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjU2MTk5KQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x NDM0LDcgKzE0MzQsNyBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAg ICAgICAgIG1lc3NhZ2UgPSAnUGFzc2VkIGxheW91dCB0ZXN0cycKICAgICAgICAgICAgIHNlbGYu ZGVzY3JpcHRpb25Eb25lID0gbWVzc2FnZQogICAgICAgICAgICAgc2VsZi5idWlsZC5yZXN1bHRz ID0gU1VDQ0VTUwotICAgICAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFttZXNzYWdl XSwgU1VDQ0VTUykKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkX3N1bW1hcnkn LCBtZXNzYWdlKQogICAgICAgICBlbHNlOgogICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRTdGVw c0FmdGVyQ3VycmVudFN0ZXAoWwogICAgICAgICAgICAgICAgIEFyY2hpdmVUZXN0UmVzdWx0cygp LApAQCAtMTQ3NSw3ICsxNDc1LDcgQEAgY2xhc3MgUmVSdW5XZWJLaXRUZXN0cyhSdW5XZWJLaXRU ZXN0cyk6CiAgICAgICAgICAgICBzZWxmLmJ1aWxkLnJlc3VsdHMgPSBTVUNDRVNTCiAgICAgICAg ICAgICBpZiBub3QgZmlyc3RfcmVzdWx0c19kaWRfZXhjZWVkX3Rlc3RfZmFpbHVyZV9saW1pdDoK ICAgICAgICAgICAgICAgICBtZXNzYWdlID0gJ0ZvdW5kIGZsYWt5IHRlc3RzOiB7fScuZm9ybWF0 KGZsYWt5X2ZhaWx1cmVzX3N0cmluZykKLSAgICAgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5p c2hlZChbbWVzc2FnZV0sIFNVQ0NFU1MpCisgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdi dWlsZF9zdW1tYXJ5JywgbWVzc2FnZSkKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHNlbGYu c2V0UHJvcGVydHkoJ3BhdGNoRmFpbGVkVGVzdHMnLCBUcnVlKQogICAgICAgICAgICAgc2VsZi5i dWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0FyY2hpdmVUZXN0UmVzdWx0cygpLApAQCAt MTU0NSw3ICsxNTQ1LDcgQEAgY2xhc3MgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhidWlsZHN0 ZQogICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKGNsZWFuX3RyZWVfZmFpbHVyZXMp ID4gMSBlbHNlICcnCiAgICAgICAgIGNsZWFuX3RyZWVfZmFpbHVyZXNfc3RyaW5nID0gJywgJy5q b2luKFtmYWlsdXJlX25hbWUgZm9yIGZhaWx1cmVfbmFtZSBpbiBjbGVhbl90cmVlX2ZhaWx1cmVz XSkKICAgICAgICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBwcmUtZXhpc3RpbmcgdGVzdCBmYWlsdXJl e306IHt9Jy5mb3JtYXQobGVuKGNsZWFuX3RyZWVfZmFpbHVyZXMpLCBwbHVyYWxTdWZmaXgsIGNs ZWFuX3RyZWVfZmFpbHVyZXNfc3RyaW5nKQotICAgICAgICBzZWxmLmJ1aWxkLmJ1aWxkRmluaXNo ZWQoW21lc3NhZ2VdLCBTVUNDRVNTKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZF9z dW1tYXJ5JywgbWVzc2FnZSkKICAgICAgICAgcmV0dXJuIGRlZmVyLnN1Y2NlZWQoTm9uZSkKIAog ICAgIGRlZiByZXRyeV9idWlsZChzZWxmLCBtZXNzYWdlPScnKToK