207464 2020-02-10 08:37:11 -0800 Crash under WebProcessProxy::shouldSendPendingMessage() 2020-02-10 09:57:37 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren koivisto webkit-bug-importer youennf oldest_to_newest 1616875 0 cdumez 2020-02-10 08:37:11 -0800 Crash under WebProcessProxy::shouldSendPendingMessage(): Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000018) [ 0] 0x000000019713ef68 WebKit`WebKit::WebProcessProxy::shouldSendPendingMessage(WebKit::AuxiliaryProcessProxy::PendingMessage const&) [inlined] IPC::Encoder::messageName() const at Encoder.h:46:50 42 Encoder(StringReference messageReceiverName, StringReference messageName, uint64_t destinationID); 43 ~Encoder(); 44 45 StringReference messageReceiverName() const { return m_messageReceiverName; } -> 46 StringReference messageName() const { return m_messageName; } 47 uint64_t destinationID() const { return m_destinationID; } 48 49 void setIsSyncMessage(bool); 50 bool isSyncMessage() const; 0x000000019713ef58: stp x29, x30, [sp, #0x40] 0x000000019713ef5c: add x29, sp, #0x40 ; =0x40 0x000000019713ef60: sub sp, sp, #0x380 ; =0x380 0x000000019713ef64: ldr x19, [x1] -> 0x000000019713ef68: ldr x8, [x19, #0x18] 0x000000019713ef6c: cmp x8, #0x22 ; =0x22 0x000000019713ef70: b.ne 0x2e1f90 ; <+76> at WebProcessProxy.cpp 0x000000019713ef74: mov x20, x0 0x000000019713ef78: ldr x0, [x19, #0x10] [ 0] 0x000000019713ef68 WebKit`WebKit::WebProcessProxy::shouldSendPendingMessage(WebKit::AuxiliaryProcessProxy::PendingMessage const&) + 36 at WebProcessProxy.cpp:331 327 328 bool WebProcessProxy::shouldSendPendingMessage(const PendingMessage& message) 329 { 330 #if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) -> 331 if (message.encoder->messageName() == "LoadRequestWaitingForProcessLaunch") { 332 auto buffer = message.encoder->buffer(); 333 auto bufferSize = message.encoder->bufferSize(); 334 std::unique_ptr<IPC::Decoder> decoder = makeUnique<IPC::Decoder>(buffer, bufferSize, nullptr, Vector<IPC::Attachment> { }); 335 LoadParameters loadParameters; [ 1] 0x0000000197081553 WebKit`WebKit::AuxiliaryProcessProxy::didFinishLaunching(WebKit::ProcessLauncher*, IPC::Connection::Identifier) + 295 at AuxiliaryProcessProxy.cpp:217:14 213 connectionWillOpen(*m_connection); 214 m_connection->open(); 215 216 for (auto&& pendingMessage : std::exchange(m_pendingMessages, { })) { -> 217 if (!shouldSendPendingMessage(pendingMessage)) 218 continue; 219 auto encoder = WTFMove(pendingMessage.encoder); 220 auto sendOptions = pendingMessage.sendOptions; 221 if (pendingMessage.asyncReplyInfo) [ 2] 0x0000000197081553 WebKit`WebKit::AuxiliaryProcessProxy::didFinishLaunching(WebKit::ProcessLauncher*, IPC::Connection::Identifier) + 295 at AuxiliaryProcessProxy.cpp:217:14 213 connectionWillOpen(*m_connection); 214 m_connection->open(); 215 216 for (auto&& pendingMessage : std::exchange(m_pendingMessages, { })) { -> 217 if (!shouldSendPendingMessage(pendingMessage)) 218 continue; 219 auto encoder = WTFMove(pendingMessage.encoder); 220 auto sendOptions = pendingMessage.sendOptions; 221 if (pendingMessage.asyncReplyInfo) [ 3] 0x00000001971413cf WebKit`WebKit::WebProcessProxy::didFinishLaunching(WebKit::ProcessLauncher*, IPC::Connection::Identifier) + 99 at WebProcessProxy.cpp:867:28 1616876 1 cdumez 2020-02-10 08:37:21 -0800 <rdar://problem/59293825> 1616878 2 390253 cdumez 2020-02-10 08:40:14 -0800 Created attachment 390253 Patch 1616925 3 commit-queue 2020-02-10 09:56:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 390253: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1616926 4 390253 commit-queue 2020-02-10 09:57:36 -0800 Comment on attachment 390253 Patch Clearing flags on attachment: 390253 Committed r256187: <https://trac.webkit.org/changeset/256187> 1616927 5 commit-queue 2020-02-10 09:57:37 -0800 All reviewed patches have been landed. Closing bug. 390253 2020-02-10 08:40:14 -0800 2020-02-10 09:57:36 -0800 Patch bug-207464-20200210084014.patch text/plain 1744 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUyNTM0ZGE1NWRiZDNmZGFi NDExZjEzZjc3NGU5ZGNlNzI4MDBkZmMuLjM5YWE5NjA1OWNkYzAyOGFhMGI1ZDFiZTg4YzFmZWMy NmM0MWY0ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDItMTAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJQcm9jZXNz UHJveHk6OnNob3VsZFNlbmRQZW5kaW5nTWVzc2FnZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc0NjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU5MjkzODI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEkgc3VzcGVjdCB0aGUgV2ViUHJvY2Vzc1Byb3h5IG9iamVjdCBpcyBnZXR0aW5nIGRlc3Ry b3llZCBhcyB3ZSBhcmUgaXRlcmF0aW5nIG92ZXIgdGhlCisgICAgICAgIHBlbmRpbmcgbWVzc2Fn ZXMgaW4gQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hMYXVuY2hpbmcoKSwgdGh1cyBj cmFzaGluZyB3aGVuCisgICAgICAgIGNhbGxpbmcgV2ViUHJvY2Vzc1Byb3h5OjpzaG91bGRTZW5k UGVuZGluZ01lc3NhZ2UoKSBpbnNpZGUgdGhlIGxvb3AuIEFzIGEgc3BlY3VsYXRpdmUKKyAgICAg ICAgZml4LCBwcm90ZWN0IHx0aGlzfCBhdCB0aGUgYmVnaW5uaW5nIG9mIFdlYlByb2Nlc3NQcm94 eTo6ZGlkRmluaXNoTGF1bmNoaW5nKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vz c1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hM YXVuY2hpbmcpOgorCiAyMDIwLTAyLTEwICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2dlb2xvY2F0aW9uXSBGaXggbm9uLXVuaWZpZWQgYnVp bGQgaXNzdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNz UHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApp bmRleCAzNTZhMmM3NzY5Y2M0NTQ4MzNlNjQyODg1Y2NiMDM4MDQyZjQwNWVjLi44MmM3Y2IwYmU0 NjNmY2Q5MTIxNzE1NWE1ZjcyNGU4ZTI2OWY0ZTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTg5MSw2ICs4OTEsNyBAQCB2b2lkIFdlYlByb2Nl c3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKFByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIElQ Qzo6Q29ubmVjdAogewogICAgIFJFTEVBU0VfQVNTRVJUKGlzTWFpblRocmVhZE9yQ2hlY2tEaXNh YmxlZCgpKTsKIAorICAgIGF1dG8gcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpOwogICAg IEF1eGlsaWFyeVByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKGxhdW5jaGVyLCBjb25u ZWN0aW9uSWRlbnRpZmllcik7CiAKICAgICBpZiAoIUlQQzo6Q29ubmVjdGlvbjo6aWRlbnRpZmll cklzVmFsaWQoY29ubmVjdGlvbklkZW50aWZpZXIpKSB7Cg==