207408 2020-02-07 14:30:58 -0800 Web Inspector: injected scripts for the worlds cleared before normal are lost 2020-02-07 16:55:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED DUPLICATE 207232 P2 Normal --- 1 pfeldman pfeldman cdumez dbates ews-watchlist inspector-bugzilla-changes japhet joepeck oldest_to_newest 1616372 0 pfeldman 2020-02-07 14:30:58 -0800 This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=206110, please see the discussion there. To recap, I believe there is a subtle issue here - when didClearWindowObjectInWorld is called for the User world before it is called for the Normal world, subsequent call to clear the normal world will erase this injected script from the InjectedScriptManager through m_injectedScriptManager->discardInjectedScripts(). This can either be patched via the following change to the dispatchDidClearWindowObjectsInAllWorlds (that is somewhat hacky), or via going back to instrumenting only normal worlds and iterating over the remaining worlds within agents explicitly. 1616419 1 390138 pfeldman 2020-02-07 15:33:42 -0800 Created attachment 390138 Patch 1616427 2 joepeck 2020-02-07 15:44:53 -0800 Was this addressed by bug 207232? https://bugs.webkit.org/show_bug.cgi?id=207232 1616458 3 pfeldman 2020-02-07 16:40:39 -0800 I believe it was! I missed it, thanks! *** This bug has been marked as a duplicate of bug 207232 *** 390138 2020-02-07 15:33:42 -0800 2020-02-07 16:55:11 -0800 Patch bug-207408-20200207153342.patch text/plain 2217 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY1YWYyM2QyZTU4NThh MmZkM2NiZjM3NDg1M2FiOGEzMWRiZWM2Ni4uNTFiOTkyNDVkMmUyM2FiY2VmNmZlNDY4ZjI2YTRk YWE4ZDMyOTI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTA3ICBQYXZl bCBGZWxkbWFuICA8cGF2ZWwuZmVsZG1hbkBnbWFpbC5jb20+CisKKyAgICAgICAgV2ViSW5zcGVj dG9yOiByZXBvcnQgbWFpbiB3b3JsZCBhcyBjbGVhcmVkIGZpcnN0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDc0MDgKKworICAgICAgICBSZXBvcnQg bm9ybWFsIHdvcmxkIGFzIGNsZWFyZWQgYmVmb3JlIHJlcG9ydGluZyBvdGhlciB3b3JsZHMuIE5v cm1hbCB3b3JsZCBjbGVhcmVkCisgICAgICAgIGV2ZW50IGNhbiBiZSAoYW5kIGlzKSB1c2VkIGJ5 IHN1YnN5c3RlbXMgdG8gcmVzZXQgdGhlaXIgc3RhdGUuIFdoZW4gdGhhdCBoYXBwZW5zCisgICAg ICAgIGFmdGVyIG5vbi1ub3JtYWwgd29ybGRzIGFyZSBjbGVhcmVkLCBpbmZvcm1hdGlvbiBhYm91 dCB0aG9zZSB3b3JsZHMgY2FuIGJlIGxvc3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNl IHRoaXMgZGVwZW5kcyBvbiB0aGUgbWFwIGl0ZXJhdGlvbiBvcmRlciBhbmQgaXMgaW5oZXJlbnRs eSByYWN5LgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyOjpkaXNwYXRjaERpZENsZWFyV2luZG93T2JqZWN0c0luQWxsV29y bGRzKToKKwogMjAyMC0wMi0wNyAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgTW92ZSB0cml2aWFsIGRlZmluaXRpb25zIGZyb20gRmVhdHVyZURlZmluZXMueGNjb25m aWcgdG8gUGxhdGZvcm1FbmFibGVDb2NvYS5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAppbmRleCAxMDU1ZDU3MTUyODU0NGQ2MDJiNmE1YmE2OGMxYjdjMTJkMmQ1ODFiLi43MDU0 OTIxZjBlZmE0MzI2ZjZhYTA3ZDMyZGI3ZWU1ZjRhNWNlODFlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAKQEAgLTM5NDgsMTMgKzM5NDgsMTcgQEAgU3RyaW5nIEZyYW1lTG9h ZGVyOjpyZWZlcnJlcigpIGNvbnN0CiAKIHZvaWQgRnJhbWVMb2FkZXI6OmRpc3BhdGNoRGlkQ2xl YXJXaW5kb3dPYmplY3RzSW5BbGxXb3JsZHMoKQogewotICAgIGlmICghbV9mcmFtZS5zY3JpcHQo KS5jYW5FeGVjdXRlU2NyaXB0cyhOb3RBYm91dFRvRXhlY3V0ZVNjcmlwdCkpCi0gICAgICAgIHJl dHVybjsKKyAgICAvLyBJdCBpcyBlc3NlbnRpYWwgdGhhdCB0aGUgbm9ybWFsIHdvcmxkIGlzIGNs ZWFyZWQgZmlyc3QuIFZhcmlvdXMgc3Vic3lzdGVtcworICAgIC8vIChkZWJ1Z2dlciwgZXRjKSB3 aWxsIHJlc2V0IHRoZWlyIHN0YXRlIHVwb24gbm9ybWFsIHdvcmxkIGluaXRpYWxpemF0aW9uLgor ICAgIERPTVdyYXBwZXJXb3JsZCYgbWFpbldvcmxkID0gbWFpblRocmVhZE5vcm1hbFdvcmxkKCk7 CisgICAgZGlzcGF0Y2hEaWRDbGVhcldpbmRvd09iamVjdEluV29ybGQobWFpbldvcmxkKTsKIAog ICAgIFZlY3RvcjxSZWY8RE9NV3JhcHBlcldvcmxkPj4gd29ybGRzOwogICAgIFNjcmlwdENvbnRy b2xsZXI6OmdldEFsbFdvcmxkcyh3b3JsZHMpOwotICAgIGZvciAoYXV0byYgd29ybGQgOiB3b3Js ZHMpCi0gICAgICAgIGRpc3BhdGNoRGlkQ2xlYXJXaW5kb3dPYmplY3RJbldvcmxkKHdvcmxkKTsK KyAgICBmb3IgKGF1dG8mIHdvcmxkIDogd29ybGRzKSB7CisgICAgICAgIGlmICh3b3JsZC5wdHIo KSAhPSAmbWFpbldvcmxkKQorICAgICAgICAgICAgZGlzcGF0Y2hEaWRDbGVhcldpbmRvd09iamVj dEluV29ybGQod29ybGQpOworICAgIH0KIH0KIAogdm9pZCBGcmFtZUxvYWRlcjo6ZGlzcGF0Y2hE aWRDbGVhcldpbmRvd09iamVjdEluV29ybGQoRE9NV3JhcHBlcldvcmxkJiB3b3JsZCkK