207387 2020-02-07 09:28:03 -0800 [ews] add commit-queue build step to close the bug 2020-02-19 07:41:55 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206536 InRadar P2 Normal --- 201934 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1616183 0 aakash_jain 2020-02-07 09:28:03 -0800 [ews] add commit-queue build step to close the bug (after the patch has been committed to repository). 1616186 1 390088 aakash_jain 2020-02-07 09:33:45 -0800 Created attachment 390088 Patch 1616192 2 aakash_jain 2020-02-07 09:38:34 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/428 1616201 3 390088 jbedard 2020-02-07 09:51:59 -0800 Comment on attachment 390088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390088&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:562 > + self._addToLog('stdio', 'bug_id build property not found.\n') Seems like we're duplicating this one a lot. Maybe add a 'has_bug_id' step to BugzillaMixin in a separate patch? 1616213 4 390088 aakash_jain 2020-02-07 10:10:58 -0800 Comment on attachment 390088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390088&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:562 >> + self._addToLog('stdio', 'bug_id build property not found.\n') > > Seems like we're duplicating this one a lot. Maybe add a 'has_bug_id' step to BugzillaMixin in a separate patch? I am actually not sure if we should even have this additional check or not, theoretically this shouldn't ever be hit. ews django app does send both bug_id and patch_id with the patch to buildbot. Also, if the patch_id is missing, ValidatePatch step will halt the build. For bug_id, it's theoretically possible to have missing bug_id though (e.g.: for security patch, if ews django app didn't send the bug_id for some reason). However, it's possible for someone to define a new factory and add this build-step in some other order/manner, so it's probably fine to have this additional check. 1616214 5 aakash_jain 2020-02-07 10:13:24 -0800 Committed r256031: <https://trac.webkit.org/changeset/256031> 1616215 6 webkit-bug-importer 2020-02-07 10:14:17 -0800 <rdar://problem/59263355> 390088 2020-02-07 09:33:45 -0800 2020-02-07 09:51:59 -0800 Patch bug-207387-20200207123343.patch text/plain 2558 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NjAyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAyLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBhZGQgY29tbWl0LXF1ZXVlIGJ1aWxkIHN0ZXAgdG8gY2xvc2Ug dGhlIGJ1ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA3Mzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChCdWd6aWxs YU1peGluLmNsb3NlX2J1Zyk6IE1ldGhvZCB0byBjbG9zZSB0aGUgYnVnemlsbGEgYnVnLgorICAg ICAgICAoQ2xvc2VCdWcpOiBCdWlsZCBzdGVwIHRvIGNsb3NlIGJ1Z3ppbGxhIGJ1Zy4KKwogMjAy MC0wMi0wNSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAg W2V3c10gYWRkIGNvbW1pdC1xdWV1ZSBidWlsZCBzdGVwIHRvIGNsZWFyIGZsYWdzIG9uIHBhdGNo CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZp c2lvbiAyNTYwMjcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkJKHdvcmtpbmcgY29weSkKQEAgLTQ0NCw2ICs0NDQsMTUgQEAgY2xhc3MgQnVnemlsbGFNaXhp bihvYmplY3QpOgogICAgICAgICAgICAgcmV0dXJuIEZBSUxVUkUKICAgICAgICAgcmV0dXJuIFNV Q0NFU1MKIAorICAgIGRlZiBjbG9zZV9idWcoc2VsZiwgYnVnX2lkKToKKyAgICAgICAgYnVnX3Vy bCA9ICd7fXJlc3QvYnVnL3t9Jy5mb3JtYXQoQlVHX1NFUlZFUl9VUkwsIGJ1Z19pZCkKKyAgICAg ICAgdHJ5OgorICAgICAgICAgICAgcmVzcG9uc2UgPSByZXF1ZXN0cy5wdXQoYnVnX3VybCwganNv bj17J3N0YXR1cyc6ICdSRVNPTFZFRCcsICdyZXNvbHV0aW9uJzogJ0ZJWEVEJywgJ0J1Z3ppbGxh X2FwaV9rZXknOiBzZWxmLmdldF9idWd6aWxsYV9hcGlfa2V5KCl9KQorICAgICAgICBleGNlcHQg RXhjZXB0aW9uIGFzIGU6CisgICAgICAgICAgICBzZWxmLl9hZGRUb0xvZygnc3RkaW8nLCAnRXJy b3IgaW4gY2xvc2luZyBidWcge30nLmZvcm1hdChidWdfaWQpKQorICAgICAgICAgICAgcmV0dXJu IEZBSUxVUkUKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKwogCiBjbGFzcyBWYWxpZGF0ZVBhdGNo KGJ1aWxkc3RlcC5CdWlsZFN0ZXAsIEJ1Z3ppbGxhTWl4aW4pOgogICAgIG5hbWUgPSAndmFsaWRh dGUtcGF0Y2gnCkBAIC01NDIsNiArNTUxLDI5IEBAIGNsYXNzIFJlbW92ZUZsYWdzT25QYXRjaChi dWlsZHN0ZXAuQnVpbGQKICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1J0ZhaWxlZCB0byByZW1v dmUgZmxhZ3Mgb24gYnVnemlsbGEgcGF0Y2gnfQogCiAKK2NsYXNzIENsb3NlQnVnKGJ1aWxkc3Rl cC5CdWlsZFN0ZXAsIEJ1Z3ppbGxhTWl4aW4pOgorICAgIG5hbWUgPSAnY2xvc2UtYnVnemlsbGEt YnVnJworICAgIGZsdW5rT25GYWlsdXJlID0gRmFsc2UKKyAgICBoYWx0T25GYWlsdXJlID0gRmFs c2UKKworICAgIGRlZiBzdGFydChzZWxmKToKKyAgICAgICAgc2VsZi5idWdfaWQgPSBzZWxmLmdl dFByb3BlcnR5KCdidWdfaWQnLCAnJykKKyAgICAgICAgaWYgbm90IHNlbGYuYnVnX2lkOgorICAg ICAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0ZGlvJywgJ2J1Z19pZCBidWlsZCBwcm9wZXJ0eSBu b3QgZm91bmQuXG4nKQorICAgICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUgPSAnTm8gYnVn IGlkIGZvdW5kJworICAgICAgICAgICAgc2VsZi5maW5pc2hlZChGQUlMVVJFKQorICAgICAgICAg ICAgcmV0dXJuIE5vbmUKKworICAgICAgICByYyA9IHNlbGYuY2xvc2VfYnVnKHNlbGYuYnVnX2lk KQorICAgICAgICBzZWxmLmZpbmlzaGVkKHJjKQorICAgICAgICByZXR1cm4gTm9uZQorCisgICAg ZGVmIGdldFJlc3VsdFN1bW1hcnkoc2VsZik6CisgICAgICAgIGlmIHNlbGYucmVzdWx0cyA9PSBT VUNDRVNTOgorICAgICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1J0Nsb3NlZCBidWcge30nLmZv cm1hdChzZWxmLmJ1Z19pZCl9CisgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWlsZWQgdG8g Y2xvc2UgYnVnIHt9Jy5mb3JtYXQoc2VsZi5idWdfaWQpfQorCisKIGNsYXNzIFVuQXBwbHlQYXRj aElmUmVxdWlyZWQoQ2xlYW5Xb3JraW5nRGlyZWN0b3J5KToKICAgICBuYW1lID0gJ3VuYXBwbHkt cGF0Y2gnCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWydVbmFwcGxpZWQgcGF0Y2gnXQo=