207367 2020-02-06 16:03:20 -0800 Build entitlements into GPU Process 2020-02-06 19:27:30 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap bfulgham commit-queue eric.carlson ggaren krollin pvollan thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1615902 0 bfulgham 2020-02-06 16:03:20 -0800 Update the build rules to embed the correct entitlements in the new GPU Process. 1615904 1 bfulgham 2020-02-06 16:03:59 -0800 <rdar://problem/59208411> 1615907 2 390019 bfulgham 2020-02-06 16:06:50 -0800 Created attachment 390019 Patch 1615915 3 390019 ggaren 2020-02-06 16:14:27 -0800 Comment on attachment 390019 Patch r=me 1615959 4 390019 ap 2020-02-06 17:40:13 -0800 Comment on attachment 390019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390019&action=review > Source/WebKit/Scripts/process-entitlements.sh:26 > + if [[ "${WK_USE_RESTRICTED_ENTITLEMENTS}" == YES ]] Will there be any more functionality unavailable in open source builds than there is today? > Source/WebKit/Scripts/process-entitlements.sh:28 > + if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 101400 )) Why is this version check necessary? 1615977 5 commit-queue 2020-02-06 18:22:01 -0800 The commit-queue encountered the following flaky tests while processing attachment 390019: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1615980 6 commit-queue 2020-02-06 18:22:07 -0800 The commit-queue encountered the following flaky tests while processing attachment 390019: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com) The commit-queue is continuing to process your patch. 1616019 7 commit-queue 2020-02-06 19:26:50 -0800 The commit-queue encountered the following flaky tests while processing attachment 390019: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1616020 8 390019 commit-queue 2020-02-06 19:27:28 -0800 Comment on attachment 390019 Patch Clearing flags on attachment: 390019 Committed r256004: <https://trac.webkit.org/changeset/256004> 1616021 9 commit-queue 2020-02-06 19:27:30 -0800 All reviewed patches have been landed. Closing bug. 390019 2020-02-06 16:06:50 -0800 2020-02-06 19:27:28 -0800 Patch bug-207367-20200206160649.patch text/plain 5279 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRhOTY1ZWYwZmU0MGQxYzY5 ZjA3Y2ZiZTkzNDlkOGUxYmI5NGM1ZTcuLmFmNGViZjFhOWRiMmIxYzYwZjlkMzNjM2RiYTZhY2Vi ZjEzN2VlM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDItMDYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQnVpbGQgZW50aXRsZW1lbnRz IGludG8gR1BVIFByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNzM2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkyMDg0MTE+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgbmV3 IEdQVSBwcm9jZXNzIHdhcyBhZGRlZCwgd2UgZGlkIG5vdCB1cGRhdGUgdGhlIGJ1aWxkIHN5c3Rl bSB0byBhZGQKKyAgICAgICAgbmVjZXNzYXJ5IGVudGl0bGVtZW50cywgb3IgdG8gZW5jb2RlIHRo ZSBzYW5kYm94IG5hbWUgZm9yIHByb2Nlc3Mgc3RhcnR1cC4KKyAgICAgICAgVGhpcyBwYXRjaCBj b3JyZWN0cyB0aGVzZSBpc3N1ZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3Byb2Nlc3MtZW50aXRs ZW1lbnRzLnNoOgorCiAyMDIwLTAyLTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI1NTk1NS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvU2NyaXB0cy9wcm9jZXNzLWVudGl0bGVtZW50cy5zaCBiL1NvdXJjZS9X ZWJLaXQvU2NyaXB0cy9wcm9jZXNzLWVudGl0bGVtZW50cy5zaAppbmRleCA2MWE0NjI1NzY3YzIx MDdjNDU1OGFmODhmZjE2NzUwYjYxMzgzNzlmLi5kODQzNGZjNGU0Njg1ZjQ2NWQ3ZGQ3ZDczZGIz YjIxNDAyM2Q2MTY2IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvcHJvY2Vzcy1l bnRpdGxlbWVudHMuc2gKKysrIGIvU291cmNlL1dlYktpdC9TY3JpcHRzL3Byb2Nlc3MtZW50aXRs ZW1lbnRzLnNoCkBAIC0yMSw2ICsyMSwyMSBAQCBmdW5jdGlvbiBtYWNfcHJvY2Vzc193ZWJjb250 ZW50X2VudGl0bGVtZW50cygpCiAgICAgbWFjX3Byb2Nlc3Nfd2ViY29udGVudF9vcl9wbHVnaW5f ZW50aXRsZW1lbnRzCiB9CiAKK2Z1bmN0aW9uIG1hY19wcm9jZXNzX2dwdV9lbnRpdGxlbWVudHMo KQoreworICAgIGlmIFtbICIke1dLX1VTRV9SRVNUUklDVEVEX0VOVElUTEVNRU5UU30iID09IFlF UyBdXQorICAgIHRoZW4KKyAgICAgICAgaWYgKCggIiR7VEFSR0VUX01BQ19PU19YX1ZFUlNJT05f TUFKT1J9IiA+PSAxMDE0MDAgKSkKKyAgICAgICAgdGhlbgorICAgICAgICAgICAgcGxpc3RidWRk eSBBZGQgOmNvbS5hcHBsZS50Y2MuZGVsZWdhdGVkLXNlcnZpY2VzIGFycmF5CisgICAgICAgICAg ICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnRjYy5kZWxlZ2F0ZWQtc2VydmljZXM6MSBzdHJp bmcga1RDQ1NlcnZpY2VNaWNyb3Bob25lCisgICAgICAgICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29t LmFwcGxlLnRjYy5kZWxlZ2F0ZWQtc2VydmljZXM6MCBzdHJpbmcga1RDQ1NlcnZpY2VDYW1lcmEK KyAgICAgICAgZmkKKworICAgICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnJvb3RsZXNz LnN0b3JhZ2UuV2ViS2l0R1BVU2FuZGJveCBib29sIFlFUworICAgIGZpCit9CisKIGZ1bmN0aW9u IG1hY19wcm9jZXNzX25ldHdvcmtfZW50aXRsZW1lbnRzKCkKIHsKICAgICBpZiBbWyAiJHtXS19V U0VfUkVTVFJJQ1RFRF9FTlRJVExFTUVOVFN9IiA9PSBZRVMgXV0KQEAgLTc3LDYgKzkyLDExIEBA IGZ1bmN0aW9uIG1hY2NhdGFseXN0X3Byb2Nlc3Nfd2ViY29udGVudF9lbnRpdGxlbWVudHMoKQog ICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUuc2VjdXJpdHkuY3MuYWxsb3ctaml0IGJvb2wg WUVTCiB9CiAKK2Z1bmN0aW9uIG1hY2NhdGFseXN0X3Byb2Nlc3NfZ3B1X2VudGl0bGVtZW50cygp Cit7CisgICAgcGxpc3RidWRkeSBBZGQgOmNvbS5hcHBsZS5zZWN1cml0eS5uZXR3b3JrLmNsaWVu dCBib29sIFlFUworfQorCiBmdW5jdGlvbiBtYWNjYXRhbHlzdF9wcm9jZXNzX25ldHdvcmtfZW50 aXRsZW1lbnRzKCkKIHsKICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnByaXZhdGUubmV0 d29yay5zb2NrZXQtZGVsZWdhdGUgYm9vbCBZRVMKQEAgLTExOSw2ICsxMzksMjUgQEAgZnVuY3Rp b24gaW9zX2ZhbWlseV9wcm9jZXNzX3dlYmNvbnRlbnRfZW50aXRsZW1lbnRzKCkKICAgICBwbGlz dGJ1ZGR5IEFkZCA6c2VhdGJlbHQtcHJvZmlsZXM6MCBzdHJpbmcgY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50CiB9CiAKK2Z1bmN0aW9uIGlvc19mYW1pbHlfcHJvY2Vzc19ncHVfZW50aXRsZW1l bnRzKCkKK3sKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLlF1YXJ0ekNvcmUuc2VjdXJl LW1vZGUgYm9vbCBZRVMKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLlF1YXJ0ekNvcmUu d2Via2l0LWVuZC1wb2ludHMgYm9vbCBZRVMKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxl Lm1lZGlhcmVtb3RlLnNldC1wbGF5YmFjay1zdGF0ZSBib29sIFlFUworICAgIHBsaXN0YnVkZHkg QWRkIDpjb20uYXBwbGUucHJpdmF0ZS5hbGxvdy1leHBsaWNpdC1ncmFwaGljcy1wcmlvcml0eSBi b29sIFlFUworICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUucHJpdmF0ZS5jb3JlbWVkaWEu ZXh0ZW5zaW9ucy5hdWRpb3JlY29yZGluZy5hbGxvdyBib29sIFlFUworICAgIHBsaXN0YnVkZHkg QWRkIDpjb20uYXBwbGUucHJpdmF0ZS5jb3JlbWVkaWEucGlkaW5oZXJpdGFuY2UuYWxsb3cgYm9v bCBZRVMKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnByaXZhdGUubWVtb3J5c3RhdHVz IGJvb2wgWUVTCisgICAgcGxpc3RidWRkeSBBZGQgOmNvbS5hcHBsZS5wcml2YXRlLm5ldHdvcmsu c29ja2V0LWRlbGVnYXRlIGJvb2wgWUVTCisKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxl LnRjYy5kZWxlZ2F0ZWQtc2VydmljZXMgYXJyYXkKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFw cGxlLnRjYy5kZWxlZ2F0ZWQtc2VydmljZXM6MCBzdHJpbmcga1RDQ1NlcnZpY2VDYW1lcmEKKyAg ICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnRjYy5kZWxlZ2F0ZWQtc2VydmljZXM6MSBzdHJp bmcga1RDQ1NlcnZpY2VNaWNyb3Bob25lCisKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6c2VhdGJlbHQt cHJvZmlsZXMgYXJyYXkKKyAgICBwbGlzdGJ1ZGR5IEFkZCA6c2VhdGJlbHQtcHJvZmlsZXM6MCBz dHJpbmcgY29tLmFwcGxlLldlYktpdC5HUFUKK30KKwogZnVuY3Rpb24gaW9zX2ZhbWlseV9wcm9j ZXNzX25ldHdvcmtfZW50aXRsZW1lbnRzKCkKIHsKICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFw cGxlLm11bHRpdGFza2luZy5zeXN0ZW1hcHBhc3NlcnRpb25zIGJvb2wgWUVTCkBAIC0xNTYsNiAr MTk1LDcgQEAgdGhlbgogICAgIGVsaWYgW1sgIiR7UFJPRFVDVF9OQU1FfSIgPT0gY29tLmFwcGxl LldlYktpdC5XZWJDb250ZW50IF1dOyB0aGVuIG1hY19wcm9jZXNzX3dlYmNvbnRlbnRfZW50aXRs ZW1lbnRzCiAgICAgZWxpZiBbWyAiJHtQUk9EVUNUX05BTUV9IiA9PSBjb20uYXBwbGUuV2ViS2l0 Lk5ldHdvcmtpbmcgXV07IHRoZW4gbWFjX3Byb2Nlc3NfbmV0d29ya19lbnRpdGxlbWVudHMKICAg ICBlbGlmIFtbICIke1BST0RVQ1RfTkFNRX0iID09IGNvbS5hcHBsZS5XZWJLaXQuUGx1Z2luLjY0 IF1dOyB0aGVuIG1hY19wcm9jZXNzX3BsdWdpbl9lbnRpdGxlbWVudHMKKyAgICBlbGlmIFtbICIk e1BST0RVQ1RfTkFNRX0iID09IGNvbS5hcHBsZS5XZWJLaXQuR1BVIF1dOyB0aGVuIG1hY19wcm9j ZXNzX2dwdV9lbnRpdGxlbWVudHMKICAgICBlbHNlIGVjaG8gIlVuc3VwcG9ydGVkL3Vua25vd24g cHJvZHVjdDogJHtQUk9EVUNUX05BTUV9IgogICAgIGZpCiBlbGlmIFtbICIke1dLX1BMQVRGT1JN X05BTUV9IiA9PSBtYWNjYXRhbHlzdCB8fCAiJHtXS19QTEFURk9STV9OQU1FfSIgPT0gaW9zbWFj IF1dCkBAIC0xNjYsNiArMjA2LDcgQEAgdGhlbgogICAgIGVsaWYgW1sgIiR7UFJPRFVDVF9OQU1F fSIgPT0gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IF1dOyB0aGVuIG1hY2NhdGFseXN0X3By b2Nlc3Nfd2ViY29udGVudF9lbnRpdGxlbWVudHMKICAgICBlbGlmIFtbICIke1BST0RVQ1RfTkFN RX0iID09IGNvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZyBdXTsgdGhlbiBtYWNjYXRhbHlzdF9w cm9jZXNzX25ldHdvcmtfZW50aXRsZW1lbnRzCiAgICAgZWxpZiBbWyAiJHtQUk9EVUNUX05BTUV9 IiA9PSBjb20uYXBwbGUuV2ViS2l0LlBsdWdpbi42NCBdXTsgdGhlbiBtYWNjYXRhbHlzdF9wcm9j ZXNzX3BsdWdpbl9lbnRpdGxlbWVudHMKKyAgICBlbGlmIFtbICIke1BST0RVQ1RfTkFNRX0iID09 IGNvbS5hcHBsZS5XZWJLaXQuR1BVIF1dOyB0aGVuIG1hY2NhdGFseXN0X3Byb2Nlc3NfZ3B1X2Vu dGl0bGVtZW50cwogICAgIGVsc2UgZWNobyAiVW5zdXBwb3J0ZWQvdW5rbm93biBwcm9kdWN0OiAk e1BST0RVQ1RfTkFNRX0iCiAgICAgZmkKIGVsaWYgW1sgIiR7V0tfUExBVEZPUk1fTkFNRX0iID09 IGlwaG9uZW9zIHx8CkBAIC0xNzYsNiArMjE3LDcgQEAgdGhlbgogICAgIGVsaWYgW1sgIiR7UFJP RFVDVF9OQU1FfSIgPT0gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IF1dOyB0aGVuIGlvc19m YW1pbHlfcHJvY2Vzc193ZWJjb250ZW50X2VudGl0bGVtZW50cwogICAgIGVsaWYgW1sgIiR7UFJP RFVDVF9OQU1FfSIgPT0gY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nIF1dOyB0aGVuIGlvc19m YW1pbHlfcHJvY2Vzc19uZXR3b3JrX2VudGl0bGVtZW50cwogICAgIGVsaWYgW1sgIiR7UFJPRFVD VF9OQU1FfSIgPT0gY29tLmFwcGxlLldlYktpdC5QbHVnaW4uNjQgXV07IHRoZW4gaW9zX2ZhbWls eV9wcm9jZXNzX3BsdWdpbl9lbnRpdGxlbWVudHMKKyAgICBlbGlmIFtbICIke1BST0RVQ1RfTkFN RX0iID09IGNvbS5hcHBsZS5XZWJLaXQuR1BVIF1dOyB0aGVuIGlvc19mYW1pbHlfcHJvY2Vzc19n cHVfZW50aXRsZW1lbnRzCiAgICAgZWxzZSBlY2hvICJVbnN1cHBvcnRlZC91bmtub3duIHByb2R1 Y3Q6ICR7UFJPRFVDVF9OQU1FfSIKICAgICBmaQogZWxzZQo=