207348 2020-02-06 12:51:04 -0800 ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics relies on the order of m_getAllDomainsStatement, which can be changed by HashTable's implementation 2020-02-06 19:09:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin mark.lam webkit-bug-importer wilander oldest_to_newest 1615746 0 ysuzuki 2020-02-06 12:51:04 -0800 ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics relies on the order of m_getAllDomainsStatement, which can be changed by HashTable's implementation 1615747 1 389983 ysuzuki 2020-02-06 12:52:16 -0800 Created attachment 389983 Patch 1615797 2 389983 mark.lam 2020-02-06 14:12:21 -0800 Comment on attachment 389983 Patch r=me. Is the test already expecting sorted order? If not, you should rebase the test results also. 1615807 3 ysuzuki 2020-02-06 14:19:39 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 389983 [details] > Patch > > r=me. Is the test already expecting sorted order? If not, you should > rebase the test results also. Yes, luckily :) 1615847 4 commit-queue 2020-02-06 14:58:43 -0800 The commit-queue encountered the following flaky tests while processing attachment 389983: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com) The commit-queue is continuing to process your patch. 1615850 5 commit-queue 2020-02-06 14:59:08 -0800 The commit-queue encountered the following flaky tests while processing attachment 389983: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1616004 6 389983 commit-queue 2020-02-06 19:08:44 -0800 Comment on attachment 389983 Patch Clearing flags on attachment: 389983 Committed r256002: <https://trac.webkit.org/changeset/256002> 1616005 7 commit-queue 2020-02-06 19:08:45 -0800 All reviewed patches have been landed. Closing bug. 1616006 8 webkit-bug-importer 2020-02-06 19:09:14 -0800 <rdar://problem/59248444> 389983 2020-02-06 12:52:16 -0800 2020-02-06 19:08:44 -0800 Patch bug-207348-20200206125215.patch text/plain 2299 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDExYThkZTc3OWVmMTNhZTcx ODA1OGFlYmE3ZjE3MzA4NzY5ZTQ2ZWEuLjNjNmNiMmY5Yjk0ZGZjOWNhYjM0MTNiNGM4MDhkMDE3 M2RmMTUwMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDItMDYgIFl1c3VrZSBT dXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzRGF0YWJhc2VTdG9yZTo6ZHVtcFJlc291cmNlTG9hZFN0YXRpc3RpY3MgcmVsaWVzIG9uIHRo ZSBvcmRlciBvZiBtX2dldEFsbERvbWFpbnNTdGF0ZW1lbnQsIHdoaWNoIGNhbiBiZSBjaGFuZ2Vk IGJ5IEhhc2hUYWJsZSdzIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDczNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCBSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzRGF0YWJhc2VTdG9yZTo6ZHVtcFJlc291cmNlTG9hZFN0YXRpc3RpY3MncyBvdXRwdXQK KyAgICAgICAgaXMgcmVseWluZyBvbiBIYXNoVGFibGUncyBwYXJ0aWN1bGFyIGl0ZXJhdGlvbiBv cmRlciB3aGljaCBpcyBub3QgZ3VhcmFudGVlZC4KKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0 aGlzIGFzc3VtcHRpb24gYnkgc29ydGluZyBkb21haW5zIGJlZm9yZSBkdW1waW5nLgorCisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0 YWJhc2VTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQp OgorCiAyMDIwLTAyLTA2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjU1OTEwLCByMjU1OTcwLCBhbmQg cjI1NTk3Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3Np Zmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFi YXNlU3RvcmUuY3BwCmluZGV4IDhkOTMwMzgyZDdmYzU3YjA2M2I1YzJiZDgwMWRhNmExMjI2Njg1 NWMuLjgwMTM1NjM4MmY4ODhjMjI0YjFmNzI5OTY2YTM0YjAwNTJhMGJmMTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0 aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlLmNwcApAQCAt MTcwOSwxMCArMTcwOSwxNSBAQCB2b2lkIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0 b3JlOjpkdW1wUmVzb3VyY2VMb2FkU3RhdGlzdGljcyhDb21wbGV0aW9uSAogICAgICAgICByZXR1 cm47CiAgICAgfQogCisgICAgVmVjdG9yPFN0cmluZz4gZG9tYWluczsKKyAgICB3aGlsZSAobV9n ZXRBbGxEb21haW5zU3RhdGVtZW50LnN0ZXAoKSA9PSBTUUxJVEVfUk9XKQorICAgICAgICBkb21h aW5zLmFwcGVuZChtX2dldEFsbERvbWFpbnNTdGF0ZW1lbnQuZ2V0Q29sdW1uVGV4dCgwKSk7Cisg ICAgc3RkOjpzb3J0KGRvbWFpbnMuYmVnaW4oKSwgZG9tYWlucy5lbmQoKSwgV1RGOjpjb2RlUG9p bnRDb21wYXJlTGVzc1RoYW4pOworCiAgICAgU3RyaW5nQnVpbGRlciByZXN1bHQ7CiAgICAgcmVz dWx0LmFwcGVuZExpdGVyYWwoIlJlc291cmNlIGxvYWQgc3RhdGlzdGljczpcblxuIik7Ci0gICAg d2hpbGUgKG1fZ2V0QWxsRG9tYWluc1N0YXRlbWVudC5zdGVwKCkgPT0gU1FMSVRFX1JPVykKLSAg ICAgICAgcmVzb3VyY2VUb1N0cmluZyhyZXN1bHQsIG1fZ2V0QWxsRG9tYWluc1N0YXRlbWVudC5n ZXRDb2x1bW5UZXh0KDApKTsKKyAgICBmb3IgKGF1dG8mIGRvbWFpbiA6IGRvbWFpbnMpCisgICAg ICAgIHJlc291cmNlVG9TdHJpbmcocmVzdWx0LCBkb21haW4pOwogCiAgICAgYXV0byB0aGlyZFBh cnR5RGF0YSA9IGFnZ3JlZ2F0ZWRUaGlyZFBhcnR5RGF0YSgpOwogICAgIGlmICghdGhpcmRQYXJ0 eURhdGEuaXNFbXB0eSgpKSB7Cg==