207300 2020-02-05 15:05:01 -0800 Check for null return from AXIsolatedTree::nodeForID. 2020-02-05 17:22:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1615310 0 andresg_22 2020-02-05 15:05:01 -0800 Check for null return from AXIsolatedTree::nodeForID. 1615318 1 389880 andresg_22 2020-02-05 15:14:22 -0800 Created attachment 389880 Patch 1615425 2 commit-queue 2020-02-05 17:21:13 -0800 The commit-queue encountered the following flaky tests while processing attachment 389880: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1615426 3 389880 commit-queue 2020-02-05 17:21:52 -0800 Comment on attachment 389880 Patch Clearing flags on attachment: 389880 Committed r255884: <https://trac.webkit.org/changeset/255884> 1615427 4 commit-queue 2020-02-05 17:21:53 -0800 All reviewed patches have been landed. Closing bug. 1615428 5 webkit-bug-importer 2020-02-05 17:22:13 -0800 <rdar://problem/59208931> 389880 2020-02-05 15:14:22 -0800 2020-02-05 17:21:52 -0800 Patch bug-207300-20200205181421.patch text/plain 6532 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1ODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkYWY3N2YzMmQzMzE4 MjMxNzE3ZjkwZWZiYjI3YTAxYWFkMTcyYy4uYjdhNmZjOTA2OTA5MjEwOGNhODUwYjFlNzU0MjY0 NjYyZWJkMjc4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTAyLTA1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDaGVjayBmb3Ig bnVsbCByZXR1cm4gZnJvbSBBWElzb2xhdGVkVHJlZTo6bm9kZUZvcklELgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzAwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBBcyB0aGUgSXNvbGF0ZWRUcmVl IGlzIHVwZGF0ZWQsIEFYSXNvbGF0ZWRUcmVlOjpub2RlRm9ySUQgbWF5IHJldHVybgorICAgICAg ICBudWxscHRyIGZvciBvYmplY3RzIHRoYXQgaGF2ZSBiZWVuIHJlbW92ZWQgZnJvbSB0aGUgdHJl ZS4gVGh1cywKKyAgICAgICAgSXNvbGF0ZWRPYmplY3RzIG11c3QgY2hlY2sgdGhlIHJldHVybmVk IHZhbHVlIHdoZW4gdXBkYXRpbmcgY2hpbGRyZW4KKyAgICAgICAgYW5kIGFueSBvdGhlciBvcGVy YXRpb25zIGludm9sdmluZyBjYWNoZWQgSURzLgorICAgICAgICAtIFRpZHlpbmcgdXAgdXNlIG9m IGF1dG8gb24gZm9yIGFuZCBpZiBzdGF0ZW1lbnRzLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpB WElzb2xhdGVkT2JqZWN0OjpkZXRhY2hSZW1vdGVQYXJ0cyk6CisgICAgICAgIChXZWJDb3JlOjpB WElzb2xhdGVkT2JqZWN0OjpjaGlsZHJlbik6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVk T2JqZWN0OjphY2Nlc3NpYmlsaXR5VGV4dCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpBWElz b2xhdGVkT2JqZWN0OjppbnNlcnRNYXRoUGFpcnMpOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29s YXRlZE9iamVjdDo6b2JqZWN0QXR0cmlidXRlVmFsdWUgY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6QVhJc29sYXRlZE9iamVjdDo6ZmlsbENoaWxkcmVuVmVjdG9yRm9yUHJvcGVydHkgY29uc3Qp OgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9iamVjdDo6dHJlZSBjb25zdCk6IERlbGV0 ZWQsIG1vdmVkIGlubGluZSB0byB0aGUgaGVhZGVyLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkv aXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaDoKKwogMjAyMC0wMi0wNSAgQW50b2luZSBR dWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gQ2Fu Y2VsaW5nIGFuIGFjY2VsZXJhdGVkIGFuaW1hdGlvbiBiZWZvcmUgaXQgd2FzIGNvbW1pdHRlZCBk b2VzIG5vdCBwcmV2ZW50IGl0IGZyb20gcGxheWluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNw cAppbmRleCBiODIxZjQwY2NhMGYwMzA0NDgxNzZiODhmMzEzNzhjZDRkMjk2MmQ5Li45ZmI3MDBh MGFjNmU1ZWQ0ZTdiOTg2MTg0OTk1NTNjZDUyZmI2YWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2Jq ZWN0LmNwcApAQCAtNDEwLDkgKzQxMCwxMCBAQCB2b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OnNldFBh cmVudChBWElEIHBhcmVudCkKIHZvaWQgQVhJc29sYXRlZE9iamVjdDo6ZGV0YWNoUmVtb3RlUGFy dHMoQWNjZXNzaWJpbGl0eURldGFjaG1lbnRUeXBlIGRldGFjaG1lbnRUeXBlKQogewogICAgIEFT U0VSVF9VTlVTRUQoZGV0YWNobWVudFR5cGUsIGlzTWFpblRocmVhZCgpID8gZGV0YWNobWVudFR5 cGUgPT0gQWNjZXNzaWJpbGl0eURldGFjaG1lbnRUeXBlOjpDYWNoZURlc3Ryb3llZCA6IGRldGFj aG1lbnRUeXBlICE9IEFjY2Vzc2liaWxpdHlEZXRhY2htZW50VHlwZTo6Q2FjaGVEZXN0cm95ZWQp OwotICAgIGZvciAoY29uc3QgYXV0byYgY2hpbGRJRCA6IG1fY2hpbGRyZW5JRHMpCi0gICAgICAg IHRyZWUoKS0+bm9kZUZvcklEKGNoaWxkSUQpLT5kZXRhY2hGcm9tUGFyZW50KCk7Ci0KKyAgICBm b3IgKGNvbnN0IGF1dG8mIGNoaWxkSUQgOiBtX2NoaWxkcmVuSURzKSB7CisgICAgICAgIGlmIChh dXRvIGNoaWxkID0gdHJlZSgpLT5ub2RlRm9ySUQoY2hpbGRJRCkpCisgICAgICAgICAgICBjaGls ZC0+ZGV0YWNoRnJvbVBhcmVudCgpOworICAgIH0KICAgICBtX2NoaWxkcmVuSURzLmNsZWFyKCk7 CiB9CiAKQEAgLTQzOSw5ICs0NDAsMTAgQEAgY29uc3QgQVhDb3JlT2JqZWN0OjpBY2Nlc3NpYmls aXR5Q2hpbGRyZW5WZWN0b3ImIEFYSXNvbGF0ZWRPYmplY3Q6OmNoaWxkcmVuKGJvb2wKICAgICBp ZiAoIWlzTWFpblRocmVhZCgpKSB7CiAgICAgICAgIG1fY2hpbGRyZW4uY2xlYXIoKTsKICAgICAg ICAgbV9jaGlsZHJlbi5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KG1fY2hpbGRyZW5JRHMuc2l6ZSgp KTsKLSAgICAgICAgYXV0byB0cmVlID0gdGhpcy0+dHJlZSgpOwotICAgICAgICBmb3IgKGF1dG8g Y2hpbGRJRCA6IG1fY2hpbGRyZW5JRHMpCi0gICAgICAgICAgICBtX2NoaWxkcmVuLnVuY2hlY2tl ZEFwcGVuZCh0cmVlLT5ub2RlRm9ySUQoY2hpbGRJRCkpOworICAgICAgICBmb3IgKGNvbnN0IGF1 dG8mIGNoaWxkSUQgOiBtX2NoaWxkcmVuSURzKSB7CisgICAgICAgICAgICBpZiAoYXV0byBjaGls ZCA9IHRyZWUoKS0+bm9kZUZvcklEKGNoaWxkSUQpKQorICAgICAgICAgICAgICAgIG1fY2hpbGRy ZW4udW5jaGVja2VkQXBwZW5kKGNoaWxkKTsKKyAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4g bV9jaGlsZHJlbjsKIH0KQEAgLTQ2MCw5ICs0NjIsOSBAQCBib29sIEFYSXNvbGF0ZWRPYmplY3Q6 OmlzRGV0YWNoZWRGcm9tUGFyZW50KCkKIHZvaWQgQVhJc29sYXRlZE9iamVjdDo6YWNjZXNzaWJp bGl0eVRleHQoVmVjdG9yPEFjY2Vzc2liaWxpdHlUZXh0PiYgdGV4dHMpIGNvbnN0CiB7CiAgICAg YXV0byBpc29sYXRlZFRleHRzID0gdmVjdG9yQXR0cmlidXRlVmFsdWU8QWNjZXNzaWJpbGl0eUlz b2xhdGVkVHJlZVRleHQ+KEFYUHJvcGVydHlOYW1lOjpBY2Nlc3NpYmlsaXR5VGV4dCk7Ci0gICAg Zm9yIChhdXRvIGlzb2xhdGVkVGV4dCA6IGlzb2xhdGVkVGV4dHMpIHsKKyAgICBmb3IgKGNvbnN0 IGF1dG8mIGlzb2xhdGVkVGV4dCA6IGlzb2xhdGVkVGV4dHMpIHsKICAgICAgICAgQWNjZXNzaWJp bGl0eVRleHQgdGV4dChpc29sYXRlZFRleHQudGV4dCwgaXNvbGF0ZWRUZXh0LnRleHRTb3VyY2Up OwotICAgICAgICBmb3IgKGF1dG8gYXhJRCA6IGlzb2xhdGVkVGV4dC50ZXh0RWxlbWVudHMpIHsK KyAgICAgICAgZm9yIChjb25zdCBhdXRvJiBheElEIDogaXNvbGF0ZWRUZXh0LnRleHRFbGVtZW50 cykgewogICAgICAgICAgICAgaWYgKGF1dG8gb2JqZWN0ID0gdHJlZSgpLT5ub2RlRm9ySUQoYXhJ RCkpCiAgICAgICAgICAgICAgICAgdGV4dC50ZXh0RWxlbWVudHMuYXBwZW5kKG9iamVjdCk7CiAg ICAgICAgIH0KQEAgLTUwNiwxMSArNTA4LDExIEBAIFN0cmluZyBBWElzb2xhdGVkT2JqZWN0Ojpk b2N1bWVudEVuY29kaW5nKCkgY29uc3QKIAogdm9pZCBBWElzb2xhdGVkT2JqZWN0OjppbnNlcnRN YXRoUGFpcnMoVmVjdG9yPEFjY2Vzc2liaWxpdHlJc29sYXRlZFRyZWVNYXRoTXVsdGlzY3JpcHRQ YWlyPiYgaXNvbGF0ZWRQYWlycywgQWNjZXNzaWJpbGl0eU1hdGhNdWx0aXNjcmlwdFBhaXJzJiBw YWlycykKIHsKLSAgICBmb3IgKGF1dG8gcGFpciA6IGlzb2xhdGVkUGFpcnMpIHsKKyAgICBmb3Ig KGNvbnN0IGF1dG8mIHBhaXIgOiBpc29sYXRlZFBhaXJzKSB7CiAgICAgICAgIEFjY2Vzc2liaWxp dHlNYXRoTXVsdGlzY3JpcHRQYWlyIHByZXNjcmlwdFBhaXI7Ci0gICAgICAgIGlmIChhdXRvKiBj b3JlT2JqZWN0ID0gdHJlZSgpLT5ub2RlRm9ySUQocGFpci5maXJzdCkuZ2V0KCkpCisgICAgICAg IGlmIChhdXRvIGNvcmVPYmplY3QgPSB0cmVlKCktPm5vZGVGb3JJRChwYWlyLmZpcnN0KS5nZXQo KSkKICAgICAgICAgICAgIHByZXNjcmlwdFBhaXIuZmlyc3QgPSBjb3JlT2JqZWN0OwotICAgICAg ICBpZiAoYXV0byogY29yZU9iamVjdCA9IHRyZWUoKS0+bm9kZUZvcklEKHBhaXIuc2Vjb25kKS5n ZXQoKSkKKyAgICAgICAgaWYgKGF1dG8gY29yZU9iamVjdCA9IHRyZWUoKS0+bm9kZUZvcklEKHBh aXIuc2Vjb25kKS5nZXQoKSkKICAgICAgICAgICAgIHByZXNjcmlwdFBhaXIuc2Vjb25kID0gY29y ZU9iamVjdDsKICAgICAgICAgcGFpcnMuYXBwZW5kKHByZXNjcmlwdFBhaXIpOwogICAgIH0KQEAg LTY1MiwxMSArNjU0LDYgQEAgQVhDb3JlT2JqZWN0KiBBWElzb2xhdGVkT2JqZWN0OjphY2Nlc3Np YmlsaXR5SGl0VGVzdChjb25zdCBJbnRQb2ludCYgcG9pbnQpIGNvbnMKICAgICByZXR1cm4gY29u c3RfY2FzdDxBWElzb2xhdGVkT2JqZWN0Kj4odGhpcyk7CiB9CiAKLUFYSXNvbGF0ZWRUcmVlKiBB WElzb2xhdGVkT2JqZWN0Ojp0cmVlKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9jYWNoZWRUcmVl LmdldCgpOwotfQotCiBJbnRQb2ludCBBWElzb2xhdGVkT2JqZWN0OjppbnRQb2ludEF0dHJpYnV0 ZVZhbHVlKEFYUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSkgY29uc3QKIHsKICAgICBhdXRvIHZh bHVlID0gbV9hdHRyaWJ1dGVNYXAuZ2V0KHByb3BlcnR5TmFtZSk7CkBAIC02NzMsNyArNjcwLDcg QEAgQVhDb3JlT2JqZWN0KiBBWElzb2xhdGVkT2JqZWN0OjpvYmplY3RBdHRyaWJ1dGVWYWx1ZShB WFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUKICAgICAgICAgW10gKEFYSUQmIHR5cGVkVmFsdWUp IHsgcmV0dXJuIHR5cGVkVmFsdWU7IH0sCiAgICAgICAgIFtdIChhdXRvJikgeyByZXR1cm4gSW52 YWxpZEFYSUQ7IH0KICAgICApOwotICAgIAorCiAgICAgcmV0dXJuIHRyZWUoKS0+bm9kZUZvcklE KG5vZGVJRCkuZ2V0KCk7CiB9CiAKQEAgLTc5Miw3ICs3ODksNyBAQCB2b2lkIEFYSXNvbGF0ZWRP YmplY3Q6OmZpbGxDaGlsZHJlblZlY3RvckZvclByb3BlcnR5KEFYUHJvcGVydHlOYW1lIHByb3Bl cnR5TmFtZQogewogICAgIFZlY3RvcjxBWElEPiBjaGlsZElEcyA9IHZlY3RvckF0dHJpYnV0ZVZh bHVlPEFYSUQ+KHByb3BlcnR5TmFtZSk7CiAgICAgY2hpbGRyZW4ucmVzZXJ2ZUNhcGFjaXR5KGNo aWxkSURzLnNpemUoKSk7Ci0gICAgZm9yIChhdXRvIGNoaWxkSUQgOiBjaGlsZElEcykgeworICAg IGZvciAoY29uc3QgYXV0byYgY2hpbGRJRCA6IGNoaWxkSURzKSB7CiAgICAgICAgIGlmIChhdXRv IG9iamVjdCA9IHRyZWUoKS0+bm9kZUZvcklEKGNoaWxkSUQpKQogICAgICAgICAgICAgY2hpbGRy ZW4udW5jaGVja2VkQXBwZW5kKG9iamVjdCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5o CmluZGV4IDZlNTBkZjczYTQ1ODBjOTVmY2JjZDQ2ZGQ3OGJjNzM3ZDRjNmQ1ZTguLjNhYTk2OTlk NGY5NjE0N2M1ZWJmNzMxZGM1ODQ2N2M1NzE4M2Y5ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0 LmgKQEAgLTY1LDEwICs2NSwxMCBAQCBwcml2YXRlOgogICAgIHZvaWQgZGV0YWNoUGxhdGZvcm1X cmFwcGVyKEFjY2Vzc2liaWxpdHlEZXRhY2htZW50VHlwZSkgb3ZlcnJpZGU7CiAKICAgICBBWElE IHBhcmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFyZW50OyB9Ci0gICAgCisKICAgICBBWElzb2xh dGVkVHJlZUlEIHRyZWVJZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV90cmVlSWRlbnRpZmll cjsgfQotICAgIEFYSXNvbGF0ZWRUcmVlKiB0cmVlKCkgY29uc3Q7Ci0gICAgCisgICAgQVhJc29s YXRlZFRyZWUqIHRyZWUoKSBjb25zdCB7IHJldHVybiBtX2NhY2hlZFRyZWUuZ2V0KCk7IH0KKwog ICAgIEFYSXNvbGF0ZWRPYmplY3QoKSA9IGRlZmF1bHQ7CiAgICAgQVhJc29sYXRlZE9iamVjdChB WENvcmVPYmplY3QmLCBib29sIGlzUm9vdCk7CiAgICAgdm9pZCBpbml0aWFsaXplQXR0cmlidXRl RGF0YShBWENvcmVPYmplY3QmLCBib29sIGlzUm9vdCk7Cg==