207248 2020-02-04 20:09:29 -0800 [Web Inspector][WinCairo] Selecting an error message in Console causes "TypeError:​ selection.focusNode.closest is not a function." 2020-02-06 19:49:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198594 InRadar P2 Normal --- 1 fujii fujii hi inspector-bugzilla-changes stephan.szabo webkit-bug-importer oldest_to_newest 1614918 0 fujii 2020-02-04 20:09:29 -0800 [Web Inspector][WinCairo] The error "TypeError:​ selection.focusNode.closest is not a function." happens by selecting an error message I tested with WinCairo WK2, trunk, r255482. 1. Start MiniBrowser 2. Open Web Inspector 3. Open Console Tab 4. Enter "foo" 5. An error message "ReferenceError: Can't find variable: foo" is output 6. Press left mouse button on the string of the error message 6. Drug the mouse 7. "TypeError:​ selection.focusNode.closest is not a function." happens These uncaught exceptions caused the problem: TypeError:​ selection.focusNode.closest is not a function. (In 'selection.focusNode.closest("." + WI.LogContentView.ItemWrapperStyleClassName)​', 'selection.focusNode.closest' is undefined)​ (at LogContentView.js:​552:​54)​ _mousemove @ LogContentView.js:​552:​54 handleEvent @ LogContentView.js:​653:​28 I don't see this issue in Mac port. 1614934 1 stephan.szabo 2020-02-04 21:02:33 -0800 Hmm, Devin Rousso seems to have reported similar for mac at https://bugs.webkit.org/show_bug.cgi?id=198594 1614939 2 fujii 2020-02-04 21:59:45 -0800 Looks a same issue. Thanks. But surprisingly Mac port doesn't reproduce the issue even this Bug 198594's test case on my Mac. 🤔 1615578 3 fujii 2020-02-06 02:20:13 -0800 selection.focusNode is a Text node at the time. closest is a method of Element. 1615580 4 fujii 2020-02-06 02:40:27 -0800 The code was added by r242174 (Bug 173747). 1615582 5 389941 fujii 2020-02-06 02:46:43 -0800 Created attachment 389941 Patch 1615681 6 389941 hi 2020-02-06 09:24:24 -0800 Comment on attachment 389941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389941&action=review r=me > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:552 > + var focusElement = selection.focusNode; Style: we prefer using `let` 1615967 7 390037 fujii 2020-02-06 17:56:14 -0800 Created attachment 390037 Patch for landing Thank you for the reveiw. 1616027 8 fujii 2020-02-06 19:48:13 -0800 Committed r256006: <https://trac.webkit.org/changeset/256006> 1616028 9 webkit-bug-importer 2020-02-06 19:49:13 -0800 <rdar://problem/59249046> 389941 2020-02-06 02:46:43 -0800 2020-02-06 17:55:57 -0800 Patch bug-207248-20200206194642.patch text/plain 2255 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy M2ZlODg1YTMzZWNhZjhkMjdjOGUwZTBlNWI2NDhjNDIwZTI4ZWE4Li45NzA2MmQxY2ZjMTM0Nzli OGI5OTEyODU0ZmUyOGVlOTIxZGUxODJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wMi0wNiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2ViIEluc3BlY3Rvcl1bV2luQ2Fpcm9dIFNlbGVjdGluZyBh biBlcnJvciBtZXNzYWdlIGluIENvbnNvbGUgY2F1c2VzICJUeXBlRXJyb3I64oCLIHNlbGVjdGlv bi5mb2N1c05vZGUuY2xvc2VzdCBpcyBub3QgYSBmdW5jdGlvbi4iCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcyNDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjQyMTc0IHJlcGxhY2VkIE5vZGUuZW5j bG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcyB3aXRoCisgICAgICAgIEVsZW1lbnQuY2xvc2VzdC4g SG93ZXZlciwgc2VsZWN0aW9uLmZvY3VzTm9kZSBpc24ndCBuZWNlc3NhcmlseSBhbgorICAgICAg ICBFbGVtZW50LCBidXQgY2FuIGJlIGEgVGV4dCBub2RlLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkxvZ0NvbnRlbnRWaWV3 LnByb3RvdHlwZS5fbW91c2Vtb3ZlKTogVXNlIHNlbGVjdGlvbi5mb2N1c05vZGUucGFyZW50RWxl bWVudC5jbG9zZXN0CisgICAgICAgIGlmIHNlbGVjdGlvbi5mb2N1c05vZGUgaXMgbm90IGEgaW5z dGFuY2Ugb2YgRWxlbWVudC4KKwogMjAyMC0wMi0wNSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogdGhlIGhlaWdodCBvZiB0aGUgdW5k b2NrZWQgdGl0bGUgYXJlYSBzaG91bGRuJ3QgY2hhbmdlIHdoZW4gem9vbWVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRl bnRWaWV3LmpzCmluZGV4IDk5NzJiMDU2NGFjMGFjNzJmMGQxYWQwMDNjMmM1NTNmMjE2YmE4OTYu LmJlNzZhZWZkOTUwZDUxY2UzOTlmMGE2ODAzNmRhODk1ZjkxY2E0ZDcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRl bnRWaWV3LmpzCkBAIC01NDgsOCArNTQ4LDEyIEBAIFdJLkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3Mg TG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgICAgIGlmICghd3Jh cHBlcikgewogICAgICAgICAgICAgLy8gTm8gd3JhcHBlciB1bmRlciB0aGUgbW91c2UsIHNvIGxv b2sgYXQgdGhlIHNlbGVjdGlvbiB0byB0cnkgYW5kIGZpbmQgb25lLgotICAgICAgICAgICAgaWYg KCFzZWxlY3Rpb24uaXNDb2xsYXBzZWQpCi0gICAgICAgICAgICAgICAgd3JhcHBlciA9IHNlbGVj dGlvbi5mb2N1c05vZGUuY2xvc2VzdCgiLiIgKyBXSS5Mb2dDb250ZW50Vmlldy5JdGVtV3JhcHBl clN0eWxlQ2xhc3NOYW1lKTsKKyAgICAgICAgICAgIGlmICghc2VsZWN0aW9uLmlzQ29sbGFwc2Vk KSB7CisgICAgICAgICAgICAgICAgdmFyIGZvY3VzRWxlbWVudCA9IHNlbGVjdGlvbi5mb2N1c05v ZGU7CisgICAgICAgICAgICAgICAgaWYgKCEoZm9jdXNFbGVtZW50IGluc3RhbmNlb2YgRWxlbWVu dCkpCisgICAgICAgICAgICAgICAgICAgIGZvY3VzRWxlbWVudCA9IGZvY3VzRWxlbWVudC5wYXJl bnRFbGVtZW50OworICAgICAgICAgICAgICAgIHdyYXBwZXIgPSBmb2N1c0VsZW1lbnQuY2xvc2Vz dCgiLiIgKyBXSS5Mb2dDb250ZW50Vmlldy5JdGVtV3JhcHBlclN0eWxlQ2xhc3NOYW1lKTsKKyAg ICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKCF3cmFwcGVyKSB7CiAgICAgICAgICAgICAg ICAgc2VsZWN0aW9uLnJlbW92ZUFsbFJhbmdlcygpOwo= 390037 2020-02-06 17:56:14 -0800 2020-02-06 17:56:14 -0800 Patch for landing bug-207248-20200207105613.patch text/plain 2263 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NGQ3N2FhYmZiMzAyMzNiMWI1NTU4ZmU0YWU1MzQ3MDQ3NjRmMDk1Li45Y2I0OWU3M2QxM2ZkOTM2 ODk3ZTVmMDlhMjIzZGE5ZDZkOGMwYWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wMi0wNiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2ViIEluc3BlY3Rvcl1bV2luQ2Fpcm9dIFNlbGVjdGluZyBh biBlcnJvciBtZXNzYWdlIGluIENvbnNvbGUgY2F1c2VzICJUeXBlRXJyb3I64oCLIHNlbGVjdGlv bi5mb2N1c05vZGUuY2xvc2VzdCBpcyBub3QgYSBmdW5jdGlvbi4iCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcyNDgKKworICAgICAgICBSZXZpZXdl ZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgcjI0MjE3NCByZXBsYWNlZCBOb2RlLmVuY2xv c2luZ05vZGVPclNlbGZXaXRoQ2xhc3Mgd2l0aAorICAgICAgICBFbGVtZW50LmNsb3Nlc3QuIEhv d2V2ZXIsIHNlbGVjdGlvbi5mb2N1c05vZGUgaXNuJ3QgbmVjZXNzYXJpbHkgYW4KKyAgICAgICAg RWxlbWVudCwgYnV0IGNhbiBiZSBhIFRleHQgbm9kZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5Mb2dDb250ZW50Vmlldy5w cm90b3R5cGUuX21vdXNlbW92ZSk6IFVzZSBzZWxlY3Rpb24uZm9jdXNOb2RlLnBhcmVudEVsZW1l bnQuY2xvc2VzdAorICAgICAgICBpZiBzZWxlY3Rpb24uZm9jdXNOb2RlIGlzIG5vdCBhIGluc3Rh bmNlIG9mIEVsZW1lbnQuCisKIDIwMjAtMDItMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04ocjI0OTgzMSk6IFNv dXJjZXM6IGVuZGxlc3Mgc3Bpbm5lciB3aGVuIHRyeWluZyB0byB2aWV3IGEgcmVzb3VyY2UKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0Nv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TG9nQ29udGVudFZpZXcuanMKaW5kZXggOTk3MmIwNTY0YWMwYWM3MmYwZDFhZDAwM2MyYzU1M2Yy MTZiYTg5Ni4uYmViYzA0NjkyYzA5MjFlOGY4ZmMwZGJjYzJlYWY3NjQ5NzQzM2Q0NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVu dFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TG9nQ29udGVudFZpZXcuanMKQEAgLTU0OCw4ICs1NDgsMTIgQEAgV0kuTG9nQ29udGVudFZpZXcg PSBjbGFzcyBMb2dDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAKICAgICAgICAg aWYgKCF3cmFwcGVyKSB7CiAgICAgICAgICAgICAvLyBObyB3cmFwcGVyIHVuZGVyIHRoZSBtb3Vz ZSwgc28gbG9vayBhdCB0aGUgc2VsZWN0aW9uIHRvIHRyeSBhbmQgZmluZCBvbmUuCi0gICAgICAg ICAgICBpZiAoIXNlbGVjdGlvbi5pc0NvbGxhcHNlZCkKLSAgICAgICAgICAgICAgICB3cmFwcGVy ID0gc2VsZWN0aW9uLmZvY3VzTm9kZS5jbG9zZXN0KCIuIiArIFdJLkxvZ0NvbnRlbnRWaWV3Lkl0 ZW1XcmFwcGVyU3R5bGVDbGFzc05hbWUpOworICAgICAgICAgICAgaWYgKCFzZWxlY3Rpb24uaXND b2xsYXBzZWQpIHsKKyAgICAgICAgICAgICAgICBsZXQgZm9jdXNFbGVtZW50ID0gc2VsZWN0aW9u LmZvY3VzTm9kZTsKKyAgICAgICAgICAgICAgICBpZiAoIShmb2N1c0VsZW1lbnQgaW5zdGFuY2Vv ZiBFbGVtZW50KSkKKyAgICAgICAgICAgICAgICAgICAgZm9jdXNFbGVtZW50ID0gZm9jdXNFbGVt ZW50LnBhcmVudEVsZW1lbnQ7CisgICAgICAgICAgICAgICAgd3JhcHBlciA9IGZvY3VzRWxlbWVu dC5jbG9zZXN0KCIuIiArIFdJLkxvZ0NvbnRlbnRWaWV3Lkl0ZW1XcmFwcGVyU3R5bGVDbGFzc05h bWUpOworICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBpZiAoIXdyYXBwZXIpIHsKICAgICAg ICAgICAgICAgICBzZWxlY3Rpb24ucmVtb3ZlQWxsUmFuZ2VzKCk7Cg==