207180 2020-02-03 19:39:32 -0800 Web Inspector: REGRESSION(r248287): Console: function objects saved to a $n will be invoked instead of just referenced when evaluating in the Console 2020-02-04 07:59:50 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 195834 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1614362 0 hi 2020-02-03 19:39:32 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. evaluate `function foo() { return "test"; }` in the Console 3. evaluate `foo` => should see `$1` 4. evaluate `$1` => `"test"` is logged instead of `function foo() { return "test"; }` 1614363 1 hi 2020-02-03 19:39:50 -0800 <rdar://problem/58860268> 1614364 2 389620 hi 2020-02-03 19:44:03 -0800 Created attachment 389620 Patch 1614415 3 389620 joepeck 2020-02-03 22:23:20 -0800 Comment on attachment 389620 Patch Nice. r=me 1614536 4 389620 commit-queue 2020-02-04 07:59:48 -0800 Comment on attachment 389620 Patch Clearing flags on attachment: 389620 Committed r255675: <https://trac.webkit.org/changeset/255675> 1614537 5 commit-queue 2020-02-04 07:59:50 -0800 All reviewed patches have been landed. Closing bug. 389620 2020-02-03 19:44:03 -0800 2020-02-04 07:59:48 -0800 Patch bug-207180-20200203194402.patch text/plain 6885 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE2NmU4OWZkZTc0ZTE2MTY4MzIxMmE1ZGZjYmIx NjljMjZiNjNkM2EuLmQzZWIxMGRmYjc1ODJiYjI1Mzg0MDVhZmRhMTk3MDBhMTUwMTBkZTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDgyODcpOiBDb25zb2xlOiBmdW5jdGlvbiBvYmplY3RzIHNhdmVkIHRvIGEg JG4gd2lsbCBiZSBpbnZva2VkIGluc3RlYWQgb2YganVzdCByZWZlcmVuY2VkIHdoZW4gZXZhbHVh dGluZyBpbiB0aGUgQ29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA3MTgwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg2MDI2OD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgKENvbW1hbmRMaW5lQVBJKToKKyAg ICAgICAgSW5zdGVhZCBvZiBkZWNpZGluZyB3aGV0aGVyIHRvIHdyYXAgdGhlIHZhbHVlIGdpdmVu IGZvciBhIGAkbmAgZ2V0dGVyIGJhc2VkIG9uIGlmIHRoZSB2YWx1ZQorICAgICAgICBpcyBhbHJl YWR5IGEgZnVuY3Rpb24sIGFsd2F5cyB3cmFwIGdldHRlciB2YWx1ZXMgaW4gYSBmdW5jdGlvbiBz byB0aGF0IGlmIHRoZSB2YWx1ZSBiZWluZworICAgICAgICBzdG9yZWQgaW4gdGhlIGdldHRlciBp cyBhbHJlYWR5IGEgZnVuY3Rpb24sIGl0IGlzbid0IHVzZWQgYXMgdGhlIGNhbGxiYWNrIGZvciB0 aGUgZ2V0dGVyIGFuZAorICAgICAgICB0aGVyZWZvcmUgaW52b2tlZCB3aGVuIHRoZSBnZXR0ZXIg aXMgcmVmZXJlbmNlZC4KKwogMjAyMC0wMi0wMyAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVz aEBnbWFpbC5jb20+CiAKICAgICAgICAgXDAgaWRlbnRpdHkgZXNjYXBlcyBzaG91bGQgYmUgc3lu dGF4IGVycm9ycyBpbiBVbmljb2RlIHBhdHRlcm5zIG9ubHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDZi ZGI0OWQ5MGRkZjRhZTYzZjg2NTJlZWE1MGJkN2QwMjBlMWI4ZjMuLmNkNTkzYTI0YWY0ZmUyNGJh NTk1NzdiNzNiMjY5NDc3NjVlZGNjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwpAQCAtMTQ2Niw4ICsxNDY2 LDggQEAgZnVuY3Rpb24gQ29tbWFuZExpbmVBUEkoY2FsbEZyYW1lKQogewogICAgIGxldCBzYXZl ZFJlc3VsdEFsaWFzID0gSW5qZWN0ZWRTY3JpcHRIb3N0LnNhdmVkUmVzdWx0QWxpYXM7CiAKLSAg ICBsZXQgZGVmaW5lR2V0dGVyID0gKGtleSwgdmFsdWUpID0+IHsKLSAgICAgICAgaWYgKHR5cGVv ZiB2YWx1ZSAhPT0gImZ1bmN0aW9uIikgeworICAgIGxldCBkZWZpbmVHZXR0ZXIgPSAoa2V5LCB2 YWx1ZSwgd3JhcCkgPT4geworICAgICAgICBpZiAod3JhcCkgewogICAgICAgICAgICAgbGV0IG9y aWdpbmFsVmFsdWUgPSB2YWx1ZTsKICAgICAgICAgICAgIHZhbHVlID0gZnVuY3Rpb24oKSB7IHJl dHVybiBvcmlnaW5hbFZhbHVlOyB9OwogICAgICAgICB9CkBAIC0xNDc4LDE3ICsxNDc4LDE3IEBA IGZ1bmN0aW9uIENvbW1hbmRMaW5lQVBJKGNhbGxGcmFtZSkKICAgICB9OwogCiAgICAgaWYgKCJf bGFzdFJlc3VsdCIgaW4gaW5qZWN0ZWRTY3JpcHQpCi0gICAgICAgIGRlZmluZUdldHRlcigiXyIs IGluamVjdGVkU2NyaXB0Ll9sYXN0UmVzdWx0KTsKKyAgICAgICAgZGVmaW5lR2V0dGVyKCJfIiwg aW5qZWN0ZWRTY3JpcHQuX2xhc3RSZXN1bHQsIHRydWUpOwogCiAgICAgaWYgKCJfZXhjZXB0aW9u VmFsdWUiIGluIGluamVjdGVkU2NyaXB0KQotICAgICAgICBkZWZpbmVHZXR0ZXIoImV4Y2VwdGlv biIsIGluamVjdGVkU2NyaXB0Ll9leGNlcHRpb25WYWx1ZSk7CisgICAgICAgIGRlZmluZUdldHRl cigiZXhjZXB0aW9uIiwgaW5qZWN0ZWRTY3JpcHQuX2V4Y2VwdGlvblZhbHVlLCB0cnVlKTsKIAog ICAgIGlmICgiX2V2ZW50VmFsdWUiIGluIGluamVjdGVkU2NyaXB0KQotICAgICAgICBkZWZpbmVH ZXR0ZXIoImV2ZW50IiwgaW5qZWN0ZWRTY3JpcHQuX2V2ZW50VmFsdWUpOworICAgICAgICBkZWZp bmVHZXR0ZXIoImV2ZW50IiwgaW5qZWN0ZWRTY3JpcHQuX2V2ZW50VmFsdWUsIHRydWUpOwogCiAg ICAgLy8gJDEtJDk5CiAgICAgZm9yIChsZXQgaSA9IDE7IGkgPCBpbmplY3RlZFNjcmlwdC5fc2F2 ZWRSZXN1bHRzLmxlbmd0aDsgKytpKQotICAgICAgICBkZWZpbmVHZXR0ZXIoaSwgaW5qZWN0ZWRT Y3JpcHQuX3NhdmVkUmVzdWx0c1tpXSk7CisgICAgICAgIGRlZmluZUdldHRlcihpLCBpbmplY3Rl ZFNjcmlwdC5fc2F2ZWRSZXN1bHRzW2ldLCB0cnVlKTsKIAogICAgIGZvciAobGV0IG5hbWUgaW4g Q29tbWFuZExpbmVBUEkuZ2V0dGVycykKICAgICAgICAgZGVmaW5lR2V0dGVyKG5hbWUsIENvbW1h bmRMaW5lQVBJLmdldHRlcnNbbmFtZV0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRjMTM4MTgzNjM2MTFlYjdmZmYwZGFl OWNhYzlmMTA5MWEyOGU5MmEuLjQ4NzQ5OGU3OGM1ZWRmNjkyMjVkZjc5OGQxMzVhNTM5NGNjYzU2 M2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMi0wMyAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjQ4 Mjg3KTogQ29uc29sZTogZnVuY3Rpb24gb2JqZWN0cyBzYXZlZCB0byBhICRuIHdpbGwgYmUgaW52 b2tlZCBpbnN0ZWFkIG9mIGp1c3QgcmVmZXJlbmNlZCB3aGVuIGV2YWx1YXRpbmcgaW4gdGhlIENv bnNvbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzE4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg4NjAyNjg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcnVudGltZS9zYXZl UmVzdWx0Lmh0bWw6CisgICAgICAgICogaW5zcGVjdG9yL3J1bnRpbWUvc2F2ZVJlc3VsdC1leHBl Y3RlZC50eHQ6CisKIDIwMjAtMDItMDMgIEphY29iIFVwaG9mZiAgPGphY29iX3VwaG9mZkBhcHBs ZS5jb20+CiAKICAgICAgICAgWyBtYWNPUyB3azEgXSBpbnNwZWN0b3IvdW5pdC10ZXN0cy9zZXJ2 ZXItdGltaW5nLWVudHJ5Lmh0bWwgaXMgZmxha3kgdGltZW91dApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL3J1bnRpbWUvc2F2ZVJlc3VsdC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvcnVudGltZS9zYXZlUmVzdWx0LWV4cGVjdGVkLnR4dAppbmRleCAyZTcy MWMzYzZmM2YwNzJiNjIxMGRkM2I5NDM3MmFlZDZjMTJiNjM3Li40YmEyZTI1ODdiNTZhNTc0M2Zj NzNjYjFkOGIwZDExYTlhZjYwYjdlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv cnVudGltZS9zYXZlUmVzdWx0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvcnVudGltZS9zYXZlUmVzdWx0LWV4cGVjdGVkLnR4dApAQCAtMzQsMyArMzQsMTAgQEAgUEFT UzogVmFsdWUgOTk5IHNob3VsZCBiZWNvbWUgJDEuCiBQQVNTOiBFdmFsdWF0ZWQgcmVzdWx0IDk5 MCBzaG91bGQgYmVjb21lICQyLgogUEFTUzogRXZhbHVhdGVkIHJlc3VsdCA5OTkgc2hvdWxkIG1h dGNoIHByZXZpb3VzIHZhbHVlICQxLgogCistLSBSdW5uaW5nIHRlc3QgY2FzZTogU2F2ZUZ1bmN0 aW9uVmFsdWUKK1BBU1M6IEZ1bmN0aW9uIHNob3VsZCBiZWNvbWUgJDMuCitQQVNTOiBTYXZlZCB2 YWx1ZSBzaG91bGQgbWF0Y2ggcHJldmlvdXMgdmFsdWUgJDMuCitQQVNTOiBFdmFsdWF0ZWQgZnVu Y3Rpb24gc2hvdWxkIG1hdGNoIHByZXZpb3VzIHZhbHVlICQzLgorUEFTUzogQ2FsbGluZyBzYXZl ZCBmdW5jdGlvbiBzaG91bGQgYmVjb21lICQ0LgorUEFTUzogQ2FsbGluZyBzYXZlZCBmdW5jdGlv biBzaG91bGQgcmV0dXJuIGV4cGVjdGVkIHZhbHVlLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvcnVudGltZS9zYXZlUmVzdWx0Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvcnVudGltZS9zYXZlUmVzdWx0Lmh0bWwKaW5kZXggY2ExZDE3MDI2OTZlNzM4ODVkYjUwNDI3 N2IwNzE3NzIxNGM5ZDFhNi4uYjI3ODY1NGRjMTkyMGFlOWFiNDQyZmU4NDBhM2JkYjNlNmVhNmYz NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3J1bnRpbWUvc2F2ZVJlc3VsdC5o dG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1lL3NhdmVSZXN1bHQuaHRtbApA QCAtMTcxLDYgKzE3MSwzMSBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgfQogICAgIH0pOwog CisgICAgLy8gLS0tLS0tCisKKyAgICBzdWl0ZS5hZGRUZXN0Q2FzZSh7CisgICAgICAgIG5hbWU6 ICJTYXZlRnVuY3Rpb25WYWx1ZSIsCisgICAgICAgIGRlc2NyaXB0aW9uOiAiRW5zdXJlIHRoYXQg c2F2aW5nIGEgZnVuY3Rpb24gb2JqZWN0IGRvZXNuJ3QgZXZhbHVhdGUgdGhlIGZ1bmN0aW9uIG9i amVjdCB3aGVuIGZldGNoaW5nIGl0IHZpYSBhICRuIGdldHRlci4iLAorICAgICAgICBhc3luYyB0 ZXN0KCkgeworICAgICAgICAgICAgY29uc3QgZnVuY3Rpb25OYW1lID0gInRlc3RTYXZlRnVuY3Rp b25WYWx1ZSI7CisgICAgICAgICAgICBjb25zdCBmdW5jdGlvblJldHVybiA9ICJ0ZXN0U2F2ZUZ1 bmN0aW9uVmFsdWUgUmV0dXJuIFZhbHVlIjsKKworICAgICAgICAgICAgbGV0IGNyZWF0ZUZ1bmN0 aW9uRXZhbHVhdGVSZXN1bHQgPSBhd2FpdCBSdW50aW1lQWdlbnQuZXZhbHVhdGUuaW52b2tlKHtl eHByZXNzaW9uOiBgZnVuY3Rpb24gJHtmdW5jdGlvbk5hbWV9KCkgeyByZXR1cm4gIiR7ZnVuY3Rp b25SZXR1cm59IjsgfSAke2Z1bmN0aW9uTmFtZX1gLCBvYmplY3RHcm91cDogInRlc3QiLCBpbmNs dWRlQ29tbWFuZExpbmVBUEk6IHRydWUsIHNhdmVSZXN1bHQ6IHRydWV9KTsKKyAgICAgICAgICAg IEluc3BlY3RvclRlc3QuYXNzZXJ0KCFjcmVhdGVGdW5jdGlvbkV2YWx1YXRlUmVzdWx0LmVycm9y LCAiU2hvdWxkIG5vdCBiZSBhIHByb3RvY29sIGVycm9yLiIpOworICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5leHBlY3RFcXVhbChjcmVhdGVGdW5jdGlvbkV2YWx1YXRlUmVzdWx0LnNhdmVkUmVz dWx0SW5kZXgsIDMsICJGdW5jdGlvbiBzaG91bGQgYmVjb21lICQzLiIpOworCisgICAgICAgICAg ICBsZXQgZ2V0U2F2ZWRWYWx1ZUV2YWx1YXRlUmVzdWx0ID0gYXdhaXQgUnVudGltZUFnZW50LmV2 YWx1YXRlLmludm9rZSh7ZXhwcmVzc2lvbjogYCQzYCwgb2JqZWN0R3JvdXA6ICJ0ZXN0IiwgaW5j bHVkZUNvbW1hbmRMaW5lQVBJOiB0cnVlLCBzYXZlUmVzdWx0OiB0cnVlfSk7CisgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmFzc2VydCghZ2V0U2F2ZWRWYWx1ZUV2YWx1YXRlUmVzdWx0LmVycm9y LCAiU2hvdWxkIG5vdCBiZSBhIHByb3RvY29sIGVycm9yLiIpOworICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5leHBlY3RFcXVhbChnZXRTYXZlZFZhbHVlRXZhbHVhdGVSZXN1bHQuc2F2ZWRSZXN1 bHRJbmRleCwgMywgIlNhdmVkIHZhbHVlIHNob3VsZCBtYXRjaCBwcmV2aW91cyB2YWx1ZSAkMy4i KTsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwoY3JlYXRlRnVuY3Rpb25F dmFsdWF0ZVJlc3VsdC5yZXN1bHQuZGVzY3JpcHRpb24sIGdldFNhdmVkVmFsdWVFdmFsdWF0ZVJl c3VsdC5yZXN1bHQuZGVzY3JpcHRpb24sICJFdmFsdWF0ZWQgZnVuY3Rpb24gc2hvdWxkIG1hdGNo IHByZXZpb3VzIHZhbHVlICQzLiIpOworCisgICAgICAgICAgICBsZXQgY2FsbEZ1bmN0aW9uRXZh bHVhdGVSZXN1bHQgPSBhd2FpdCBSdW50aW1lQWdlbnQuZXZhbHVhdGUuaW52b2tlKHtleHByZXNz aW9uOiBmdW5jdGlvbk5hbWUgKyAiKCkiLCBvYmplY3RHcm91cDogInRlc3QiLCBpbmNsdWRlQ29t bWFuZExpbmVBUEk6IHRydWUsIHNhdmVSZXN1bHQ6IHRydWV9KTsKKyAgICAgICAgICAgIEluc3Bl Y3RvclRlc3QuYXNzZXJ0KCFjYWxsRnVuY3Rpb25FdmFsdWF0ZVJlc3VsdC5lcnJvciwgIlNob3Vs ZCBub3QgYmUgYSBwcm90b2NvbCBlcnJvci4iKTsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu ZXhwZWN0RXF1YWwoY2FsbEZ1bmN0aW9uRXZhbHVhdGVSZXN1bHQuc2F2ZWRSZXN1bHRJbmRleCwg NCwgIkNhbGxpbmcgc2F2ZWQgZnVuY3Rpb24gc2hvdWxkIGJlY29tZSAkNC4iKTsKKyAgICAgICAg ICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwoY2FsbEZ1bmN0aW9uRXZhbHVhdGVSZXN1bHQu cmVzdWx0LnZhbHVlLCBmdW5jdGlvblJldHVybiwgIkNhbGxpbmcgc2F2ZWQgZnVuY3Rpb24gc2hv dWxkIHJldHVybiBleHBlY3RlZCB2YWx1ZS4iKTsKKyAgICAgICAgfQorICAgIH0pOworCiAgICAg c3VpdGUucnVuVGVzdENhc2VzQW5kRmluaXNoKCk7CiB9CiA8L3NjcmlwdD4K