207137 2020-02-03 11:54:14 -0800 Crash in WebCore::IDBServer::IDBServer::createIndex 2020-02-03 16:31:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson cdumez commit-queue darin ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1614072 0 sihui_liu 2020-02-03 11:54:14 -0800 0 com.apple.WebCore WTF::StringImpl::ref() + 12 (StringImpl.h:1098) 1 com.apple.WebCore void WTF::refIfNotNull<WTF::StringImpl>(WTF::StringImpl*) + 46 (RefPtr.h:39) 2 com.apple.WebCore WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::RefPtr(WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > const&) + 46 (RefPtr.h:59) 3 com.apple.WebCore WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::RefPtr(WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > const&) + 29 (RefPtr.h:59) 4 com.apple.WebCore WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::operator=(WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > const&) + 37 5 com.apple.WebCore WTF::String::operator=(WTF::String const&) + 36 (WTFString.h:134) 6 com.apple.WebCore void WTF::__copy_assign_op_table<WTF::Variant<WTF::String, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::__index_sequence<0l, 1l> >::__copy_assign_func<0l>(WTF::Variant<WTF::String, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >*, WTF::Variant<WTF::String, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > const&) + 50 (Variant.h:800) 7 com.apple.WebCore WTF::Variant<WTF::String, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >::operator=(WTF::Variant<WTF::String, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > const&) + 125 (Variant.h:1633) 8 com.apple.WebCore WebCore::IDBIndexInfo::operator=(WebCore::IDBIndexInfo const&) + 111 (IDBIndexInfo.h:35) 9 com.apple.WebCore void WTF::GenericHashTraits<WebCore::IDBIndexInfo>::assignToEmpty<WebCore::IDBIndexInfo, WebCore::IDBIndexInfo const&>(WebCore::IDBIndexInfo&, WebCore::IDBIndexInfo const&) + 37 (HashTraits.h:73) 10 com.apple.WebCore void WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WebCore::IDBIndexInfo, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebCore::IDBIndexInfo> >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >::translate<WTF::KeyValuePair<unsigned long long, WebCore::IDBIndexInfo>, unsigned long long, WebCore::IDBIndexInfo const&>(WTF::KeyValuePair<unsigned long long, WebCore::IDBIndexInfo>&, unsigned long long&&, WebCore::IDBIndexInfo const&) + 87 (HashMap.h:210) ... 16 com.apple.WebCore WebCore::IDBServer::SQLiteIDBBackingStore::createIndex(WebCore::IDBResourceIdentifier const&, WebCore::IDBIndexInfo const&) + 3659 (SQLiteIDBBackingStore.cpp:1385) 17 com.apple.WebCore WebCore::IDBServer::UniqueIDBDatabase::createIndex(WebCore::IDBServer::UniqueIDBDatabaseTransaction&, WebCore::IDBIndexInfo const&, WTF::Function<void (WebCore::IDBError const&)>) + 491 (UniqueIDBDatabase.cpp:631) 18 com.apple.WebCore WebCore::IDBServer::UniqueIDBDatabaseTransaction::createIndex(WebCore::IDBRequestData const&, WebCore::IDBIndexInfo const&) + 523 (UniqueIDBDatabaseTransaction.cpp:202) 19 com.apple.WebCore WebCore::IDBServer::IDBServer::createIndex(WebCore::IDBRequestData const&, WebCore::IDBIndexInfo const&) + 429 (IDBServer.cpp:268) 20 com.apple.WebKitLegacy InProcessIDBServer::createIndex(WebCore::IDBRequestData const&, WebCore::IDBIndexInfo const&)::$_30::operator()() const + 116 (InProcessIDBServer.cpp:328) 21 com.apple.WebKitLegacy WTF::Detail::CallableWrapper<InProcessIDBServer::createIndex(WebCore::IDBRequestData const&, WebCore::IDBIndexInfo const&)::$_30, void>::call() + 30 (Function.h:52) 1614073 1 sihui_liu 2020-02-03 11:54:55 -0800 <rdar://problem/59096231> 1614074 2 389544 sihui_liu 2020-02-03 11:56:35 -0800 Created attachment 389544 Patch 1614091 3 cdumez 2020-02-03 12:48:57 -0800 That's a lot of red bubbles you got there :) 1614169 4 389544 darin 2020-02-03 14:29:37 -0800 Comment on attachment 389544 Patch Need to add WEBCORE_EXPORT to the function. 1614217 5 389581 sihui_liu 2020-02-03 15:27:38 -0800 Created attachment 389581 Patch 1614235 6 389581 darin 2020-02-03 15:47:08 -0800 Comment on attachment 389581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389581&action=review > Source/WebCore/ChangeLog:11 > + No behavior change. > + > + * Modules/indexeddb/shared/IDBIndexInfo.h: This is not a great way to write the change log. Ideally the comment on the file would say something like "Export IDBIndexInfo::isolatedCopy so it can be used in WebKitLegacy framework code." Replacing the line about testing with "No behavior change" is also not great. Just deleting it is better. After all, the patch does create a behavior change, although it’s the part of the change in WebKitLegacy rather than the part in WebCore, so it’s not accurate. > Source/WebKitLegacy/ChangeLog:9 > + Create an isolated copy of IDBIndexInfo before passing it to IDB thread. Seems like this comment should be on the function line rather than up here. 1614242 7 sihui_liu 2020-02-03 15:52:24 -0800 (In reply to Darin Adler from comment #6) > Comment on attachment 389581 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389581&action=review > > > Source/WebCore/ChangeLog:11 > > + No behavior change. > > + > > + * Modules/indexeddb/shared/IDBIndexInfo.h: > > This is not a great way to write the change log. Ideally the comment on the > file would say something like "Export IDBIndexInfo::isolatedCopy so it can > be used in WebKitLegacy framework code." > > Replacing the line about testing with "No behavior change" is also not > great. Just deleting it is better. After all, the patch does create a > behavior change, although it’s the part of the change in WebKitLegacy rather > than the part in WebCore, so it’s not accurate. > > > Source/WebKitLegacy/ChangeLog:9 > > + Create an isolated copy of IDBIndexInfo before passing it to IDB thread. > > Seems like this comment should be on the function line rather than up here. Will change. Thanks for the review! 1614244 8 389585 sihui_liu 2020-02-03 15:55:00 -0800 Created attachment 389585 Patch for landing 1614273 9 389585 commit-queue 2020-02-03 16:31:07 -0800 Comment on attachment 389585 Patch for landing Clearing flags on attachment: 389585 Committed r255615: <https://trac.webkit.org/changeset/255615> 1614274 10 commit-queue 2020-02-03 16:31:09 -0800 All reviewed patches have been landed. Closing bug. 389544 2020-02-03 11:56:35 -0800 2020-02-03 15:27:35 -0800 Patch bug-207137-20200203115634.patch text/plain 1735 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IDQ4NmMw MTQ1YjcwMjhhNTBhZjU4MjA0YjZjYTMyMjMyOTAyODBjMzkuLjRhOGJlMDkwNGY5MzI0OGMxN2Zh MjAwOWE0M2ZmMmE3NDc0MzVlYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMjAtMDItMDMgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAg ICAgQ3Jhc2ggaW4gV2ViQ29yZTo6SURCU2VydmVyOjpJREJTZXJ2ZXI6OmNyZWF0ZUluZGV4Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcxMzcKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5MDk2MjMxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBhbiBpc29sYXRlZCBjb3B5IG9mIElEQklu ZGV4SW5mbyBiZWZvcmUgcGFzc2luZyBpdCB0byBJREIgdGhyZWFkLgorCisgICAgICAgICogU3Rv cmFnZS9JblByb2Nlc3NJREJTZXJ2ZXIuY3BwOgorICAgICAgICAoSW5Qcm9jZXNzSURCU2VydmVy OjpjcmVhdGVJbmRleCk6CisKIDIwMjAtMDEtMjAgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFw cGxlLmNvbT4KIAogICAgICAgICBGaXggbWlzc2luZyBoZWFkZXIgZ3VhcmRzIGFuZCBjbGVhbiB1 cCBlbXB0eSBmaWxlcyBpbiBXZWJDb3JlLCBXZWJLaXRMZWdhY3ksIFdlYktpdCwgVG9vbHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvU3RvcmFnZS9JblByb2Nlc3NJREJTZXJ2ZXIu Y3BwIGIvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNlcnZlci5jcHAK aW5kZXggOWJjNGIzNjMwZTMxYjZjYTk3YmU1OTU1ODI5YjQ2YWYzYzhiZDZjYy4uYTU0OWIwNDkw NWM2YTIyM2NkNjc2YzA5MGMwNGE0YjcxNzJlN2ZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYktp dExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNlcnZlci5jcHAKQEAgLTMyMiw3ICszMjIsNyBA QCB2b2lkIEluUHJvY2Vzc0lEQlNlcnZlcjo6Y2xlYXJPYmplY3RTdG9yZShjb25zdCBXZWJDb3Jl OjpJREJSZXF1ZXN0RGF0YSYgcmVxdWVzdAogCiB2b2lkIEluUHJvY2Vzc0lEQlNlcnZlcjo6Y3Jl YXRlSW5kZXgoY29uc3QgV2ViQ29yZTo6SURCUmVxdWVzdERhdGEmIHJlcXVlc3REYXRhLCBjb25z dCBJREJJbmRleEluZm8mIGluZm8pCiB7Ci0gICAgZGlzcGF0Y2hUYXNrKFt0aGlzLCBwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIHJlcXVlc3REYXRhID0gcmVxdWVzdERhdGEuaXNvbGF0 ZWRDb3B5KCksIGluZm9dIHsKKyAgICBkaXNwYXRjaFRhc2soW3RoaXMsIHByb3RlY3RlZFRoaXMg PSBtYWtlUmVmKCp0aGlzKSwgcmVxdWVzdERhdGEgPSByZXF1ZXN0RGF0YS5pc29sYXRlZENvcHko KSwgaW5mbyA9IGluZm8uaXNvbGF0ZWRDb3B5KCldIHsKICAgICAgICAgTG9ja0hvbGRlciBsb2Nr ZXIobV9zZXJ2ZXItPmxvY2soKSk7CiAgICAgICAgIG1fc2VydmVyLT5jcmVhdGVJbmRleChyZXF1 ZXN0RGF0YSwgaW5mbyk7CiAgICAgfSk7Cg== 389581 2020-02-03 15:27:38 -0800 2020-02-03 15:54:57 -0800 Patch bug-207137-20200203152736.patch text/plain 3175 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2VjZmE5MzIyYzc1ZjUy MmJkYzgxNGFlNTNjZTI0MmUyODZkOTgyNC4uMThlMGYxYjA1Zjg3MTYzZWZmNzRhYzg4YzExNDBh NTYwN2UwN2NlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6 OklEQlNlcnZlcjo6SURCU2VydmVyOjpjcmVhdGVJbmRleAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MTM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81OTA5NjIzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9z aGFyZWQvSURCSW5kZXhJbmZvLmg6CisKIDIwMjAtMDItMDMgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIEFjY2VsZXJhdGVkIGFu aW1hdGlvbnMgZG9uJ3QgcnVuIHVudGlsIHRoZWlyIG5hdHVyYWwgY29tcGxldGlvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5 L0NoYW5nZUxvZwppbmRleCA3N2FjODdiYjVlZjU2YjBiNTU5MmVjYzJkODgxYzc3NjhiYmY4ZTY0 Li5iYmU4OTAwYzYyYjlmYTI2NjJkZTNhOGM5YmJjNDVkNTMxYjU4YWI3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0TGVnYWN5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTAzICBTaWh1aSBMaXUgIDxzaWh1aV9s aXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OklEQlNlcnZlcjo6SURC U2VydmVyOjpjcmVhdGVJbmRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA3MTM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTA5NjIzMT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgYW4g aXNvbGF0ZWQgY29weSBvZiBJREJJbmRleEluZm8gYmVmb3JlIHBhc3NpbmcgaXQgdG8gSURCIHRo cmVhZC4KKworICAgICAgICAqIFN0b3JhZ2UvSW5Qcm9jZXNzSURCU2VydmVyLmNwcDoKKyAgICAg ICAgKEluUHJvY2Vzc0lEQlNlcnZlcjo6Y3JlYXRlSW5kZXgpOgorCiAyMDIwLTAxLTMxICBEb24g T2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBBZGQg X1BSSVZBVEVfTElCUkFSSUVTIHRvIGZyYW1ld29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvc2hhcmVkL0lEQkluZGV4SW5mby5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvc2hhcmVkL0lEQkluZGV4SW5mby5oCmluZGV4IDFlMzc0MTc5 MmExYTYxMDdmMTg3MmU0OWVmZTNmOGUyM2M2NDI2MjYuLjI1NGNkOTE5MDU0MGY2ZTc0OTEwMjli NmY0MThhN2QxZWEzMjYxZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k ZXhlZGRiL3NoYXJlZC9JREJJbmRleEluZm8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9zaGFyZWQvSURCSW5kZXhJbmZvLmgKQEAgLTM3LDcgKzM3LDcgQEAgcHVibGlj OgogICAgIFdFQkNPUkVfRVhQT1JUIElEQkluZGV4SW5mbygpOwogICAgIElEQkluZGV4SW5mbyh1 aW50NjRfdCBpZGVudGlmaWVyLCB1aW50NjRfdCBvYmplY3RTdG9yZUlkZW50aWZpZXIsIGNvbnN0 IFN0cmluZyYgbmFtZSwgSURCS2V5UGF0aCYmLCBib29sIHVuaXF1ZSwgYm9vbCBtdWx0aUVudHJ5 KTsKIAotICAgIElEQkluZGV4SW5mbyBpc29sYXRlZENvcHkoKSBjb25zdDsKKyAgICBXRUJDT1JF X0VYUE9SVCBJREJJbmRleEluZm8gaXNvbGF0ZWRDb3B5KCkgY29uc3Q7CiAKICAgICB1aW50NjRf dCBpZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9pZGVudGlmaWVyOyB9CiAgICAgdWludDY0 X3Qgb2JqZWN0U3RvcmVJZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9vYmplY3RTdG9yZUlk ZW50aWZpZXI7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvU3RvcmFnZS9JblBy b2Nlc3NJREJTZXJ2ZXIuY3BwIGIvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vz c0lEQlNlcnZlci5jcHAKaW5kZXggOWJjNGIzNjMwZTMxYjZjYTk3YmU1OTU1ODI5YjQ2YWYzYzhi ZDZjYy4uYTU0OWIwNDkwNWM2YTIyM2NkNjc2YzA5MGMwNGE0YjcxNzJlN2ZhMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNlcnZlci5jcHAKKysr IGIvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNlcnZlci5jcHAKQEAg LTMyMiw3ICszMjIsNyBAQCB2b2lkIEluUHJvY2Vzc0lEQlNlcnZlcjo6Y2xlYXJPYmplY3RTdG9y ZShjb25zdCBXZWJDb3JlOjpJREJSZXF1ZXN0RGF0YSYgcmVxdWVzdAogCiB2b2lkIEluUHJvY2Vz c0lEQlNlcnZlcjo6Y3JlYXRlSW5kZXgoY29uc3QgV2ViQ29yZTo6SURCUmVxdWVzdERhdGEmIHJl cXVlc3REYXRhLCBjb25zdCBJREJJbmRleEluZm8mIGluZm8pCiB7Ci0gICAgZGlzcGF0Y2hUYXNr KFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIHJlcXVlc3REYXRhID0gcmVx dWVzdERhdGEuaXNvbGF0ZWRDb3B5KCksIGluZm9dIHsKKyAgICBkaXNwYXRjaFRhc2soW3RoaXMs IHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgcmVxdWVzdERhdGEgPSByZXF1ZXN0RGF0 YS5pc29sYXRlZENvcHkoKSwgaW5mbyA9IGluZm8uaXNvbGF0ZWRDb3B5KCldIHsKICAgICAgICAg TG9ja0hvbGRlciBsb2NrZXIobV9zZXJ2ZXItPmxvY2soKSk7CiAgICAgICAgIG1fc2VydmVyLT5j cmVhdGVJbmRleChyZXF1ZXN0RGF0YSwgaW5mbyk7CiAgICAgfSk7Cg== 389585 2020-02-03 15:55:00 -0800 2020-02-03 16:31:07 -0800 Patch for landing bug-207137-20200203155458.patch text/plain 3222 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2VjZmE5MzIyYzc1ZjUy MmJkYzgxNGFlNTNjZTI0MmUyODZkOTgyNC4uOGU5Y2M5YWQ3Y2UzMWQyNTAyYmU3OTgwODU2NWUz ZGZiMzNjMTYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6 OklEQlNlcnZlcjo6SURCU2VydmVyOjpjcmVhdGVJbmRleAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MTM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81OTA5NjIzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAg ICBFeHBvcnQgSURCSW5kZXhJbmZvOjppc29sYXRlZENvcHkgc28gaXQgY2FuIGJlIHVzZWQgaW4g V2ViS2l0TGVnYWN5IGZyYW1ld29yayBjb2RlLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVk ZGIvc2hhcmVkL0lEQkluZGV4SW5mby5oOgorCiAyMDIwLTAyLTAzICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYiBBbmltYXRpb25zXSBBY2NlbGVyYXRl ZCBhbmltYXRpb25zIGRvbid0IHJ1biB1bnRpbCB0aGVpciBuYXR1cmFsIGNvbXBsZXRpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExl Z2FjeS9DaGFuZ2VMb2cKaW5kZXggNzdhYzg3YmI1ZWY1NmIwYjU1OTJlY2MyZDg4MWM3NzY4YmJm OGU2NC4uODk4ZjQ1YjAwNjQ5NjE4NGJkNzE0YTllMTM0NjI2MWEwYzFhNzIxMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdExlZ2FjeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdExlZ2Fj eS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMi0wMyAgU2lodWkgTGl1ICA8c2lo dWlfbGl1QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBXZWJDb3JlOjpJREJTZXJ2ZXI6 OklEQlNlcnZlcjo6Y3JlYXRlSW5kZXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzEzNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwOTYyMzE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBTdG9yYWdl L0luUHJvY2Vzc0lEQlNlcnZlci5jcHA6CisgICAgICAgIChJblByb2Nlc3NJREJTZXJ2ZXI6OmNy ZWF0ZUluZGV4KTogQ3JlYXRlIGFuIGlzb2xhdGVkIGNvcHkgb2YgSURCSW5kZXhJbmZvIGJlZm9y ZSBwYXNzaW5nIGl0IHRvIElEQiB0aHJlYWQuCisKIDIwMjAtMDEtMzEgIERvbiBPbG1zdGVhZCAg PGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIEFkZCBfUFJJVkFURV9M SUJSQVJJRVMgdG8gZnJhbWV3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9zaGFyZWQvSURCSW5kZXhJbmZvLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9zaGFyZWQvSURCSW5kZXhJbmZvLmgKaW5kZXggMWUzNzQxNzkyYTFhNjEwN2Yx ODcyZTQ5ZWZlM2Y4ZTIzYzY0MjYyNi4uMjU0Y2Q5MTkwNTQwZjZlNzQ5MTAyOWI2ZjQxOGE3ZDFl YTMyNjFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2hh cmVkL0lEQkluZGV4SW5mby5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L3NoYXJlZC9JREJJbmRleEluZm8uaApAQCAtMzcsNyArMzcsNyBAQCBwdWJsaWM6CiAgICAgV0VC Q09SRV9FWFBPUlQgSURCSW5kZXhJbmZvKCk7CiAgICAgSURCSW5kZXhJbmZvKHVpbnQ2NF90IGlk ZW50aWZpZXIsIHVpbnQ2NF90IG9iamVjdFN0b3JlSWRlbnRpZmllciwgY29uc3QgU3RyaW5nJiBu YW1lLCBJREJLZXlQYXRoJiYsIGJvb2wgdW5pcXVlLCBib29sIG11bHRpRW50cnkpOwogCi0gICAg SURCSW5kZXhJbmZvIGlzb2xhdGVkQ29weSgpIGNvbnN0OworICAgIFdFQkNPUkVfRVhQT1JUIElE QkluZGV4SW5mbyBpc29sYXRlZENvcHkoKSBjb25zdDsKIAogICAgIHVpbnQ2NF90IGlkZW50aWZp ZXIoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXI7IH0KICAgICB1aW50NjRfdCBvYmplY3RT dG9yZUlkZW50aWZpZXIoKSBjb25zdCB7IHJldHVybiBtX29iamVjdFN0b3JlSWRlbnRpZmllcjsg fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9TdG9yYWdlL0luUHJvY2Vzc0lEQlNl cnZlci5jcHAgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L1N0b3JhZ2UvSW5Qcm9jZXNzSURCU2VydmVy LmNwcAppbmRleCA5YmM0YjM2MzBlMzFiNmNhOTdiZTU5NTU4MjliNDZhZjNjOGJkNmNjLi5hNTQ5 YjA0OTA1YzZhMjIzY2Q2NzZjMDkwYzA0YTRiNzE3MmU3ZmEwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0TGVnYWN5L1N0b3JhZ2UvSW5Qcm9jZXNzSURCU2VydmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0TGVnYWN5L1N0b3JhZ2UvSW5Qcm9jZXNzSURCU2VydmVyLmNwcApAQCAtMzIyLDcgKzMy Miw3IEBAIHZvaWQgSW5Qcm9jZXNzSURCU2VydmVyOjpjbGVhck9iamVjdFN0b3JlKGNvbnN0IFdl YkNvcmU6OklEQlJlcXVlc3REYXRhJiByZXF1ZXN0CiAKIHZvaWQgSW5Qcm9jZXNzSURCU2VydmVy OjpjcmVhdGVJbmRleChjb25zdCBXZWJDb3JlOjpJREJSZXF1ZXN0RGF0YSYgcmVxdWVzdERhdGEs IGNvbnN0IElEQkluZGV4SW5mbyYgaW5mbykKIHsKLSAgICBkaXNwYXRjaFRhc2soW3RoaXMsIHBy b3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgcmVxdWVzdERhdGEgPSByZXF1ZXN0RGF0YS5p c29sYXRlZENvcHkoKSwgaW5mb10geworICAgIGRpc3BhdGNoVGFzayhbdGhpcywgcHJvdGVjdGVk VGhpcyA9IG1ha2VSZWYoKnRoaXMpLCByZXF1ZXN0RGF0YSA9IHJlcXVlc3REYXRhLmlzb2xhdGVk Q29weSgpLCBpbmZvID0gaW5mby5pc29sYXRlZENvcHkoKV0gewogICAgICAgICBMb2NrSG9sZGVy IGxvY2tlcihtX3NlcnZlci0+bG9jaygpKTsKICAgICAgICAgbV9zZXJ2ZXItPmNyZWF0ZUluZGV4 KHJlcXVlc3REYXRhLCBpbmZvKTsKICAgICB9KTsK