207027 2020-01-30 19:20:17 -0800 [ews] Set custom build summary for webkitpy tests 2020-02-03 11:42:15 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 207026 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1613261 0 aakash_jain 2020-01-30 19:20:17 -0800 [ews] We should set custom build summary for webkitpy tests, currently it says 'build successful' (e.g.: https://ews-build.webkit.org/#/builders/5/builds/17024), it should say 'Passed webkitpy tests' (or appropriate failure message). We had custom build summary prior to r254547, in which we removed self.build.buildFinished() which was being used to set custom build summary. Bug 207026 added another way to set custom build summary, so we should use that and set custom build summary for webkitpy tests. 1613262 1 389326 aakash_jain 2020-01-30 19:21:51 -0800 Created attachment 389326 Patch 1613263 2 aakash_jain 2020-01-30 19:24:13 -0800 Sample runs: https://ews-build.webkit-uat.org/#/builders/8/builds/102 https://ews-build.webkit-uat.org/#/builders/8/builds/103 1613265 3 aakash_jain 2020-01-30 19:25:14 -0800 'services' ews failure is because this patch is dependent on patch in Bug 207026. 1613438 4 jbedard 2020-01-31 09:52:14 -0800 (In reply to Aakash Jain from comment #3) > 'services' ews failure is because this patch is dependent on patch in Bug > 207026. Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. 1613459 5 aakash_jain 2020-01-31 10:11:21 -0800 (In reply to Jonathan Bedard from comment #4) > Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. Done. 'services' and 'style' bubbles are green now. win, ios-wk2 are flaky failures. 1613461 6 389326 jbedard 2020-01-31 10:18:39 -0800 Comment on attachment 389326 Patch Code looks good, but I'd like to see the example where Python 2 fails but Python 3 does not 1614041 7 aakash_jain 2020-02-03 10:58:33 -0800 > I'd like to see the example where Python 2 fails but Python 3 does not https://ews-build.webkit-uat.org/#/builders/8/builds/142 1614065 8 389326 commit-queue 2020-02-03 11:41:46 -0800 Comment on attachment 389326 Patch Clearing flags on attachment: 389326 Committed r255580: <https://trac.webkit.org/changeset/255580> 1614066 9 commit-queue 2020-02-03 11:41:48 -0800 All reviewed patches have been landed. Closing bug. 1614067 10 webkit-bug-importer 2020-02-03 11:42:15 -0800 <rdar://problem/59118524> 389326 2020-01-30 19:21:51 -0800 2020-02-03 11:41:46 -0800 Patch bug-207027-20200130222150.patch text/plain 4697 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTQ4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAxLTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBTZXQgY3VzdG9tIGJ1aWxkIHN1bW1hcnkgZm9yIHdlYmtpdHB5 IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDcwMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6CisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoV2ViS2l0UHlUZXN0 LnNldEJ1aWxkU3VtbWFyeSk6CisgICAgICAgIChXZWJLaXRQeVRlc3QuZ2V0UmVzdWx0U3VtbWFy eSk6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0 dGVzdC5weToKKwogMjAyMC0wMS0zMCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFub3RoZXIgc3BlY3VsYXRpdmUgdGVzdCBmaXggYWZ0 ZXIgcjI1NTA0MQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rv cmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv ZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNTU0ODIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBA IGZyb20gc3RlcHMgaW1wb3J0IChBcHBseVBhdGNoLCBBcHBseVdhdGMKICAgICAgICAgICAgICAg ICAgICBEb3dubG9hZEJ1aWx0UHJvZHVjdCwgRXh0cmFjdEJ1aWx0UHJvZHVjdCwgSW5zdGFsbEd0 a0RlcGVuZGVuY2llcywgSW5zdGFsbFdwZURlcGVuZGVuY2llcywgS2lsbE9sZFByb2Nlc3NlcywK ICAgICAgICAgICAgICAgICAgICBQcmludENvbmZpZ3VyYXRpb24sIFJ1bkFQSVRlc3RzLCBSdW5C aW5kaW5nc1Rlc3RzLCBSdW5CdWlsZFdlYktpdE9yZ1VuaXRUZXN0cywgUnVuRVdTQnVpbGRib3RD aGVja0NvbmZpZywgUnVuRVdTVW5pdFRlc3RzLAogICAgICAgICAgICAgICAgICAgIFJ1bkphdmFT Y3JpcHRDb3JlVGVzdHMsIFJ1bldlYktpdDFUZXN0cywgUnVuV2ViS2l0UGVybFRlc3RzLAotICAg ICAgICAgICAgICAgICAgIFJ1bldlYktpdFB5UHl0aG9uMlRlc3RzLCBSdW5XZWJLaXRQeVB5dGhv bjNUZXN0cywgUnVuV2ViS2l0VGVzdHMsIFVwZGF0ZVdvcmtpbmdEaXJlY3RvcnksIFZhbGlkYXRl UGF0Y2gpCisgICAgICAgICAgICAgICAgICAgUnVuV2ViS2l0UHlQeXRob24yVGVzdHMsIFJ1bldl YktpdFB5UHl0aG9uM1Rlc3RzLCBSdW5XZWJLaXRUZXN0cywgU2V0QnVpbGRTdW1tYXJ5LCBVcGRh dGVXb3JraW5nRGlyZWN0b3J5LCBWYWxpZGF0ZVBhdGNoKQogCiAKIGNsYXNzIEZhY3RvcnkoZmFj dG9yeS5CdWlsZEZhY3RvcnkpOgpAQCAtODksNiArODksNyBAQCBjbGFzcyBXZWJLaXRQeUZhY3Rv cnkoRmFjdG9yeSk6CiAgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm09cGxh dGZvcm0sIGNvbmZpZ3VyYXRpb249Y29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcz1hcmNoaXRl Y3R1cmVzLCBidWlsZE9ubHk9RmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudD1hZGRpdGlvbmFsQXJn dW1lbnRzLCBjaGVja1JlbGV2YW5jZT1UcnVlKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuV2Vi S2l0UHlQeXRob24yVGVzdHMoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bldlYktpdFB5UHl0 aG9uM1Rlc3RzKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChTZXRCdWlsZFN1bW1hcnkoKSkKIAog CiBjbGFzcyBCdWlsZEZhY3RvcnkoRmFjdG9yeSk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRlc3QucHkJKHJldmlz aW9uIDI1NTQ4MikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3Jp ZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTEzNiw2ICsxMzYsNyBAQCBjbGFzcyBU ZXN0VGVzdHNGYWN0b3J5KFRlc3RDYXNlKToKICAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5 KHN0ZXBzLkFwcGx5UGF0Y2gpLAogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMu UnVuV2ViS2l0UHlQeXRob24yVGVzdHMpLAogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnko c3RlcHMuUnVuV2ViS2l0UHlQeXRob24zVGVzdHMpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZh Y3Rvcnkoc3RlcHMuU2V0QnVpbGRTdW1tYXJ5KSwKICAgICAgICAgXSkKIAogICAgIGRlZiB0ZXN0 X3NlcnZpY2VzX2ZhY3Rvcnkoc2VsZik6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTU0ODIpCisrKyBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTcyNSw5ICs3MjUs MjQgQEAgY2xhc3MgV2ViS2l0UHlUZXN0KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgICAgIHNl bGYuYWRkTG9nT2JzZXJ2ZXIoJ2pzb24nLCBzZWxmLmxvZ19vYnNlcnZlcikKICAgICAgICAgcmV0 dXJuIHNoZWxsLlNoZWxsQ29tbWFuZC5zdGFydChzZWxmKQogCisgICAgZGVmIHNldEJ1aWxkU3Vt bWFyeShzZWxmLCBidWlsZF9zdW1tYXJ5KToKKyAgICAgICAgcHJldmlvdXNfYnVpbGRfc3VtbWFy eSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkX3N1bW1hcnknLCAnJykKKyAgICAgICAgaWYgbm90 IHByZXZpb3VzX2J1aWxkX3N1bW1hcnk6CisgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdi dWlsZF9zdW1tYXJ5JywgYnVpbGRfc3VtbWFyeSkKKyAgICAgICAgICAgIHJldHVybgorCisgICAg ICAgIGlmIGJ1aWxkX3N1bW1hcnkgaW4gcHJldmlvdXNfYnVpbGRfc3VtbWFyeToKKyAgICAgICAg ICAgICMgRW5zdXJlIHRoYXQgd2UgZG8gbm90IGFwcGVuZCBzYW1lIGJ1aWxkIHN1bW1hcnkgbXVs dGlwbGUgdGltZXMgaW4gY2FzZQorICAgICAgICAgICAgIyB0aGlzIG1ldGhvZCBpcyBjYWxsZWQg bXVsdGlwbGUgdGltZXMuCisgICAgICAgICAgICByZXR1cm4KKworICAgICAgICBuZXdfYnVpbGRf c3VtbWFyeSA9IHByZXZpb3VzX2J1aWxkX3N1bW1hcnkgKyAnLCAnICsgYnVpbGRfc3VtbWFyeQor ICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZF9zdW1tYXJ5JywgbmV3X2J1aWxkX3N1bW1h cnkpCisKICAgICBkZWYgZ2V0UmVzdWx0U3VtbWFyeShzZWxmKToKICAgICAgICAgaWYgc2VsZi5y ZXN1bHRzID09IFNVQ0NFU1M6CiAgICAgICAgICAgICBtZXNzYWdlID0gJ1Bhc3NlZCB3ZWJraXRw eSB7fSB0ZXN0cycuZm9ybWF0KHNlbGYubGFuZ3VhZ2UpCisgICAgICAgICAgICBzZWxmLnNldEJ1 aWxkU3VtbWFyeShtZXNzYWdlKQogICAgICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1bmljb2Rl KG1lc3NhZ2UpfQogCiAgICAgICAgIGxvZ0xpbmVzID0gc2VsZi5sb2dfb2JzZXJ2ZXIuZ2V0U3Rk b3V0KCkKQEAgLTc0Myw3ICs3NTgsOCBAQCBjbGFzcyBXZWJLaXRQeVRlc3Qoc2hlbGwuU2hlbGxD b21tYW5kKToKICAgICAgICAgICAgIHJldHVybiBzdXBlcihXZWJLaXRQeVRlc3QsIHNlbGYpLmdl dFJlc3VsdFN1bW1hcnkoKQogICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKGZhaWx1 cmVzKSA+IDEgZWxzZSAnJwogICAgICAgICBmYWlsdXJlc19zdHJpbmcgPSAnLCAnLmpvaW4oW2Zh aWx1cmUuZ2V0KCduYW1lJykucmVwbGFjZSgnd2Via2l0cHkuJywgJycpIGZvciBmYWlsdXJlIGlu IGZhaWx1cmVzXSkKLSAgICAgICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBXZWJLaXRQeSB0ZXN0IGZh aWx1cmV7fToge30nLmZvcm1hdChsZW4oZmFpbHVyZXMpLCBwbHVyYWxTdWZmaXgsIGZhaWx1cmVz X3N0cmluZykKKyAgICAgICAgbWVzc2FnZSA9ICdGb3VuZCB7fSB3ZWJraXRweSB7fSB0ZXN0IGZh aWx1cmV7fToge30nLmZvcm1hdChsZW4oZmFpbHVyZXMpLCBzZWxmLmxhbmd1YWdlLCBwbHVyYWxT dWZmaXgsIGZhaWx1cmVzX3N0cmluZykKKyAgICAgICAgc2VsZi5zZXRCdWlsZFN1bW1hcnkobWVz c2FnZSkKICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1bmljb2RlKG1lc3NhZ2UpfQogCiAgICAg QGRlZmVyLmlubGluZUNhbGxiYWNrcwo=