207026 2020-01-30 18:59:46 -0800 [ews] add build step to set custom build summary 2020-01-31 10:06:20 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 207027 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1613258 0 aakash_jain 2020-01-30 18:59:46 -0800 [ews] add build step to set custom build summary based on a property which any previous step can set. Currently in order to set custom build summary we are using self.build.buildFinished(build_summary, result) method, but this method also finishes the build immediately whenever it's called. So if a step uses buildFinished(), no further build step can be run. For example: Layout-test set custom build summary (e.g.: 'Passed layout tests', 'Found 1 pre-existing test failure: xyz'). In case commit-queue (or any factory) run layout-test step, layout-test will call self.build.buildFinished() and commit-queue (or that factory) would not be able to execute any subsequent build-step. The fix is to avoid calling buildFinished() inside the regular build-steps, instead set a property in those build-steps, and at the end run a specific build-step (e.g.: SetBuildSummary) which would set the build summary based on that property. 1613259 1 389325 aakash_jain 2020-01-30 19:01:32 -0800 Created attachment 389325 Patch 1613264 2 aakash_jain 2020-01-30 19:24:30 -0800 Sample runs: https://ews-build.webkit-uat.org/#/builders/8/builds/102 https://ews-build.webkit-uat.org/#/builders/8/builds/103 1613412 3 389325 jbedard 2020-01-31 09:27:51 -0800 Comment on attachment 389325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389325&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2021 > + self.build.buildFinished([build_summary], self.build.results) What is self.build.results? 1613419 4 aakash_jain 2020-01-31 09:35:48 -0800 (In reply to Jonathan Bedard from comment #3) > What is self.build.results? results is a variable inside Build class https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/build.py#L77 It stores the current result based on the steps which have executed. This I am trying SetBuildSummary to set the same overall build status which Buildbot would have set otherwise, based on the status of previously executed steps. 1613425 5 jbedard 2020-01-31 09:40:21 -0800 (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #3) > > What is self.build.results? > results is a variable inside Build class > https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/ > build.py#L77 > > It stores the current result based on the steps which have executed. > > This I am trying SetBuildSummary to set the same overall build status which > Buildbot would have set otherwise, based on the status of previously > executed steps. Can we contrive an example where Python 2 fails, but python 3 does not? I think this is right, but that's the only case we haven't tested. 1613428 6 aakash_jain 2020-01-31 09:44:22 -0800 (In reply to Jonathan Bedard from comment #5) > Can we contrive an example where Python 2 fails, but python 3 does not? I think this is right, but that's the only case we haven't tested. Will provide that in https://bugs.webkit.org/show_bug.cgi?id=207027 1613455 7 389325 aakash_jain 2020-01-31 10:05:10 -0800 Comment on attachment 389325 Patch Clearing flags on attachment: 389325 Committed r255506: <https://trac.webkit.org/changeset/255506> 1613456 8 aakash_jain 2020-01-31 10:05:14 -0800 All reviewed patches have been landed. Closing bug. 1613457 9 webkit-bug-importer 2020-01-31 10:06:20 -0800 <rdar://problem/59065405> 389325 2020-01-30 19:01:32 -0800 2020-01-31 10:05:10 -0800 Patch bug-207026-20200130220131.patch text/plain 1842 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTQ4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAxLTMwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBhZGQgYnVpbGQgc3RlcCB0byBzZXQgY3VzdG9tIGJ1aWxkIHN1 bW1hcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzAyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoU2V0QnVpbGRT dW1tYXJ5LmRvU3RlcElmKTogUnVuIHRoaXMgc3RlcCBvbmx5IGlmIGJ1aWxkX3N1bW1hcnkgcHJv cGVydHkgaXMgc2V0LgorICAgICAgICAoU2V0QnVpbGRTdW1tYXJ5LmhpZGVTdGVwSWYpOiBIaWRl IHRoaXMgc3RlcCBpZiBpdCBpcyBub3QgZXhlY3V0ZWQuCisgICAgICAgIChTZXRCdWlsZFN1bW1h cnkuc3RhcnQpOgorCiAyMDIwLTAxLTMwICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciBzcGVjdWxhdGl2ZSB0ZXN0IGZpeCBh ZnRlciByMjU1MDQxCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzLnB5CShyZXZpc2lvbiAyNTU0ODIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwMDAsMyArMjAwMCwyMyBAQCBjbGFz cyBBcHBseVdhdGNoTGlzdChzaGVsbC5TaGVsbENvbW1hbmQpCiAgICAgICAgIGlmIHNlbGYucmVz dWx0cyAhPSBTVUNDRVNTOgogICAgICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1J0ZhaWxlZCB0 byBhcHBseSB3YXRjaGxpc3QnfQogICAgICAgICByZXR1cm4gc3VwZXIoQXBwbHlXYXRjaExpc3Qs IHNlbGYpLmdldFJlc3VsdFN1bW1hcnkoKQorCisKK2NsYXNzIFNldEJ1aWxkU3VtbWFyeShidWls ZHN0ZXAuQnVpbGRTdGVwKToKKyAgICBuYW1lID0gInNldC1idWlsZC1zdW1tYXJ5IgorICAgIGRl c2NyaXB0aW9uRG9uZSA9IFsnU2V0IGJ1aWxkIHN1bW1hcnknXQorICAgIGFsd2F5c1J1biA9IFRy dWUKKyAgICBoYWx0T25GYWlsdXJlID0gRmFsc2UKKyAgICBmbHVua09uRmFpbHVyZSA9IEZhbHNl CisKKyAgICBkZWYgZG9TdGVwSWYoc2VsZiwgc3RlcCk6CisgICAgICAgIHJldHVybiBzZWxmLmdl dFByb3BlcnR5KCdidWlsZF9zdW1tYXJ5JywgRmFsc2UpCisKKyAgICBkZWYgaGlkZVN0ZXBJZihz ZWxmLCByZXN1bHRzLCBzdGVwKToKKyAgICAgICAgcmV0dXJuIG5vdCBzZWxmLmRvU3RlcElmKHN0 ZXApCisKKyAgICBkZWYgc3RhcnQoc2VsZik6CisgICAgICAgIGJ1aWxkX3N1bW1hcnkgPSBzZWxm LmdldFByb3BlcnR5KCdidWlsZF9zdW1tYXJ5JywgJ2J1aWxkIHN1Y2Nlc3NmdWwnKQorICAgICAg ICBzZWxmLmZpbmlzaGVkKFNVQ0NFU1MpCisgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hl ZChbYnVpbGRfc3VtbWFyeV0sIHNlbGYuYnVpbGQucmVzdWx0cykKKyAgICAgICAgcmV0dXJuIGRl ZmVyLnN1Y2NlZWQoTm9uZSkK