206904 2020-01-28 13:07:41 -0800 Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend 2020-01-29 12:49:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu commit-queue ggaren mjs webkit-bug-importer oldest_to_newest 1612133 0 sihui_liu 2020-01-28 13:07:41 -0800 Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x00000000000000a8) 94 m_isSuspended = true; -> 95 m_server->lock().lock(); 96 m_server->stopDatabaseActivitiesOnMainThread(); 15 WebKit: WebKit::WebIDBServer::suspend(WebKit::WebIDBServer::ShouldForceStop) <== 15 WebKit: WebKit::WebIDBServer::suspend(WebKit::WebIDBServer::ShouldForceStop) 15 WebKit: WebKit::NetworkProcess::prepareToSuspend(bool, WTF::CompletionHandler<void ()>&&) 15 WebKit: void IPC::handleMessageAsync<Messages::NetworkProcess::PrepareToSuspend, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&)) 15 WebKit: WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&) 1612137 1 sihui_liu 2020-01-28 13:08:10 -0800 <rdar://problem/58791603> 1612141 2 389054 sihui_liu 2020-01-28 13:13:35 -0800 Created attachment 389054 Patch 1612267 3 389054 mjs 2020-01-28 17:02:26 -0800 Comment on attachment 389054 Patch r=me (seems like this could block the main thread of the network process though, unless I misunderstand what happens on which thread. 1612607 4 commit-queue 2020-01-29 12:21:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 389054: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1612612 5 commit-queue 2020-01-29 12:22:14 -0800 The commit-queue encountered the following flaky tests while processing attachment 389054: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) imported/w3c/web-platform-tests/xhr/send-send.any.worker.html bug 206345 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1612613 6 389054 commit-queue 2020-01-29 12:38:47 -0800 Comment on attachment 389054 Patch Clearing flags on attachment: 389054 Committed r255375: <https://trac.webkit.org/changeset/255375> 1612614 7 commit-queue 2020-01-29 12:38:48 -0800 All reviewed patches have been landed. Closing bug. 1612618 8 ggaren 2020-01-29 12:49:05 -0800 Can we just initialize m_server directly in the constructor on the main thread, instead of posting a task? Since no tasks have been queued yet, there's nothing to synchronize with yet. Specifically, maybe we can initialize m_server directly, and then post a task to upgradeFilesIfNecessary() (and change IDBServer::IDBServer() not to upgradeFilesIfNecessary(), to avoid I/O on the main thread). 389054 2020-01-28 13:13:35 -0800 2020-01-29 12:38:47 -0800 Patch bug-206904-20200128131334.patch text/plain 2074 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3NDg1YTAwOWNjMzExZjA2 OWQ0MGU3Nzk5NTVlMzMyNzVmNGEyNjQuLmFhMzZhZDBmODFlY2JiMmFiNjA1MGM4MmU5MjBmNjEx NjliZjcwYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMjggIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgY29tLmFwcGxl LldlYktpdC5OZXR3b3JraW5nIGF0IFdlYktpdDogV2ViS2l0OjpXZWJJREJTZXJ2ZXI6OnN1c3Bl bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjkw NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg3OTE2MDM+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2FpdCB1bnRpbCBtX3NlcnZlciBpcyBzZXQg aW4gY29uc3RydWN0b3Igb2YgV2ViSURCU2VydmVyIHRvIG1ha2Ugc3VyZSBtX3NlcnZlciBjYW4g YmUgYWNjZXNzZWQgaW4gCisgICAgICAgIFdlYklEQlNlcnZlcjo6c3VzcGVuZC4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL0luZGV4ZWREQi9XZWJJREJTZXJ2ZXIuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJJREJTZXJ2ZXI6OldlYklEQlNlcnZlcik6CisKIDIwMjAtMDEtMjcgIFNhaWQg QWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBUaHJvdHRs aW5nIHJlcXVlc3RBbmltYXRpb25GcmFtZSBzaG91bGQgYmUgY29udHJvbGxlZCBieSBSZW5kZXJp bmdVcGRhdGVTY2hlZHVsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvSW5kZXhlZERCL1dlYklEQlNlcnZlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL0luZGV4ZWREQi9XZWJJREJTZXJ2ZXIuY3BwCmluZGV4IDQ3NzcyNjAzYzFhMThlYWMwMjYx NmFlMTgzZTZmMWJmYmE1OTNkNWIuLjVmM2QzMDVkMWNkOTg5NDdlMGRkNDVkZjU5NGQ1OWQ3NDEw OGUwNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvSW5kZXhlZERC L1dlYklEQlNlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9JbmRl eGVkREIvV2ViSURCU2VydmVyLmNwcApAQCAtNDYsOSArNDYsMTIgQEAgV2ViSURCU2VydmVyOjpX ZWJJREJTZXJ2ZXIoUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBjb25zdCBTdHJpbmcmIGRpcmVj dG9yeSwgV2UKIHsKICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogCi0gICAgcG9zdFRh c2soW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgc2Vzc2lvbklELCBkaXJl Y3RvcnkgPSBkaXJlY3RvcnkuaXNvbGF0ZWRDb3B5KCksIHNwYWNlUmVxdWVzdGVyID0gV1RGTW92 ZShzcGFjZVJlcXVlc3RlcildICgpIG11dGFibGUgeworICAgIEJpbmFyeVNlbWFwaG9yZSBzZW1h cGhvcmU7CisgICAgcG9zdFRhc2soW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlz KSwgJnNlbWFwaG9yZSwgc2Vzc2lvbklELCBkaXJlY3RvcnkgPSBkaXJlY3RvcnkuaXNvbGF0ZWRD b3B5KCksIHNwYWNlUmVxdWVzdGVyID0gV1RGTW92ZShzcGFjZVJlcXVlc3RlcildICgpIG11dGFi bGUgewogICAgICAgICBtX3NlcnZlciA9IG1ha2VVbmlxdWU8V2ViQ29yZTo6SURCU2VydmVyOjpJ REJTZXJ2ZXI+KHNlc3Npb25JRCwgZGlyZWN0b3J5LCBXVEZNb3ZlKHNwYWNlUmVxdWVzdGVyKSk7 CisgICAgICAgIHNlbWFwaG9yZS5zaWduYWwoKTsKICAgICB9KTsKKyAgICBzZW1hcGhvcmUud2Fp dCgpOwogfQogICAgIAogdm9pZCBXZWJJREJTZXJ2ZXI6OmNsb3NlQW5kRGVsZXRlRGF0YWJhc2Vz TW9kaWZpZWRTaW5jZShXYWxsVGltZSBtb2RpZmljYXRpb25UaW1lLCBDb21wbGV0aW9uSGFuZGxl cjx2b2lkKCk+JiYgY2FsbGJhY2spCg==