206494 2020-01-20 04:01:16 -0800 ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small 2020-01-20 22:20:37 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 204882 P2 Normal --- 1 fujii fujii ap cathiechen ddkilzer don.olmstead rniwa ross.kirsling ryanhaddad simon.fraser tsavell oldest_to_newest 1608707 0 fujii 2020-01-20 04:01:16 -0800 ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small AppleWin 32bit can't compile since r254807 (Bug 204882) > C:\webkit\gc\Source\WebCore\platform/ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small 1608713 1 388228 fujii 2020-01-20 04:10:50 -0800 Created attachment 388228 Patch 1608717 2 cathiechen 2020-01-20 05:06:49 -0800 LGTM, thanks for fixing this! 1608767 3 388228 cathiechen 2020-01-20 07:44:31 -0800 Comment on attachment 388228 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388228&action=review > Source/WebCore/platform/ScrollableArea.h:412 > + ScrollBehaviorStatus m_currentScrollBehaviorStatus { ScrollBehaviorStatus::NotInAnimation }; Hmmm, it seems we don't have to expand the size, we can use the bit field in stead, like m_currentScrollType. Currently, ScrollBehaviorStatus only have two values, so 1 bit seems enough. 1608852 4 ddkilzer 2020-01-20 13:48:46 -0800 This static assertion failure broke some internal Apple builds as well. 1608896 5 fujii 2020-01-20 17:42:14 -0800 Cathiechen, it sounds a good idea. I think it should be reverted to fix internal Apple builds as soon as possible. Reverted in r254839. *** This bug has been marked as a duplicate of bug 204882 *** 1608932 6 cathiechen 2020-01-20 22:20:37 -0800 Thanks, I'll fix this in the new patch. 388228 2020-01-20 04:10:50 -0800 2020-01-20 20:34:24 -0800 Patch bug-206494-20200120211049.patch text/plain 2635 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdkYTY1NWI4N2E4ZGU5 OWI0ZDE3ZWE3NzgzZDhhMTg4Y2Q5NmYwOS4uODMwODUxN2YxMzllOGY0NzY4YmU1NzAxMzNiMjlk N2ViMTRmNzQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTIwICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFNjcm9sbGFi bGVBcmVhLmNwcCg2Myk6IGVycm9yIEMyMzM4OiBTY3JvbGxhYmxlQXJlYV9zaG91bGRfc3RheV9z bWFsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXBw bGVXaW4gMzJiaXQgY2FuJ3QgY29tcGlsZSBzaW5jZSByMjU0ODA3IChCdWcgMjA0ODgyKSBkdWUg dG8gYQorICAgICAgICBDT01QSUxFX0FTU0VSVCBjaGVja2luZyBTY3JvbGxhYmxlQXJlYSBzaXpl LgorCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwOiBBZGRlZCBhIGludDhf dCB0byB0aGUgYm90dG9tIG9mIFNhbWVTaXplQXNTY3JvbGxhYmxlQXJlYS4KKyAgICAgICAgKiBw bGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oOiBNb3ZlZCBtX2N1cnJlbnRTY3JvbGxCZWhhdmlvclN0 YXR1cworICAgICAgICB0byB0aGUgYm90dG9tIG9mIFNjcm9sbGFibGVBcmVhLiBJdHMgdHlwZSBp cyB1aW50OF90IGJhc2VkIGVudW0gY2xhc3MKKyAgICAgICAgU2Nyb2xsQmVoYXZpb3JTdGF0dXMu CisKIDIwMjAtMDEtMjAgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIFZpZGVvIHNvdW5kIHNvbWV0aW1lcyBrZWVwcyBwbGF5aW5nIGluIHBhZ2UgY2FjaGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNwcAppbmRleCBmNTM1ZjYzMjQw YzEwZmRlYjc0NDYxM2FmNDBjYzhmYWFiN2Y4YjIyLi43YWU3MThkODFkODk1Yzg1ZTkxNDYyODcz ZjgyYWExNWNlYjQ0ZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxhYmxlQXJlYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFy ZWEuY3BwCkBAIC01OCw2ICs1OCw3IEBAIHN0cnVjdCBTYW1lU2l6ZUFzU2Nyb2xsYWJsZUFyZWEg ewogI2VuZGlmCiAgICAgSW50UG9pbnQgb3JpZ2luOwogICAgIHVuc2lnbmVkIGJpdGZpZWxkcyA6 IDE2OworICAgIGludDhfdCBpbnQ4OwogfTsKIAogQ09NUElMRV9BU1NFUlQoc2l6ZW9mKFNjcm9s bGFibGVBcmVhKSA9PSBzaXplb2YoU2FtZVNpemVBc1Njcm9sbGFibGVBcmVhKSwgU2Nyb2xsYWJs ZUFyZWFfc2hvdWxkX3N0YXlfc21hbGwpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsYWJsZUFyZWEuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFi bGVBcmVhLmgKaW5kZXggNGJkOWQ5NTI5NjQ5OGIyMmY1YjE1N2JkZTVkNzY4YjcwMjU4M2FkNi4u ODFiMTZkYTkxN2ZhN2RmODM1NjQ3YTZiMzQ1NDMxNjhjNTg2YjkxYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCkBAIC0zODMsOCArMzgzLDYgQEAgcHJpdmF0ZToK ICAgICB1bnNpZ25lZCBtX2N1cnJlbnRWZXJ0aWNhbFNuYXBQb2ludEluZGV4IHsgMCB9OwogI2Vu ZGlmCiAKLSAgICBTY3JvbGxCZWhhdmlvclN0YXR1cyBtX2N1cnJlbnRTY3JvbGxCZWhhdmlvclN0 YXR1cyB7IFNjcm9sbEJlaGF2aW9yU3RhdHVzOjpOb3RJbkFuaW1hdGlvbiB9OwotCiAgICAgLy8g VGhlcmUgYXJlIDggcG9zc2libGUgY29tYmluYXRpb25zIG9mIHdyaXRpbmcgbW9kZSBhbmQgZGly ZWN0aW9uLiBTY3JvbGwgb3JpZ2luIHdpbGwgYmUgbm9uLXplcm8gaW4gdGhlIHggb3IgeSBheGlz CiAgICAgLy8gaWYgdGhlcmUgaXMgYW55IHJldmVyc2VkIGRpcmVjdGlvbiBvciB3cml0aW5nLW1v ZGUuIFRoZSBjb21iaW5hdGlvbnMgYXJlOgogICAgIC8vIHdyaXRpbmctbW9kZSAvIGRpcmVjdGlv biAgICAgc2Nyb2xsT3JpZ2luLngoKSBzZXQgICAgc2Nyb2xsT3JpZ2luLnkoKSBzZXQKQEAgLTQx MCw2ICs0MDgsOCBAQCBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fc2Nyb2xsT3JpZ2luQ2hhbmdl ZCA6IDE7CiAgICAgdW5zaWduZWQgbV9jdXJyZW50U2Nyb2xsVHlwZSA6IDE7IC8vIFNjcm9sbFR5 cGUKICAgICB1bnNpZ25lZCBtX3Njcm9sbFNob3VsZENsZWFyTGF0Y2hlZFN0YXRlIDogMTsKKwor ICAgIFNjcm9sbEJlaGF2aW9yU3RhdHVzIG1fY3VycmVudFNjcm9sbEJlaGF2aW9yU3RhdHVzIHsg U2Nyb2xsQmVoYXZpb3JTdGF0dXM6Ok5vdEluQW5pbWF0aW9uIH07CiB9OwogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCg==