206402 2020-01-17 00:19:19 -0800 Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails 2020-01-20 01:45:17 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1607907 0 youennf 2020-01-17 00:19:19 -0800 Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails 1607908 1 388017 youennf 2020-01-17 00:21:08 -0800 Created attachment 388017 Patch 1608020 2 388017 eric.carlson 2020-01-17 09:00:24 -0800 Comment on attachment 388017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388017&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/helpers.cc:134 > + RTC_LOG(LS_ERROR) << "VTSessionSetProperty failed to set: " << key_string it might be worth also logging 'vtSession' so we know which call was made 1608648 3 388213 youennf 2020-01-20 00:41:11 -0800 Created attachment 388213 Patch for landing 1608665 4 commit-queue 2020-01-20 01:44:08 -0800 The commit-queue encountered the following flaky tests while processing attachment 388213: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1608666 5 388213 commit-queue 2020-01-20 01:44:38 -0800 Comment on attachment 388213 Patch for landing Clearing flags on attachment: 388213 Committed r254815: <https://trac.webkit.org/changeset/254815> 1608667 6 commit-queue 2020-01-20 01:44:40 -0800 All reviewed patches have been landed. Closing bug. 1608668 7 webkit-bug-importer 2020-01-20 01:45:17 -0800 <rdar://problem/58733419> 388017 2020-01-17 00:21:08 -0800 2020-01-20 00:41:08 -0800 Patch bug-206402-20200117092107.patch text/plain 3262 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBkMjAyYjQyYWViYWY4ZDhlOWEwMDk3ZWI2OGY5ZmNjNTE5NWYwYmY2Li40ODQx ODFmOGEyNDI1YWEyZmY4YjhhOWJiZmY3ZTJiMzg4ZDNiYTJkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wMS0xNyAgeW91ZW5uIGZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgU2V0dGluZyBrVlRDb21wcmVzc2lv blByb3BlcnR5S2V5X0RhdGFSYXRlTGltaXRzIG9uIFJUQ1ZpZGVvRW5jb2RlckgyNjQgZmFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQwMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBoZWxw ZXIgcm91dGluZSBkZWRpY2F0ZWQgdG8gc2V0dGluZyBWVEIvVkNQIGFycmF5IHZhbHVlIHByb3Bl cnRpZXMuCisgICAgICAgIExvZ2dpbmcgc2hvd3MgdGhlIGJpdHJhdGUgaXMgdGhlbiBzZXQgYXBw cm9wcmlhdGVseS4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50 cy92aWRlb19jb2RlYy9oZWxwZXJzLmNjOgorICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29i amMvY29tcG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmg6CisKIDIwMjAtMDEtMDYgIHlvdWVu biBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBSVEMgVlRC IGVuY29kZXJzIGluIEdQVVByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9fY29kZWMvaGVs cGVycy5jYyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9v YmpjL2NvbXBvbmVudHMvdmlkZW9fY29kZWMvaGVscGVycy5jYwppbmRleCBhOGUyMDYyNjRjMjRi NGY2MWM2NDMxZDY3YTFlNDA1NTU4MjdmZWNjLi42OTFiZjFlZDIzZGQyMjk4ODdkN2Y2ODlmOThh ZTYyMjc4MmM4NWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291 cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL2hlbHBlcnMuY2MKKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvY29t cG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmNjCkBAIC0xMTYsMyArMTE2LDIyIEBAIHZvaWQg U2V0VlRTZXNzaW9uUHJvcGVydHkoVlRDb21wcmVzc2lvblNlc3Npb25SZWYgdnRTZXNzaW9uLCBW Q1BDb21wcmVzc2lvblNlc3NpCiAgICAgICAgICAgICAgICAgICAgICAgPDwgIiB0byAiIDw8IHZh bF9zdHJpbmcgPDwgIjogIiA8PCBzdGF0dXM7CiAgIH0KIH0KKworLy8gQ29udmVuaWVuY2UgZnVu Y3Rpb24gZm9yIHNldHRpbmcgYSBWVCBwcm9wZXJ0eS4KK3ZvaWQgU2V0VlRTZXNzaW9uUHJvcGVy dHkoVlRDb21wcmVzc2lvblNlc3Npb25SZWYgdnRTZXNzaW9uLCBWQ1BDb21wcmVzc2lvblNlc3Np b25SZWYgdmNwU2Vzc2lvbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgQ0ZTdHJpbmdSZWYg a2V5LAorICAgICAgICAgICAgICAgICAgICAgICAgICBDRkFycmF5UmVmIHZhbHVlKSB7CisgIFJU Q19EQ0hFQ0sodnRTZXNzaW9uIHx8IHZjcFNlc3Npb24pOworICBPU1N0YXR1cyBzdGF0dXMgPSBu b0VycjsKKyAgaWYgKHZ0U2Vzc2lvbikKKyAgICBzdGF0dXMgPSBWVFNlc3Npb25TZXRQcm9wZXJ0 eSh2dFNlc3Npb24sIGtleSwgdmFsdWUpOworI2lmIEVOQUJMRV9WQ1BfRU5DT0RFUgorICBlbHNl CisgICAgc3RhdHVzID0gd2VicnRjOjpWQ1BDb21wcmVzc2lvblNlc3Npb25TZXRQcm9wZXJ0eSh2 Y3BTZXNzaW9uLCBrZXksIHZhbHVlKTsKKyNlbmRpZgorICBpZiAoc3RhdHVzICE9IG5vRXJyKSB7 CisgICAgc3RkOjpzdHJpbmcga2V5X3N0cmluZyA9IENGU3RyaW5nVG9TdHJpbmcoa2V5KTsKKyAg ICBSVENfTE9HKExTX0VSUk9SKSA8PCAiVlRTZXNzaW9uU2V0UHJvcGVydHkgZmFpbGVkIHRvIHNl dDogIiA8PCBrZXlfc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgPDwgIiB0byBhcnJheSB2 YWx1ZTogIiA8PCBzdGF0dXM7CisgIH0KK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9fY29kZWMv aGVscGVycy5oIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2Rr L29iamMvY29tcG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmgKaW5kZXggYzdkNzlkMzI3NzFj MGJmY2RlN2E4ZjEyMTMyZTU2OTgwZjY2ZGM2NC4uNjAzMzQ3YThhOWJmYjQ2MjhmYzU0ZDM5ZTNk MjhiNjRjY2EzZDA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1Nv dXJjZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmgKKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvY29t cG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmgKQEAgLTQ2LDQgKzQ2LDkgQEAgdm9pZCBTZXRW VFNlc3Npb25Qcm9wZXJ0eShWVENvbXByZXNzaW9uU2Vzc2lvblJlZiBzZXNzaW9uLCBWQ1BDb21w cmVzc2lvblNlc3Npb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgQ0ZTdHJpbmdSZWYga2V5 LAogICAgICAgICAgICAgICAgICAgICAgICAgICBDRlN0cmluZ1JlZiB2YWx1ZSk7CiAKKy8vIENv bnZlbmllbmNlIGZ1bmN0aW9uIGZvciBzZXR0aW5nIGEgVlQgcHJvcGVydHkuCit2b2lkIFNldFZU U2Vzc2lvblByb3BlcnR5KFZUQ29tcHJlc3Npb25TZXNzaW9uUmVmIHNlc3Npb24sIFZDUENvbXBy ZXNzaW9uU2Vzc2lvblJlZiB2Y3BTZXNzaW9uLAorICAgICAgICAgICAgICAgICAgICAgICAgICBD RlN0cmluZ1JlZiBrZXksCisgICAgICAgICAgICAgICAgICAgICAgICAgIENGQXJyYXlSZWYgdmFs dWUpOworCiAjZW5kaWYgIC8vIFNES19PQkpDX0ZSQU1FV09SS19DTEFTU0VTX1ZJREVPVE9PTEJP WF9IRUxQRVJTX0hfCg== 388213 2020-01-20 00:41:11 -0800 2020-01-20 01:44:38 -0800 Patch for landing bug-206402-20200120094110.patch text/plain 3296 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBkMjAyYjQyYWViYWY4ZDhlOWEwMDk3ZWI2OGY5ZmNjNTE5NWYwYmY2Li5iYjQ2 N2YyYmY0MTU0MWRmZWQ5MGVmYmFkYjRiYmI2Y2EyMzU0MjVkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wMS0yMCAgeW91ZW5uIGZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgU2V0dGluZyBrVlRDb21wcmVzc2lv blByb3BlcnR5S2V5X0RhdGFSYXRlTGltaXRzIG9uIFJUQ1ZpZGVvRW5jb2RlckgyNjQgZmFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQwMgor CisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBBZGQgaGVscGVy IHJvdXRpbmUgZGVkaWNhdGVkIHRvIHNldHRpbmcgVlRCL1ZDUCBhcnJheSB2YWx1ZSBwcm9wZXJ0 aWVzLgorICAgICAgICBMb2dnaW5nIHNob3dzIHRoZSBiaXRyYXRlIGlzIHRoZW4gc2V0IGFwcHJv cHJpYXRlbHkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMv dmlkZW9fY29kZWMvaGVscGVycy5jYzoKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL3Nkay9vYmpj L2NvbXBvbmVudHMvdmlkZW9fY29kZWMvaGVscGVycy5oOgorCiAyMDIwLTAxLTA2ICB5b3Vlbm4g ZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgUlRDIFZUQiBl bmNvZGVycyBpbiBHUFVQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL2hlbHBl cnMuY2MgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2Jq Yy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL2hlbHBlcnMuY2MKaW5kZXggYThlMjA2MjY0YzI0YjRm NjFjNjQzMWQ2N2ExZTQwNTU1ODI3ZmVjYy4uNDU3ZDRjYmU2ODY4M2JhM2Y1ZmY5MzM0MGExY2Fk MjM1ZTU2NWI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50cy92aWRlb19jb2RlYy9oZWxwZXJzLmNjCisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBv bmVudHMvdmlkZW9fY29kZWMvaGVscGVycy5jYwpAQCAtMTE2LDMgKzExNiwyMyBAQCB2b2lkIFNl dFZUU2Vzc2lvblByb3BlcnR5KFZUQ29tcHJlc3Npb25TZXNzaW9uUmVmIHZ0U2Vzc2lvbiwgVkNQ Q29tcHJlc3Npb25TZXNzaQogICAgICAgICAgICAgICAgICAgICAgIDw8ICIgdG8gIiA8PCB2YWxf c3RyaW5nIDw8ICI6ICIgPDwgc3RhdHVzOwogICB9CiB9CisKKy8vIENvbnZlbmllbmNlIGZ1bmN0 aW9uIGZvciBzZXR0aW5nIGEgVlQgcHJvcGVydHkuCit2b2lkIFNldFZUU2Vzc2lvblByb3BlcnR5 KFZUQ29tcHJlc3Npb25TZXNzaW9uUmVmIHZ0U2Vzc2lvbiwgVkNQQ29tcHJlc3Npb25TZXNzaW9u UmVmIHZjcFNlc3Npb24sCisgICAgICAgICAgICAgICAgICAgICAgICAgIENGU3RyaW5nUmVmIGtl eSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgQ0ZBcnJheVJlZiB2YWx1ZSkgeworICBSVENf RENIRUNLKHZ0U2Vzc2lvbiB8fCB2Y3BTZXNzaW9uKTsKKyAgT1NTdGF0dXMgc3RhdHVzID0gbm9F cnI7CisgIGlmICh2dFNlc3Npb24pCisgICAgc3RhdHVzID0gVlRTZXNzaW9uU2V0UHJvcGVydHko dnRTZXNzaW9uLCBrZXksIHZhbHVlKTsKKyNpZiBFTkFCTEVfVkNQX0VOQ09ERVIKKyAgZWxzZQor ICAgIHN0YXR1cyA9IHdlYnJ0Yzo6VkNQQ29tcHJlc3Npb25TZXNzaW9uU2V0UHJvcGVydHkodmNw U2Vzc2lvbiwga2V5LCB2YWx1ZSk7CisjZW5kaWYKKworICBpZiAoc3RhdHVzICE9IG5vRXJyKSB7 CisgICAgc3RkOjpzdHJpbmcga2V5X3N0cmluZyA9IENGU3RyaW5nVG9TdHJpbmcoa2V5KTsKKyAg ICBSVENfTE9HKExTX0VSUk9SKSA8PCAiVlRTZXNzaW9uU2V0UHJvcGVydHkgZmFpbGVkIHRvIHNl dDogIiA8PCBrZXlfc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgPDwgIiB0byBhcnJheSB2 YWx1ZTogIiA8PCBzdGF0dXMgPDwgIiwgdmNwU2Vzc2lvbjogIiA8PCB2Y3BTZXNzaW9uOworICB9 Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0 Yy9zZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL2hlbHBlcnMuaCBiL1NvdXJjZS9UaGly ZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9f Y29kZWMvaGVscGVycy5oCmluZGV4IGM3ZDc5ZDMyNzcxYzBiZmNkZTdhOGYxMjEzMmU1Njk4MGY2 NmRjNjQuLjYwMzM0N2E4YTliZmI0NjI4ZmM1NGQzOWUzZDI4YjY0Y2NhM2QwNTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2Nv bXBvbmVudHMvdmlkZW9fY29kZWMvaGVscGVycy5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9fY29kZWMvaGVs cGVycy5oCkBAIC00Niw0ICs0Niw5IEBAIHZvaWQgU2V0VlRTZXNzaW9uUHJvcGVydHkoVlRDb21w cmVzc2lvblNlc3Npb25SZWYgc2Vzc2lvbiwgVkNQQ29tcHJlc3Npb25TZXNzaW9uCiAgICAgICAg ICAgICAgICAgICAgICAgICAgIENGU3RyaW5nUmVmIGtleSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgQ0ZTdHJpbmdSZWYgdmFsdWUpOwogCisvLyBDb252ZW5pZW5jZSBmdW5jdGlvbiBmb3Ig c2V0dGluZyBhIFZUIHByb3BlcnR5Lgordm9pZCBTZXRWVFNlc3Npb25Qcm9wZXJ0eShWVENvbXBy ZXNzaW9uU2Vzc2lvblJlZiBzZXNzaW9uLCBWQ1BDb21wcmVzc2lvblNlc3Npb25SZWYgdmNwU2Vz c2lvbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgQ0ZTdHJpbmdSZWYga2V5LAorICAgICAg ICAgICAgICAgICAgICAgICAgICBDRkFycmF5UmVmIHZhbHVlKTsKKwogI2VuZGlmICAvLyBTREtf T0JKQ19GUkFNRVdPUktfQ0xBU1NFU19WSURFT1RPT0xCT1hfSEVMUEVSU19IXwo=