206346 2020-01-16 04:31:15 -0800 [LFC][IFC] TextUtil::width should use StringView for substrings 2020-01-16 07:39:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1607412 0 koivisto 2020-01-16 04:31:15 -0800 Instead of creating temporary Strings. 1607414 1 387909 koivisto 2020-01-16 04:39:34 -0800 Created attachment 387909 patch 1607465 2 commit-queue 2020-01-16 07:38:08 -0800 The commit-queue encountered the following flaky tests while processing attachment 387909: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1607466 3 387909 commit-queue 2020-01-16 07:38:40 -0800 Comment on attachment 387909 patch Clearing flags on attachment: 387909 Committed r254679: <https://trac.webkit.org/changeset/254679> 1607467 4 commit-queue 2020-01-16 07:38:41 -0800 All reviewed patches have been landed. Closing bug. 1607468 5 webkit-bug-importer 2020-01-16 07:39:18 -0800 <rdar://problem/58643875> 387909 2020-01-16 04:39:34 -0800 2020-01-16 07:38:40 -0800 patch lfc-stringview.patch text/plain 1659 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYWM3MzUyZDA1Mi4uODhlZTkwMmNjZjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMC0wMS0xNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSUZDXSBUZXh0VXRpbDo6d2lkdGggc2hvdWxkIHVzZSBTdHJpbmdW aWV3IGZvciBzdWJzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDYzNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL3RleHQvVGV4dFV0aWwuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpUZXh0VXRpbDo6d2lkdGgpOgorCiAyMDIwLTAxLTE1 ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0xGQ10g Rml4IENNYWtlIEJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5l Zm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp bmVmb3JtYXR0aW5nL3RleHQvVGV4dFV0aWwuY3BwCmluZGV4IDgxMjBkMjZkMzFjLi43ODJmNWJk NDhkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv dGV4dC9UZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTY2LDEwICs2NiwxMCBAQCBJbmxpbmVMYXlvdXRV bml0IFRleHRVdGlsOjp3aWR0aChjb25zdCBCb3gmIGlubGluZUJveCwgdW5zaWduZWQgZnJvbSwg dW5zaWduZWQgdAogICAgICAgICBpZiAoZm9udC5pc0ZpeGVkUGl0Y2goKSkKICAgICAgICAgICAg IHdpZHRoID0gZml4ZWRQaXRjaFdpZHRoKHRleHQsIHN0eWxlLCBmcm9tLCB0bywgY29udGVudExv Z2ljYWxMZWZ0KTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgd2lkdGggPSBmb250LndpZHRo Rm9yU2ltcGxlVGV4dCh0ZXh0LnN1YnN0cmluZyhmcm9tLCB0byAtIGZyb20pKTsKKyAgICAgICAg ICAgIHdpZHRoID0gZm9udC53aWR0aEZvclNpbXBsZVRleHQoU3RyaW5nVmlldyh0ZXh0KS5zdWJz dHJpbmcoZnJvbSwgdG8gLSBmcm9tKSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgYXV0byB0YWJX aWR0aCA9IHN0eWxlLmNvbGxhcHNlV2hpdGVTcGFjZSgpID8gVGFiU2l6ZSgwKSA6IHN0eWxlLnRh YlNpemUoKTsKLSAgICAgICAgV2ViQ29yZTo6VGV4dFJ1biBydW4odGV4dC5zdWJzdHJpbmcoZnJv bSwgdG8gLSBmcm9tKSwgY29udGVudExvZ2ljYWxMZWZ0KTsKKyAgICAgICAgV2ViQ29yZTo6VGV4 dFJ1biBydW4oU3RyaW5nVmlldyh0ZXh0KS5zdWJzdHJpbmcoZnJvbSwgdG8gLSBmcm9tKSwgY29u dGVudExvZ2ljYWxMZWZ0KTsKICAgICAgICAgaWYgKHRhYldpZHRoKQogICAgICAgICAgICAgcnVu LnNldFRhYlNpemUodHJ1ZSwgdGFiV2lkdGgpOwogICAgICAgICB3aWR0aCA9IGZvbnQud2lkdGgo cnVuKTsK