206273 2020-01-14 19:22:24 -0800 [Win] Remove obsolete useGDI code path and FontRenderingMode enum 2023-03-03 03:07:16 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham mmaxfield pvollan webkit-bug-importer oldest_to_newest 1606767 0 fujii 2020-01-14 19:22:24 -0800 [Win] Remove obsolete useGDI code path and FontRenderingMode enum The code was added by r28867. It draws texts using ExtTextOut with ETO_GLYPH_INDEX for useGDI code path. However, r126666 removes drawGDIGlyphs, the most important part of useGDI code path. 1606770 1 fujii 2020-01-14 19:39:45 -0800 Oh, it is being used for CGContextSetShouldUsePlatformNativeGlyphs. https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/win/FontCGWin.cpp?rev=238253 > CGContextSetShouldUsePlatformNativeGlyphs(cgContext, usePlatformNativeGlyphs); Does AppleWin port still use useGDI code path? 1606773 2 fujii 2020-01-14 19:51:17 -0800 Oops, usePlatformNativeGlyphs is always false. https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/win/FontCGWin.cpp?rev=254556#L177 1606774 3 fujii 2020-01-14 19:55:09 -0800 Oh, no. comment 2 was wrong. isPrinterFont is always false, usePlatformNativeGlyphs is font.platformData().useGDI(). 1606827 4 387758 fujii 2020-01-15 00:01:37 -0800 Created attachment 387758 minibrowser.exe.plist to enable useGDI There are two ways to enable useGDI code path for AppleWin MiniBrowser. 1. applying the following patch diff --git a/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp b/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp index f81a9be39f3..a062b973aca 100644 --- a/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp +++ b/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp @@ -297,6 +297,7 @@ bool WebKitLegacyBrowserWindow::setToDefaultPreferences() m_standardPreferences->setJavaScriptEnabled(TRUE); m_prefsPrivate->setAllowUniversalAccessFromFileURLs(FALSE); m_prefsPrivate->setAllowFileAccessFromFileURLs(TRUE); + m_standardPreferences->setFontSmoothing(FontSmoothingTypeWindows); m_prefsPrivate->setDeveloperExtrasEnabled(TRUE); 2. put this minibrowser.exe.plist to %userprofile%\AppData\Roaming\Apple Computer\Preferences 1606828 5 fujii 2020-01-15 00:08:20 -0800 I don't know AppleWin is still using useGDI code path, but it is still valid code path to work as expected. Closed as INVALID. 1606972 6 pvollan 2020-01-15 10:04:06 -0800 (In reply to Fujii Hironori from comment #1) > Oh, it is being used for CGContextSetShouldUsePlatformNativeGlyphs. > > https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/ > graphics/win/FontCGWin.cpp?rev=238253 > > > CGContextSetShouldUsePlatformNativeGlyphs(cgContext, usePlatformNativeGlyphs); > > Does AppleWin port still use useGDI code path? I don't believe it is still being used. 1607172 7 fujii 2020-01-15 14:37:48 -0800 Can i remove it ? 1607174 8 pvollan 2020-01-15 14:43:09 -0800 (In reply to Fujii Hironori from comment #7) > Can i remove it ? I think so, but it would be good to confirm with Brent or Alex. 1821247 9 mmaxfield 2021-12-07 15:33:40 -0800 The default is FontRenderingMode::Normal, but it looks like users can override that by setting a preference. It looks like that preference is set by placing a .plist in a specific place (as Fujii found in https://bugs.webkit.org/show_bug.cgi?id=206273#c4). I think this is a tradeoff between the pros of eliminating maintenance burden against the cons of making some (specific) Windows users' text look different. In this case, because the change is somewhat subtle, and because it's difficult to imagine someone going through the trouble of putting a plist in a specific place on the filesystem on Windows just to get their iTunes text to look slightly different, I think maintenance burden wins, and we can just delete this. 1937173 10 fujii 2023-02-27 13:23:53 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10756 1938452 11 ews-feeder 2023-03-03 03:06:08 -0800 Committed 261133@main (21e5a249467d): <https://commits.webkit.org/261133@main> Reviewed commits have been landed. Closing PR #10756 and removing active labels. 1938453 12 webkit-bug-importer 2023-03-03 03:07:16 -0800 <rdar://problem/106188944> 387758 2020-01-15 00:01:37 -0800 2020-01-15 00:01:37 -0800 minibrowser.exe.plist to enable useGDI minibrowser.exe.plist application/octet-stream 223 fujii YnBsaXN0MDDVAQIDBAUGBgYJBl8QFVdlYktpdERldmVsb3BlckV4dHJhc18QF1dlYktpdEZ1bGxT Y3JlZW5FbmFibGVkXxAwV2ViS2l0RGlkTWlncmF0ZVdlYktpdFByZWZlcmVuY2VzVG9DRlByZWZl cmVuY2VzXxAXV2ViS2l0Rm9udFNtb290aGluZ1R5cGVfEBlXZWJLaXRBVkZvdW5kYXRpb25FbmFi bGVkCQkJEAQJCBMrRXiSrq+wsbMAAAAAAAABAQAAAAAAAAALAAAAAAAAAAAAAAAAAAAAtA==