206233 2020-01-14 07:48:13 -0800 Offlineasm warnings with newer Ruby versions 2020-01-15 14:16:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1606386 0 aperez 2020-01-14 07:48:13 -0800 Using Ruby 2.7 the following will be printed out: /home/aperez/WebKit/Source/JavaScriptCore/offlineasm/parser.rb:631: warning: deprecated Object#=~ is called on Annotation; it always returns nil This is caused by the following change in Ruby: https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=65989&view=revision I see that the Annotation class does *not* define an overload for the =~ operator, so previously applying it to an Annotation instance was already returning “nil” (but silently). Therefore I *think* that swapping the checks in the code to something like if @tokens[@idx].is_a? Annotation # ... elsif (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final) # ... should both silence the warning and still be correct. Note that I do not have much experience with Ruby, nor with modifying offlineasm, so suggestions are definitely welcome. 1606389 1 387655 aperez 2020-01-14 07:52:28 -0800 Created attachment 387655 Patch 1606843 2 aperez 2020-01-15 01:58:24 -0800 The failed test run from the “mac-wk1” EWS seems unrelated. 1607003 3 387655 ysuzuki 2020-01-15 10:52:33 -0800 Comment on attachment 387655 Patch r=me 1607081 4 commit-queue 2020-01-15 12:32:21 -0800 The commit-queue encountered the following flaky tests while processing attachment 387655: The commit-queue is continuing to process your patch. 1607084 5 commit-queue 2020-01-15 12:32:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 387655: media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org) The commit-queue is continuing to process your patch. 1607161 6 387655 commit-queue 2020-01-15 14:15:43 -0800 Comment on attachment 387655 Patch Clearing flags on attachment: 387655 Committed r254637: <https://trac.webkit.org/changeset/254637> 1607162 7 commit-queue 2020-01-15 14:15:45 -0800 All reviewed patches have been landed. Closing bug. 1607163 8 webkit-bug-importer 2020-01-15 14:16:19 -0800 <rdar://problem/58618860> 387655 2020-01-14 07:52:28 -0800 2020-01-15 14:15:43 -0800 Patch bug-206233-20200114175227.patch text/plain 2138 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZGJlYTg4M2U4N2E2YjEwMDhkNzUxZGQ3M2I2YTU3YzQ4Y2RkYmRlLi5jZTQzNGFlOWMzM2Q4NjJl ZDk4NjUxZTljODcxYWUwMTk0MThmZjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMS0xNCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIE9mZmxpbmVhc20gd2FybmluZ3Mgd2l0aCBuZXdlciBSdWJ5 IHZlcnNpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDYyMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBdm9pZCBhIHdhcm5pbmcgYWJvdXQgdXNpbmcgT2JqZWN0Iz1+IG9uIEFubm90YXRpb24gaW5z dGFuY2VzLCB3aGljaAorICAgICAgICBoYXMgYmVlbiBkZXByZWNhdGVkIGluIFJ1YnkgMi43Lgor CisgICAgICAgICogb2ZmbGluZWFzbS9wYXJzZXIucmI6IFN3YXAgY2hlY2tzIHRvIHByZXZlbnQg YXBwbHlpbmcgdGhlID1+IG9wZXJhdG9yCisgICAgICAgIHRvIEFubm90YXRpb24gaW5zdGFuY2Vz LCB3aGljaCBkbyBub3QgZGVmaW5lIGl0LgorCiAyMDIwLTAxLTE0ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIC1XY29uZGl0aW9uYWwtdW5pbml0 aWFsaXplZCBpbiBibWFsbG9jLCBXVEYsIEphdmFTY3JpcHRDb3JlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIKaW5kZXggNzkxYzgxYTk4NjhkOTY5Y2Y1ZDMyMzJh MWY2NDc1NTQzMzE1MDY1YS4uZjE0Yzg3M2UyZGJkZjkzNTM2YzFlMTg1ZmU1YmM4ODI1NDk4YWVl NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vcGFyc2VyLnJi CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3BhcnNlci5yYgpAQCAtNjI4 LDkgKzYyOCw3IEBAIGNsYXNzIFBhcnNlcgogICAgICAgICBmaXJzdENvZGVPcmlnaW4gPSBAdG9r ZW5zW0BpZHhdLmNvZGVPcmlnaW4KICAgICAgICAgbGlzdCA9IFtdCiAgICAgICAgIGxvb3Agewot ICAgICAgICAgICAgaWYgKEBpZHggPT0gQHRva2Vucy5sZW5ndGggYW5kIG5vdCBmaW5hbCkgb3Ig KGZpbmFsIGFuZCBAdG9rZW5zW0BpZHhdID1+IGZpbmFsKQotICAgICAgICAgICAgICAgIGJyZWFr Ci0gICAgICAgICAgICBlbHNpZiBAdG9rZW5zW0BpZHhdLmlzX2E/IEFubm90YXRpb24KKyAgICAg ICAgICAgIGlmIEB0b2tlbnNbQGlkeF0uaXNfYT8gQW5ub3RhdGlvbgogICAgICAgICAgICAgICAg ICMgVGhpcyBpcyB0aGUgb25seSBwbGFjZSB3aGVyZSB3ZSBjYW4gZW5jb3VudGVyIGEgZ2xvYmFs CiAgICAgICAgICAgICAgICAgIyBhbm5vdGF0aW9uLCBhbmQgaGVuY2UgbmVlZCB0byBiZSBhYmxl IHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4KICAgICAgICAgICAgICAgICAjIHRoZW0uCkBAIC02NDQs NiArNjQyLDggQEAgY2xhc3MgUGFyc2VyCiAgICAgICAgICAgICAgICAgbGlzdCA8PCBJbnN0cnVj dGlvbi5uZXcoY29kZU9yaWdpbiwgYW5ub3RhdGlvbk9wY29kZSwgW10sIEB0b2tlbnNbQGlkeF0u c3RyaW5nKQogICAgICAgICAgICAgICAgIEBhbm5vdGF0aW9uID0gbmlsCiAgICAgICAgICAgICAg ICAgQGlkeCArPSAyICMgQ29uc3VtZSB0aGUgbmV3bGluZSBhcyB3ZWxsLgorICAgICAgICAgICAg ZWxzaWYgKEBpZHggPT0gQHRva2Vucy5sZW5ndGggYW5kIG5vdCBmaW5hbCkgb3IgKGZpbmFsIGFu ZCBAdG9rZW5zW0BpZHhdID1+IGZpbmFsKQorICAgICAgICAgICAgICAgIGJyZWFrCiAgICAgICAg ICAgICBlbHNpZiBAdG9rZW5zW0BpZHhdID09ICJcbiIKICAgICAgICAgICAgICAgICAjIGlnbm9y ZQogICAgICAgICAgICAgICAgIEBpZHggKz0gMQo=