206188 2020-01-13 12:59:43 -0800 Remove calls to testRunner.installStatisticsDidModifyDataRecordsCallback() in http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins* 2020-01-13 19:15:42 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206100 InRadar P2 Normal --- 1 wilander wilander commit-queue webkit-bug-importer oldest_to_newest 1606009 0 wilander 2020-01-13 12:59:43 -0800 We should not call both testRunner.installStatisticsDidScanDataRecordsCallback() and testRunner.installStatisticsDidModifyDataRecordsCallback(). 1606011 1 webkit-bug-importer 2020-01-13 13:00:02 -0800 <rdar://problem/58540033> 1606024 2 387563 wilander 2020-01-13 13:19:46 -0800 Created attachment 387563 Patch for landing 1606201 3 commit-queue 2020-01-13 19:15:14 -0800 The commit-queue encountered the following flaky tests while processing attachment 387563: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1606202 4 387563 commit-queue 2020-01-13 19:15:41 -0800 Comment on attachment 387563 Patch for landing Clearing flags on attachment: 387563 Committed r254482: <https://trac.webkit.org/changeset/254482> 1606203 5 commit-queue 2020-01-13 19:15:42 -0800 All reviewed patches have been landed. Closing bug. 387563 2020-01-13 13:19:46 -0800 2020-01-13 19:15:41 -0800 Patch for landing bug-206188-20200113131946.patch text/plain 3126 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDQ2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWYyNTE2MTAwY2RiMTU2OGU3NDk1 MTkyNjBmMGYyMmYzZjA1ZmY5Zi4uZWYyYmMzNTA1MGViZTQxYmY0ZmY1MTkzNzAzY2ZmN2M2OTEx ODY0ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTEzICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBjYWxscyB0byB0ZXN0UnVubmVy Lmluc3RhbGxTdGF0aXN0aWNzRGlkTW9kaWZ5RGF0YVJlY29yZHNDYWxsYmFjaygpIGluIGh0dHAv dGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9jbGFzc2lmeS1hcy1ub24tcHJldmFsZW50LWJh c2VkLW9uLXN1Yi1mcmFtZS11bmRlci10b3AtZnJhbWUtb3JpZ2lucyoKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjE4OAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTg1NDAwMzM+CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4K KworICAgICAgICBSZW1vdmVkIHRoZSBjYWxscyB0byB0ZXN0UnVubmVyLmluc3RhbGxTdGF0aXN0 aWNzRGlkTW9kaWZ5RGF0YVJlY29yZHNDYWxsYmFjaygpCisgICAgICAgIHRvIGFkZHJlc3MgZmxh a2luZXNzLgorCisgICAgICAgICogaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2Ns YXNzaWZ5LWFzLW5vbi1wcmV2YWxlbnQtYmFzZWQtb24tc3ViLWZyYW1lLXVuZGVyLXRvcC1mcmFt ZS1vcmlnaW5zLWRhdGFiYXNlLmh0bWw6CisgICAgICAgICogaHR0cC90ZXN0cy9yZXNvdXJjZUxv YWRTdGF0aXN0aWNzL2NsYXNzaWZ5LWFzLW5vbi1wcmV2YWxlbnQtYmFzZWQtb24tc3ViLWZyYW1l LXVuZGVyLXRvcC1mcmFtZS1vcmlnaW5zLmh0bWw6CisKIDIwMjAtMDEtMTMgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBFeHBsYWluIHdoeSB3ZSBzdGFydGVkIHNr aXBwaW5nICJpbnNlcnQtc3Bhbi1pbnRvLWxvbmctdGV4dC1idWctMjgyNDUuaHRtbCIgaW4gZGVi dWcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRp c3RpY3MvY2xhc3NpZnktYXMtbm9uLXByZXZhbGVudC1iYXNlZC1vbi1zdWItZnJhbWUtdW5kZXIt dG9wLWZyYW1lLW9yaWdpbnMtZGF0YWJhc2UuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv cmVzb3VyY2VMb2FkU3RhdGlzdGljcy9jbGFzc2lmeS1hcy1ub24tcHJldmFsZW50LWJhc2VkLW9u LXN1Yi1mcmFtZS11bmRlci10b3AtZnJhbWUtb3JpZ2lucy1kYXRhYmFzZS5odG1sCmluZGV4IGNh MmVjNmQ5Mzc1NGY4MTdlMGQ1M2MxYjI0ZjZhMzVjODc1ZTU0ZjIuLjVmYmI3YjkyNmYyZTBjZGU5 NzhmMWI1OWU2MWM1NzZkOTVlMjI1N2UgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9jbGFzc2lmeS1hcy1ub24tcHJldmFsZW50LWJhc2Vk LW9uLXN1Yi1mcmFtZS11bmRlci10b3AtZnJhbWUtb3JpZ2lucy1kYXRhYmFzZS5odG1sCisrKyBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9jbGFzc2lmeS1h cy1ub24tcHJldmFsZW50LWJhc2VkLW9uLXN1Yi1mcmFtZS11bmRlci10b3AtZnJhbWUtb3JpZ2lu cy1kYXRhYmFzZS5odG1sCkBAIC0zNSw3ICszNSw2IEBACiAgICAgICAgICAgICB0ZXN0UnVubmVy LnNldFN0YXRpc3RpY3NTdWJmcmFtZVVuZGVyVG9wRnJhbWVPcmlnaW4oc3RhdGlzdGljc1VybCwg dG9wRnJhbWVPcmlnaW4zKTsKIAogICAgICAgICAgICAgdGVzdFJ1bm5lci5pbnN0YWxsU3RhdGlz dGljc0RpZFNjYW5EYXRhUmVjb3Jkc0NhbGxiYWNrKGNvbXBsZXRlVGVzdCk7Ci0gICAgICAgICAg ICB0ZXN0UnVubmVyLmluc3RhbGxTdGF0aXN0aWNzRGlkTW9kaWZ5RGF0YVJlY29yZHNDYWxsYmFj ayhjb21wbGV0ZVRlc3QpOwogCiAgICAgICAgICAgICB0ZXN0UnVubmVyLnN0YXRpc3RpY3NQcm9j ZXNzU3RhdGlzdGljc0FuZERhdGFSZWNvcmRzKCk7CiAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2NsYXNzaWZ5LWFz LW5vbi1wcmV2YWxlbnQtYmFzZWQtb24tc3ViLWZyYW1lLXVuZGVyLXRvcC1mcmFtZS1vcmlnaW5z Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvY2xh c3NpZnktYXMtbm9uLXByZXZhbGVudC1iYXNlZC1vbi1zdWItZnJhbWUtdW5kZXItdG9wLWZyYW1l LW9yaWdpbnMuaHRtbAppbmRleCBkOTFkZTk0MjY5OGY3NzExMjYwNmYxODUwM2Y5YzJmOTc3NWNk YmU5Li4yMzM4MTg0MGFjNTg4MWFmMTBiNDU2NWQ0NmE0MWRmYzY5NzQ5ZTM2IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvY2xhc3NpZnkt YXMtbm9uLXByZXZhbGVudC1iYXNlZC1vbi1zdWItZnJhbWUtdW5kZXItdG9wLWZyYW1lLW9yaWdp bnMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3Rp Y3MvY2xhc3NpZnktYXMtbm9uLXByZXZhbGVudC1iYXNlZC1vbi1zdWItZnJhbWUtdW5kZXItdG9w LWZyYW1lLW9yaWdpbnMuaHRtbApAQCAtMzUsNyArMzUsNiBAQAogICAgICAgICAgICAgdGVzdFJ1 bm5lci5zZXRTdGF0aXN0aWNzU3ViZnJhbWVVbmRlclRvcEZyYW1lT3JpZ2luKHN0YXRpc3RpY3NV cmwsIHRvcEZyYW1lT3JpZ2luMyk7CiAKICAgICAgICAgICAgIHRlc3RSdW5uZXIuaW5zdGFsbFN0 YXRpc3RpY3NEaWRTY2FuRGF0YVJlY29yZHNDYWxsYmFjayhjb21wbGV0ZVRlc3QpOwotICAgICAg ICAgICAgdGVzdFJ1bm5lci5pbnN0YWxsU3RhdGlzdGljc0RpZE1vZGlmeURhdGFSZWNvcmRzQ2Fs bGJhY2soY29tcGxldGVUZXN0KTsKIAogICAgICAgICAgICAgdGVzdFJ1bm5lci5zdGF0aXN0aWNz UHJvY2Vzc1N0YXRpc3RpY3NBbmREYXRhUmVjb3JkcygpOwogICAgICAgICB9KTsK